fix(cli): make plan correct accept plan_id as primary identifier #1055

Merged
brent.edwards merged 3 commits from bugfix/m3-plan-correct-plan-id into master 2026-03-21 18:45:18 +00:00

3 Commits

Author SHA1 Message Date
brent.edwards 9db59c3965 Merge remote-tracking branch 'origin/master' into bugfix/m3-plan-correct-plan-id
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 16s
CI / lint (pull_request) Successful in 3m21s
CI / typecheck (pull_request) Successful in 3m57s
CI / quality (pull_request) Successful in 4m7s
CI / security (pull_request) Successful in 4m30s
CI / unit_tests (pull_request) Successful in 8m59s
CI / integration_tests (pull_request) Successful in 9m2s
CI / e2e_tests (pull_request) Successful in 9m6s
CI / docker (pull_request) Successful in 1m16s
CI / coverage (pull_request) Successful in 11m13s
CI / status-check (pull_request) Successful in 1s
CI / benchmark-regression (pull_request) Successful in 46m15s
2026-03-21 14:48:26 +00:00
brent.edwards dc817fe53e Merge branch 'master' into bugfix/m3-plan-correct-plan-id
CI / lint (pull_request) Successful in 23s
CI / typecheck (pull_request) Successful in 50s
CI / quality (pull_request) Successful in 32s
CI / security (pull_request) Successful in 44s
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 28s
CI / integration_tests (pull_request) Successful in 4m17s
CI / coverage (pull_request) Successful in 6m39s
CI / e2e_tests (pull_request) Failing after 12m29s
CI / unit_tests (pull_request) Failing after 12m55s
CI / benchmark-regression (pull_request) Failing after 22m24s
CI / docker (pull_request) Has been cancelled
2026-03-19 23:43:24 +00:00
brent.edwards a449989730 fix(cli): make plan correct accept plan_id as primary identifier
CI / lint (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 43s
CI / security (pull_request) Successful in 55s
CI / quality (pull_request) Successful in 28s
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 30s
CI / unit_tests (pull_request) Successful in 3m39s
CI / integration_tests (pull_request) Successful in 3m58s
CI / e2e_tests (pull_request) Successful in 5m41s
CI / docker (pull_request) Successful in 1m3s
CI / coverage (pull_request) Has been cancelled
CI / benchmark-regression (pull_request) Has been cancelled
The `plan correct` command previously only accepted a decision_id as its
positional argument. When M3 acceptance tests pass a plan_id instead, the
command fails because the plan_id is not a valid decision.

The positional parameter is now named `identifier` and tries plan_id
resolution first via `PlanLifecycleService.get_plan()`. When the
identifier is a valid plan, the root decision (parent_decision_id is
None) is automatically selected as the correction target. If the
identifier is not a plan, the original decision_id behavior is preserved
for backward compatibility.

ISSUES CLOSED: #969
2026-03-19 22:52:54 +00:00