cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

test: add TDD bug-capture test for #969 — plan correct plan_id handling #1051

Merged
hurui200320 merged 1 commits from tdd/m3-plan-correct-plan-id into master 2026-03-19 07:31:13 +00:00
Conversation 1 Commits 1 Files Changed 6
+550
hurui200320 commented 2026-03-18 08:58:12 +00:00
Member
Copy Link
Copy Source

Summary

Add TDD bug-capture tests for bug #969 (plan correct expects decision_id but M3 acceptance test passes plan_id). These tests prove the bug exists and will serve as regression guards once the fix in #969 is merged.

Changes

  • Behave test (features/tdd_plan_correct_plan_id.feature): Two scenarios tagged @tdd_expected_fail @tdd_bug @tdd_bug_969 — one for --mode revert and one for --mode append — that invoke plan correct <plan_id> (without --plan flag) and assert the command resolves the plan_id to its root decision as target_decision_id. Both modes are tested because the bug affects target_decision_id resolution before mode-specific branching.

  • Step definitions (features/steps/tdd_plan_correct_plan_id_steps.py): Mock setup for DI container (DecisionService), CorrectionService, and _resolve_active_plan_id. Uses tpcpid step prefix per project conventions.

  • Shared fixtures (features/mocks/tdd_plan_correct_plan_id_fixtures.py): Centralised constants, patch targets, mock builders (make_decision_ns, make_mock_container, make_correction_svc, make_default_decisions, make_default_container), and build_cli_args helper. Both the Behave steps and Robot helper import from this shared module, eliminating code duplication and drift risk.

  • Robot test (robot/tdd_plan_correct_plan_id.robot): Two integration-level tests (revert + append) with tdd_expected_fail tdd_bug tdd_bug_969 tags, exercising the same code paths via the helper script.

  • Robot helper (robot/helper_tdd_plan_correct_plan_id.py): Standalone helper that exits 0 with sentinel when the bug is fixed, exits 1 when the bug is present. Imports shared fixtures from features/mocks/.

  • Changelog (CHANGELOG.md): Added entry under Unreleased for #979.

Bug Description

The correct_decision function in cleveragents.cli.commands.plan declares decision_id as its first positional argument. When the M3 acceptance test calls plan correct <plan_id> --mode revert --guidance "...", the plan_id is captured as decision_id and used directly as target_decision_id in svc.request_correction(). Since the plan_id is not a valid decision_id, the correction service cannot find the targeted decision. The same bug path is exercised by --mode append.

How TDD Expected-Fail Works

  • The @tdd_expected_fail tag causes the test framework to invert the result: the test passes CI when the underlying assertion fails (proving the bug exists) and fails CI if the assertion passes (bug was fixed without removing the tag).
  • When bug #969 is fixed, the developer removes the @tdd_expected_fail tag, and the test runs normally as a regression guard.

Quality Gates

All nox sessions pass:

  • nox -s lint ✅
  • nox -s typecheck ✅ (0 errors)
  • nox -s unit_tests ✅ (387 features, 11121 scenarios, 0 failures)
  • nox -s integration_tests ✅ (1561 tests, 0 failures)
  • nox -s e2e_tests ✅ (16 tests, 0 failures)
  • nox -s coverage_report ✅ (≥97%)

Closes #979

## Summary Add TDD bug-capture tests for bug #969 (`plan correct` expects `decision_id` but M3 acceptance test passes `plan_id`). These tests prove the bug exists and will serve as regression guards once the fix in #969 is merged. ### Changes - **Behave test** (`features/tdd_plan_correct_plan_id.feature`): Two scenarios tagged `@tdd_expected_fail @tdd_bug @tdd_bug_969` — one for `--mode revert` and one for `--mode append` — that invoke `plan correct <plan_id>` (without `--plan` flag) and assert the command resolves the plan_id to its root decision as `target_decision_id`. Both modes are tested because the bug affects `target_decision_id` resolution **before** mode-specific branching. - **Step definitions** (`features/steps/tdd_plan_correct_plan_id_steps.py`): Mock setup for DI container (DecisionService), CorrectionService, and `_resolve_active_plan_id`. Uses `tpcpid` step prefix per project conventions. - **Shared fixtures** (`features/mocks/tdd_plan_correct_plan_id_fixtures.py`): Centralised constants, patch targets, mock builders (`make_decision_ns`, `make_mock_container`, `make_correction_svc`, `make_default_decisions`, `make_default_container`), and `build_cli_args` helper. Both the Behave steps and Robot helper import from this shared module, eliminating code duplication and drift risk. - **Robot test** (`robot/tdd_plan_correct_plan_id.robot`): Two integration-level tests (revert + append) with `tdd_expected_fail tdd_bug tdd_bug_969` tags, exercising the same code paths via the helper script. - **Robot helper** (`robot/helper_tdd_plan_correct_plan_id.py`): Standalone helper that exits 0 with sentinel when the bug is fixed, exits 1 when the bug is present. Imports shared fixtures from `features/mocks/`. - **Changelog** (`CHANGELOG.md`): Added entry under Unreleased for #979. ### Bug Description The `correct_decision` function in `cleveragents.cli.commands.plan` declares `decision_id` as its first positional argument. When the M3 acceptance test calls `plan correct <plan_id> --mode revert --guidance "..."`, the plan_id is captured as `decision_id` and used directly as `target_decision_id` in `svc.request_correction()`. Since the plan_id is not a valid decision_id, the correction service cannot find the targeted decision. The same bug path is exercised by `--mode append`. ### How TDD Expected-Fail Works - The `@tdd_expected_fail` tag causes the test framework to invert the result: the test passes CI when the underlying assertion fails (proving the bug exists) and fails CI if the assertion passes (bug was fixed without removing the tag). - When bug #969 is fixed, the developer removes the `@tdd_expected_fail` tag, and the test runs normally as a regression guard. ### Quality Gates All nox sessions pass: - `nox -s lint` ✅ - `nox -s typecheck` ✅ (0 errors) - `nox -s unit_tests` ✅ (387 features, 11121 scenarios, 0 failures) - `nox -s integration_tests` ✅ (1561 tests, 0 failures) - `nox -s e2e_tests` ✅ (16 tests, 0 failures) - `nox -s coverage_report` ✅ (≥97%) Closes #979
hurui200320 added the
Type
Testing
 label 2026-03-18 08:58:19 +00:00
hurui200320 added this to the v3.2.0 milestone 2026-03-18 08:58:19 +00:00
hurui200320 force-pushed tdd/m3-plan-correct-plan-id from 5a08e12ebd to 433aa7db21 2026-03-18 11:56:02 +00:00 Compare
freemo approved these changes 2026-03-19 04:55:12 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Code Review — PR #1051 test: TDD bug-capture test for #969 — plan correct plan_id handling

Clean TDD test with correct tag triplet (@tdd_expected_fail @tdd_bug @tdd_bug_969). Excellent use of shared fixtures in features/mocks/tdd_plan_correct_plan_id_fixtures.py — this eliminates duplication between Behave steps and Robot helper and should be the standard pattern for future TDD PRs. Two scenarios (revert + append modes) thoroughly test the root bug.

Approved. No issues found.

## Code Review — PR #1051 `test: TDD bug-capture test for #969 — plan correct plan_id handling` Clean TDD test with correct tag triplet (`@tdd_expected_fail @tdd_bug @tdd_bug_969`). Excellent use of shared fixtures in `features/mocks/tdd_plan_correct_plan_id_fixtures.py` — this eliminates duplication between Behave steps and Robot helper and should be the standard pattern for future TDD PRs. Two scenarios (revert + append modes) thoroughly test the root bug. **Approved.** No issues found.
freemo requested review from brent.edwards 2026-03-19 05:16:15 +00:00
freemo requested review from freemo 2026-03-19 05:16:15 +00:00
hurui200320 force-pushed tdd/m3-plan-correct-plan-id from 433aa7db21 to 7b8b15f75c 2026-03-19 07:23:19 +00:00 Compare
hurui200320 dismissed freemo's review 2026-03-19 07:23:19 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

hurui200320 scheduled this pull request to auto merge when all checks succeed 2026-03-19 07:29:26 +00:00
hurui200320 merged commit 0b415a6e5e into master 2026-03-19 07:31:13 +00:00
hurui200320 deleted branch tdd/m3-plan-correct-plan-id 2026-03-19 07:31:13 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
freemo
brent.edwards
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Testing
Milestone
No items
No Milestone v3.2.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#979 TDD: Write failing test for #969 — plan correct expects decision_id but test passes plan_id
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#1051
Delete Branch "tdd/m3-plan-correct-plan-id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?