cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

feat(lsp): implement functional LSP runtime #1044

Merged
hamza.khyari merged 1 commits from feature/lsp-functional-runtime into master 2026-03-24 13:17:44 +00:00
Conversation 2 Commits 1 Files Changed 16
+2369 -100
hamza.khyari commented 2026-03-18 04:37:21 +00:00
Member
Copy Link
Copy Source

Summary

Implement the functional LSP runtime, replacing local-mode stubs with real LSP protocol support.

New files

  • lsp/transport.py — StdioTransport for subprocess JSON-RPC over stdin/stdout
  • lsp/client.py — LspClient implementing LSP protocol (initialize/shutdown/diagnostics/completions)
  • lsp/lifecycle.py — LspLifecycleManager with reference-counted instances, health checks, crash restart
  • lsp/discovery.py — LanguageDiscovery with 4-layer detection (extension, shebang, UKO, project config)
  • features/lsp_functional_runtime.feature — 27 Behave BDD scenarios
  • robot/lsp_functional_runtime.robot — 6 Robot integration tests

Modified files

  • lsp/runtime.py — Replaced stubs with real LSP calls via lifecycle manager
  • lsp/tool_adapter.py — Runtime-delegating handlers with local-mode fallback
  • lsp/__init__.py — Updated exports
  • features/consolidated_misc.feature — Updated runtime test assertions
  • features/steps/lsp_registry_steps.py — Updated error handling for new runtime

Quality Gates

Session Result
nox -s lint PASS
nox -s typecheck PASS (0 errors)
nox -s unit_tests -- features/lsp_functional_runtime.feature PASS (27 scenarios)
nox -s unit_tests -- features/consolidated_misc.feature PASS (250 scenarios)
nox -s unit_tests -- features/lsp_cli_new_coverage.feature PASS (20 scenarios)

Closes #826

## Summary Implement the functional LSP runtime, replacing local-mode stubs with real LSP protocol support. ### New files - `lsp/transport.py` — `StdioTransport` for subprocess JSON-RPC over stdin/stdout - `lsp/client.py` — `LspClient` implementing LSP protocol (initialize/shutdown/diagnostics/completions) - `lsp/lifecycle.py` — `LspLifecycleManager` with reference-counted instances, health checks, crash restart - `lsp/discovery.py` — `LanguageDiscovery` with 4-layer detection (extension, shebang, UKO, project config) - `features/lsp_functional_runtime.feature` — 27 Behave BDD scenarios - `robot/lsp_functional_runtime.robot` — 6 Robot integration tests ### Modified files - `lsp/runtime.py` — Replaced stubs with real LSP calls via lifecycle manager - `lsp/tool_adapter.py` — Runtime-delegating handlers with local-mode fallback - `lsp/__init__.py` — Updated exports - `features/consolidated_misc.feature` — Updated runtime test assertions - `features/steps/lsp_registry_steps.py` — Updated error handling for new runtime ### Quality Gates | Session | Result | |---|---| | `nox -s lint` | PASS | | `nox -s typecheck` | PASS (0 errors) | | `nox -s unit_tests -- features/lsp_functional_runtime.feature` | PASS (27 scenarios) | | `nox -s unit_tests -- features/consolidated_misc.feature` | PASS (250 scenarios) | | `nox -s unit_tests -- features/lsp_cli_new_coverage.feature` | PASS (20 scenarios) | Closes #826
hamza.khyari added the
Type
Feature
 label 2026-03-18 04:38:05 +00:00
hamza.khyari self-assigned this 2026-03-18 11:43:52 +00:00
hamza.khyari added the
State
In Review
 label 2026-03-18 11:43:56 +00:00
hamza.khyari added this to the v3.6.0 milestone 2026-03-18 11:44:03 +00:00
freemo approved these changes 2026-03-19 04:55:39 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Code Review — PR #1044 feat(lsp): implement functional LSP runtime

The largest of the three hamza.khyari PRs at +2,336 lines, but the architecture justifies the scope. Clean separation: StdioTransport (process I/O) → LspClient (protocol) → LspLifecycleManager (reference counting + health) → LspRuntime (orchestration). The LanguageDiscovery module with 4-layer detection (extension map, shebang, UKO, project config) and 70+ language mappings is thorough.

27 Behave BDD scenarios + 6 Robot integration tests provide strong coverage. The replacement of LspNotAvailableError stubs with real LSP calls is a significant capability upgrade.

Approved. No issues found.

## Code Review — PR #1044 `feat(lsp): implement functional LSP runtime` The largest of the three hamza.khyari PRs at +2,336 lines, but the architecture justifies the scope. Clean separation: `StdioTransport` (process I/O) → `LspClient` (protocol) → `LspLifecycleManager` (reference counting + health) → `LspRuntime` (orchestration). The `LanguageDiscovery` module with 4-layer detection (extension map, shebang, UKO, project config) and 70+ language mappings is thorough. 27 Behave BDD scenarios + 6 Robot integration tests provide strong coverage. The replacement of `LspNotAvailableError` stubs with real LSP calls is a significant capability upgrade. **Approved.** No issues found.
freemo requested review from freemo 2026-03-19 05:16:57 +00:00
freemo requested review from brent.edwards 2026-03-19 05:16:57 +00:00
freemo commented 2026-03-23 03:42:15 +00:00
Owner
Copy Link
Copy Source

Day 43 Review — Rebase Required

This PR has merge conflicts with master and cannot be merged in its current state. This is one of 9 Hamza PRs in the resource/LSP domain (v3.5.0-v3.6.0) that all have conflicts. These PRs likely share a common dependency chain and should be rebased sequentially.

@hamza.khyari: Please rebase onto current master. If multiple PRs depend on each other, start with the base PR in the chain and work upward.

Rebase priority: HIGH — these PRs represent significant feature work that is blocked by merge conflicts. Every day they remain conflicted is a day they cannot be reviewed or merged.

**Day 43 Review — Rebase Required** This PR has merge conflicts with `master` and cannot be merged in its current state. This is one of 9 Hamza PRs in the resource/LSP domain (v3.5.0-v3.6.0) that all have conflicts. These PRs likely share a common dependency chain and should be rebased sequentially. @hamza.khyari: Please rebase onto current `master`. If multiple PRs depend on each other, start with the base PR in the chain and work upward. **Rebase priority**: HIGH — these PRs represent significant feature work that is blocked by merge conflicts. Every day they remain conflicted is a day they cannot be reviewed or merged.
hamza.khyari force-pushed feature/lsp-functional-runtime from 8b19d4a737 to 773815cf97 2026-03-24 12:26:56 +00:00 Compare
hamza.khyari dismissed freemo's review 2026-03-24 12:26:56 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

hamza.khyari force-pushed feature/lsp-functional-runtime from 773815cf97 to f185c74ea5 2026-03-24 12:53:57 +00:00 Compare
hamza.khyari force-pushed feature/lsp-functional-runtime from f185c74ea5 to 4ff075e0da 2026-03-24 13:01:23 +00:00 Compare
hamza.khyari merged commit e07b68221a into master 2026-03-24 13:17:44 +00:00
hamza.khyari deleted branch feature/lsp-functional-runtime 2026-03-24 13:17:54 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
freemo
brent.edwards
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
State
In Review
Type
Feature
Milestone
No items
No Milestone v3.6.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees hamza.khyari
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#1044
Delete Branch "feature/lsp-functional-runtime"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?