feat(agents): add mandatory PR compliance checklist to implementation-pool-supervisor #10069

Merged
HAL9000 merged 4 commits from bugfix/m3-evlv-9824-implementation-pool-compliance-checklist into master 2026-05-08 18:50:34 +00:00

4 Commits

Author SHA1 Message Date
HAL9000 8861376080 fix(tests): reformat pr_compliance_pool_supervisor_steps.py and fix pre-existing lint errors
CI / benchmark-publish (pull_request) Has been skipped
CI / helm (pull_request) Successful in 44s
CI / quality (pull_request) Successful in 1m26s
CI / lint (pull_request) Successful in 1m27s
CI / build (pull_request) Successful in 1m3s
CI / push-validation (pull_request) Successful in 39s
CI / typecheck (pull_request) Successful in 1m40s
CI / benchmark-regression (pull_request) Failing after 1m20s
CI / security (pull_request) Successful in 2m7s
CI / integration_tests (pull_request) Successful in 3m39s
CI / e2e_tests (pull_request) Successful in 4m48s
CI / unit_tests (pull_request) Successful in 5m26s
CI / docker (pull_request) Successful in 1m42s
CI / coverage (pull_request) Successful in 13m50s
CI / status-check (pull_request) Successful in 3s
- ruff format: multiline AGENT_DEF_PATH assignment, compress all() comprehension,
  add blank line before decorator block — fixes CI / unit_tests lint failure
- ruff --fix: remove unused imports from tests/actor/test_registry_builtin_yaml.py
  (pre-existing F401 errors on master)

ISSUES CLOSED: #9824
2026-05-08 13:22:33 +00:00
HAL9000 cceee7af0d fix(tests): fix lint violation UP035 and match feature file step text to Pool: prefixes
- B5 (lint): changed 'from typing import Any, Callable' to
  'from collections.abc import Callable' per ruff UP035 rule
- B7 (step mismatch): added 'Pool: ' prefix to all Then/And steps in
  pr_compliance_pool_supervisor.feature to match step definition decorators

ISSUES CLOSED: #9824
2026-05-08 13:22:33 +00:00
HAL9000 63c1dbd034 fix(tests): resolve Behave AmbiguousStep conflict in pool-supervisor steps
The pr_compliance_pool_supervisor_steps.py file defined @then step texts
identical to those in the pre-existing pr_compliance_checklist_steps.py,
causing Behave's ambiguous-step detection to reject the test run.

Fix: prefix all pool-supervisor @then decorators with 'Pool:' so they're
uniquely identifiable by Behave while reusing the same validator logic.
Also fix PROJECT_ROOT from parents[3] -> parents[2] for correct repo root
resolution in step files located at features/steps/.

ISSUES CLOSED: #9824
2026-05-08 13:22:33 +00:00
HAL9000 8511cdccfb feat(agents): add mandatory PR compliance checklist to implementation-pool-supervisor
Add a new implementation-pool-supervisor agent definition with an embedded
8-item PR Compliance Checklist. Workers dispatched by the pool supervisor
must complete all 8 items before creating any PR: CHANGELOG.md update,
CONTRIBUTORS.md update, commit footer (ISSUES CLOSED: #N), CI verification,
BDD tests, Epic reference, label application via forgejo-label-manager,
and milestone assignment. Includes concrete markdown examples for each
subsection and compliance verification pseudocode.

Also adds BDD test coverage (pr_compliance_pool_supervisor.feature + steps)
to verify the pool supervisor agent definition contains all 8 checklist items.

Parent Epic: #9779

ISSUES CLOSED: #9824
2026-05-08 13:22:33 +00:00