cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

Epic: Output Rendering Pipeline Integration — Wire Commands to OutputSession Framework #936

New Issue
Open
opened 2026-03-14 01:14:05 +00:00 by freemo · 2 comments
freemo commented 2026-03-14 01:14:05 +00:00
Owner
Copy Link
Copy Source

Background and Context

The specification defines an Output Rendering Framework (spec §Output Rendering Framework) with a formal architecture: OutputSession, Element Handles, Element Events, Materialization Strategies, ElementRenderer Protocol, RendererRegistry, and format-specific renderers. Every CLI command must produce structured output matching the spec envelope: {command, status, exit_code, data, timing, messages}.

The current implementation has:

  • OutputSession with element handle lifecycle (functional in cli/output/session.py)
  • Element handles: PanelHandle, TableHandle, StatusHandle, ProgressHandle
  • All 6 format-specific materializers exist
  • Format selection with terminal capability detection

However:

  • CLI commands do not use OutputSession — commands still use the old format_output() path; the OutputSession framework is not integrated
  • Rich materializer is a stub — delegates to color renderer, no rich library integration
  • Spec envelope mismatch — code uses {command, session_id, elements, exit_code, timing, metadata} instead of {command, status, exit_code, data, timing, messages}
  • No RendererRegistry — hard-coded dispatch instead of pluggable registry (tracked by #917)

Note: #884 covers envelope alignment and #917 covers RendererRegistry. This Epic coordinates the full integration.

Expected Behavior

All CLI commands must produce output through the OutputSession pipeline, using the spec-defined envelope format, with a functional Rich materializer for interactive terminal use.

Acceptance Criteria

  • All CLI commands route output through OutputSession (not direct format_output())
  • Output envelope matches spec: {command, status, exit_code, data, timing, messages}
  • Rich materializer uses the rich library for live terminal rendering (panels, tables, spinners, progress bars)
  • Streaming materialization mode supports progressive real-time output for --stream commands
  • RendererRegistry dispatches element types to per-format renderers (coordinates with #917)
  • All output format tabs in the spec are reproducible by the implementation

Subtasks

  • Refactor CLI commands to use OutputSession instead of format_output() — system commands (version, info, diagnostics, init)
  • Refactor CLI commands — session commands
  • Refactor CLI commands — project commands
  • Refactor CLI commands — actor commands
  • Refactor CLI commands — plan commands
  • Refactor CLI commands — resource, tool, skill, action, config, invariant, validation, lsp commands
  • Implement functional Rich materializer with rich Live Display integration
  • Implement streaming materialization mode for --stream
  • Align output envelope to spec structure (coordinates with #884)
  • Tests (Behave): Add scenarios for each output format
  • Tests (Robot): Add integration tests for command output structure
  • Verify coverage >=97% via nox -s coverage_report
  • Run nox (all default sessions), fix any errors

Definition of Done

This epic is complete when all child issues are closed AND every CLI command produces structured output through the OutputSession framework, the Rich materializer provides interactive terminal rendering, and all output formats match the specification examples.

## Background and Context The specification defines an Output Rendering Framework (spec §Output Rendering Framework) with a formal architecture: OutputSession, Element Handles, Element Events, Materialization Strategies, ElementRenderer Protocol, RendererRegistry, and format-specific renderers. Every CLI command must produce structured output matching the spec envelope: `{command, status, exit_code, data, timing, messages}`. The current implementation has: - `OutputSession` with element handle lifecycle (functional in `cli/output/session.py`) - Element handles: `PanelHandle`, `TableHandle`, `StatusHandle`, `ProgressHandle` - All 6 format-specific materializers exist - Format selection with terminal capability detection However: - **CLI commands do not use OutputSession** — commands still use the old `format_output()` path; the OutputSession framework is not integrated - **Rich materializer is a stub** — delegates to color renderer, no `rich` library integration - **Spec envelope mismatch** — code uses `{command, session_id, elements, exit_code, timing, metadata}` instead of `{command, status, exit_code, data, timing, messages}` - **No RendererRegistry** — hard-coded dispatch instead of pluggable registry (tracked by #917) Note: #884 covers envelope alignment and #917 covers RendererRegistry. This Epic coordinates the full integration. ## Expected Behavior All CLI commands must produce output through the OutputSession pipeline, using the spec-defined envelope format, with a functional Rich materializer for interactive terminal use. ## Acceptance Criteria - [ ] All CLI commands route output through `OutputSession` (not direct `format_output()`) - [ ] Output envelope matches spec: `{command, status, exit_code, data, timing, messages}` - [ ] Rich materializer uses the `rich` library for live terminal rendering (panels, tables, spinners, progress bars) - [ ] Streaming materialization mode supports progressive real-time output for `--stream` commands - [ ] `RendererRegistry` dispatches element types to per-format renderers (coordinates with #917) - [ ] All output format tabs in the spec are reproducible by the implementation ## Subtasks - [ ] Refactor CLI commands to use `OutputSession` instead of `format_output()` — system commands (version, info, diagnostics, init) - [ ] Refactor CLI commands — session commands - [ ] Refactor CLI commands — project commands - [ ] Refactor CLI commands — actor commands - [ ] Refactor CLI commands — plan commands - [ ] Refactor CLI commands — resource, tool, skill, action, config, invariant, validation, lsp commands - [ ] Implement functional Rich materializer with `rich` Live Display integration - [ ] Implement streaming materialization mode for `--stream` - [ ] Align output envelope to spec structure (coordinates with #884) - [ ] Tests (Behave): Add scenarios for each output format - [ ] Tests (Robot): Add integration tests for command output structure - [ ] Verify coverage >=97% via `nox -s coverage_report` - [ ] Run `nox` (all default sessions), fix any errors ## Definition of Done This epic is complete when all child issues are closed AND every CLI command produces structured output through the OutputSession framework, the Rich materializer provides interactive terminal rendering, and all output formats match the specification examples.
freemo added the
MoSCoW
Must have
Priority
High
State
Verified
Type
Epic
 labels 2026-03-14 01:15:30 +00:00
freemo added this to the v3.5.0 milestone 2026-03-14 01:15:49 +00:00
freemo commented 2026-03-14 01:18:59 +00:00
Author
Owner
Copy Link
Copy Source

Dependency Links

Parent Legendary: cleverthis/cleveragents#3 — Core Functionality

Blocked by:

  • #933 (A2A Protocol) — CLI commands must route through A2A before OutputSession wiring

Coordinates with:

  • #884 (output envelope alignment) — envelope format change
  • #917 (RendererRegistry) — pluggable renderer dispatch
## Dependency Links **Parent Legendary**: [cleverthis/cleveragents#3 — Core Functionality](https://git.cleverthis.com/cleverthis/cleveragents/issues/3) **Blocked by**: - #933 (A2A Protocol) — CLI commands must route through A2A before OutputSession wiring **Coordinates with**: - #884 (output envelope alignment) — envelope format change - #917 (RendererRegistry) — pluggable renderer dispatch
freemo added the
Points
34
 label 2026-03-14 03:14:51 +00:00
freemo self-assigned this 2026-03-14 04:27:20 +00:00
freemo was unassigned by brent.edwards 2026-03-30 18:34:59 +00:00
brent.edwards self-assigned this 2026-03-30 18:34:59 +00:00
brent.edwards added
State
In Progress
 and removed
State
Verified
 labels 2026-03-30 18:35:18 +00:00
brent.edwards was unassigned by freemo 2026-04-02 06:13:55 +00:00
freemo self-assigned this 2026-04-02 06:13:55 +00:00
freemo removed the
State
In Progress
 label 2026-04-02 23:11:11 +00:00
freemo commented 2026-04-02 23:22:41 +00:00
Author
Owner
Copy Link
Copy Source

Label compliance fix applied:

  • Replaced orphaned label State/In Progress with valid label State/In progress
  • Reason: State/In Progress (capital P) is an orphaned label that no longer exists in the repository's label list. The correct label is State/In progress (lowercase p, ID: 1322).

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: ca-backlog-groomer

Label compliance fix applied: - Replaced orphaned label `State/In Progress` with valid label `State/In progress` - Reason: `State/In Progress` (capital P) is an orphaned label that no longer exists in the repository's label list. The correct label is `State/In progress` (lowercase p, ID: 1322). --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: ca-backlog-groomer
HAL9000 added the
State
Unverified
 label 2026-04-17 06:03:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
MoSCoW
Must have
Points
34
Priority
High
State
Unverified
Type
Epic
Milestone
No items
No Milestone v3.5.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees freemo
1 Participants
Notifications
Due Date
No due date set.
Blocks
#945 Legendary: Specification Alignment — Close All Gaps Between Implementation and Specification
cleveragents/cleveragents-core
#1879 UAT: JSON/YAML envelope `messages` field is an empty dict `{}` instead of spec-required list of `{level, text}` objects
cleveragents/cleveragents-core
#1880 TDD: JSON/YAML envelope `messages` field is an empty dict `{}` instead of spec-required list of `{level, text}` objects
cleveragents/cleveragents-core
#1944 UAT: JSON/YAML envelope `timing` field uses wrong structure — spec requires `{duration_ms: N}` but implementation produces `{start_time, end_time, duration}`
cleveragents/cleveragents-core
#1949 TDD: JSON/YAML envelope `timing` field uses wrong structure — spec requires `{duration_ms: N}` but implementation produces `{start_time, end_time, duration}`
cleveragents/cleveragents-core
#2080 UAT: `agents skill add` Tool Sources panel missing "Details" column — shows only Source and Count
cleveragents/cleveragents-core
Depends on
#1468 UAT: `agents plan use` rich output missing spec-required structured panels (Plan Created, Inputs, Actors, Automation, Context, Next Steps)
cleveragents/cleveragents-core
#1473 UAT: `agents plan cancel` rich output is a one-liner — missing spec-required structured panels (Plan Cancelled, Sandbox, Child Plans, Recovery)
cleveragents/cleveragents-core
#1499 UAT: `agents actor add` rich output missing spec-required `Type`, `Config`, `Capabilities`, and `Tools` panels
cleveragents/cleveragents-core
#1735 UAT: `agents config list` incorrectly masks non-secret config values containing "token" or "key" in key name
cleveragents/cleveragents-core
#1814 UAT: `agents project list` rich output missing spec-required `Remote`, `Active Plans` columns and `Summary` panel
cleveragents/cleveragents-core
#1827 UAT: `format_output()` `color` format returns plain text without ANSI codes — spec requires colored output
cleveragents/cleveragents-core
#1839 UAT: `agents config list <PATTERN>` includes false positive keys when pattern is a glob (e.g. `plan.*` matches `sandbox.checkpoint.max-per-plan`)
cleveragents/cleveragents-core
#1877 UAT: `agents project show` rich output missing spec-required panels (Active Plans, Validations, Context, Indexing Status) and shows resource IDs instead of names
cleveragents/cleveragents-core
#1878 UAT: `agents resource add` rich output missing spec-required structured panels (Resource, Auto-discovered Children, Capabilities)
cleveragents/cleveragents-core
#1935 UAT: `agents resource remove` does not cascade-delete child resources and blocks on DAG edges instead of project links
cleveragents/cleveragents-core
#1945 UAT: `agents resource type add` rich output uses single combined panel instead of spec-required separate panels, and `--update` flag not implemented
cleveragents/cleveragents-core
#1982 UAT: `CLEVERAGENTS_FORMAT` environment variable not supported — spec requires it as second-highest priority in format resolution chain
cleveragents/cleveragents-core
#1986 UAT: `agents project delete` rich output missing spec-required structured panels (Deletion Summary, Index Cleanup, Backups)
cleveragents/cleveragents-core
#2047 UAT: `agents resource type add --update` does not overwrite existing type — aborts with "Update mode is not yet fully supported"
cleveragents/cleveragents-core
#2053 UAT: `SkillService.add_skill` sets `description` to empty string when omitted, causing Pydantic `ValidationError` instead of a user-friendly error
cleveragents/cleveragents-core
#2057 UAT: `SkillService.get_dependents()` always returns empty actors list — `skill remove` dependency check never warns about referencing actors
cleveragents/cleveragents-core
#2062 UAT: `agents resource type show` rich output uses a single flat panel instead of spec-required separate structured panels
cleveragents/cleveragents-core
#2063 UAT: `--data-dir` and `--config-path` global CLI flags are missing from `agents` command — spec requires them as top-level options
cleveragents/cleveragents-core
#2067 UAT: `agents skill tools --format json` omits `read_only`, `writes`, and `checkpoint` fields for non-inline tools
cleveragents/cleveragents-core
#2072 UAT: `-p` shorthand for `--project` missing from `agents invariant add` and `agents invariant list` — spec requires it
cleveragents/cleveragents-core
#2075 UAT: `core.format` config key is registered but never applied — setting it has no effect on CLI output format
cleveragents/cleveragents-core
#2077 UAT: `SkillCapabilitySummary` missing `requires_approval` field — `skill show` capability summary panel incomplete
cleveragents/cleveragents-core
#2082 UAT: `agents project clean` is an unimplemented stub — outputs "not yet implemented" and aborts instead of cleaning project cache
cleveragents/cleveragents-core
#2087 UAT: All `agents skill` commands produce raw JSON output without the spec-required `{command, status, exit_code, data, timing, messages}` envelope
cleveragents/cleveragents-core
#2092 UAT: `agents invariant list --effective` not restricted to `--plan` scope — spec requires `--effective` only with `--plan`
cleveragents/cleveragents-core
#2094 UAT: `agents invariant add` silently defaults to `--global` when no scope flag is provided — spec requires at least one scope flag
cleveragents/cleveragents-core
#2095 UAT: Child plan spawning does not propagate parent plan's effective invariant set — spec requires inheritance
cleveragents/cleveragents-core
#2102 UAT: `merge_invariants()` and `InvariantSet.merge()` lack `action_invariants` parameter — inconsistent with four-scope architecture
cleveragents/cleveragents-core
#2104 UAT: `agents invariant add` rich output uses plain text lines instead of spec-required panel box format
cleveragents/cleveragents-core
#2108 UAT: `agents skill refresh` does not actually refresh MCP tools — stub implementation with TODO comment
cleveragents/cleveragents-core
#2120 UAT: `--format color` renders plain text without ANSI color codes — spec requires ANSI-colored output
cleveragents/cleveragents-core
#2121 UAT: Global CLI options `--data-dir`, `--config-path`, and `-v` (verbosity) are missing from `main_callback()` — spec requires them as global options
cleveragents/cleveragents-core
#2127 UAT: `agents diagnostics` missing health checks for text index (tantivy), vector index (faiss), and graph store — spec requires these checks
cleveragents/cleveragents-core
#2128 UAT: `--format` help text on `version`, `info`, and `diagnostics` commands omits `table` and `color` formats — spec defines 6 valid formats
cleveragents/cleveragents-core
#2133 UAT: `--format` is not a global option — spec requires `agents --format <fmt> <command>` syntax but only per-command `agents <command> --format <fmt>` works
cleveragents/cleveragents-core
#2908 UAT Bug: `--format` flag is per-command rather than global — spec requires a single global `--format` option on the root CLI callback
cleveragents/cleveragents-core
#2921 UAT: `format_output()` silently falls back to JSON for `rich` format — spec requires styled terminal output with Rich library components
cleveragents/cleveragents-core
#2998 UAT: `agents validation attach` args format mismatch — spec shows `--coverage-threshold 90` named options but implementation requires `coverage_threshold=90` positional key=value pairs
cleveragents/cleveragents-core
#3998 UAT: Global `--format` flag not implemented at top-level CLI — spec requires `agents --format table <subcommand>` syntax
cleveragents/cleveragents-core
#3999 UAT: `format_output()` with `rich` format silently falls back to JSON — should use rich/color renderer
cleveragents/cleveragents-core
#4004 UAT: `render_error()` JSON/YAML output goes to stdout instead of stderr — error output should be on stderr
cleveragents/cleveragents-core
#8987 refactor(output): Refactor system, session, and project CLI commands to use OutputSession
cleveragents/cleveragents-core
#8996 refactor(output): Refactor actor, plan, and resource/tool/skill/config CLI commands to use OutputSession
cleveragents/cleveragents-core
#8997 feat(output): Implement functional Rich materializer with rich Live Display integration
cleveragents/cleveragents-core
#8998 feat(output): Align output envelope to spec, implement streaming materialization, and add output format tests
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#936
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?