UAT: `agents skill add` Tool Sources panel missing "Details" column — shows only Source and Count #2080

New issue

Open

opened 2026-04-03 03:53:36 +00:00 by freemo · 1 comment

freemo commented

2026-04-03 03:53:36 +00:00

Owner

Metadata

Branch: fix/skill-add-tool-sources-details-column
Commit Message: fix(cli): add missing Details column to Tool Sources panel in skill add output
Milestone: v3.7.0
Parent Epic: #936

Background

The _print_skill_registered() function in src/cleveragents/cli/commands/skill.py renders the "Tool Sources" panel after agents skill add completes. The spec (§agents skill add, Rich output) defines a 3-column table (Source, Count, Details), but the implementation only renders 2 columns (Source, Count), omitting the Details column entirely.

Spec-defined output (§agents skill add):

╭─ Tool Sources ────────────────────────────────╮
│ Source         Count  Details                 │
│ ─────────────  ─────  ───────────────────     │
│ builtin        14     file, dir, git, shell   │
│ mcp            6      github (4), linear (2)  │
│ agent_skill    2      deploy, code-review     │
│ custom         1      run_migrations          │
│ ─────────────  ─────  ───────────────────     │
│ Total:         23                             │
╰───────────────────────────────────────────────╯

Actual output (from implementation):

╭─ Tool Sources ──╮
│ Source  ┃ Count │
│ ━━━━━━━━╇━━━━━━ │
│ builtin │     2 │
│ Total   │     2 │
╰─────────────────╯

Buggy code in src/cleveragents/cli/commands/skill.py, _print_skill_registered():

source_table = Table(show_header=True, show_edge=False, pad_edge=False)
source_table.add_column("Source", style="cyan")
source_table.add_column("Count", justify="right")
# BUG: Missing "Details" column
total = 0
if "builtin" in sources:
    c = len(skill.tool_refs)
    total += c
    source_table.add_row("builtin", str(c))  # BUG: No details argument

Root Cause: The _print_skill_registered() function creates the Tool Sources table with only 2 columns (Source, Count) instead of the 3 columns (Source, Count, Details) required by the spec. The Details column must be populated with descriptive names of the tools or servers in each source category.

Subtasks

Write a TDD issue-capture Behave scenario (@tdd_expected_fail) that asserts the Details column is present and populated in the Tool Sources panel output
Add the "Details" column to the Table definition in _print_skill_registered()
Populate Details for builtin source: comma-separated tool ref names (e.g., file, dir, git, shell)
Populate Details for mcp source: server names with per-server tool counts (e.g., github (4), linear (2))
Populate Details for agent_skill source: agent skill folder names (e.g., deploy, code-review)
Populate Details for custom source: inline tool names (e.g., run_migrations)
Remove @tdd_expected_fail tag once the fix is in place and the scenario passes
Run nox (all default sessions) and fix any errors
Verify coverage >= 97% via nox -s coverage_report

Definition of Done

A Behave scenario exists that asserts the Tool Sources panel renders 3 columns: Source, Count, Details
The Details column is populated correctly for all 4 source types (builtin, mcp, agent_skill, custom)
The rendered output matches the spec example in §agents skill add (Rich output)
No regressions in existing skill command tests
All nox stages pass
Coverage >= 97%
PR is merged and this issue is closed

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-new-issue-creator

## Metadata - **Branch**: `fix/skill-add-tool-sources-details-column` - **Commit Message**: `fix(cli): add missing Details column to Tool Sources panel in skill add output` - **Milestone**: v3.7.0 - **Parent Epic**: #936 ## Background The `_print_skill_registered()` function in `src/cleveragents/cli/commands/skill.py` renders the "Tool Sources" panel after `agents skill add` completes. The spec (§agents skill add, Rich output) defines a 3-column table (Source, Count, Details), but the implementation only renders 2 columns (Source, Count), omitting the Details column entirely. **Spec-defined output (§agents skill add):** ``` ╭─ Tool Sources ────────────────────────────────╮ │ Source Count Details │ │ ───────────── ───── ─────────────────── │ │ builtin 14 file, dir, git, shell │ │ mcp 6 github (4), linear (2) │ │ agent_skill 2 deploy, code-review │ │ custom 1 run_migrations │ │ ───────────── ───── ─────────────────── │ │ Total: 23 │ ╰───────────────────────────────────────────────╯ ``` **Actual output (from implementation):** ``` ╭─ Tool Sources ──╮ │ Source ┃ Count │ │ ━━━━━━━━╇━━━━━━ │ │ builtin │ 2 │ │ Total │ 2 │ ╰─────────────────╯ ``` **Buggy code in `src/cleveragents/cli/commands/skill.py`, `_print_skill_registered()`:** ```python source_table = Table(show_header=True, show_edge=False, pad_edge=False) source_table.add_column("Source", style="cyan") source_table.add_column("Count", justify="right") # BUG: Missing "Details" column total = 0 if "builtin" in sources: c = len(skill.tool_refs) total += c source_table.add_row("builtin", str(c)) # BUG: No details argument ``` **Root Cause:** The `_print_skill_registered()` function creates the Tool Sources table with only 2 columns (Source, Count) instead of the 3 columns (Source, Count, Details) required by the spec. The Details column must be populated with descriptive names of the tools or servers in each source category. ## Subtasks - [ ] Write a TDD issue-capture Behave scenario (`@tdd_expected_fail`) that asserts the Details column is present and populated in the Tool Sources panel output - [ ] Add the "Details" column to the `Table` definition in `_print_skill_registered()` - [ ] Populate Details for `builtin` source: comma-separated tool ref names (e.g., `file, dir, git, shell`) - [ ] Populate Details for `mcp` source: server names with per-server tool counts (e.g., `github (4), linear (2)`) - [ ] Populate Details for `agent_skill` source: agent skill folder names (e.g., `deploy, code-review`) - [ ] Populate Details for `custom` source: inline tool names (e.g., `run_migrations`) - [ ] Remove `@tdd_expected_fail` tag once the fix is in place and the scenario passes - [ ] Run `nox` (all default sessions) and fix any errors - [ ] Verify coverage >= 97% via `nox -s coverage_report` ## Definition of Done - [ ] A Behave scenario exists that asserts the Tool Sources panel renders 3 columns: Source, Count, Details - [ ] The Details column is populated correctly for all 4 source types (`builtin`, `mcp`, `agent_skill`, `custom`) - [ ] The rendered output matches the spec example in §agents skill add (Rich output) - [ ] No regressions in existing `skill` command tests - [ ] All nox stages pass - [ ] Coverage >= 97% - [ ] PR is merged and this issue is closed --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-new-issue-creator

freemo added this to the v3.7.0 milestone

2026-04-03 03:53:40 +00:00

freemo added a new dependency

2026-04-03 03:54:29 +00:00

#936 Epic: Output Rendering Pipeline Integration — Wire Commands to OutputSession Framework

freemo referenced this issue

2026-04-03 03:57:57 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.7.0 — Session Tracker #2023

freemo referenced this issue

2026-04-03 03:58:31 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.7.0 — Session Tracker #2023

freemo referenced this issue

2026-04-03 04:01:23 +00:00

[UAT-SUPERVISOR] Progress Report — Cycle 701 — v3.7.0 #2093

freemo referenced this issue

2026-04-03 04:22:00 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.7.0 — Session Tracker #2023

freemo self-assigned this

2026-04-03 16:58:09 +00:00

freemo commented

2026-04-03 18:28:20 +00:00

Author

Owner

MoSCoW classification: Should Have

Rationale: This issue addresses a spec requirement or important quality improvement. It should be included in the milestone if possible.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

MoSCoW classification: **Should Have** Rationale: This issue addresses a spec requirement or important quality improvement. It should be included in the milestone if possible. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner