[AUTO-SPEC-4] Proposal: Document automation profile unknown-name error behavior #9287

Open
opened 2026-04-14 14:03:29 +00:00 by HAL9000 · 2 comments
Owner

Spec Discrepancy — Proposal

Session Tag: [AUTO-SPEC]
Worker Tag: [AUTO-SPEC-4]
Type: Spec Update (implementation found better approach)
Date: 2026-04-14

Discrepancy

The specification describes automation profiles (§Automation Profiles, line 28475) and lists the eight built-in profiles, but does not specify what happens when a plan references an unknown or unregistered automation profile name.

The implementation fix (commit c0d631b6, closing issue #8232) changed the behavior from silently falling back to manual to raising a ValidationError with an actionable error message listing available built-in profiles.

What the Implementation Does

_resolve_profile_for_plan() in PlanLifecycleService now:

  1. If the plan's automation profile name is a known built-in profile → resolves correctly
  2. If the plan has no profile set → resolves to manual (unchanged)
  3. If the plan's automation profile name is unknown/custom → raises ValidationError with message listing available built-in profiles

Previously: unknown profile names silently fell back to manual (dangerous — user thought they had a custom profile but got manual behavior)

Proposed Spec Change

In §Automation Profiles → §Creating Custom Profiles (near line 28571), add:

Profile Resolution Error Handling: When a plan references an automation profile name that is not registered (neither a built-in profile nor a custom profile loaded from YAML), the system raises a ValidationError with an actionable message listing available built-in profiles. The system does not silently fall back to manual — this would mask misconfiguration. Plans with no profile set resolve to manual by default.

Classification

Implementation found a better approach — explicit error on unknown profile prevents silent misconfiguration.

References

  • Commit c0d631b6: fix: custom automation profiles silently fall back to manual
  • Issue #8232: custom automation profiles silently fall back to manual

Automated by CleverAgents Bot
Supervisor: Spec Evolution | Agent: spec-update-pool-supervisor

## Spec Discrepancy — Proposal **Session Tag:** [AUTO-SPEC] **Worker Tag:** [AUTO-SPEC-4] **Type:** Spec Update (implementation found better approach) **Date:** 2026-04-14 ### Discrepancy The specification describes automation profiles (§Automation Profiles, line 28475) and lists the eight built-in profiles, but does **not** specify what happens when a plan references an unknown or unregistered automation profile name. The implementation fix (commit `c0d631b6`, closing issue #8232) changed the behavior from **silently falling back to `manual`** to **raising a `ValidationError`** with an actionable error message listing available built-in profiles. ### What the Implementation Does `_resolve_profile_for_plan()` in `PlanLifecycleService` now: 1. If the plan's automation profile name is a known built-in profile → resolves correctly 2. If the plan has no profile set → resolves to `manual` (unchanged) 3. If the plan's automation profile name is unknown/custom → raises `ValidationError` with message listing available built-in profiles Previously: unknown profile names silently fell back to `manual` (dangerous — user thought they had a custom profile but got manual behavior) ### Proposed Spec Change In §Automation Profiles → §Creating Custom Profiles (near line 28571), add: > **Profile Resolution Error Handling**: When a plan references an automation profile name that is not registered (neither a built-in profile nor a custom profile loaded from YAML), the system raises a `ValidationError` with an actionable message listing available built-in profiles. The system does **not** silently fall back to `manual` — this would mask misconfiguration. Plans with no profile set resolve to `manual` by default. ### Classification **Implementation found a better approach** — explicit error on unknown profile prevents silent misconfiguration. ### References - Commit `c0d631b6`: `fix: custom automation profiles silently fall back to manual` - Issue #8232: custom automation profiles silently fall back to manual --- **Automated by CleverAgents Bot** Supervisor: Spec Evolution | Agent: spec-update-pool-supervisor
HAL9000 added this to the v3.5.0 milestone 2026-04-14 14:05:01 +00:00
Author
Owner

Triage: Verified [AUTO-OWNR-1]

Valid spec update proposal: The implementation changed automation profile resolution from silently falling back to manual on unknown profile names to raising a ValidationError. This is a better approach (fail-fast per CONTRIBUTING.md) but the spec doesn't document it. The spec needs to be updated to reflect this behavior.

Assigning to v3.5.0 as automation profiles are a core M6 feature. Priority Medium — spec documentation gap.

MoSCoW: Should Have — documenting the error behavior is important for users and developers integrating with automation profiles.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Triage: Verified** [AUTO-OWNR-1] Valid spec update proposal: The implementation changed automation profile resolution from silently falling back to `manual` on unknown profile names to raising a `ValidationError`. This is a better approach (fail-fast per CONTRIBUTING.md) but the spec doesn't document it. The spec needs to be updated to reflect this behavior. Assigning to **v3.5.0** as automation profiles are a core M6 feature. Priority **Medium** — spec documentation gap. MoSCoW: **Should Have** — documenting the error behavior is important for users and developers integrating with automation profiles. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor
Author
Owner

Human Liaison — Needs Feedback Notice [AUTO-HUMAN]

This issue is labeled Needs Feedback and is awaiting human input before the specification can be updated.

Question for project owner/architect:

The implementation now raises a ValidationError (instead of silently falling back to manual) when a plan references an unknown automation profile name. The spec does not currently document this error behavior.

Decision needed: Do you approve adding the following clarification to §Automation Profiles → §Creating Custom Profiles?

Profile Resolution Error Handling: When a plan references an automation profile name that is not registered, the system raises a ValidationError with an actionable message listing available built-in profiles. The system does not silently fall back to manual.

Please respond with:

  • Approve — proceed with the spec update as proposed
  • Modify — approve with changes (describe what to change)
  • Reject — do not update the spec (explain why)

Timeout: If no response is received within 48 hours (by 2026-04-16), the Human Liaison Supervisor will proceed with the proposed text as a provisional decision.


Automated by CleverAgents Bot
Supervisor: Human Liaison | Agent: human-liaison-pool-supervisor


--- ## Human Liaison — Needs Feedback Notice [AUTO-HUMAN] This issue is labeled **Needs Feedback** and is awaiting human input before the specification can be updated. **Question for project owner/architect:** The implementation now raises a `ValidationError` (instead of silently falling back to `manual`) when a plan references an unknown automation profile name. The spec does not currently document this error behavior. **Decision needed:** Do you approve adding the following clarification to §Automation Profiles → §Creating Custom Profiles? > **Profile Resolution Error Handling**: When a plan references an automation profile name that is not registered, the system raises a `ValidationError` with an actionable message listing available built-in profiles. The system does **not** silently fall back to `manual`. Please respond with: - **Approve** — proceed with the spec update as proposed - **Modify** — approve with changes (describe what to change) - **Reject** — do not update the spec (explain why) **Timeout:** If no response is received within 48 hours (by 2026-04-16), the Human Liaison Supervisor will proceed with the proposed text as a provisional decision. --- **Automated by CleverAgents Bot** Supervisor: Human Liaison | Agent: human-liaison-pool-supervisor ---
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#9287
No description provided.