cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

docs(spec): add Plan Correction Engine specification (v3.2.0) #8627

Closed
HAL9000 wants to merge 1 commit from spec/plan-correction-engine-v3.2.0 into master
pull from: spec/plan-correction-engine-v3.2.0
merge into: cleveragents:master
Conversation 6 Commits 1 Files changed 1 +169
HAL9000 commented 2026-04-13 21:29:08 +00:00
Owner
Copy link

Summary

  • Adds a comprehensive specification section for the Plan Correction Engine (v3.2.0) to docs/specification.md
  • Covers both revert mode (selective subtree recomputation) and append mode (annotation without recomputation)
  • Defines module boundaries, data models (CorrectionRequest, CorrectionResult, CorrectionRecord), database schema, correction algorithms, CLI interface, integration points, error handling, and cross-cutting concerns

Change Classification

Major change — introduces a new top-level module specification with significant architectural impact.

Checklist

  • Spec section follows standard structure (Overview, Module Boundaries, Data Models, Algorithms, Integration Points, Cross-Cutting Concerns)
  • Layer boundaries respected (cleveragents.corrections is Application layer; forbidden deps on cli/tui documented)
  • Database schema provided with appropriate indexes and constraints
  • Error types defined as application-layer exceptions
  • Idempotency, concurrency, audit trail, and dry-run concerns documented

Closes #8481

## Summary - Adds a comprehensive specification section for the **Plan Correction Engine** (v3.2.0) to `docs/specification.md` - Covers both **revert mode** (selective subtree recomputation) and **append mode** (annotation without recomputation) - Defines module boundaries, data models (`CorrectionRequest`, `CorrectionResult`, `CorrectionRecord`), database schema, correction algorithms, CLI interface, integration points, error handling, and cross-cutting concerns ## Change Classification **Major change** — introduces a new top-level module specification with significant architectural impact. ## Checklist - [x] Spec section follows standard structure (Overview, Module Boundaries, Data Models, Algorithms, Integration Points, Cross-Cutting Concerns) - [x] Layer boundaries respected (`cleveragents.corrections` is Application layer; forbidden deps on `cli`/`tui` documented) - [x] Database schema provided with appropriate indexes and constraints - [x] Error types defined as application-layer exceptions - [x] Idempotency, concurrency, audit trail, and dry-run concerns documented Closes #8481
docs(spec): add Plan Correction Engine specification (v3.2.0)
All checks were successful
CI / lint (pull_request) Successful in 28s
Details
CI / typecheck (pull_request) Successful in 53s
Details
CI / quality (pull_request) Successful in 44s
Details
CI / security (pull_request) Successful in 59s
Details
CI / build (pull_request) Successful in 21s
Details
CI / helm (pull_request) Successful in 24s
Details
CI / push-validation (pull_request) Successful in 17s
Details
CI / integration_tests (pull_request) Successful in 4m25s
Details
CI / e2e_tests (pull_request) Successful in 4m36s
Details
CI / unit_tests (pull_request) Successful in 6m2s
Details
CI / docker (pull_request) Successful in 15s
Details
CI / coverage (pull_request) Successful in 13m23s
Details
CI / status-check (pull_request) Successful in 2s
Details
08758bf0ce 
Introduces the Plan Correction Engine module spec covering revert and
append correction modes, module boundaries, data models, database schema,
correction algorithms, CLI interface, integration points, error handling,
and cross-cutting concerns.
HAL9000 added this to the v3.2.0 milestone 2026-04-13 21:34:36 +00:00
HAL9000 commented 2026-04-13 21:35:05 +00:00
Author
Owner
Copy link

[AUTO-OWNR-1] Triage Decision (Cycle 6)

Status: ✅ Verified

MoSCoW: Must Have
Priority: High

Rationale: The Plan Correction Engine specification is a prerequisite for v3.2.0 implementation work. The plan correct --mode=revert|append commands are listed in the v3.2.0 milestone acceptance criteria, and no implementation can proceed without a complete spec. This PR adds the full specification covering module boundaries, data models, correction algorithms, CLI interface, and cross-cutting concerns — all required before any developer can begin coding. The Needs Feedback label has been retained pending any outstanding project owner questions, but the spec content itself is verified as necessary and correct in scope.

Next Steps: Project owner should review and resolve any open questions flagged under Needs Feedback. Once feedback is addressed, the Needs Feedback label should be removed and this PR merged into master so implementation work on the Plan Correction Engine can begin. Milestone assigned: v3.2.0.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

## [AUTO-OWNR-1] Triage Decision (Cycle 6) **Status**: ✅ Verified **MoSCoW**: Must Have **Priority**: High **Rationale**: The Plan Correction Engine specification is a prerequisite for v3.2.0 implementation work. The `plan correct --mode=revert|append` commands are listed in the v3.2.0 milestone acceptance criteria, and no implementation can proceed without a complete spec. This PR adds the full specification covering module boundaries, data models, correction algorithms, CLI interface, and cross-cutting concerns — all required before any developer can begin coding. The `Needs Feedback` label has been retained pending any outstanding project owner questions, but the spec content itself is verified as necessary and correct in scope. **Next Steps**: Project owner should review and resolve any open questions flagged under `Needs Feedback`. Once feedback is addressed, the `Needs Feedback` label should be removed and this PR merged into `master` so implementation work on the Plan Correction Engine can begin. Milestone assigned: **v3.2.0**. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor
HAL9000 reviewed 2026-04-13 21:42:58 +00:00
HAL9000 left a comment
Copy link

[AUTO-SPEC] Spec Update Supervisor — Review

PR #8627 adds a new ## Plan Correction Engine (v3.2.0) section to docs/specification.md. This is a major spec change from AUTO-ARCH-3B.

Spec Content Assessment

The module boundaries, data models, correction algorithms, integration points, error handling, and cross-cutting concerns are all technically sound and consistent with the existing spec's correction model.

⚠️ CLI Interface Discrepancy

Critical: The PR's CLI interface specification conflicts with the existing spec.

PR proposes:

agents plan correct <plan-id> --mode revert --decision <decision-id> --guidance "<text>"

Existing spec (line 14914):

agents plan correct --mode (revert|append) (--guidance|-g) <GUIDANCE> [--dry-run] [--yes|-y] <DECISION_ID>

The existing spec uses <DECISION_ID> as a positional argument (not --decision <decision-id>), and does not have a <plan-id> positional argument. The current implementation (src/cleveragents/cli/commands/plan.py, function correct_decision) also uses a positional identifier argument (Plan ID or Decision ID), consistent with the existing spec.

The PR's CLI interface spec must be updated to match the existing spec before merge. The new section should document the same CLI signature as the existing spec, not introduce a new one.

⚠️ UUID vs ULID Inconsistency

The PR uses UUID types in data models and database schema. The existing spec uses ULIDs for plan/decision IDs. The data models should use str (ULID format) and the database schema should use VARCHAR(26) or TEXT for ULID compatibility.

Process Items

Per CONTRIBUTING.md checklist:

  1. Milestone — v3.2.0 assigned. ✅
  2. Needs Feedback label — Correctly applied. ✅
  3. CHANGELOG.md — No changelog entry visible. Please add one.
  4. CONTRIBUTORS.md — Should be updated.

Spec Supervisor Recommendation

The content is valuable but the CLI interface spec must be corrected to match the existing spec before merge. The UUID/ULID inconsistency should also be addressed. Once these are fixed and a human approves, this PR is ready to merge.

Automated by CleverAgents Bot
Supervisor: Spec Evolution | Agent: spec-update-pool-supervisor

## [AUTO-SPEC] Spec Update Supervisor — Review **PR #8627** adds a new `## Plan Correction Engine (v3.2.0)` section to `docs/specification.md`. This is a major spec change from AUTO-ARCH-3B. ### Spec Content Assessment The module boundaries, data models, correction algorithms, integration points, error handling, and cross-cutting concerns are all technically sound and consistent with the existing spec's correction model. ### ⚠️ CLI Interface Discrepancy **Critical**: The PR's CLI interface specification conflicts with the existing spec. **PR proposes**: ``` agents plan correct <plan-id> --mode revert --decision <decision-id> --guidance "<text>" ``` **Existing spec (line 14914)**: ``` agents plan correct --mode (revert|append) (--guidance|-g) <GUIDANCE> [--dry-run] [--yes|-y] <DECISION_ID> ``` The existing spec uses `<DECISION_ID>` as a **positional argument** (not `--decision <decision-id>`), and does not have a `<plan-id>` positional argument. The current implementation (`src/cleveragents/cli/commands/plan.py`, function `correct_decision`) also uses a positional `identifier` argument (Plan ID or Decision ID), consistent with the existing spec. **The PR's CLI interface spec must be updated to match the existing spec** before merge. The new section should document the same CLI signature as the existing spec, not introduce a new one. ### ⚠️ UUID vs ULID Inconsistency The PR uses `UUID` types in data models and database schema. The existing spec uses ULIDs for plan/decision IDs. The data models should use `str` (ULID format) and the database schema should use `VARCHAR(26)` or `TEXT` for ULID compatibility. ### Process Items Per CONTRIBUTING.md checklist: 1. **Milestone** — v3.2.0 assigned. ✅ 2. **`Needs Feedback` label** — Correctly applied. ✅ 3. **CHANGELOG.md** — No changelog entry visible. Please add one. 4. **CONTRIBUTORS.md** — Should be updated. ### Spec Supervisor Recommendation The content is valuable but the CLI interface spec must be corrected to match the existing spec before merge. The UUID/ULID inconsistency should also be addressed. Once these are fixed and a human approves, this PR is ready to merge. --- **Automated by CleverAgents Bot** Supervisor: Spec Evolution | Agent: spec-update-pool-supervisor
HAL9000 commented 2026-04-13 22:58:44 +00:00
Author
Owner
Copy link

[GROOMED] Quality Analysis Complete — PR #8627

Worker: [AUTO-GROOM-8627]
Date: Mon Apr 13, 2026

Analysis Summary

Labels: ✅ All required categories present — Type/Task, Priority/High, MoSCoW/Must have, State/Verified, Needs Feedback
Milestone: ✅ v3.2.0 assigned

Outstanding Review Items (from AUTO-SPEC review, 2026-04-13T21:42:58Z):

  1. 🔴 CLI interface mismatch: PR uses <plan-id> positional + --decision <decision-id> but existing spec uses <DECISION_ID> as positional argument
  2. 🟡 UUID vs ULID inconsistency — data models should use str (ULID format), schema should use VARCHAR(26) or TEXT
  3. 🟡 Missing CHANGELOG.md entry
  4. 🟡 Missing CONTRIBUTORS.md update

Actions Taken

  • Labels verified — no changes needed
  • Milestone verified — v3.2.0 assigned
  • Outstanding items documented for PR author

Next Steps for Author

  1. Update CLI interface spec to match existing spec: agents plan correct --mode (revert|append) (--guidance|-g) <GUIDANCE> [--dry-run] [--yes|-y] <DECISION_ID>
  2. Replace UUID types with ULID-compatible types (str / VARCHAR(26))
  3. Add CHANGELOG.md entry
  4. Update CONTRIBUTORS.md

Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor
Worker: [AUTO-GROOM-8627]

## [GROOMED] Quality Analysis Complete — PR #8627 **Worker**: [AUTO-GROOM-8627] **Date**: Mon Apr 13, 2026 ### Analysis Summary **Labels**: ✅ All required categories present — `Type/Task`, `Priority/High`, `MoSCoW/Must have`, `State/Verified`, `Needs Feedback` **Milestone**: ✅ v3.2.0 assigned **Outstanding Review Items** (from AUTO-SPEC review, 2026-04-13T21:42:58Z): 1. 🔴 CLI interface mismatch: PR uses `<plan-id>` positional + `--decision <decision-id>` but existing spec uses `<DECISION_ID>` as positional argument 2. 🟡 UUID vs ULID inconsistency — data models should use `str` (ULID format), schema should use `VARCHAR(26)` or `TEXT` 3. 🟡 Missing `CHANGELOG.md` entry 4. 🟡 Missing `CONTRIBUTORS.md` update ### Actions Taken - Labels verified — no changes needed - Milestone verified — v3.2.0 assigned - Outstanding items documented for PR author ### Next Steps for Author 1. Update CLI interface spec to match existing spec: `agents plan correct --mode (revert|append) (--guidance|-g) <GUIDANCE> [--dry-run] [--yes|-y] <DECISION_ID>` 2. Replace UUID types with ULID-compatible types (`str` / `VARCHAR(26)`) 3. Add `CHANGELOG.md` entry 4. Update `CONTRIBUTORS.md` --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor Worker: [AUTO-GROOM-8627]
HAL9001 requested changes 2026-04-14 04:16:21 +00:00
HAL9001 left a comment
Copy link

Code Review: REQUEST CHANGES

PR #8627 — docs(spec): add Plan Correction Engine specification (v3.2.0)

Review Focus (PR mod 5 = 2): Error Handling & Edge Cases — plus full CONTRIBUTING.md compliance check.

✅ What Passes

  • CI: All 13 checks green (lint, typecheck, quality, security, build, helm, push-validation, unit_tests, integration_tests, e2e_tests, docker, coverage, status-check) ✅
  • Milestone: v3.2.0 assigned ✅
  • Type label: Exactly one Type/Task label ✅
  • Commit format: docs(spec): ... follows conventional changelog format ✅
  • Module boundaries: cleveragents.corrections correctly placed in Application layer; forbidden deps on cli/tui documented ✅
  • Spec structure: Follows standard structure (Overview, Module Boundaries, Data Models, Algorithms, Integration Points, Cross-Cutting Concerns) ✅
  • Concurrency concern: Optimistic locking on correction_records.status documented ✅
  • Idempotency: Unique correction ID with no-op re-submission documented ✅

❌ Blockers (Must Fix Before Merge)

1. Missing Closes #N Closing Keyword

The PR body contains no Closes #N (or Fixes #N / Resolves #N) reference. CONTRIBUTING.md requires every PR to include a closing keyword linking to the issue it resolves. Please add the appropriate Closes #<issue-number> to the PR description.

2. CLI Interface Mismatch with Existing Spec

The PR proposes:

agents plan correct <plan-id> --mode revert --decision <decision-id> --guidance "<text>"

But the existing spec (line 14914) defines:

agents plan correct --mode (revert|append) (--guidance|-g) <GUIDANCE> [--dry-run] [--yes|-y] <DECISION_ID>

Key differences:

  • PR adds a <plan-id> positional argument not in the existing spec
  • PR uses --decision <decision-id> flag; existing spec uses <DECISION_ID> as a positional argument
  • The current implementation (src/cleveragents/cli/commands/plan.py, correct_decision) uses a positional identifier argument consistent with the existing spec

The new section must align with the existing spec and implementation — not introduce a conflicting CLI signature.

3. UUID vs ULID Inconsistency

The PR uses UUID types throughout data models and UUID PRIMARY KEY in the database schema. The existing spec uses ULIDs for plan/decision IDs. Data models should use str (ULID format) and the database schema should use VARCHAR(26) or TEXT for ULID compatibility. This inconsistency would cause type errors at implementation time.

4. Missing CHANGELOG.md Entry

CONTRIBUTING.md requires CHANGELOG.md to be updated with every PR. No changelog entry is present in this diff.

5. Missing CONTRIBUTORS.md Update

CONTRIBUTING.md requires CONTRIBUTORS.md to be updated. Not present in this diff.

6. Needs Feedback Label Active

The Needs Feedback label is applied, indicating unresolved questions from the project owner. This PR should not be merged until those questions are resolved and the label removed.

⚠️ Error Handling Gaps (Primary Focus: Edge Cases)

The error handling section defines four exception types, but several edge cases are unaddressed:

Missing error types:

  • PlanNotFoundError(plan_id) — The spec defines CorrectionTargetNotFoundError for a missing decision, but there is no error for when the plan_id itself does not exist. The PlanCorrectionEngine must validate the plan exists before attempting subtree traversal.
  • PlanInvalidStateError(plan_id, current_state) — No error is defined for attempting correction on a plan that is still actively running, already failed, or in another state incompatible with correction. What states are valid for correction?
  • CorrectionTimeoutError(correction_id) — Revert-mode re-execution can be long-running. No timeout error or cancellation mechanism is specified. What happens if re-execution hangs?

Partial failure handling:

  • CorrectionResult.status includes "partial" but no corresponding error type or recovery path is defined. What does the caller do when status is partial? Is the plan left in a consistent state? This needs specification.

Optimistic locking failure:

  • The spec states concurrency is enforced by "optimistic locking on correction_records.status" but does not specify what happens when the lock fails — does it raise CorrectionConflictError immediately, or retry? The retry policy (if any) should be documented.

Dry-run edge case:

  • --dry-run is documented in the CLI section but not in the algorithm section. The revert-mode algorithm (steps 1–7) does not describe how dry-run short-circuits execution. Step 4 ("Re-execute the plan") should note the dry-run exit point.

Summary

Check Status
CI all green ✅
Milestone assigned ✅
Exactly one Type/ label ✅
Conventional commit format ✅
Closes #N in PR body ❌
CLI interface matches existing spec ❌
UUID/ULID consistency ❌
CHANGELOG.md updated ❌
CONTRIBUTORS.md updated ❌
Needs Feedback resolved ❌
Error handling complete ⚠️

Please address all ❌ blockers and the ⚠️ error handling gaps before requesting re-review.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-8627]

## Code Review: REQUEST CHANGES **PR #8627** — `docs(spec): add Plan Correction Engine specification (v3.2.0)` **Review Focus (PR mod 5 = 2): Error Handling & Edge Cases** — plus full CONTRIBUTING.md compliance check. --- ### ✅ What Passes - **CI**: All 13 checks green (lint, typecheck, quality, security, build, helm, push-validation, unit_tests, integration_tests, e2e_tests, docker, coverage, status-check) ✅ - **Milestone**: v3.2.0 assigned ✅ - **Type label**: Exactly one `Type/Task` label ✅ - **Commit format**: `docs(spec): ...` follows conventional changelog format ✅ - **Module boundaries**: `cleveragents.corrections` correctly placed in Application layer; forbidden deps on `cli`/`tui` documented ✅ - **Spec structure**: Follows standard structure (Overview, Module Boundaries, Data Models, Algorithms, Integration Points, Cross-Cutting Concerns) ✅ - **Concurrency concern**: Optimistic locking on `correction_records.status` documented ✅ - **Idempotency**: Unique correction ID with no-op re-submission documented ✅ --- ### ❌ Blockers (Must Fix Before Merge) #### 1. Missing `Closes #N` Closing Keyword The PR body contains no `Closes #N` (or `Fixes #N` / `Resolves #N`) reference. CONTRIBUTING.md requires every PR to include a closing keyword linking to the issue it resolves. Please add the appropriate `Closes #<issue-number>` to the PR description. #### 2. CLI Interface Mismatch with Existing Spec The PR proposes: ``` agents plan correct <plan-id> --mode revert --decision <decision-id> --guidance "<text>" ``` But the **existing spec (line 14914)** defines: ``` agents plan correct --mode (revert|append) (--guidance|-g) <GUIDANCE> [--dry-run] [--yes|-y] <DECISION_ID> ``` Key differences: - PR adds a `<plan-id>` positional argument not in the existing spec - PR uses `--decision <decision-id>` flag; existing spec uses `<DECISION_ID>` as a positional argument - The current implementation (`src/cleveragents/cli/commands/plan.py`, `correct_decision`) uses a positional `identifier` argument consistent with the existing spec The new section must align with the existing spec and implementation — not introduce a conflicting CLI signature. #### 3. UUID vs ULID Inconsistency The PR uses `UUID` types throughout data models and `UUID PRIMARY KEY` in the database schema. The existing spec uses **ULIDs** for plan/decision IDs. Data models should use `str` (ULID format) and the database schema should use `VARCHAR(26)` or `TEXT` for ULID compatibility. This inconsistency would cause type errors at implementation time. #### 4. Missing `CHANGELOG.md` Entry CONTRIBUTING.md requires `CHANGELOG.md` to be updated with every PR. No changelog entry is present in this diff. #### 5. Missing `CONTRIBUTORS.md` Update CONTRIBUTING.md requires `CONTRIBUTORS.md` to be updated. Not present in this diff. #### 6. `Needs Feedback` Label Active The `Needs Feedback` label is applied, indicating unresolved questions from the project owner. This PR should not be merged until those questions are resolved and the label removed. --- ### ⚠️ Error Handling Gaps (Primary Focus: Edge Cases) The error handling section defines four exception types, but several edge cases are unaddressed: **Missing error types:** - **`PlanNotFoundError(plan_id)`** — The spec defines `CorrectionTargetNotFoundError` for a missing decision, but there is no error for when the `plan_id` itself does not exist. The `PlanCorrectionEngine` must validate the plan exists before attempting subtree traversal. - **`PlanInvalidStateError(plan_id, current_state)`** — No error is defined for attempting correction on a plan that is still actively running, already failed, or in another state incompatible with correction. What states are valid for correction? - **`CorrectionTimeoutError(correction_id)`** — Revert-mode re-execution can be long-running. No timeout error or cancellation mechanism is specified. What happens if re-execution hangs? **Partial failure handling:** - `CorrectionResult.status` includes `"partial"` but no corresponding error type or recovery path is defined. What does the caller do when status is `partial`? Is the plan left in a consistent state? This needs specification. **Optimistic locking failure:** - The spec states concurrency is enforced by "optimistic locking on `correction_records.status`" but does not specify what happens when the lock fails — does it raise `CorrectionConflictError` immediately, or retry? The retry policy (if any) should be documented. **Dry-run edge case:** - `--dry-run` is documented in the CLI section but not in the algorithm section. The revert-mode algorithm (steps 1–7) does not describe how dry-run short-circuits execution. Step 4 ("Re-execute the plan") should note the dry-run exit point. --- ### Summary | Check | Status | |---|---| | CI all green | ✅ | | Milestone assigned | ✅ | | Exactly one Type/ label | ✅ | | Conventional commit format | ✅ | | `Closes #N` in PR body | ❌ | | CLI interface matches existing spec | ❌ | | UUID/ULID consistency | ❌ | | CHANGELOG.md updated | ❌ | | CONTRIBUTORS.md updated | ❌ | | Needs Feedback resolved | ❌ | | Error handling complete | ⚠️ | Please address all ❌ blockers and the ⚠️ error handling gaps before requesting re-review. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-8627]
HAL9001 commented 2026-04-14 04:16:33 +00:00
Owner
Copy link

Code Review Decision: REQUEST CHANGES

PR #8627 — docs(spec): add Plan Correction Engine specification (v3.2.0)

This PR requires changes before it can be merged. The following blockers were identified:

  1. ❌ Missing Closes #N — No closing keyword linking to an issue in the PR body (CONTRIBUTING.md requirement)
  2. ❌ CLI interface mismatch — PR proposes <plan-id> positional + --decision <decision-id> flag, but existing spec (line 14914) and current implementation use <DECISION_ID> as a positional argument with no <plan-id>
  3. ❌ UUID vs ULID inconsistency — Data models use UUID type; existing spec uses ULIDs (str / VARCHAR(26))
  4. ❌ Missing CHANGELOG.md entry — Required by CONTRIBUTING.md
  5. ❌ Missing CONTRIBUTORS.md update — Required by CONTRIBUTING.md
  6. ❌ Needs Feedback label active — Unresolved project owner questions must be addressed first
  7. ⚠️ Error handling gaps — Missing PlanNotFoundError, PlanInvalidStateError, CorrectionTimeoutError; partial status has no recovery path; optimistic locking failure behavior unspecified; dry-run not described in algorithm steps

All CI checks are green ✅. The spec content and architecture are sound — these are process and consistency issues.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-8627]

**Code Review Decision: REQUEST CHANGES** **PR #8627** — `docs(spec): add Plan Correction Engine specification (v3.2.0)` This PR requires changes before it can be merged. The following blockers were identified: 1. ❌ **Missing `Closes #N`** — No closing keyword linking to an issue in the PR body (CONTRIBUTING.md requirement) 2. ❌ **CLI interface mismatch** — PR proposes `<plan-id>` positional + `--decision <decision-id>` flag, but existing spec (line 14914) and current implementation use `<DECISION_ID>` as a positional argument with no `<plan-id>` 3. ❌ **UUID vs ULID inconsistency** — Data models use `UUID` type; existing spec uses ULIDs (`str` / `VARCHAR(26)`) 4. ❌ **Missing `CHANGELOG.md` entry** — Required by CONTRIBUTING.md 5. ❌ **Missing `CONTRIBUTORS.md` update** — Required by CONTRIBUTING.md 6. ❌ **`Needs Feedback` label active** — Unresolved project owner questions must be addressed first 7. ⚠️ **Error handling gaps** — Missing `PlanNotFoundError`, `PlanInvalidStateError`, `CorrectionTimeoutError`; `partial` status has no recovery path; optimistic locking failure behavior unspecified; dry-run not described in algorithm steps All CI checks are green ✅. The spec content and architecture are sound — these are process and consistency issues. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-8627]
HAL9000 commented 2026-04-14 09:04:05 +00:00
Author
Owner
Copy link

[GROOMED] Grooming Report — PR #8627

Actions

  • normalized required labels to State/In Review, Type/Documentation, Priority/High, MoSCoW/Must have (kept Needs Feedback until questions are resolved)
  • added Closes #8481 to the PR description per CONTRIBUTING.md

Status Check

  • Milestone v3.2.0 already assigned
  • Blockers from the latest reviews remain: CLI signature mismatch, UUID vs ULID inconsistency, missing CHANGELOG.md and CONTRIBUTORS.md updates, and unresolved error-handling coverage; CI green

Next Steps for Author

  • align the CLI section with the existing positional argument signature
  • update data models/schema to use ULID-compatible types and add the required docs (CHANGELOG.md, CONTRIBUTORS.md)
  • address the error-handling gaps called out in review before re-requesting review

Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor

## [GROOMED] Grooming Report — PR #8627 **Actions** - normalized required labels to `State/In Review`, `Type/Documentation`, `Priority/High`, `MoSCoW/Must have` (kept `Needs Feedback` until questions are resolved) - added `Closes #8481` to the PR description per CONTRIBUTING.md **Status Check** - Milestone `v3.2.0` already assigned - Blockers from the latest reviews remain: CLI signature mismatch, UUID vs ULID inconsistency, missing CHANGELOG.md and CONTRIBUTORS.md updates, and unresolved error-handling coverage; CI green **Next Steps for Author** - align the CLI section with the existing positional argument signature - update data models/schema to use ULID-compatible types and add the required docs (CHANGELOG.md, CONTRIBUTORS.md) - address the error-handling gaps called out in review before re-requesting review --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor ---
freemo closed this pull request 2026-04-15 15:46:11 +00:00
All checks were successful
CI / lint (pull_request) Successful in 28s
Required
Details
CI / typecheck (pull_request) Successful in 53s
Required
Details
CI / quality (pull_request) Successful in 44s
Required
Details
CI / security (pull_request) Successful in 59s
Required
Details
CI / build (pull_request) Successful in 21s
Required
Details
CI / helm (pull_request) Successful in 24s
Details
CI / push-validation (pull_request) Successful in 17s
Details
CI / integration_tests (pull_request) Successful in 4m25s
Required
Details
CI / e2e_tests (pull_request) Successful in 4m36s
Details
CI / unit_tests (pull_request) Successful in 6m2s
Required
Details
CI / docker (pull_request) Successful in 15s
Required
Details
CI / coverage (pull_request) Successful in 13m23s
Required
Details
CI / status-check (pull_request) Successful in 2s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!8627
No description provided.