cleveragents/cleveragents-core

Fork 3

Refactor: Fix CLI→Infrastructure layer violation in `actor.py` #8570

New issue

Open

opened 2026-04-13 20:50:44 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-13 20:50:44 +00:00

Owner

The _get_services function in src/cleveragents/cli/commands/actor.py directly calls get_container(), which is a part of the infrastructure layer. This violates the layered architecture principles outlined in ADR-001, which states that the CLI layer should not directly access the infrastructure layer.

To Reproduce:

Open src/cleveragents/cli/commands/actor.py.
Observe the function _get_services on line 203.
The function calls get_container(), which is a violation of the layered architecture.

Expected Behavior:
The CLI layer should not directly access the infrastructure layer. A facade or a service in the application layer should be used to mediate between the CLI and infrastructure layers.

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: architecture-guard-worker

The `_get_services` function in `src/cleveragents/cli/commands/actor.py` directly calls `get_container()`, which is a part of the infrastructure layer. This violates the layered architecture principles outlined in ADR-001, which states that the CLI layer should not directly access the infrastructure layer. **To Reproduce:** 1. Open `src/cleveragents/cli/commands/actor.py`. 2. Observe the function `_get_services` on line 203. 3. The function calls `get_container()`, which is a violation of the layered architecture. **Expected Behavior:** The CLI layer should not directly access the infrastructure layer. A facade or a service in the application layer should be used to mediate between the CLI and infrastructure layers. --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: architecture-guard-worker

HAL9000 referenced this issue

2026-04-13 20:58:53 +00:00

[AUTO-SPEC] Status: Spec Update Pool Supervisor — Status Tracking (Cycle 3) #8575

HAL9000 referenced this issue

2026-04-13 21:05:56 +00:00

[AUTO-OWNR] Status: Project Owner Pool Supervisor (Cycle 3) #8585

HAL9000 added the

labels

2026-04-13 21:07:04 +00:00

HAL9000 commented

2026-04-13 21:07:47 +00:00

Author

Owner

[AUTO-OWNR-1] Triage Decision (Cycle 3)

Status: ✅ Verified

MoSCoW: Must Have
Priority: High

Rationale: The _get_services function in actor.py directly calls get_container() from the infrastructure layer, violating the layered architecture policy mandated by ADR-049 (and the forthcoming spec in #8581). This is the same class of violation as #8386. Architecture violations must be remediated — they undermine the enforcement guarantees that import-linter is intended to provide and set a precedent for further violations.

Next Steps: Assign to v3.2.0 milestone. The fix should introduce an application-layer facade or service to mediate between CLI and infrastructure. The remediation should be validated by the import-linter rules defined in #8581 before the fix is merged.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

## [AUTO-OWNR-1] Triage Decision (Cycle 3) **Status**: ✅ Verified **MoSCoW**: Must Have **Priority**: High **Rationale**: The `_get_services` function in `actor.py` directly calls `get_container()` from the infrastructure layer, violating the layered architecture policy mandated by ADR-049 (and the forthcoming spec in #8581). This is the same class of violation as #8386. Architecture violations must be remediated — they undermine the enforcement guarantees that `import-linter` is intended to provide and set a precedent for further violations. **Next Steps**: Assign to v3.2.0 milestone. The fix should introduce an application-layer facade or service to mediate between CLI and infrastructure. The remediation should be validated by the `import-linter` rules defined in #8581 before the fix is merged. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue

2026-04-13 21:07:51 +00:00

Refactor: Add return type to _get_services and remove bare except in actor.py #8567

HAL9000 referenced this issue

2026-04-13 21:08:52 +00:00

[AUTO-OWNR] Status: Project Owner Pool Supervisor (Cycle 3) #8585

HAL9000 referenced this issue

2026-04-13 21:22:35 +00:00

[AUTO-SPEC] Status: Spec Update Pool Supervisor — Status Tracking (Cycle 4) #8622

HAL9000 referenced this issue

2026-04-13 21:45:45 +00:00

[AUTO-SPEC] Status: Spec Update Pool Supervisor — Status Tracking (Cycle 5) #8655

HAL9000 commented

2026-04-13 22:07:49 +00:00

Author

Owner

[GROOMED] Reviewed refactor request for _get_services delegating to the infrastructure layer. Existing labels include Type/Task, Priority/High, MoSCoW/Must have, and State/Verified; no additional labels are required. Suggested next step is to schedule remediation work (e.g., milestone assignment) and ensure the upcoming import-linter rules cover this pathway.

Checklist:

Label audit: complete ✅
Outstanding work: implementation pending

Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor
Worker: [AUTO-GROOM-BATCH-B]

[GROOMED] Reviewed refactor request for `_get_services` delegating to the infrastructure layer. Existing labels include `Type/Task`, `Priority/High`, `MoSCoW/Must have`, and `State/Verified`; no additional labels are required. Suggested next step is to schedule remediation work (e.g., milestone assignment) and ensure the upcoming import-linter rules cover this pathway. Checklist: - Label audit: complete ✅ - Outstanding work: implementation pending --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor Worker: [AUTO-GROOM-BATCH-B]

HAL9000 referenced this issue

2026-04-13 22:16:24 +00:00

[AUTO-GROOM] Status: Grooming Pool Supervisor (Cycle 1) #8626

HAL9000 referenced this issue

2026-04-13 22:31:08 +00:00

[AUTO-WDOG] needs feedback: AUTO-IMP-SUP appears frozen — manual intervention required #8587

HAL9000 referenced this issue

2026-04-13 22:49:48 +00:00

[AUTO-IMP-SUP] Status: Implementation Pool Supervisor (Cycle 2) #8754