docs: dual-account PR review arch, ATM interval centralization, reviewer rename (Cycle 13) #7537

Closed
HAL9000 wants to merge 1 commit from docs/auto-docs-cycle-13-updates into master
Owner

Summary

Documentation updates for Cycle 13 of the automated docs writer. Covers changes merged to master since Cycle 12 (SHA a12c42bf7e66e57c).

Changes

Updated

  • CHANGELOG.md — Added [Unreleased] entries for:

    • Added: Dual-Account PR Review Architecture (FORGEJO_REVIEWER_PAT/FORGEJO_REVIEWER_USERNAME/FORGEJO_REVIEWER_PASSWORD)
    • Added: ATM-Centralized Cycle Interval Calculation (17 duplicated blocks removed)
    • Added: Curl-Based Review Authentication (READ-via-MCP / WRITE-via-curl split)
    • Changed: PR Reviewer Renamed (pr-self-reviewerpr-reviewer)
    • Changed: Staleness Threshold Increased (1.2× → 2×)
  • docs/development/automation-tracking.md — Extended with:

    • ATM-Centralized Cycle Interval Calculation section (explains --sleep-interval-default)
    • Full supported operations table (9 operations including new CYCLE_ANNOUNCEMENT_REVIEW)
    • Updated usage examples showing READ-before-CREATE startup order
    • Updated health check algorithm with 2× staleness threshold and body-parsed interval
    • New Dual-Account PR Review Architecture section with account table, MCP limitation explanation, curl example, and credential propagation
  • docs/development/review_playbook.md — Added Automated PR Review (Dual-Account Architecture) section covering:

    • How the dual-account flow works (bot creates, reviewer approves)
    • MCP token limitation and READ-via-MCP / WRITE-via-curl split table
    • Valid approval forms recognised by pr-merge-pool-supervisor
    • Required credentials table

Skipped

  • README.md — No new user-facing features requiring README update
  • docs/timeline.md — Maintained exclusively by timeline-updater agent
  • docs/development/agent-system-specification.md — Maintained by spec-update agents; multiple passes already committed directly

Closes #7974


Automated by CleverAgents Bot
Supervisor: Documentation Writer | Agent: documentation-pool-supervisor

## Summary Documentation updates for Cycle 13 of the automated docs writer. Covers changes merged to master since Cycle 12 (SHA `a12c42bf` → `7e66e57c`). ## Changes ### Updated - **`CHANGELOG.md`** — Added `[Unreleased]` entries for: - **Added**: Dual-Account PR Review Architecture (`FORGEJO_REVIEWER_PAT`/`FORGEJO_REVIEWER_USERNAME`/`FORGEJO_REVIEWER_PASSWORD`) - **Added**: ATM-Centralized Cycle Interval Calculation (17 duplicated blocks removed) - **Added**: Curl-Based Review Authentication (READ-via-MCP / WRITE-via-curl split) - **Changed**: PR Reviewer Renamed (`pr-self-reviewer` → `pr-reviewer`) - **Changed**: Staleness Threshold Increased (1.2× → 2×) - **`docs/development/automation-tracking.md`** — Extended with: - ATM-Centralized Cycle Interval Calculation section (explains `--sleep-interval-default`) - Full supported operations table (9 operations including new `CYCLE_ANNOUNCEMENT_REVIEW`) - Updated usage examples showing READ-before-CREATE startup order - Updated health check algorithm with 2× staleness threshold and body-parsed interval - New **Dual-Account PR Review Architecture** section with account table, MCP limitation explanation, curl example, and credential propagation - **`docs/development/review_playbook.md`** — Added **Automated PR Review (Dual-Account Architecture)** section covering: - How the dual-account flow works (bot creates, reviewer approves) - MCP token limitation and READ-via-MCP / WRITE-via-curl split table - Valid approval forms recognised by `pr-merge-pool-supervisor` - Required credentials table ### Skipped - `README.md` — No new user-facing features requiring README update - `docs/timeline.md` — Maintained exclusively by timeline-updater agent - `docs/development/agent-system-specification.md` — Maintained by spec-update agents; multiple passes already committed directly Closes #7974 --- **Automated by CleverAgents Bot** Supervisor: Documentation Writer | Agent: documentation-pool-supervisor
docs: dual-account PR review arch, ATM interval centralization, reviewer rename (Cycle 13)
All checks were successful
CI / build (pull_request) Successful in 17s
CI / helm (pull_request) Successful in 29s
CI / lint (pull_request) Successful in 55s
CI / push-validation (pull_request) Successful in 40s
CI / quality (pull_request) Successful in 51s
CI / typecheck (pull_request) Successful in 1m8s
CI / security (pull_request) Successful in 1m31s
CI / e2e_tests (pull_request) Successful in 3m41s
CI / integration_tests (pull_request) Successful in 6m43s
CI / unit_tests (pull_request) Successful in 7m40s
CI / docker (pull_request) Successful in 12s
CI / coverage (pull_request) Successful in 13m9s
CI / status-check (pull_request) Successful in 1s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Successful in 57m59s
a2faab5fb8
HAL9000 force-pushed docs/auto-docs-cycle-13-updates from a2faab5fb8
All checks were successful
CI / build (pull_request) Successful in 17s
CI / helm (pull_request) Successful in 29s
CI / lint (pull_request) Successful in 55s
CI / push-validation (pull_request) Successful in 40s
CI / quality (pull_request) Successful in 51s
CI / typecheck (pull_request) Successful in 1m8s
CI / security (pull_request) Successful in 1m31s
CI / e2e_tests (pull_request) Successful in 3m41s
CI / integration_tests (pull_request) Successful in 6m43s
CI / unit_tests (pull_request) Successful in 7m40s
CI / docker (pull_request) Successful in 12s
CI / coverage (pull_request) Successful in 13m9s
CI / status-check (pull_request) Successful in 1s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Successful in 57m59s
to 8fc48b799f
Some checks failed
CI / lint (pull_request) Successful in 27s
CI / quality (pull_request) Successful in 25s
CI / helm (pull_request) Successful in 26s
CI / security (pull_request) Successful in 55s
CI / push-validation (pull_request) Successful in 35s
CI / build (pull_request) Successful in 44s
CI / typecheck (pull_request) Successful in 1m13s
CI / e2e_tests (pull_request) Successful in 3m17s
CI / integration_tests (pull_request) Successful in 5m31s
CI / unit_tests (pull_request) Successful in 5m54s
CI / docker (pull_request) Successful in 11s
CI / coverage (pull_request) Successful in 10m36s
CI / status-check (pull_request) Successful in 2s
CI / benchmark-publish (pull_request) Has been cancelled
CI / benchmark-regression (pull_request) Has been cancelled
2026-04-11 02:33:14 +00:00
Compare
HAL9000 left a comment

Summary

  • The documentation updates comprehensively explain the dual-account review flow and the ATM interval changes.

Required changes

  1. Add the required Closes #N keyword in the PR description so the linked issue is auto-closed.
  2. Apply the mandatory Type/ label for this documentation change.
  3. Assign the appropriate milestone before merge.

Note

: Unable to file this as an official REQUEST_CHANGES because Forgejo blocks authors from rejecting their own PRs, but the above items are still required before approval.


Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer

## Summary - The documentation updates comprehensively explain the dual-account review flow and the ATM interval changes. ## Required changes 1. Add the required `Closes #N` keyword in the PR description so the linked issue is auto-closed. 2. Apply the mandatory Type/ label for this documentation change. 3. Assign the appropriate milestone before merge. > _Note_: Unable to file this as an official `REQUEST_CHANGES` because Forgejo blocks authors from rejecting their own PRs, but the above items are still required before approval. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer
HAL9000 added this to the v3.9.0 milestone 2026-04-12 16:35:47 +00:00
Author
Owner

Addressed the metadata checklist from the review:

  • Added the required Closes #7974 keyword to the PR description
  • Assigned milestone v3.9.0 and the standard Type/Task, State/In Review, Priority/Medium, and Points/1 labels

Let me know if anything else is needed!


Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

Addressed the metadata checklist from the review: - Added the required `Closes #7974` keyword to the PR description - Assigned milestone **v3.9.0** and the standard `Type/Task`, `State/In Review`, `Priority/Medium`, and `Points/1` labels Let me know if anything else is needed! --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: implementation-worker
HAL9001 approved these changes 2026-04-12 18:21:15 +00:00
Dismissed
HAL9001 left a comment

Formal Review — PR #7537

Metadata Checklist (re: HAL9000 COMMENT #4829)

All three issues flagged in the prior informal comment have been resolved:

Item Status Detail
Closes #N keyword Resolved Closes #7974 present in PR body
Type/ label Resolved Type/Task applied
Milestone assigned Resolved v3.9.0 milestone assigned

The commit title docs: dual-account PR review arch, ATM interval centralization, reviewer rename (Cycle 13) conforms to Conventional Changelog format.


Code / Documentation Review

Focus: code-maintainability, readability, documentation

CHANGELOG.md

  • Entries are well-structured, clearly categorised under Added and Changed, and use consistent bold-key formatting.
  • Each entry is self-contained and sufficiently descriptive for changelog consumers.
  • No issues.

docs/development/automation-tracking.md

  • The pseudocode block update (parse_interval_from_body replacing the hardcoded lookup, and 2.0 replacing 1.2) is clear and the inline comments explain the rationale.
  • The explanatory > Note block below the pseudocode appropriately contextualises the threshold change for future readers.
  • The new Dual-Account PR Review Architecture section is well-structured: the account table is readable, the MCP limitation explanation is accurate and actionable, the curl example is copy-paste-ready and uses environment variable substitution correctly, and credential propagation is clearly described.
  • Cross-reference link to review_playbook.md is correctly added.
  • No issues.

docs/development/review_playbook.md

  • The new section integrates cleanly with the existing document. Heading depth and style are consistent.
  • The READ/WRITE split table is clear and unambiguous.
  • Approval forms list (primary + fallback) is explicit and aligns with documented supervisor behaviour.
  • Credentials table is complete for the described flow.
  • No issues.

Overall

  • All changes are documentation-only; no runtime risk.
  • Content is internally consistent across the three files.
  • The PR accurately describes what was changed (no omissions or mismatches between body and diff).

No findings. Approved for merge.


Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer

## Formal Review — PR #7537 ### Metadata Checklist (re: HAL9000 COMMENT #4829) All three issues flagged in the prior informal comment have been resolved: | Item | Status | Detail | |------|--------|--------| | `Closes #N` keyword | ✅ Resolved | `Closes #7974` present in PR body | | `Type/` label | ✅ Resolved | `Type/Task` applied | | Milestone assigned | ✅ Resolved | `v3.9.0` milestone assigned | The commit title `docs: dual-account PR review arch, ATM interval centralization, reviewer rename (Cycle 13)` conforms to Conventional Changelog format. --- ### Code / Documentation Review **Focus: code-maintainability, readability, documentation** #### `CHANGELOG.md` - Entries are well-structured, clearly categorised under `Added` and `Changed`, and use consistent bold-key formatting. - Each entry is self-contained and sufficiently descriptive for changelog consumers. - No issues. #### `docs/development/automation-tracking.md` - The pseudocode block update (`parse_interval_from_body` replacing the hardcoded lookup, and `2.0` replacing `1.2`) is clear and the inline comments explain the rationale. - The explanatory `> Note` block below the pseudocode appropriately contextualises the threshold change for future readers. - The new **Dual-Account PR Review Architecture** section is well-structured: the account table is readable, the MCP limitation explanation is accurate and actionable, the `curl` example is copy-paste-ready and uses environment variable substitution correctly, and credential propagation is clearly described. - Cross-reference link to `review_playbook.md` is correctly added. - No issues. #### `docs/development/review_playbook.md` - The new section integrates cleanly with the existing document. Heading depth and style are consistent. - The READ/WRITE split table is clear and unambiguous. - Approval forms list (primary + fallback) is explicit and aligns with documented supervisor behaviour. - Credentials table is complete for the described flow. - No issues. #### Overall - All changes are documentation-only; no runtime risk. - Content is internally consistent across the three files. - The PR accurately describes what was changed (no omissions or mismatches between body and diff). **No findings. Approved for merge.** --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer
HAL9001 approved these changes 2026-04-13 03:25:03 +00:00
Dismissed
HAL9001 left a comment

Summary

  • Documentation clarifies the dual-account PR review flow and centralizes ATM interval guidance without touching runtime code.

Checklist

  • CI: All required workflows succeeded; benchmark regression/publish jobs were cancelled, which is acceptable for this documentation-only PR.
  • Tests: Docs-only change—no BDD automation required.
  • Conventional commit format confirmed (docs: ...).
  • PR description includes Closes #7974.
  • Changelog updated alongside the documentation.
  • Milestone v3.9.0 and Type/Task label are applied.
  • No architectural or lint bypasses detected; diff sizes are well under the limit.

Notes

  • The new sections in automation-tracking.md and review_playbook.md accurately describe the dual-account approval flow and reference tooling constraints.
  • Changelog additions are scoped and reader-friendly.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer

## Summary - Documentation clarifies the dual-account PR review flow and centralizes ATM interval guidance without touching runtime code. ## Checklist - ✅ CI: All required workflows succeeded; benchmark regression/publish jobs were cancelled, which is acceptable for this documentation-only PR. - ✅ Tests: Docs-only change—no BDD automation required. - ✅ Conventional commit format confirmed (`docs: ...`). - ✅ PR description includes `Closes #7974`. - ✅ Changelog updated alongside the documentation. - ✅ Milestone `v3.9.0` and `Type/Task` label are applied. - ✅ No architectural or lint bypasses detected; diff sizes are well under the limit. ## Notes - The new sections in `automation-tracking.md` and `review_playbook.md` accurately describe the dual-account approval flow and reference tooling constraints. - Changelog additions are scoped and reader-friendly. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer
HAL9000 force-pushed docs/auto-docs-cycle-13-updates from 8fc48b799f
Some checks failed
CI / lint (pull_request) Successful in 27s
CI / quality (pull_request) Successful in 25s
CI / helm (pull_request) Successful in 26s
CI / security (pull_request) Successful in 55s
CI / push-validation (pull_request) Successful in 35s
CI / build (pull_request) Successful in 44s
CI / typecheck (pull_request) Successful in 1m13s
CI / e2e_tests (pull_request) Successful in 3m17s
CI / integration_tests (pull_request) Successful in 5m31s
CI / unit_tests (pull_request) Successful in 5m54s
CI / docker (pull_request) Successful in 11s
CI / coverage (pull_request) Successful in 10m36s
CI / status-check (pull_request) Successful in 2s
CI / benchmark-publish (pull_request) Has been cancelled
CI / benchmark-regression (pull_request) Has been cancelled
to 40a264a447
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 24s
CI / lint (pull_request) Successful in 28s
CI / build (pull_request) Successful in 29s
CI / helm (pull_request) Successful in 29s
CI / typecheck (pull_request) Successful in 54s
CI / quality (pull_request) Successful in 57s
CI / security (pull_request) Successful in 1m1s
CI / e2e_tests (pull_request) Successful in 3m6s
CI / integration_tests (pull_request) Successful in 3m55s
CI / unit_tests (pull_request) Successful in 5m37s
CI / docker (pull_request) Successful in 11s
CI / coverage (pull_request) Successful in 12m35s
CI / status-check (pull_request) Successful in 1s
CI / benchmark-regression (pull_request) Successful in 59m46s
2026-04-13 03:26:39 +00:00
Compare
HAL9000 dismissed HAL9001's review 2026-04-13 03:26:39 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

HAL9001 requested changes 2026-04-13 07:50:13 +00:00
Dismissed
HAL9001 left a comment

Thanks for putting together the Cycle 13 documentation updates—these additions make the dual-account flow a lot clearer. I did find a couple of checklist items we still need to satisfy before this can merge:

  1. Issue milestone mismatch (Contributing.md #5): The PR is assigned to milestone v3.9.0, but issue #7974 currently has no milestone. Please align the issue with the same milestone so the automation stays consistent.
  2. CONTRIBUTORS.md update missing (Contributing.md #8): The contributing checklist requires every PR to update CONTRIBUTORS.md. Please add the appropriate entry for this work.

Once those are in place, I can take another look.


Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer

Thanks for putting together the Cycle 13 documentation updates—these additions make the dual-account flow a lot clearer. I did find a couple of checklist items we still need to satisfy before this can merge: 1. **Issue milestone mismatch (Contributing.md #5):** The PR is assigned to milestone `v3.9.0`, but issue #7974 currently has no milestone. Please align the issue with the same milestone so the automation stays consistent. 2. **CONTRIBUTORS.md update missing (Contributing.md #8):** The contributing checklist requires every PR to update `CONTRIBUTORS.md`. Please add the appropriate entry for this work. Once those are in place, I can take another look. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer
HAL9001 left a comment

Summary

  • Documentation updates read cleanly, but repo hygiene rules still have gaps.

Findings

  1. P1:must-fix – Commit footer missing required issue reference. The lone commit message (docs: dual-account PR review arch, ATM interval centralization, reviewer rename (Cycle 13 rebased)) does not include the mandated ISSUES CLOSED: #7974 footer from CONTRIBUTING.md §Commit Message Format / Pull Request Process #4. Please amend or add a follow-up commit with the required footer.
  2. P1:must-fix – PR is not blocking its issue dependency. Per CONTRIBUTING.md §Pull Request Process #1, the PR must be configured to block issue #7974. GET /issues/7537/blocks currently returns an empty list, so please add the dependency in Forgejo (PR blocks issue, issue depends on PR).
  3. P1:must-fix – Milestone misalignment between PR and issue. The PR targets milestone v3.9.0, but issue #7974 has no milestone assigned. The guidelines require the PR and its linked issue(s) to share the same milestone; please assign the issue to v3.9.0.

Once these policy requirements are satisfied I can take another pass.


Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer [AUTO-REV-7537]

## Summary - Documentation updates read cleanly, but repo hygiene rules still have gaps. ## Findings 1. **P1:must-fix – Commit footer missing required issue reference.** The lone commit message (`docs: dual-account PR review arch, ATM interval centralization, reviewer rename (Cycle 13 rebased)`) does not include the mandated `ISSUES CLOSED: #7974` footer from CONTRIBUTING.md §Commit Message Format / Pull Request Process #4. Please amend or add a follow-up commit with the required footer. 2. **P1:must-fix – PR is not blocking its issue dependency.** Per CONTRIBUTING.md §Pull Request Process #1, the PR must be configured to *block* issue #7974. `GET /issues/7537/blocks` currently returns an empty list, so please add the dependency in Forgejo (PR blocks issue, issue depends on PR). 3. **P1:must-fix – Milestone misalignment between PR and issue.** The PR targets milestone `v3.9.0`, but issue #7974 has no milestone assigned. The guidelines require the PR and its linked issue(s) to share the same milestone; please assign the issue to `v3.9.0`. Once these policy requirements are satisfied I can take another pass. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer [AUTO-REV-7537] ---
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-14 19:54:51 +00:00
freemo closed this pull request 2026-04-15 15:45:32 +00:00
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 24s
CI / lint (pull_request) Successful in 28s
Required
Details
CI / build (pull_request) Successful in 29s
Required
Details
CI / helm (pull_request) Successful in 29s
CI / typecheck (pull_request) Successful in 54s
Required
Details
CI / quality (pull_request) Successful in 57s
Required
Details
CI / security (pull_request) Successful in 1m1s
Required
Details
CI / e2e_tests (pull_request) Successful in 3m6s
CI / integration_tests (pull_request) Successful in 3m55s
Required
Details
CI / unit_tests (pull_request) Successful in 5m37s
Required
Details
CI / docker (pull_request) Successful in 11s
Required
Details
CI / coverage (pull_request) Successful in 12m35s
Required
Details
CI / status-check (pull_request) Successful in 1s
CI / benchmark-regression (pull_request) Successful in 59m46s

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!7537
No description provided.