TDD: `plan correct` single-node impact analysis test #636

New issue

Closed

opened 2026-03-07 23:05:58 +00:00 by freemo · 1 comment

freemo commented

2026-03-07 23:05:58 +00:00

Owner

Metadata

Commit Message: test(plan): add TDD failing tests for plan correct tree wiring
Branch: tdd/plan-correct-tree-wiring

Parent

Bug: #606 — CLI plan correct never passes decision tree to CorrectionService

Background and Context

Per CONTRIBUTING.md TDD Bug Fix Workflow. Bug #606 root cause: correct_decision() in plan.py creates a bare CorrectionService() without passing decision_tree or influence_edges. Both default to None, causing _compute_affected_subtree() to BFS on an empty dict, returning only the target decision. Discovered by @CoreRasurae during PR #559 review.

Acceptance Criteria

Behave BDD scenarios tagged @tdd_bug @tdd_bug_606 @tdd_expected_fail
Robot Framework integration test verifying correction reports full subtree
ASV benchmark for correction impact analysis
Tests fail until bug #606 is fixed (impact analysis returns single-node instead of full subtree)

Dependencies

Blocked by: #627, #628 (TDD infrastructure)
Blocks: #606 (bug fix)

Definition of Done

TDD tests reproducing bug #606 are merged to master.

## Metadata - **Commit Message**: `test(plan): add TDD failing tests for plan correct tree wiring` - **Branch**: `tdd/plan-correct-tree-wiring` ## Parent Bug: #606 — CLI `plan correct` never passes decision tree to CorrectionService ## Background and Context Per CONTRIBUTING.md TDD Bug Fix Workflow. Bug #606 root cause: `correct_decision()` in `plan.py` creates a bare `CorrectionService()` without passing `decision_tree` or `influence_edges`. Both default to `None`, causing `_compute_affected_subtree()` to BFS on an empty dict, returning only the target decision. Discovered by @CoreRasurae during PR #559 review. ## Acceptance Criteria - [ ] Behave BDD scenarios tagged `@tdd_bug @tdd_bug_606 @tdd_expected_fail` - [ ] Robot Framework integration test verifying correction reports full subtree - [ ] ASV benchmark for correction impact analysis - [ ] Tests fail until bug #606 is fixed (impact analysis returns single-node instead of full subtree) ## Dependencies - Blocked by: #627, #628 (TDD infrastructure) - Blocks: #606 (bug fix) ## Definition of Done TDD tests reproducing bug #606 are merged to master.

freemo added the

labels

2026-03-07 23:06:16 +00:00

brent.edwards was assigned by freemo

2026-03-07 23:06:36 +00:00

freemo added this to the v3.3.0 milestone

2026-03-07 23:06:36 +00:00

freemo referenced this issue

2026-03-07 23:07:46 +00:00

CLI plan correct never passes decision tree to CorrectionService, producing single-node impact analysis #606

freemo added a new dependency

2026-03-07 23:57:21 +00:00

#606 CLI plan correct never passes decision tree to CorrectionService, producing single-node impact analysis

freemo commented

2026-03-09 02:44:30 +00:00

Author

Owner

Day 29 Planning Review — Closing

The TDD test for bug #606 was included directly in the fix PR #639 (merged 2026-03-08), which contains:

3 Behave BDD scenarios verifying tree/edge forwarding (dry-run subtree, execution subtree, leaf node)
3 Robot Framework integration smoke tests
ASV benchmarks for tree building and analyze_impact overhead

While CONTRIBUTING.md prescribes a two-PR TDD workflow (TDD test merged first, then fix removes @tdd_expected_fail), Jeff (CTO/project owner) merged both test and fix in a single PR using maintainer override. The tests exist in the codebase and the bug is verified fixed.

Closing as the TDD test deliverable is satisfied by PR #639.

**Day 29 Planning Review — Closing** The TDD test for bug #606 was included directly in the fix PR #639 (merged 2026-03-08), which contains: - 3 Behave BDD scenarios verifying tree/edge forwarding (dry-run subtree, execution subtree, leaf node) - 3 Robot Framework integration smoke tests - ASV benchmarks for tree building and analyze_impact overhead While CONTRIBUTING.md prescribes a two-PR TDD workflow (TDD test merged first, then fix removes `@tdd_expected_fail`), Jeff (CTO/project owner) merged both test and fix in a single PR using maintainer override. The tests exist in the codebase and the bug is verified fixed. Closing as the TDD test deliverable is satisfied by PR #639.

freemo

2026-03-09 02:44:31 +00:00