Proposal: update specification — agents validation attach uses --key value named option format #6193

New issue

Open

opened 2026-04-09 17:32:14 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-09 17:32:14 +00:00

Owner

Proposal: Update Specification — `agents validation attach` Extra Args Format

What Changed in the Implementation

Merged PR #3837 (fix(cli): change agents validation attach extra args to use --key value named option format, merged 2026-04-06) changed the agents validation attach command to accept extra arguments as named options (--key value) instead of the previously implemented positional key=value format.

What Spec Sections Need Updating

§9537 — `agents validation attach` command reference

Current text (approximate, based on spec structure): The spec at §9537 documents agents validation attach with extra arguments. The current implementation uses:

# CORRECT (spec-compliant, now implemented)
agents validation attach git-checkout/my-repo local/coverage-check --coverage-threshold 90

# REJECTED (old positional format — now explicitly rejected with error)
agents validation attach git-checkout/my-repo local/coverage-check coverage-threshold=90

Proposed update: Ensure the spec's agents validation attach section explicitly documents:

Extra validation-specific arguments are passed as named options: --key value
Hyphens in option names are normalised to underscores in the stored dict: --coverage-threshold → coverage_threshold
Positional key=value format is explicitly rejected with a descriptive error message
A dangling --key with no following value is also rejected

Proposed spec text addition (to §9537 Attachment Arguments subsection):

##### Attachment Arguments

Validation-specific arguments are passed as named options using the `--key value` format:

```bash
agents validation attach git-checkout/my-repo local/coverage-check --coverage-threshold 90
agents validation attach --project myproj git-checkout/my-repo local/lint --min-score 8

Key normalisation: Hyphens in option names are converted to underscores in the stored argument dict. For example, --coverage-threshold 90 is stored as {"coverage_threshold": "90"}.

Rejected formats: The positional key=value format (e.g., coverage-threshold=90) is explicitly rejected with an error message directing users to the --key value format.


### Rationale

The implementation in PR #3837 brings the CLI into compliance with the spec's intended `--key value` format. The spec may have been ambiguous or inconsistent on this point. The implementation is correct and the spec should be updated to be unambiguous.

### Scope

Spec sections affected:
- §9537 — `agents validation attach` command reference
- §22587 — Attachment Arguments (Core Concepts > Validation > Attachment Arguments)

---
**Automated by CleverAgents Bot**
Supervisor: Spec Evolution | Agent: spec-updater

## Proposal: Update Specification — `agents validation attach` Extra Args Format ### What Changed in the Implementation **Merged PR #3837** (`fix(cli): change agents validation attach extra args to use --key value named option format`, merged 2026-04-06) changed the `agents validation attach` command to accept extra arguments as named options (`--key value`) instead of the previously implemented positional `key=value` format. ### What Spec Sections Need Updating #### §9537 — `agents validation attach` command reference **Current text** (approximate, based on spec structure): The spec at §9537 documents `agents validation attach` with extra arguments. The current implementation uses: ```bash # CORRECT (spec-compliant, now implemented) agents validation attach git-checkout/my-repo local/coverage-check --coverage-threshold 90 # REJECTED (old positional format — now explicitly rejected with error) agents validation attach git-checkout/my-repo local/coverage-check coverage-threshold=90 ``` **Proposed update**: Ensure the spec's `agents validation attach` section explicitly documents: 1. Extra validation-specific arguments are passed as named options: `--key value` 2. Hyphens in option names are normalised to underscores in the stored dict: `--coverage-threshold` → `coverage_threshold` 3. Positional `key=value` format is **explicitly rejected** with a descriptive error message 4. A dangling `--key` with no following value is also rejected **Proposed spec text addition** (to §9537 Attachment Arguments subsection): ```markdown ##### Attachment Arguments Validation-specific arguments are passed as named options using the `--key value` format: ```bash agents validation attach git-checkout/my-repo local/coverage-check --coverage-threshold 90 agents validation attach --project myproj git-checkout/my-repo local/lint --min-score 8 ``` **Key normalisation**: Hyphens in option names are converted to underscores in the stored argument dict. For example, `--coverage-threshold 90` is stored as `{"coverage_threshold": "90"}`. **Rejected formats**: The positional `key=value` format (e.g., `coverage-threshold=90`) is explicitly rejected with an error message directing users to the `--key value` format. ``` ### Rationale The implementation in PR #3837 brings the CLI into compliance with the spec's intended `--key value` format. The spec may have been ambiguous or inconsistent on this point. The implementation is correct and the spec should be updated to be unambiguous. ### Scope Spec sections affected: - §9537 — `agents validation attach` command reference - §22587 — Attachment Arguments (Core Concepts > Validation > Attachment Arguments) --- **Automated by CleverAgents Bot** Supervisor: Spec Evolution | Agent: spec-updater

Rows
Columns

Proposal: update specification — agents validation attach uses --key value named option format #6193

Proposal: Update Specification — agents validation attach Extra Args Format

What Changed in the Implementation

What Spec Sections Need Updating

§9537 — agents validation attach command reference

Proposal: Update Specification — `agents validation attach` Extra Args Format

§9537 — `agents validation attach` command reference