cleveragents/cleveragents-core

Fork 3

UAT: `MCPToolFilter` and `MCPTransport` missing from `cleveragents.mcp` public exports #5713

New issue

Open

opened 2026-04-09 08:47:13 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-09 08:47:13 +00:00

Owner

Bug Report

Feature Area: MCP adapter — tool discovery, server configuration
Severity: Low — usability issue, workaround available
Tested: Code-level analysis of src/cleveragents/mcp/__init__.py

What Was Tested

Feature: Tool discovery via MCP protocol and MCP server configuration and authentication

Reviewed the public API surface of the cleveragents.mcp package to verify all user-facing types are exported.

Expected Behavior

All types needed to use the MCP adapter should be importable from the top-level cleveragents.mcp package. Specifically:

MCPToolFilter — required to filter which tools are discovered/registered
MCPTransport — required to implement custom transports for testing or non-standard protocols

Actual Behavior

src/cleveragents/mcp/__init__.py exports:

from cleveragents.mcp.adapter import (
    MCPCapabilityMetadata,
    MCPServerConfig,
    MCPToolAdapter,
    MCPToolDescriptor,
    MCPToolResult,
)

MCPToolFilter and MCPTransport are NOT exported.

Users who want to filter tools must import from the internal path:

# Forced to use internal path — not part of public API
from cleveragents.mcp.adapter import MCPToolFilter, MCPTransport

This is inconsistent with the rest of the public API and breaks the encapsulation contract.

Impact

Users cannot do from cleveragents.mcp import MCPToolFilter — required for discover_tools(filter=...) and register_tools(registry, namespace, tool_filter=...)
Users cannot do from cleveragents.mcp import MCPTransport — required to implement custom transports for testing
The __all__ list in __init__.py is also missing these entries

Code Location

src/cleveragents/mcp/__init__.py — missing MCPToolFilter and MCPTransport imports and __all__ entries
src/cleveragents/mcp/adapter.py — both classes are defined here

Suggested Fix

Add to src/cleveragents/mcp/__init__.py:

from cleveragents.mcp.adapter import (
    MCPCapabilityMetadata,
    MCPServerConfig,
    MCPToolAdapter,
    MCPToolDescriptor,
    MCPToolFilter,   # ADD
    MCPToolResult,
    MCPTransport,    # ADD
)

And add "MCPToolFilter" and "MCPTransport" to __all__.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** MCP adapter — tool discovery, server configuration **Severity:** Low — usability issue, workaround available **Tested:** Code-level analysis of `src/cleveragents/mcp/__init__.py` --- ## What Was Tested Feature: *Tool discovery via MCP protocol* and *MCP server configuration and authentication* Reviewed the public API surface of the `cleveragents.mcp` package to verify all user-facing types are exported. --- ## Expected Behavior All types needed to use the MCP adapter should be importable from the top-level `cleveragents.mcp` package. Specifically: - `MCPToolFilter` — required to filter which tools are discovered/registered - `MCPTransport` — required to implement custom transports for testing or non-standard protocols --- ## Actual Behavior `src/cleveragents/mcp/__init__.py` exports: ```python from cleveragents.mcp.adapter import ( MCPCapabilityMetadata, MCPServerConfig, MCPToolAdapter, MCPToolDescriptor, MCPToolResult, ) ``` **`MCPToolFilter` and `MCPTransport` are NOT exported.** Users who want to filter tools must import from the internal path: ```python # Forced to use internal path — not part of public API from cleveragents.mcp.adapter import MCPToolFilter, MCPTransport ``` This is inconsistent with the rest of the public API and breaks the encapsulation contract. --- ## Impact - Users cannot do `from cleveragents.mcp import MCPToolFilter` — required for `discover_tools(filter=...)` and `register_tools(registry, namespace, tool_filter=...)` - Users cannot do `from cleveragents.mcp import MCPTransport` — required to implement custom transports for testing - The `__all__` list in `__init__.py` is also missing these entries --- ## Code Location - `src/cleveragents/mcp/__init__.py` — missing `MCPToolFilter` and `MCPTransport` imports and `__all__` entries - `src/cleveragents/mcp/adapter.py` — both classes are defined here --- ## Suggested Fix Add to `src/cleveragents/mcp/__init__.py`: ```python from cleveragents.mcp.adapter import ( MCPCapabilityMetadata, MCPServerConfig, MCPToolAdapter, MCPToolDescriptor, MCPToolFilter, # ADD MCPToolResult, MCPTransport, # ADD ) ``` And add `"MCPToolFilter"` and `"MCPTransport"` to `__all__`. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added the

labels

2026-04-09 08:51:10 +00:00

HAL9000 commented

2026-04-09 09:05:10 +00:00

Author

Owner

MoSCoW classification: MoSCoW/Should have

Rationale: Missing public exports (MCPToolFilter and MCPTransport) from the cleveragents.mcp package breaks the public API contract. Users who need to filter tools or implement custom transports are forced to import from internal paths, which is fragile and violates encapsulation. This is a usability issue that should be fixed before the MCP adapter is considered production-ready. The fix is trivial (add two imports to __init__.py).

Also adding Points/1 — XS — Adding two imports to __init__.py is less than 1 hour of work.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

MoSCoW classification: **MoSCoW/Should have** Rationale: Missing public exports (`MCPToolFilter` and `MCPTransport`) from the `cleveragents.mcp` package breaks the public API contract. Users who need to filter tools or implement custom transports are forced to import from internal paths, which is fragile and violates encapsulation. This is a usability issue that should be fixed before the MCP adapter is considered production-ready. The fix is trivial (add two imports to `__init__.py`). Also adding `Points/1` — XS — Adding two imports to `__init__.py` is less than 1 hour of work. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 added the

Points

label

2026-04-09 09:06:24 +00:00

HAL9000 referenced this issue

2026-04-09 09:07:51 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 29) #5759