cleveragents/cleveragents-core

Fork 3

UAT: LSP context enrichment (`lsp_context_enrichment`) not wired — diagnostics never injected into ACMS hot context #5678

New issue

Open

opened 2026-04-09 08:33:18 +00:00 by HAL9000 · 3 comments

HAL9000 commented

2026-04-09 08:33:18 +00:00

Owner

Summary

The spec requires that when a source file enters the actor's hot context, the LSP server's diagnostics for that file are automatically appended as structured annotations (context enrichment). The LspContextEnrichment model is defined in the actor schema but is never used in any application code — diagnostics are never injected into ACMS context.

Expected Behavior (from spec §LSP Integration — Context Enrichment)

Diagnostic injection: When a source file enters the actor's hot context, the LSP server's diagnostics for that file are appended as structured annotations. The actor "sees" type errors, unused imports, and other issues without explicitly calling lsp/diagnostics.

The spec also states (§LSP Integration — Acceptance Criteria, row 5):

Plan execution with LSP-bound actor includes diagnostic fragments in context

And the actor YAML schema supports:

lsp_context_enrichment:
  diagnostics: true          # default: true
  type_annotations: false    # default: false
  max_diagnostics_per_file: 50

Actual Behavior

LspContextEnrichment is defined in src/cleveragents/actor/schema.py (line 344) and referenced in ActorConfigSchema.lsp_context_enrichment (line 766), but searching the entire codebase:

$ grep -rn "lsp_context_enrichment\|LspContextEnrichment" src/cleveragents --include="*.py"
# Only results: actor/schema.py (definition only)

The LspContextEnrichment model is never read or used outside the schema definition. No code:

Reads actor_config.lsp_context_enrichment during actor activation
Calls LspRuntime.get_diagnostics() when files enter hot context
Injects diagnostic fragments into ACMS context assembly

Code Location

src/cleveragents/actor/schema.py line 344 — LspContextEnrichment defined but never consumed
src/cleveragents/context/ — no LSP integration in context assembly pipeline
src/cleveragents/application/services/plan_lifecycle_service.py — no LSP context enrichment

Impact

The automatic diagnostic injection feature — one of the key value propositions of LSP integration — is completely non-functional. Actors cannot benefit from automatic type error awareness without explicitly calling lsp/diagnostics as a tool.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Summary The spec requires that when a source file enters the actor's hot context, the LSP server's diagnostics for that file are automatically appended as structured annotations (context enrichment). The `LspContextEnrichment` model is defined in the actor schema but is **never used** in any application code — diagnostics are never injected into ACMS context. ## Expected Behavior (from spec §LSP Integration — Context Enrichment) > **Diagnostic injection**: When a source file enters the actor's hot context, the LSP server's diagnostics for that file are appended as structured annotations. The actor "sees" type errors, unused imports, and other issues without explicitly calling `lsp/diagnostics`. The spec also states (§LSP Integration — Acceptance Criteria, row 5): > Plan execution with LSP-bound actor includes diagnostic fragments in context And the actor YAML schema supports: ```yaml lsp_context_enrichment: diagnostics: true # default: true type_annotations: false # default: false max_diagnostics_per_file: 50 ``` ## Actual Behavior `LspContextEnrichment` is defined in `src/cleveragents/actor/schema.py` (line 344) and referenced in `ActorConfigSchema.lsp_context_enrichment` (line 766), but searching the entire codebase: ``` $ grep -rn "lsp_context_enrichment\|LspContextEnrichment" src/cleveragents --include="*.py" # Only results: actor/schema.py (definition only) ``` The `LspContextEnrichment` model is **never read or used** outside the schema definition. No code: - Reads `actor_config.lsp_context_enrichment` during actor activation - Calls `LspRuntime.get_diagnostics()` when files enter hot context - Injects diagnostic fragments into ACMS context assembly ## Code Location - `src/cleveragents/actor/schema.py` line 344 — `LspContextEnrichment` defined but never consumed - `src/cleveragents/context/` — no LSP integration in context assembly pipeline - `src/cleveragents/application/services/plan_lifecycle_service.py` — no LSP context enrichment ## Impact The automatic diagnostic injection feature — one of the key value propositions of LSP integration — is completely non-functional. Actors cannot benefit from automatic type error awareness without explicitly calling `lsp/diagnostics` as a tool. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added the

labels

2026-04-09 08:34:10 +00:00

HAL9000 referenced this issue

2026-04-09 08:41:19 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 28) #5666

HAL9000 added

and removed

labels

2026-04-09 08:41:36 +00:00

HAL9000 referenced this issue

2026-04-09 08:45:21 +00:00

[AUTO-GROOMER] Backlog Grooming Report (Cycle 55) #5677

HAL9000 added this to the v3.5.0 milestone

2026-04-09 08:47:47 +00:00

HAL9000 commented

2026-04-09 08:48:55 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Critical — LSP context enrichment is a spec-required feature (§LSP Integration — Context Enrichment). The LspContextEnrichment model is defined but never consumed anywhere in the codebase. Automatic diagnostic injection into ACMS hot context is completely non-functional, which is a key value proposition of LSP integration.
Milestone: v3.6.0 — LSP integration is an advanced feature scoped to v3.6.0 (Advanced Concepts & Deferred Features).
Story Points: 5 — L — Wiring LspContextEnrichment into the context assembly pipeline and ACMS hot context injection requires touching multiple layers (actor activation, context assembly, ACMS pipeline), estimated 1-2 days.
MoSCoW: MoSCoW/Must have — The spec explicitly states (§LSP Integration — Acceptance Criteria, row 5): "Plan execution with LSP-bound actor includes diagnostic fragments in context." This is a spec-required acceptance criterion for LSP integration.
Parent Epic: Needs linking to LSP Integration Epic

This is a complete integration gap. LspContextEnrichment is defined in the actor schema but never read or used outside the schema definition. The fix requires wiring context enrichment into the ACMS context assembly pipeline when files enter the actor's hot context.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Critical — LSP context enrichment is a spec-required feature (§LSP Integration — Context Enrichment). The `LspContextEnrichment` model is defined but never consumed anywhere in the codebase. Automatic diagnostic injection into ACMS hot context is completely non-functional, which is a key value proposition of LSP integration. - **Milestone**: v3.6.0 — LSP integration is an advanced feature scoped to v3.6.0 (Advanced Concepts & Deferred Features). - **Story Points**: 5 — L — Wiring `LspContextEnrichment` into the context assembly pipeline and ACMS hot context injection requires touching multiple layers (actor activation, context assembly, ACMS pipeline), estimated 1-2 days. - **MoSCoW**: MoSCoW/Must have — The spec explicitly states (§LSP Integration — Acceptance Criteria, row 5): "Plan execution with LSP-bound actor includes diagnostic fragments in context." This is a spec-required acceptance criterion for LSP integration. - **Parent Epic**: Needs linking to LSP Integration Epic This is a complete integration gap. `LspContextEnrichment` is defined in the actor schema but never read or used outside the schema definition. The fix requires wiring context enrichment into the ACMS context assembly pipeline when files enter the actor's hot context. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 commented

2026-04-09 08:49:05 +00:00

Author

Owner

Label compliance fix applied:

Added missing labels and/or milestone to bring issue into compliance with CONTRIBUTING.md

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: backlog-groomer

Label compliance fix applied: - Added missing labels and/or milestone to bring issue into compliance with CONTRIBUTING.md --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: backlog-groomer

HAL9000 referenced this issue

2026-04-09 08:49:07 +00:00

[AUTO-GROOMER] Backlog Grooming Report (Cycle 1) #5720

HAL9000 modified the milestone from v3.5.0 to v3.6.0

2026-04-09 08:50:10 +00:00

HAL9000 added

and removed

labels

2026-04-09 08:50:45 +00:00

HAL9000 referenced this issue

2026-04-09 08:53:51 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 28) #5666

HAL9000 referenced this issue

2026-04-09 09:03:59 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 10) #5748

HAL9000 referenced this issue

2026-04-09 09:07:51 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 29) #5759

HAL9000 added a new dependency

2026-04-09 09:10:48 +00:00

#5166 EPIC: Context Assembly Pipeline — Budget-Constrained Context Views (ACMS v3.4.0)

HAL9000 referenced this issue

2026-04-09 09:13:58 +00:00

[AUTO-EPIC] Epic Planning Health Report (Cycle 11) #5298

HAL9000 commented

2026-04-09 10:17:00 +00:00

Author

Owner

Milestone compliance fix applied:

Assigned to milestone: v3.6.0 (Advanced Concepts & Deferred Features)
Reason: Issue is State/Verified but had no milestone assigned. LSP context enrichment belongs to v3.6.0 scope.

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: backlog-groomer

Milestone compliance fix applied: - Assigned to milestone: **v3.6.0** (Advanced Concepts & Deferred Features) - Reason: Issue is `State/Verified` but had no milestone assigned. LSP context enrichment belongs to v3.6.0 scope. --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: backlog-groomer

HAL9000 referenced this issue

2026-04-09 12:02:40 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 34) #5941

HAL9000 referenced this issue

2026-04-09 13:32:13 +00:00

[AUTO-GROOMER] Backlog Grooming Report (Cycle 1) #5720