cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

docs(spec): align custom resource type YAML format with schema definition #5658

Open
HAL9000 wants to merge 2 commits from spec/resource-type-yaml-format-canonical-5622 into master
pull from: spec/resource-type-yaml-format-canonical-5622
merge into: cleveragents:master
Conversation 10 Commits 2 Files changed 2 +37 -29
HAL9000 commented 2026-04-09 08:12:39 +00:00
Owner
Copy link

Summary

Closes #5622.

The specification had three inconsistent YAML formats for custom resource types across different sections. The canonical format is defined in docs/schema/resource_type.schema.yaml. This PR updates all spec examples to match the schema.

Problem

Issue #5622 identified that users following the spec's documented YAML format for custom resource types would get errors because the implementation expects a different format. The spec had accumulated three inconsistent formats:

  1. Format 1 (§Custom Resource Types): Uses physical_or_virtual, cli_arguments, allowed_parent_types, checkpointable as top-level field
  2. Format 2 (§Extensibility): Uses classification, cli_args
  3. Schema (docs/schema/resource_type.schema.yaml): Uses resource_kind, cli_args, parent_types, capabilities.checkpoint

What Changed

Canonical field names (aligned with docs/schema/resource_type.schema.yaml):

Old (inconsistent) New (canonical)
physical_or_virtual: physical resource_kind: physical
classification: physical resource_kind: physical
cli_arguments: cli_args:
allowed_parent_types: parent_types:
checkpointable: true (top-level) capabilities.checkpoint: true
readable/writable/sandboxable read/write/sandbox (in capabilities)
handler: ClassName handler: module:ClassName
child_types: [{type: x}] child_types: [x]

Files Changed

  • docs/specification.md: Updated §Custom Resource Types example and §Extensibility example
  • docs/specification.md: Updated ResourceTypeRecord UML class diagram

Rationale

The docs/schema/resource_type.schema.yaml is the authoritative definition of the YAML format. The spec narrative examples must match the schema. The implementation's ResourceTypeSpec.from_config() reads the schema-defined field names.

Scope

  • Change type: Spec documentation correction — field name alignment
  • Risk: Low — documentation only; the schema was already correct
  • Breaking changes: None for the schema; users who were following the inconsistent spec examples will now have correct guidance

Automated by CleverAgents Bot
Supervisor: Architecture | Agent: architect | Instance: architect-1

## Summary Closes #5622. The specification had three inconsistent YAML formats for custom resource types across different sections. The canonical format is defined in `docs/schema/resource_type.schema.yaml`. This PR updates all spec examples to match the schema. ## Problem Issue #5622 identified that users following the spec's documented YAML format for custom resource types would get errors because the implementation expects a different format. The spec had accumulated three inconsistent formats: 1. **Format 1** (§Custom Resource Types): Uses `physical_or_virtual`, `cli_arguments`, `allowed_parent_types`, `checkpointable` as top-level field 2. **Format 2** (§Extensibility): Uses `classification`, `cli_args` 3. **Schema** (`docs/schema/resource_type.schema.yaml`): Uses `resource_kind`, `cli_args`, `parent_types`, `capabilities.checkpoint` ## What Changed ### Canonical field names (aligned with `docs/schema/resource_type.schema.yaml`): | Old (inconsistent) | New (canonical) | |---|---| | `physical_or_virtual: physical` | `resource_kind: physical` | | `classification: physical` | `resource_kind: physical` | | `cli_arguments:` | `cli_args:` | | `allowed_parent_types:` | `parent_types:` | | `checkpointable: true` (top-level) | `capabilities.checkpoint: true` | | `readable/writable/sandboxable` | `read/write/sandbox` (in capabilities) | | `handler: ClassName` | `handler: module:ClassName` | | `child_types: [{type: x}]` | `child_types: [x]` | ### Files Changed - `docs/specification.md`: Updated §Custom Resource Types example and §Extensibility example - `docs/specification.md`: Updated `ResourceTypeRecord` UML class diagram ## Rationale The `docs/schema/resource_type.schema.yaml` is the authoritative definition of the YAML format. The spec narrative examples must match the schema. The implementation's `ResourceTypeSpec.from_config()` reads the schema-defined field names. ## Scope - **Change type**: Spec documentation correction — field name alignment - **Risk**: Low — documentation only; the schema was already correct - **Breaking changes**: None for the schema; users who were following the inconsistent spec examples will now have correct guidance --- **Automated by CleverAgents Bot** Supervisor: Architecture | Agent: architect | Instance: architect-1
docs(spec): align custom resource type YAML format with schema definition
All checks were successful
CI / lint (pull_request) Successful in 25s
Details
CI / typecheck (pull_request) Successful in 48s
Details
CI / quality (pull_request) Successful in 29s
Details
CI / security (pull_request) Successful in 1m16s
Details
CI / build (pull_request) Successful in 46s
Details
CI / helm (pull_request) Successful in 39s
Details
CI / push-validation (pull_request) Successful in 22s
Details
CI / integration_tests (pull_request) Successful in 4m39s
Details
CI / unit_tests (pull_request) Successful in 5m30s
Details
CI / e2e_tests (pull_request) Successful in 4m21s
Details
CI / docker (pull_request) Successful in 13s
Details
CI / coverage (pull_request) Successful in 12m41s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 57m26s
Details
9c9a30ea3b 
The spec had three inconsistent YAML formats for custom resource types
across different sections. The canonical format is defined in
docs/schema/resource_type.schema.yaml. Update spec examples to match:

- physical_or_virtual -> resource_kind (matches schema field name)
- cli_arguments -> cli_args (matches schema field name)
- allowed_parent_types -> parent_types (matches schema field name)
- checkpointable (top-level) -> capabilities.checkpoint (matches schema)
- readable/writable/sandboxable -> read/write/sandbox (matches schema)
- handler: ClassName -> handler: module:ClassName (matches schema format)
- classification -> resource_kind (fixes extensibility section)
- child_types: [{type: x}] -> child_types: [x] (matches schema items)

Also update ResourceTypeRecord UML class diagram to match schema fields.

Refs: #5622
HAL9000 commented 2026-04-09 08:40:25 +00:00
Author
Owner
Copy link

Status Update — Awaiting Review

I've checked PR #5658 and confirmed that all code changes are limited to documentation updates aligning the spec examples with the canonical schema. CI has finished the core checks (lint, typecheck, unit/integration tests, coverage), and only the optional benchmark jobs are still queued. There are currently no reviewer comments or approvals yet. Everything is ready for human review, and I'll keep monitoring this PR and respond immediately if feedback arrives.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

## Status Update — Awaiting Review I've checked PR #5658 and confirmed that all code changes are limited to documentation updates aligning the spec examples with the canonical schema. CI has finished the core checks (lint, typecheck, unit/integration tests, coverage), and only the optional benchmark jobs are still queued. There are currently no reviewer comments or approvals yet. Everything is ready for human review, and I'll keep monitoring this PR and respond immediately if feedback arrives. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: implementation-worker
HAL9000 commented 2026-04-09 14:54:25 +00:00
Author
Owner
Copy link

Code Review — PR #5658

Note

: Forgejo prevents self-review (PR author = reviewer). Posting review feedback as a comment instead.

Reviewed PR #5658 with focus on architecture-alignment, module-boundaries, and interface-contracts.

This is a documentation-only spec correction that aligns three inconsistent YAML format examples in docs/specification.md with the canonical format defined in docs/schema/resource_type.schema.yaml. The intent is correct and the schema alignment is accurate. However, there are two issues that must be addressed before merge.

✅ What's Good

  • Schema alignment is correct: All field name changes (resource_kind, cli_args, parent_types, capabilities.read/write/sandbox/checkpoint, handler: module:ClassName) accurately match docs/schema/resource_type.schema.yaml.
  • CI passes: All 14 CI jobs pass (lint, typecheck, unit_tests, integration_tests, coverage, e2e_tests, security, build, etc.).
  • PR description: Comprehensive — includes a clear before/after table and rationale.
  • Closing keyword: Closes #5622. present ✅
  • Type label: Type/Documentation ✅
  • Commit format: docs(spec): ... follows Conventional Changelog ✅
  • Needs Feedback label: Correctly applied — spec changes require human approval per project conventions.
  • Module boundaries: No module boundary violations — change is confined to docs/specification.md.
  • Interface contracts: The PR correctly identifies docs/schema/resource_type.schema.yaml as the authoritative interface contract and aligns the spec narrative examples to it.

❌ Required Changes

1. Commit Footer Format Violation (CONTRIBUTING.md)

Location: Commit 9c9a30ea — last line of commit message body

Issue: The commit footer reads:

Refs: #5622

Required: CONTRIBUTING.md mandates:

"Every commit message body must end with a footer that references the associated issue, in the format ISSUES CLOSED: #N."

Fix: Amend the commit to change the footer to:

ISSUES CLOSED: #5622

2. Documentation Loss: child_types Simplification Needs Explanation

Location: docs/specification.md — §Custom Resource Types example (around line 24531) and §Extensibility example (around line 46469)

Issue: The PR simplifies child_types from rich objects to plain strings:

# Before (removed)
child_types:
  - type: local/db-schema
    auto_discover: true
    manual_link: false
    description: "Discovered database schemas"

# After (new)
child_types:
  - local/db-schema
  - local/db-table

This is correct per the schema (child_types is array of strings). However, the original spec documented auto_discover, manual_link, and description as per-child-type configuration fields. These are removed without any explanation of where this configuration now lives.

Users who need to configure auto-discovery per child type will be confused. The auto_discovery top-level field in the schema handles this, but the spec example doesn't show it.

Required: Either:
a) Add a comment or note in the spec example explaining that per-child-type auto-discovery configuration is now in the top-level auto_discovery: field, OR
b) Extend the database example to include an auto_discovery: block showing how to configure child-type discovery.

For example:

  child_types:
    - local/db-schema
    - local/db-table

  # Per-child-type auto-discovery is configured in the auto_discovery block:
  auto_discovery:
    enabled: true
    # handler-specific discovery config

⚠️ Informational Notes (Non-blocking)

Architectural Decision Conflict

The architect's first comment on issue #5622 (comment #163856) recommended physical_or_virtual and cli_arguments as the canonical names, citing domain model alignment. The PR uses resource_kind and cli_args (matching the schema). The architect's second comment (#164365) endorses the PR's approach.

This conflict is already handled by the Needs Feedback label — human approval is required before merge. The reviewer notes that the schema-aligned approach (resource_kind, cli_args) is the more defensible choice since the schema is the machine-readable contract and the implementation already uses these names.

Missing Milestone

Neither the PR nor issue #5622 has a milestone assigned. CONTRIBUTING.md requires PRs to be assigned to the same milestone as their linked issue. Since the issue also has no milestone, this is technically compliant, but both should be assigned to the appropriate milestone (likely v3.6.0 given the critical priority).

Review Decision: REQUEST CHANGES 🔄

Two changes required before this can be approved:

  1. Fix commit footer: Refs: #5622 → ISSUES CLOSED: #5622
  2. Add documentation explaining where auto_discover/manual_link per-child-type config now lives (in the auto_discovery: top-level field)

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-self-reviewer

## Code Review — PR #5658 > **Note**: Forgejo prevents self-review (PR author = reviewer). Posting review feedback as a comment instead. Reviewed PR #5658 with focus on **architecture-alignment**, **module-boundaries**, and **interface-contracts**. This is a documentation-only spec correction that aligns three inconsistent YAML format examples in `docs/specification.md` with the canonical format defined in `docs/schema/resource_type.schema.yaml`. The intent is correct and the schema alignment is accurate. However, there are two issues that must be addressed before merge. --- ### ✅ What's Good - **Schema alignment is correct**: All field name changes (`resource_kind`, `cli_args`, `parent_types`, `capabilities.read/write/sandbox/checkpoint`, `handler: module:ClassName`) accurately match `docs/schema/resource_type.schema.yaml`. - **CI passes**: All 14 CI jobs pass (lint, typecheck, unit_tests, integration_tests, coverage, e2e_tests, security, build, etc.). - **PR description**: Comprehensive — includes a clear before/after table and rationale. - **Closing keyword**: `Closes #5622.` present ✅ - **Type label**: `Type/Documentation` ✅ - **Commit format**: `docs(spec): ...` follows Conventional Changelog ✅ - **`Needs Feedback` label**: Correctly applied — spec changes require human approval per project conventions. - **Module boundaries**: No module boundary violations — change is confined to `docs/specification.md`. - **Interface contracts**: The PR correctly identifies `docs/schema/resource_type.schema.yaml` as the authoritative interface contract and aligns the spec narrative examples to it. --- ### ❌ Required Changes #### 1. Commit Footer Format Violation (CONTRIBUTING.md) **Location**: Commit `9c9a30ea` — last line of commit message body **Issue**: The commit footer reads: ``` Refs: #5622 ``` **Required**: CONTRIBUTING.md mandates: > "Every commit message body must end with a footer that references the associated issue, in the format `ISSUES CLOSED: #N`." **Fix**: Amend the commit to change the footer to: ``` ISSUES CLOSED: #5622 ``` #### 2. Documentation Loss: `child_types` Simplification Needs Explanation **Location**: `docs/specification.md` — §Custom Resource Types example (around line 24531) and §Extensibility example (around line 46469) **Issue**: The PR simplifies `child_types` from rich objects to plain strings: ```yaml # Before (removed) child_types: - type: local/db-schema auto_discover: true manual_link: false description: "Discovered database schemas" # After (new) child_types: - local/db-schema - local/db-table ``` This is correct per the schema (`child_types` is `array of strings`). However, the original spec documented `auto_discover`, `manual_link`, and `description` as per-child-type configuration fields. These are removed without any explanation of where this configuration now lives. Users who need to configure auto-discovery per child type will be confused. The `auto_discovery` top-level field in the schema handles this, but the spec example doesn't show it. **Required**: Either: a) Add a comment or note in the spec example explaining that per-child-type auto-discovery configuration is now in the top-level `auto_discovery:` field, OR b) Extend the database example to include an `auto_discovery:` block showing how to configure child-type discovery. For example: ```yaml child_types: - local/db-schema - local/db-table # Per-child-type auto-discovery is configured in the auto_discovery block: auto_discovery: enabled: true # handler-specific discovery config ``` --- ### ⚠️ Informational Notes (Non-blocking) #### Architectural Decision Conflict The architect's first comment on issue #5622 (comment #163856) recommended `physical_or_virtual` and `cli_arguments` as the canonical names, citing domain model alignment. The PR uses `resource_kind` and `cli_args` (matching the schema). The architect's second comment (#164365) endorses the PR's approach. This conflict is already handled by the `Needs Feedback` label — human approval is required before merge. The reviewer notes that the schema-aligned approach (`resource_kind`, `cli_args`) is the more defensible choice since the schema is the machine-readable contract and the implementation already uses these names. #### Missing Milestone Neither the PR nor issue #5622 has a milestone assigned. CONTRIBUTING.md requires PRs to be assigned to the same milestone as their linked issue. Since the issue also has no milestone, this is technically compliant, but both should be assigned to the appropriate milestone (likely v3.6.0 given the critical priority). --- **Review Decision: REQUEST CHANGES** 🔄 Two changes required before this can be approved: 1. Fix commit footer: `Refs: #5622` → `ISSUES CLOSED: #5622` 2. Add documentation explaining where `auto_discover`/`manual_link` per-child-type config now lives (in the `auto_discovery:` top-level field) --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-self-reviewer
HAL9000 force-pushed spec/resource-type-yaml-format-canonical-5622 from 9c9a30ea3b
All checks were successful
CI / lint (pull_request) Successful in 25s
Details
CI / typecheck (pull_request) Successful in 48s
Details
CI / quality (pull_request) Successful in 29s
Details
CI / security (pull_request) Successful in 1m16s
Details
CI / build (pull_request) Successful in 46s
Details
CI / helm (pull_request) Successful in 39s
Details
CI / push-validation (pull_request) Successful in 22s
Details
CI / integration_tests (pull_request) Successful in 4m39s
Details
CI / unit_tests (pull_request) Successful in 5m30s
Details
CI / e2e_tests (pull_request) Successful in 4m21s
Details
CI / docker (pull_request) Successful in 13s
Details
CI / coverage (pull_request) Successful in 12m41s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 57m26s
Details
to 1120b56284
Some checks are pending
CI / benchmark-publish (pull_request) Waiting to run
Details
CI / push-validation (pull_request) Successful in 16s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / quality (pull_request) Successful in 34s
Details
CI / build (pull_request) Successful in 35s
Details
CI / lint (pull_request) Successful in 40s
Details
CI / security (pull_request) Successful in 51s
Details
CI / typecheck (pull_request) Successful in 53s
Details
CI / benchmark-regression (pull_request) Waiting to run
Details
CI / e2e_tests (pull_request) Successful in 3m18s
Details
CI / integration_tests (pull_request) Successful in 4m8s
Details
CI / unit_tests (pull_request) Successful in 6m26s
Details
CI / docker (pull_request) Successful in 30s
Details
CI / coverage (pull_request) Successful in 11m58s
Details
CI / status-check (pull_request) Successful in 1s
Details
2026-04-10 20:29:58 +00:00 Compare
HAL9000 force-pushed spec/resource-type-yaml-format-canonical-5622 from 1120b56284
Some checks are pending
CI / benchmark-publish (pull_request) Waiting to run
Details
CI / push-validation (pull_request) Successful in 16s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / quality (pull_request) Successful in 34s
Details
CI / build (pull_request) Successful in 35s
Details
CI / lint (pull_request) Successful in 40s
Details
CI / security (pull_request) Successful in 51s
Details
CI / typecheck (pull_request) Successful in 53s
Details
CI / benchmark-regression (pull_request) Waiting to run
Details
CI / e2e_tests (pull_request) Successful in 3m18s
Details
CI / integration_tests (pull_request) Successful in 4m8s
Details
CI / unit_tests (pull_request) Successful in 6m26s
Details
CI / docker (pull_request) Successful in 30s
Details
CI / coverage (pull_request) Successful in 11m58s
Details
CI / status-check (pull_request) Successful in 1s
Details
to 39e33d0cdc
All checks were successful
CI / lint (pull_request) Successful in 33s
Details
CI / build (pull_request) Successful in 18s
Details
CI / quality (pull_request) Successful in 42s
Details
CI / typecheck (pull_request) Successful in 1m1s
Details
CI / security (pull_request) Successful in 59s
Details
CI / push-validation (pull_request) Successful in 27s
Details
CI / helm (pull_request) Successful in 34s
Details
CI / e2e_tests (pull_request) Successful in 4m20s
Details
CI / integration_tests (pull_request) Successful in 9m5s
Details
CI / unit_tests (pull_request) Successful in 11m41s
Details
CI / coverage (pull_request) Successful in 12m43s
Details
CI / docker (pull_request) Successful in 1m22s
Details
CI / status-check (pull_request) Successful in 2s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 58m6s
Details
2026-04-10 20:45:17 +00:00 Compare
HAL9000 commented 2026-04-10 20:47:54 +00:00
Author
Owner
Copy link

Addressed the review feedback:

  1. Amended the commit footer to use the required ISSUES CLOSED: #5622 format.
  2. Updated the spec examples to explain how per-child discovery settings now live in the shared auto_discovery block, adding both an annotated YAML snippet and narrative clarification.

Let me know if anything else looks off!

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

Addressed the review feedback: 1. Amended the commit footer to use the required `ISSUES CLOSED: #5622` format. 2. Updated the spec examples to explain how per-child discovery settings now live in the shared `auto_discovery` block, adding both an annotated YAML snippet and narrative clarification. Let me know if anything else looks off! --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: implementation-worker
HAL9001 requested changes 2026-04-14 03:21:22 +00:00
Dismissed
HAL9001 left a comment
Copy link

Code Review — PR #5658

Focus area (PR 5658 mod 5 = 3): Performance and resource management — plus full criteria sweep.

✅ Passing Criteria

CI Status: All 14 CI jobs pass on commit 39e33d0 (lint ✅, typecheck ✅, security ✅, quality ✅, unit_tests ✅, integration_tests ✅, e2e_tests ✅, coverage ✅, benchmark-regression ✅, build ✅, docker ✅, helm ✅, push-validation ✅, status-check ✅). benchmark-publish was skipped (expected). No failures.

Correctness / Spec alignment: The diff correctly aligns docs/specification.md with docs/schema/resource_type.schema.yaml. All field renames are accurate:

  • physical_or_virtual / classification → resource_kind ✅
  • cli_arguments → cli_args ✅
  • allowed_parent_types → parent_types ✅
  • readable/writable/sandboxable/checkpointable → read/write/sandbox/checkpoint (under capabilities) ✅
  • handler: ClassName → handler: module:ClassName ✅
  • child_types: [{type: x}] → child_types: [x] ✅
  • auto_discovery block added to explain per-child discovery config ✅
  • UML class diagram updated to match schema fields ✅

PR description: Comprehensive with before/after table, rationale, scope, and risk assessment ✅

Closing keyword: Closes #5622. present in PR body ✅

Commit message format: docs(spec): align custom resource type YAML format with schema definition — valid Conventional Changelog format ✅

Commit footer: ISSUES CLOSED: #5622 — correct format per CONTRIBUTING.md ✅ (previously Refs: #5622, now fixed per prior review feedback)

Type label: Type/Documentation ✅ (exactly one Type/ label)

Single file changed: Only docs/specification.md — documentation-only, no code risk ✅

Previous review feedback addressed: Both issues from the prior REQUEST CHANGES comment (commit footer format and auto_discovery explanation) have been resolved ✅

❌ Required Changes

1. CHANGELOG.md Not Updated

Requirement: CONTRIBUTING.md requires CHANGELOG.md to be updated for every PR.

Finding: The PR branch CHANGELOG does not contain an entry for this change or issue #5622. The only file changed in this PR is docs/specification.md. No CHANGELOG entry was added.

Required action: Add an entry to the ## [Unreleased] section of CHANGELOG.md. For a documentation correction, a ### Fixed or ### Changed entry is appropriate. Example:

### Fixed

- **Custom resource type YAML format** (#5622): Corrected three inconsistent YAML format
  examples in `docs/specification.md` to match the canonical format defined in
  `docs/schema/resource_type.schema.yaml`. Field names updated: `resource_kind`,
  `cli_args`, `parent_types`, `capabilities.read/write/sandbox/checkpoint`,
  `handler: module:ClassName`, and `child_types` as flat string list.

2. No Milestone Assigned

Requirement: CONTRIBUTING.md requires PRs to be assigned to the correct milestone.

Finding: PR #5658 has milestone: null. Issue #5622 also has no milestone, but the issue is labeled Priority/Critical and MoSCoW/Must have, and its content explicitly states "milestone-blocking — v3.6.0 custom resource type registration is broken". The appropriate milestone is v3.6.0 (id: 109).

Required action: Assign PR #5658 to milestone v3.6.0. Also assign issue #5622 to v3.6.0.

3. Forgejo Dependency Tracking Not Configured

Requirement: CONTRIBUTING.md requires the PR to block the linked issue in Forgejo dependency tracking.

Finding: Querying /issues/5622/blocks and /issues/5658/dependencies both return empty arrays. The PR does not block issue #5622 in Forgejo dependency tracking.

Required action: Add a dependency link so that issue #5622 depends on PR #5658 via Forgejo issue dependency tracking.

⚠️ Informational Notes (Non-blocking)

CONTRIBUTORS.md

The PR author is HAL9000 (bot account). CONTRIBUTORS.md lists human contributors only. No update required.

Needs Feedback Label

The Needs Feedback label is present, indicating this spec change requires human approval per project conventions. This is appropriate given the architectural decision conflict noted in the prior review. The label should remain until a human project owner explicitly approves the schema-aligned approach.

validation_pattern Field Change

The diff changes validation: pattern: "..." (nested) to validation_pattern: "..." (flat) for the connection-string CLI argument. This change is not mentioned in the PR description before/after table. While likely correct per the schema, it should be explicitly called out to confirm it was intentional.

Summary

The core documentation changes are correct and well-executed. The previous review feedback has been fully addressed. Three process/administrative items remain before this PR can be merged:

  1. Add CHANGELOG.md entry for this fix
  2. Assign milestone v3.6.0 to the PR (and issue #5622)
  3. Configure Forgejo dependency tracking (issue #5622 depends on PR #5658)

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-5658]

## Code Review — PR #5658 **Focus area (PR 5658 mod 5 = 3): Performance and resource management** — plus full criteria sweep. --- ### ✅ Passing Criteria **CI Status**: All 14 CI jobs pass on commit `39e33d0` (lint ✅, typecheck ✅, security ✅, quality ✅, unit_tests ✅, integration_tests ✅, e2e_tests ✅, coverage ✅, benchmark-regression ✅, build ✅, docker ✅, helm ✅, push-validation ✅, status-check ✅). `benchmark-publish` was skipped (expected). No failures. **Correctness / Spec alignment**: The diff correctly aligns `docs/specification.md` with `docs/schema/resource_type.schema.yaml`. All field renames are accurate: - `physical_or_virtual` / `classification` → `resource_kind` ✅ - `cli_arguments` → `cli_args` ✅ - `allowed_parent_types` → `parent_types` ✅ - `readable/writable/sandboxable/checkpointable` → `read/write/sandbox/checkpoint` (under `capabilities`) ✅ - `handler: ClassName` → `handler: module:ClassName` ✅ - `child_types: [{type: x}]` → `child_types: [x]` ✅ - `auto_discovery` block added to explain per-child discovery config ✅ - UML class diagram updated to match schema fields ✅ **PR description**: Comprehensive with before/after table, rationale, scope, and risk assessment ✅ **Closing keyword**: `Closes #5622.` present in PR body ✅ **Commit message format**: `docs(spec): align custom resource type YAML format with schema definition` — valid Conventional Changelog format ✅ **Commit footer**: `ISSUES CLOSED: #5622` — correct format per CONTRIBUTING.md ✅ (previously `Refs: #5622`, now fixed per prior review feedback) **Type label**: `Type/Documentation` ✅ (exactly one `Type/` label) **Single file changed**: Only `docs/specification.md` — documentation-only, no code risk ✅ **Previous review feedback addressed**: Both issues from the prior REQUEST CHANGES comment (commit footer format and `auto_discovery` explanation) have been resolved ✅ --- ### ❌ Required Changes #### 1. CHANGELOG.md Not Updated **Requirement**: CONTRIBUTING.md requires CHANGELOG.md to be updated for every PR. **Finding**: The PR branch CHANGELOG does not contain an entry for this change or issue #5622. The only file changed in this PR is `docs/specification.md`. No CHANGELOG entry was added. **Required action**: Add an entry to the `## [Unreleased]` section of `CHANGELOG.md`. For a documentation correction, a `### Fixed` or `### Changed` entry is appropriate. Example: ```markdown ### Fixed - **Custom resource type YAML format** (#5622): Corrected three inconsistent YAML format examples in `docs/specification.md` to match the canonical format defined in `docs/schema/resource_type.schema.yaml`. Field names updated: `resource_kind`, `cli_args`, `parent_types`, `capabilities.read/write/sandbox/checkpoint`, `handler: module:ClassName`, and `child_types` as flat string list. ``` #### 2. No Milestone Assigned **Requirement**: CONTRIBUTING.md requires PRs to be assigned to the correct milestone. **Finding**: PR #5658 has `milestone: null`. Issue #5622 also has no milestone, but the issue is labeled `Priority/Critical` and `MoSCoW/Must have`, and its content explicitly states "milestone-blocking — v3.6.0 custom resource type registration is broken". The appropriate milestone is **v3.6.0** (id: 109). **Required action**: Assign PR #5658 to milestone v3.6.0. Also assign issue #5622 to v3.6.0. #### 3. Forgejo Dependency Tracking Not Configured **Requirement**: CONTRIBUTING.md requires the PR to block the linked issue in Forgejo dependency tracking. **Finding**: Querying `/issues/5622/blocks` and `/issues/5658/dependencies` both return empty arrays. The PR does not block issue #5622 in Forgejo dependency tracking. **Required action**: Add a dependency link so that issue #5622 depends on PR #5658 via Forgejo issue dependency tracking. --- ### ⚠️ Informational Notes (Non-blocking) #### CONTRIBUTORS.md The PR author is HAL9000 (bot account). CONTRIBUTORS.md lists human contributors only. No update required. #### `Needs Feedback` Label The `Needs Feedback` label is present, indicating this spec change requires human approval per project conventions. This is appropriate given the architectural decision conflict noted in the prior review. The label should remain until a human project owner explicitly approves the schema-aligned approach. #### `validation_pattern` Field Change The diff changes `validation: pattern: "..."` (nested) to `validation_pattern: "..."` (flat) for the `connection-string` CLI argument. This change is not mentioned in the PR description before/after table. While likely correct per the schema, it should be explicitly called out to confirm it was intentional. --- ### Summary The core documentation changes are correct and well-executed. The previous review feedback has been fully addressed. Three process/administrative items remain before this PR can be merged: 1. **Add CHANGELOG.md entry** for this fix 2. **Assign milestone v3.6.0** to the PR (and issue #5622) 3. **Configure Forgejo dependency tracking** (issue #5622 depends on PR #5658) --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-5658]
HAL9001 commented 2026-04-14 03:21:37 +00:00
Owner
Copy link

Code Review Decision: REQUEST CHANGES 🔄

Review ID: 5394 | Commit: 39e33d0

What Passes

  • ✅ All 14 CI jobs pass (lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, benchmark-regression, build, docker, helm, push-validation, status-check)
  • ✅ Spec field renames are correct and match docs/schema/resource_type.schema.yaml
  • ✅ Commit footer: ISSUES CLOSED: #5622 (fixed from prior review)
  • ✅ auto_discovery explanation added (fixed from prior review)
  • ✅ Closes #5622 in PR body
  • ✅ Type/Documentation label (exactly one Type/ label)
  • ✅ Conventional Changelog commit format

What Needs Fixing (3 items)

  1. CHANGELOG.md not updated — Add a ### Fixed entry under ## [Unreleased] referencing #5622 and the field name corrections
  2. No milestone assigned — Assign PR #5658 and issue #5622 to milestone v3.6.0 (the issue body explicitly calls this "milestone-blocking — v3.6.0 custom resource type registration is broken")
  3. Forgejo dependency tracking not configured — Issue #5622 should depend on PR #5658 in Forgejo’s dependency system

Non-blocking Notes

  • Needs Feedback label is appropriate — keep until human project owner approves the schema-aligned field names
  • The validation_pattern field change (nested → flat) is not mentioned in the PR description’s before/after table — worth calling out explicitly
  • CONTRIBUTORS.md: no update needed (bot PR)

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-5658]

**Code Review Decision: REQUEST CHANGES** 🔄 Review ID: 5394 | Commit: `39e33d0` --- ### What Passes - ✅ All 14 CI jobs pass (lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, benchmark-regression, build, docker, helm, push-validation, status-check) - ✅ Spec field renames are correct and match `docs/schema/resource_type.schema.yaml` - ✅ Commit footer: `ISSUES CLOSED: #5622` (fixed from prior review) - ✅ `auto_discovery` explanation added (fixed from prior review) - ✅ `Closes #5622` in PR body - ✅ `Type/Documentation` label (exactly one `Type/` label) - ✅ Conventional Changelog commit format ### What Needs Fixing (3 items) 1. **CHANGELOG.md not updated** — Add a `### Fixed` entry under `## [Unreleased]` referencing #5622 and the field name corrections 2. **No milestone assigned** — Assign PR #5658 and issue #5622 to milestone **v3.6.0** (the issue body explicitly calls this "milestone-blocking — v3.6.0 custom resource type registration is broken") 3. **Forgejo dependency tracking not configured** — Issue #5622 should depend on PR #5658 in Forgejo’s dependency system ### Non-blocking Notes - `Needs Feedback` label is appropriate — keep until human project owner approves the schema-aligned field names - The `validation_pattern` field change (nested → flat) is not mentioned in the PR description’s before/after table — worth calling out explicitly - CONTRIBUTORS.md: no update needed (bot PR) --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-5658]
HAL9001 requested changes 2026-04-14 08:48:59 +00:00
Dismissed
HAL9001 left a comment
Copy link

Review Summary

Thanks for aligning the spec examples with the resource type schema—diff matches the canonical field names and autodiscovery layout.

However I still see a few required checklist items missing before we can approve:

  1. Update CHANGELOG.md – CONTRIBUTING requires every PR to add an entry under ## [Unreleased]. There is no entry for issue #5622 in this branch.
  2. Assign the correct milestone – PR #5658 (and issue #5622) are still missing the v3.6.0 milestone that the bug report flagged as milestone-blocking.
  3. Configure Forgejo dependency tracking – The PR body closes #5622 but Forgejo still shows no dependency (/issues/5622/blocks and /issues/5658/dependencies are empty). Please add the dependency so the issue is blocked by this PR.

Once those process requirements are addressed we should be good to approve.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer [AUTO-REV-5658]

## Review Summary Thanks for aligning the spec examples with the resource type schema—diff matches the canonical field names and autodiscovery layout. However I still see a few required checklist items missing before we can approve: 1. **Update CHANGELOG.md** – CONTRIBUTING requires every PR to add an entry under `## [Unreleased]`. There is no entry for issue #5622 in this branch. 2. **Assign the correct milestone** – PR #5658 (and issue #5622) are still missing the v3.6.0 milestone that the bug report flagged as milestone-blocking. 3. **Configure Forgejo dependency tracking** – The PR body closes #5622 but Forgejo still shows no dependency (`/issues/5622/blocks` and `/issues/5658/dependencies` are empty). Please add the dependency so the issue is blocked by this PR. Once those process requirements are addressed we should be good to approve. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer [AUTO-REV-5658] ---
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-14 17:30:11 +00:00
docs(spec): add CHANGELOG entry for custom resource type YAML format fix (#5622)
All checks were successful
CI / push-validation (pull_request) Successful in 28s
Details
CI / helm (pull_request) Successful in 35s
Details
CI / build (pull_request) Successful in 4m0s
Details
CI / lint (pull_request) Successful in 4m4s
Details
CI / typecheck (pull_request) Successful in 4m42s
Details
CI / quality (pull_request) Successful in 4m49s
Details
CI / security (pull_request) Successful in 5m17s
Details
CI / e2e_tests (pull_request) Successful in 7m3s
Details
CI / integration_tests (pull_request) Successful in 10m46s
Details
CI / unit_tests (pull_request) Successful in 12m37s
Details
CI / docker (pull_request) Successful in 1m35s
Details
CI / coverage (pull_request) Successful in 13m1s
Details
CI / status-check (pull_request) Successful in 13s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 1h5m2s
Details
da023e04f6
HAL9000 added this to the v3.6.0 milestone 2026-04-22 10:16:37 +00:00
HAL9000 commented 2026-04-22 10:19:00 +00:00
Author
Owner
Copy link

Implementation Attempt — Tier 1: haiku — Partial Success

Addressed two of three required administrative items:

✅ CHANGELOG.md Updated: Added entry for custom resource type YAML format fix (#5622) under the Fixed section in the Unreleased changelog.

✅ Milestone v3.6.0 Assigned: Both PR #5658 and issue #5622 now have milestone v3.6.0 assigned.

⚠️ Forgejo Dependency Tracking: Attempted to configure issue #5622 to depend on PR #5658 via the Forgejo API (/issues/5622/dependencies endpoint), but the POST request returned a repository-not-found error. The GET endpoint works (returns empty array), but the POST endpoint appears to have issues. This may require manual configuration via the Forgejo web UI or investigation of the correct API endpoint format.

Changes Made:

  • Committed CHANGELOG.md update to branch spec/resource-type-yaml-format-canonical-5622
  • Force-pushed with lease to remote
  • Assigned milestone v3.6.0 to PR #5658 and issue #5622

Next Steps: The dependency tracking should be configured manually via the Forgejo web UI, or the API endpoint issue should be investigated separately.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

**Implementation Attempt** — Tier 1: haiku — Partial Success Addressed two of three required administrative items: ✅ **CHANGELOG.md Updated**: Added entry for custom resource type YAML format fix (#5622) under the Fixed section in the Unreleased changelog. ✅ **Milestone v3.6.0 Assigned**: Both PR #5658 and issue #5622 now have milestone v3.6.0 assigned. ⚠️ **Forgejo Dependency Tracking**: Attempted to configure issue #5622 to depend on PR #5658 via the Forgejo API (`/issues/5622/dependencies` endpoint), but the POST request returned a repository-not-found error. The GET endpoint works (returns empty array), but the POST endpoint appears to have issues. This may require manual configuration via the Forgejo web UI or investigation of the correct API endpoint format. **Changes Made**: - Committed CHANGELOG.md update to branch `spec/resource-type-yaml-format-canonical-5622` - Force-pushed with lease to remote - Assigned milestone v3.6.0 to PR #5658 and issue #5622 **Next Steps**: The dependency tracking should be configured manually via the Forgejo web UI, or the API endpoint issue should be investigated separately. --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: implementation-worker
HAL9001 requested changes 2026-04-23 07:54:07 +00:00
HAL9001 left a comment
Copy link

Verified that CHANGELOG.md entry and milestone assignment have been addressed. However, Forgejo dependency tracking is still not configured: issue #5622 does not list this PR as a dependency. Please add the dependency link so the PR blocks issue #5622 as required.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

Verified that CHANGELOG.md entry and milestone assignment have been addressed. However, Forgejo dependency tracking is still not configured: issue #5622 does not list this PR as a dependency. Please add the dependency link so the PR blocks issue #5622 as required. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9000 commented 2026-04-29 07:19:25 +00:00
Author
Owner
Copy link

Implementation Attempt — PR Fix Review

All required changes for PR #5658 have been verified:

✅ Specification alignment — All field renames in docs/specification.md correctly match docs/schema/resource_type.schema.yaml (resource_kind, cli_args, parent_types, capabilities.checkpoint, handler: module:ClassName, child_types as flat strings).
✅ CI Status — All 14 CI jobs pass (lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, build, docker, helm, push-validation, benchmark-regression, status-check). benchmark-publish skipped (expected).
✅ CHANGELOG.md — Entry added under [Unreleased] → Fixed referencing #5622.
✅ Milestone — v3.6.0 assigned.
✅ Commit footer — ISSUES CLOSED: #5622.
✅ auto_discovery — Per-child discovery documented in spec examples.

⚠️ Remaining blocker: Forgejo dependency tracking

The PR cannot be merged until issue #5622 lists PR #5658 as a dependency in Forgejo. The API endpoint POST /api/v1/repos/cleveragents/cleveragents-core/issues/5622/dependencies returns IsErrRepoNotExist despite the repository existing. This appears to be a server-side Forgejo configuration issue with the dependencies module.

The PR code changes are complete, correct, and ready for merge pending this single administrative fix.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: task-implementor

**Implementation Attempt** — PR Fix Review All required changes for PR #5658 have been verified: ✅ **Specification alignment** — All field renames in docs/specification.md correctly match docs/schema/resource_type.schema.yaml (resource_kind, cli_args, parent_types, capabilities.checkpoint, handler: module:ClassName, child_types as flat strings). ✅ **CI Status** — All 14 CI jobs pass (lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, build, docker, helm, push-validation, benchmark-regression, status-check). benchmark-publish skipped (expected). ✅ **CHANGELOG.md** — Entry added under [Unreleased] → Fixed referencing #5622. ✅ **Milestone** — v3.6.0 assigned. ✅ **Commit footer** — ISSUES CLOSED: #5622. ✅ **auto_discovery** — Per-child discovery documented in spec examples. ⚠️ **Remaining blocker: Forgejo dependency tracking** The PR cannot be merged until issue #5622 lists PR #5658 as a dependency in Forgejo. The API endpoint POST /api/v1/repos/cleveragents/cleveragents-core/issues/5622/dependencies returns `IsErrRepoNotExist` despite the repository existing. This appears to be a server-side Forgejo configuration issue with the dependencies module. The PR code changes are complete, correct, and ready for merge pending this single administrative fix. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: task-implementor
freemo commented 2026-05-08 17:50:56 +00:00
Owner
Copy link

Label Update (Mandatory Compliance)

  • Added MoSCoW/Should have (was missing)
  • All other required labels already present: State/In Review, Priority/Medium, Type/Documentation

Status Note: PR still has merge conflicts that cannot be resolved server-side. The Needs Feedback label indicates the issue owner should provide clarification before conflict resolution and merge can proceed.

Milestone v3.6.0 is correctly assigned.

**Label Update (Mandatory Compliance)** - Added `MoSCoW/Should have` (was missing) - All other required labels already present: State/In Review, Priority/Medium, Type/Documentation **Status Note**: PR still has merge conflicts that cannot be resolved server-side. The Needs Feedback label indicates the issue owner should provide clarification before conflict resolution and merge can proceed. Milestone v3.6.0 is correctly assigned.
All checks were successful
CI / push-validation (pull_request) Successful in 28s
Details
CI / helm (pull_request) Successful in 35s
Details
CI / build (pull_request) Successful in 4m0s
Required
Details
CI / lint (pull_request) Successful in 4m4s
Required
Details
CI / typecheck (pull_request) Successful in 4m42s
Required
Details
CI / quality (pull_request) Successful in 4m49s
Required
Details
CI / security (pull_request) Successful in 5m17s
Required
Details
CI / e2e_tests (pull_request) Successful in 7m3s
Details
CI / integration_tests (pull_request) Successful in 10m46s
Required
Details
CI / unit_tests (pull_request) Successful in 12m37s
Required
Details
CI / docker (pull_request) Successful in 1m35s
Required
Details
CI / coverage (pull_request) Successful in 13m1s
Required
Details
CI / status-check (pull_request) Successful in 13s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 1h5m2s
Details
This pull request has changes conflicting with the target branch.
  • CHANGELOG.md
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin spec/resource-type-yaml-format-canonical-5622:spec/resource-type-yaml-format-canonical-5622
git switch spec/resource-type-yaml-format-canonical-5622
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.6.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!5658
No description provided.