feat(cli): wire project context CLI stubs to ACMS pipeline #534
No reviewers
Labels
No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
cleveragents/cleveragents-core!534
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/m5-context-cli-wiring"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Wire all four project context CLI commands (
inspect,simulate,set,show) to live ACMS pipeline services, replacing the previousNotImplementedErrorstubs with fully functional implementations backed byContextTierServiceand CRP models. Also fixes two bugs found during review:context inspectincorrectly reported global tier fragment counts instead of project-scoped counts, andcontext simulate --focussilently ignored the focus URIs.Closes #499
Changes
Source
src/cleveragents/cli/commands/project_context.py(+720/-11)context inspect: QueriesContextTierServicefor project-scoped tier metrics (hot/warm/cold fragment counts, hit/miss rates) and per-project fragments. Supports optional filtering by--strategy,--focus,--breadth, and--depth. Displays tier budget utilisation, per-actor visibility (strategist/executor/reviewer), and fragment details (first 20). All output formats supported (rich/json/yaml/plain/table).context simulate: Performs dry-run context assembly using CRP models (ContextRequest,ContextFragment,AssembledContext). Builds simulated fragments from tier data with budget enforcement. Configurable--budget(token limit override) and--strategy(repeatable hint). When--focusis provided, fragments are filtered by matchingresource_idagainst the focus URIs. Outputs fragment provenance, total tokens, budget usage percentage, strategy list, and a context hash.context set: Gains 12 new ACMS pipeline options:--hot-max-tokens,--warm-max-decisions,--cold-max-decisions,--summary-max-tokens,--temporal-scope,--auto-refresh/--no-auto-refresh,--summarize/--no-summarize,--strategy,--default-breadth,--default-depth,--skeleton-ratio,--query-limit. Persists ACMS config alongside the context policy via_write_policy()/_read_acms_config().context show: Displays ACMS pipeline configuration (tier budgets, strategies, temporal scope, auto-refresh, skeleton ratio) alongside existing context policy in all output formats._get_context_tier_service(),_read_acms_config(),_default_acms_config(),_write_policy()(extended withacms_configparameter),_tier_metrics_to_dict(),_fragment_to_dict(),_assembled_to_dict(),_simulate_context_assembly().src/cleveragents/application/services/context_tiers.py(+27)get_scoped_metrics(project_names)method toContextTierService. ReturnsTierMetricswith fragment counts (hot/warm/cold) filtered to the specified projects usingScopedBackendView, while keeping hit/miss counters as global service-level cache metrics. RaisesValueErrorifproject_namesis empty.src/cleveragents/shared/redaction.py(+2)hot_max_tokensandsummary_max_tokensto_FALSE_POSITIVE_KEYSto prevent legitimate ACMS config keys from being redacted as sensitive data.Bug Fixes
context inspectdisplayed global tier fragment counts across all projects instead of counts for the target project only. Fixed by callingget_scoped_metrics([project])instead ofget_metrics().context simulate --focusaccepted focus URIs and passed them to theContextRequestmodel but never applied them to filter the fragment list, making--focusa no-op. Fixed by adding a filtering step in_simulate_context_assembly()that retains only fragments whoseresource_idmatches a supplied focus URI.Tests
Behave BDD (unit-level)
features/context_cli_wiring.feature— 30 scenarios covering all ACMS set options (12 scenarios), show with ACMS config (2), inspect with tier data (6, including scoped metrics verification and error cases), and simulate with budget/strategy/focus/fragments (8, including focus URI filtering and error cases).features/steps/context_cli_wiring_steps.py— 646 lines of step definitions using an in-memory SQLite database and a realContextTierServiceinstance with mocked DI container.features/project_context_cli.feature— replacedNotImplementedErrorexpectations for inspect/simulate with wired success assertions (2 scenarios updated).features/steps/project_context_cli_steps.py— addedContextTierServiceto mock container, addedwidth=500, soft_wrap=Trueto Rich Console to prevent JSON parse failures from line-wrapping, added inspect/simulate success step definitions.features/m5_acms_smoke.feature— replacedNotImplementedErrorexpectations with wired ACMS success assertions (2 scenarios updated).features/steps/m5_acms_smoke_steps.py— rewired inspect/simulate steps to use mocked DI container with realContextTierService, added success assertion steps.Robot Framework (integration)
robot/project_context_cli.robot— 5 test cases: set-show round-trip, inspect-wired, simulate-wired, set-acms, show-acms (replaces 3 previous tests that tested stubs).robot/helper_project_context_cli.py— added_make_mock_container(),_run_cli_func()helpers with mocked DI; addedtest_context_inspect_wired(),test_context_simulate_wired(),test_context_set_acms_options(),test_context_show_acms_config()(replaces stub tests).Documentation
docs/reference/project_context_cli.md(+169/-12): Full reference documentation for all four commands. Added ACMS pipeline options table forset, output descriptions forshow/inspect/simulate, usage examples for ACMS configuration, and replaced stub notices with complete command references.CHANGELOG.md: Three entries under Unreleased — one for the feature wiring, one for the scoped inspect metrics fix, one for the focus URI filtering fix. All reference #499.Verification
ruff check(lint)ruff format --check(format)pyright(typecheck)context_cli_wiring.featureproject_context_cli.featurem5_acms_smoke.featureproject_context.pyReview — PR #534
feat(cli): wire project context CLI stubs to ACMS pipelineVerdict: APPROVED with comments
Nice end-to-end wiring of
project contextcommands with comprehensive Behave + Robot coverage and solid reference docs. The ACMS config persistence via shared policy JSON is consistent with existing patterns, and the new redaction allowlist keys close the false-positive leak for config output.No P0 or P1 findings.
P2:should-fix
Missing required PR label — Per
CONTRIBUTING.md, every PR must carry exactly oneType/label. This PR has no labels. The linked issue #499 isType/Feature.Missing PR milestone — Per
CONTRIBUTING.md, the PR milestone must match the linked issue. This PR has no milestone set. Issue #499 is assigned to milestonev3.4.0.context inspecttier metrics are global, not project-scoped — The command is per-project butContextTierService.get_metrics()is global. In multi-project setups, the "Tier Metrics" panel and JSONtier_metricswill reflect all fragments, not just the target project. Please either compute metrics fromget_scoped_view([project])or add a scoped metrics helper soinspectreflects the project-specific tier state. (Seesrc/cleveragents/cli/commands/project_context.py.)context simulate --focusis ignored in the simulated assembly —focus_urisare only passed intoContextRequest, but the simulated fragment selection usesproject_fragmentswithout filtering. This makes--focusa no-op for the CLI output. Please filter the selectedTieredFragmentlist byresource_id/fragment ID when--focusis provided so the simulation respects the option. (See_simulate_context_assemblyinsrc/cleveragents/cli/commands/project_context.py.)P2 items should be addressed in a follow-up within 3 business days.
cf514957a770cd342e97New commits pushed, approval review dismissed automatically according to repository settings
Review — PR #534 (updated)
Verdict: APPROVED
Verified all prior P2 findings are resolved:
Type/Featurelabel and milestonev3.4.0.context inspectnow uses project-scoped tier metrics viaget_scoped_metrics([project]).context simulate --focusnow filters fragments by focus URIs in_simulate_context_assembly().ContextTierService.get_scoped_metrics()added to support scoped counts (global hit/miss retained as intended).No P0/P1 findings. No remaining P2/P3 items.
70cd342e97ff42d59d6dNew commits pushed, approval review dismissed automatically according to repository settings