feat(acp): wire ACP local facade handlers to live services #526

Merged
freemo merged 1 commits from feature/m6-acp-facade-wiring into master 2026-03-03 03:50:36 +00:00
Owner

Summary

  • Wire all AcpLocalFacade operation handlers to live application services via constructor-injected service dependencies
  • Add domain-to-ACP error code mapping (NOT_FOUND, VALIDATION_ERROR, INVALID_STATE, PLAN_ERROR, etc.) via map_domain_error()
  • context.get returns stub pending ACMS ContextAssemblyPipeline completion

Wired Operations

Operation Service
session.create / session.close SessionService
plan.create / execute / status / diff / apply PlanLifecycleService
registry.list_tools ToolRegistry
registry.list_resources ResourceRegistryService
event.subscribe AcpEventQueue
context.get Stub (ACMS pipeline pending)

Tests

  • Behave: 21 scenarios in features/acp_facade_wiring.feature
  • Robot: 9 integration tests in robot/acp_facade_wiring.robot
  • Coverage >=97% verified

Quality Gates

  • nox -s lint — pass
  • nox -s typecheck — pass (0 errors)
  • nox -s unit_tests — pass (pre-existing failures only)
  • nox -s integration_tests — pass (pre-existing failures only)
  • nox -s coverage_report — pass (>=97%)

Closes #501

## Summary - Wire all `AcpLocalFacade` operation handlers to live application services via constructor-injected service dependencies - Add domain-to-ACP error code mapping (`NOT_FOUND`, `VALIDATION_ERROR`, `INVALID_STATE`, `PLAN_ERROR`, etc.) via `map_domain_error()` - `context.get` returns stub pending ACMS `ContextAssemblyPipeline` completion ## Wired Operations | Operation | Service | |-----------|--------| | `session.create` / `session.close` | `SessionService` | | `plan.create` / `execute` / `status` / `diff` / `apply` | `PlanLifecycleService` | | `registry.list_tools` | `ToolRegistry` | | `registry.list_resources` | `ResourceRegistryService` | | `event.subscribe` | `AcpEventQueue` | | `context.get` | Stub (ACMS pipeline pending) | ## Tests - **Behave:** 21 scenarios in `features/acp_facade_wiring.feature` - **Robot:** 9 integration tests in `robot/acp_facade_wiring.robot` - Coverage >=97% verified ## Quality Gates - [x] `nox -s lint` — pass - [x] `nox -s typecheck` — pass (0 errors) - [x] `nox -s unit_tests` — pass (pre-existing failures only) - [x] `nox -s integration_tests` — pass (pre-existing failures only) - [x] `nox -s coverage_report` — pass (>=97%) Closes #501
freemo force-pushed feature/m6-acp-facade-wiring from e9b2f85116 to 4b9df961f0 2026-03-03 03:46:13 +00:00 Compare
freemo scheduled this pull request to auto merge when all checks succeed 2026-03-03 03:46:30 +00:00
freemo merged commit 4b9df961f0 into master 2026-03-03 03:50:36 +00:00
freemo deleted branch feature/m6-acp-facade-wiring 2026-03-03 03:50:36 +00:00
freemo added the
Type
Feature
label 2026-03-03 03:58:32 +00:00
freemo added this to the v3.5.0 milestone 2026-03-03 04:24:00 +00:00
freemo added the
State
Completed
label 2026-03-04 00:41:36 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#526