cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

perf(tests): optimize medium-slow BDD features (10-100s tier) #489

Closed
brent.edwards wants to merge 1 commit from perf/optimize-medium-features into perf/optimize-slowest-features
pull from: perf/optimize-medium-features
merge into: cleveragents:perf/optimize-slowest-features
Conversation 2 Commits 1 Files changed 13 +208 -98
brent.edwards commented 2026-03-01 07:33:29 +00:00
Member
Copy link

Summary

Optimize the 20 medium-slow BDD features (10-100s range) to all run under 5s behave-internal time. Total tier runtime reduced from 565s to 21s (96% reduction).

Changes

Global sleep cap (features/environment.py)

  • Cap time.sleep and asyncio.sleep at 10ms in before_all to eliminate retry/backoff waits
  • Save originals as time._original_sleep / asyncio._original_sleep for tests needing real delays

Template DB patch enhancements (features/environment.py)

  • Add "db." to _SCENARIO_DB_PREFIXES for .cleveragents/db.sqlite paths
  • Check db_path.stat().st_size > 0 so 0-byte auto-created SQLite files get template copy

subprocess.run → CliRunner

  • module_coverage_steps.py, main_coverage_complete_steps.py, coverage_extras_steps.py
  • Eliminates ~6s Python cold-start overhead per CLI invocation

In-memory SQLite by default

  • plan_persistence_steps.py: in-memory default, file-based via explicit Given step
  • action_persistence_steps.py: switched to in-memory SQLite
  • plan_service_steps.py: Base.metadata.create_all instead of MigrationRunner.run_migrations

Real-sleep escapes for timing-sensitive tests

  • retry_patterns_steps.py: CircuitBreaker uses time._original_sleep
  • security_async_steps.py: timeout test uses asyncio._original_sleep
  • skill_refresh_steps.py: debounce wait uses time._original_sleep
  • validation_pipeline_steps.py: timeout executor uses time._original_sleep

Per-feature results

Feature Before After
plan_persistence 65.3s 2.1s
repositories_error_handling_coverage 57.4s 1.3s
auto_debug_integration 54.2s 1.6s
action_persistence 51.8s 0.3s
repository_coverage_boost 44.5s 1.1s
legacy_plan_removal 42.1s 0.02s
context_service_uncovered_lines 36.7s 0.3s
retry_patterns 30.7s 0.7s
module_coverage 25.4s 0.3s
coverage_maximum 21.8s 0.1s
garbage_collection 21.0s 1.2s
legacy_migrator_coverage 16.8s 3.4s
plan_service_uncovered_lines 14.9s 0.9s
plan_service_coverage 13.8s 0.9s
repositories_uncovered_lines 12.8s 0.6s
project_service_coverage 12.2s 3.4s
main_coverage_complete 11.8s 0.05s
project_cli_commands 11.4s 1.2s
resource_registry_tables 10.4s 1.4s
coverage_boost 10.1s 0.4s

Verification

Full 342-feature suite passes (327 pass, 4 fail + 4 error are pre-existing stderr not separately captured issues in click.testing.CliRunner, verified on clean branch).

Part of #478. Closes #480.

## Summary Optimize the 20 medium-slow BDD features (10-100s range) to all run under 5s behave-internal time. Total tier runtime reduced from 565s to 21s (96% reduction). ## Changes ### Global sleep cap (`features/environment.py`) - Cap `time.sleep` and `asyncio.sleep` at 10ms in `before_all` to eliminate retry/backoff waits - Save originals as `time._original_sleep` / `asyncio._original_sleep` for tests needing real delays ### Template DB patch enhancements (`features/environment.py`) - Add `"db."` to `_SCENARIO_DB_PREFIXES` for `.cleveragents/db.sqlite` paths - Check `db_path.stat().st_size > 0` so 0-byte auto-created SQLite files get template copy ### subprocess.run → CliRunner - `module_coverage_steps.py`, `main_coverage_complete_steps.py`, `coverage_extras_steps.py` - Eliminates ~6s Python cold-start overhead per CLI invocation ### In-memory SQLite by default - `plan_persistence_steps.py`: in-memory default, file-based via explicit Given step - `action_persistence_steps.py`: switched to in-memory SQLite - `plan_service_steps.py`: `Base.metadata.create_all` instead of `MigrationRunner.run_migrations` ### Real-sleep escapes for timing-sensitive tests - `retry_patterns_steps.py`: CircuitBreaker uses `time._original_sleep` - `security_async_steps.py`: timeout test uses `asyncio._original_sleep` - `skill_refresh_steps.py`: debounce wait uses `time._original_sleep` - `validation_pipeline_steps.py`: timeout executor uses `time._original_sleep` ## Per-feature results | Feature | Before | After | |---------|--------|-------| | plan_persistence | 65.3s | 2.1s | | repositories_error_handling_coverage | 57.4s | 1.3s | | auto_debug_integration | 54.2s | 1.6s | | action_persistence | 51.8s | 0.3s | | repository_coverage_boost | 44.5s | 1.1s | | legacy_plan_removal | 42.1s | 0.02s | | context_service_uncovered_lines | 36.7s | 0.3s | | retry_patterns | 30.7s | 0.7s | | module_coverage | 25.4s | 0.3s | | coverage_maximum | 21.8s | 0.1s | | garbage_collection | 21.0s | 1.2s | | legacy_migrator_coverage | 16.8s | 3.4s | | plan_service_uncovered_lines | 14.9s | 0.9s | | plan_service_coverage | 13.8s | 0.9s | | repositories_uncovered_lines | 12.8s | 0.6s | | project_service_coverage | 12.2s | 3.4s | | main_coverage_complete | 11.8s | 0.05s | | project_cli_commands | 11.4s | 1.2s | | resource_registry_tables | 10.4s | 1.4s | | coverage_boost | 10.1s | 0.4s | ## Verification Full 342-feature suite passes (327 pass, 4 fail + 4 error are pre-existing `stderr not separately captured` issues in click.testing.CliRunner, verified on clean branch). Part of #478. Closes #480.
Cap time.sleep and asyncio.sleep globally at 10ms in before_all to
eliminate retry/backoff waits (tenacity wait_fixed, retry_auto_debug
exponential backoff). Save originals as time._original_sleep and
asyncio._original_sleep for tests that need real wall-clock delays
(CircuitBreaker recovery, debounce timers, validation timeouts).

Enhance template-DB patch: add "db." prefix to _SCENARIO_DB_PREFIXES
and check db_path.stat().st_size > 0 so 0-byte auto-created SQLite
files receive the template copy instead of falling through to real
migrations.

Replace subprocess.run CLI invocations with typer.testing.CliRunner
in module_coverage, main_coverage_complete, and coverage_extras step
files, eliminating ~6s Python cold-start overhead per call.

Switch plan_persistence and action_persistence to in-memory SQLite by
default; only cross-restart scenarios use file-based via an explicit
Given step.

Replace MigrationRunner.run_migrations with Base.metadata.create_all
in plan_service_steps for freshly created in-memory engines.

Total tier runtime: 565s -> 21s (96% reduction), 20 features all
under 5s behave-internal time.

Part of #478. Closes #480.
freemo requested changes 2026-03-01 16:09:06 +00:00
freemo left a comment
Copy link

Code Review: PR #489 — perf(tests): optimize medium-slow BDD features (10-100s tier)

What I Fixed

  • Labels: Added Type/Task label (was missing entirely).

Code Quality Assessment

The most aggressive optimization in the chain, but carefully implemented. Key observations:

  1. Global sleep cap (_install_fast_sleep_patch) — Monkey-patching time.sleep and asyncio.sleep globally at 10ms is inherently risky but handled well:

    • Originals saved as time._original_sleep / asyncio._original_sleep
    • Guard against double-patching (if not callable(getattr(...)))
    • Well-documented rationale in the docstring
    • The _real_sleep pattern used consistently in timing-sensitive tests

  2. _original_sleep usage in test steps — Correctly applied in:

    • retry_patterns_steps.py: CircuitBreaker recovery timeout
    • security_async_steps.py: MockAsyncResource close delay
    • skill_refresh_steps.py: Debounce wait
    • validation_pipeline_steps.py: Timeout executor
      Each has a clear comment explaining why the real sleep is needed.

  3. Template DB enhancements — Adding "db." prefix and st_size > 0 check handles edge cases where SQLite auto-creates empty files.

  4. subprocess.run → CliRunner — Clean migrations in module_coverage_steps.py, main_coverage_complete_steps.py, coverage_extras_steps.py. The namespace wrapper in module_coverage_steps.py (type("R", (), {...})()) is a pragmatic solution to preserve the downstream step interface.

  5. In-memory SQLite defaults — plan_persistence_steps.py and action_persistence_steps.py changes are well-structured with the file_based parameter for cross-restart scenarios. The .feature file properly adds explicit Given steps for file-based scenarios.

  6. Base.metadata.create_all instead of MigrationRunner.run_migrations — Correct optimization in plan_service_steps.py.

  7. Single commit — This PR has exactly 1 commit.

Minor Code Concern

  • Leftover debug comment in environment.py: # DEBUG: trace which calls reach the patch at line ~199. This should be removed or reworded to a regular comment.

Process Violations Requiring Changes

  1. Missing ISSUES CLOSED: footer in commit message — Uses Closes #480. in the body; CONTRIBUTING.md §5.5 requires:

    ISSUES CLOSED: #480

  2. Missing CHANGELOG.md update — Per CONTRIBUTING.md §8.3.

  3. Missing milestone — Per CONTRIBUTING.md §8.2.

  4. Missing dependency links — Per CONTRIBUTING.md §7.3-7.4, this PR should "block" #480, and issue #480 should "depend on" #489.

Verdict

REQUEST CHANGES — Code quality is strong with one minor cleanup needed (debug comment). Process requirements must be addressed.

## Code Review: PR #489 — perf(tests): optimize medium-slow BDD features (10-100s tier) ### What I Fixed - **Labels**: Added `Type/Task` label (was missing entirely). ### Code Quality Assessment The most aggressive optimization in the chain, but carefully implemented. Key observations: 1. **Global sleep cap (`_install_fast_sleep_patch`)** — Monkey-patching `time.sleep` and `asyncio.sleep` globally at 10ms is inherently risky but handled well: - Originals saved as `time._original_sleep` / `asyncio._original_sleep` - Guard against double-patching (`if not callable(getattr(...))`) - Well-documented rationale in the docstring - The `_real_sleep` pattern used consistently in timing-sensitive tests 2. **`_original_sleep` usage in test steps** — Correctly applied in: - `retry_patterns_steps.py`: CircuitBreaker recovery timeout - `security_async_steps.py`: MockAsyncResource close delay - `skill_refresh_steps.py`: Debounce wait - `validation_pipeline_steps.py`: Timeout executor Each has a clear comment explaining why the real sleep is needed. 3. **Template DB enhancements** — Adding `"db."` prefix and `st_size > 0` check handles edge cases where SQLite auto-creates empty files. 4. **subprocess.run → CliRunner** — Clean migrations in `module_coverage_steps.py`, `main_coverage_complete_steps.py`, `coverage_extras_steps.py`. The namespace wrapper in `module_coverage_steps.py` (`type("R", (), {...})()`) is a pragmatic solution to preserve the downstream step interface. 5. **In-memory SQLite defaults** — `plan_persistence_steps.py` and `action_persistence_steps.py` changes are well-structured with the `file_based` parameter for cross-restart scenarios. The `.feature` file properly adds explicit Given steps for file-based scenarios. 6. **`Base.metadata.create_all` instead of `MigrationRunner.run_migrations`** — Correct optimization in `plan_service_steps.py`. 7. **Single commit** — This PR has exactly 1 commit. ### Minor Code Concern - **Leftover debug comment** in `environment.py`: `# DEBUG: trace which calls reach the patch` at line ~199. This should be removed or reworded to a regular comment. ### Process Violations Requiring Changes 1. **Missing `ISSUES CLOSED:` footer in commit message** — Uses `Closes #480.` in the body; CONTRIBUTING.md §5.5 requires: ``` ISSUES CLOSED: #480 ``` 2. **Missing CHANGELOG.md update** — Per CONTRIBUTING.md §8.3. 3. **Missing milestone** — Per CONTRIBUTING.md §8.2. 4. **Missing dependency links** — Per CONTRIBUTING.md §7.3-7.4, this PR should "block" #480, and issue #480 should "depend on" #489. ### Verdict **REQUEST CHANGES** — Code quality is strong with one minor cleanup needed (debug comment). Process requirements must be addressed.
freemo commented 2026-03-02 01:45:26 +00:00
Owner
Copy link

Superseded by #493 — this PR has been consolidated with all code review fixes applied into a single clean branch (perf/bdd-test-optimization) with one commit per issue and no merge commits.

Superseded by #493 — this PR has been consolidated with all code review fixes applied into a single clean branch (`perf/bdd-test-optimization`) with one commit per issue and no merge commits.
freemo closed this pull request 2026-03-02 01:45:33 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
freemo
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!489
No description provided.