cleveragents/cleveragents-core

Fork 3

UAT: `SubplanService.spawn_subplans` does not propagate parent plan invariants to child plans #4827

New issue

Open

opened 2026-04-08 19:53:21 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 19:53:21 +00:00

Owner

Bug Report

Feature Area: Invariants — propagation to child plans

What Was Tested

Code-level analysis of src/cleveragents/application/services/subplan_service.py against the specification's child plan invariant inheritance requirement.

Expected Behavior (from spec)

The specification (line 19751) states:

Child plan inheritance: When a top-level plan spawns child plans, the parent's effective invariant view (already reconciled) is passed down to each child plan. Child plans do not re-run reconciliation — they inherit the parent's resolved view.

When SubplanService.spawn_subplans creates child Plan objects, each child should receive the parent plan's invariants list (the already-reconciled effective invariant view).

Actual Behavior

SubplanService.spawn_subplans (lines 259–283 of subplan_service.py) creates child Plan objects without copying the parent's invariants:

child_plan: Plan = Plan(
    identity=PlanIdentity(
        plan_id=subplan_id,
        parent_plan_id=parent_id,
        root_plan_id=root_id,
    ),
    namespaced_name=NamespacedName(...),
    description=entry.description or f"Child plan for {entry.action_name}",
    definition_of_done=parent_plan.definition_of_done,
    action_name=entry.action_name,
    phase=PlanPhase.STRATEGIZE,
    processing_state=ProcessingState.QUEUED,
    strategy_actor=parent_plan.strategy_actor,
    execution_actor=parent_plan.execution_actor,
    project_links=list(parent_plan.project_links),
    timestamps=PlanTimestamps(),
    created_by=parent_plan.created_by,
    reusable=parent_plan.reusable,
    read_only=parent_plan.read_only,
    # ← NO invariants= field! Parent invariants are NOT propagated
)

The child plan is created with invariants=[] (the default), meaning all invariants from the parent's reconciled view are silently dropped.

Code Location

src/cleveragents/application/services/subplan_service.py lines 259–283

Steps to Reproduce

Create a plan with invariants (e.g., agents plan use local/my-action local/my-project --invariant "Never modify production DB")
During Strategize, the plan spawns a child plan via SubplanService.spawn_subplans
Inspect the child plan's invariants field — it will be empty []
The child plan does not enforce the parent's invariants during its own Strategize phase

Impact

Child plans do not inherit the parent's reconciled invariant view. This means:

Safety constraints defined at the parent level are not enforced in child plans
The spec's guarantee that "child plans do not re-run reconciliation — they inherit the parent's resolved view" is violated
Non-overridable global invariants that were enforced at the parent level are not carried forward to child plans

Suggested Fix

Add invariants=list(parent_plan.invariants) to the child Plan constructor call in SubplanService.spawn_subplans:

child_plan: Plan = Plan(
    ...
    invariants=list(parent_plan.invariants),  # Propagate parent's reconciled invariants
    invariant_actor=parent_plan.invariant_actor,  # Also propagate the actor reference
    ...
)

Note: The child plan should also inherit invariant_actor from the parent so that if reconciliation is ever triggered on the child, it uses the same actor.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Invariants — propagation to child plans ### What Was Tested Code-level analysis of `src/cleveragents/application/services/subplan_service.py` against the specification's child plan invariant inheritance requirement. ### Expected Behavior (from spec) The specification (line 19751) states: > **Child plan inheritance**: When a top-level plan spawns child plans, the parent's effective invariant view (already reconciled) is passed down to each child plan. Child plans do not re-run reconciliation — they inherit the parent's resolved view. When `SubplanService.spawn_subplans` creates child `Plan` objects, each child should receive the parent plan's `invariants` list (the already-reconciled effective invariant view). ### Actual Behavior `SubplanService.spawn_subplans` (lines 259–283 of `subplan_service.py`) creates child `Plan` objects without copying the parent's invariants: ```python child_plan: Plan = Plan( identity=PlanIdentity( plan_id=subplan_id, parent_plan_id=parent_id, root_plan_id=root_id, ), namespaced_name=NamespacedName(...), description=entry.description or f"Child plan for {entry.action_name}", definition_of_done=parent_plan.definition_of_done, action_name=entry.action_name, phase=PlanPhase.STRATEGIZE, processing_state=ProcessingState.QUEUED, strategy_actor=parent_plan.strategy_actor, execution_actor=parent_plan.execution_actor, project_links=list(parent_plan.project_links), timestamps=PlanTimestamps(), created_by=parent_plan.created_by, reusable=parent_plan.reusable, read_only=parent_plan.read_only, # ← NO invariants= field! Parent invariants are NOT propagated ) ``` The child plan is created with `invariants=[]` (the default), meaning all invariants from the parent's reconciled view are silently dropped. ### Code Location - `src/cleveragents/application/services/subplan_service.py` lines 259–283 ### Steps to Reproduce 1. Create a plan with invariants (e.g., `agents plan use local/my-action local/my-project --invariant "Never modify production DB"`) 2. During Strategize, the plan spawns a child plan via `SubplanService.spawn_subplans` 3. Inspect the child plan's `invariants` field — it will be empty `[]` 4. The child plan does not enforce the parent's invariants during its own Strategize phase ### Impact Child plans do not inherit the parent's reconciled invariant view. This means: - Safety constraints defined at the parent level are not enforced in child plans - The spec's guarantee that "child plans do not re-run reconciliation — they inherit the parent's resolved view" is violated - Non-overridable global invariants that were enforced at the parent level are not carried forward to child plans ### Suggested Fix Add `invariants=list(parent_plan.invariants)` to the child `Plan` constructor call in `SubplanService.spawn_subplans`: ```python child_plan: Plan = Plan( ... invariants=list(parent_plan.invariants), # Propagate parent's reconciled invariants invariant_actor=parent_plan.invariant_actor, # Also propagate the actor reference ... ) ``` Note: The child plan should also inherit `invariant_actor` from the parent so that if reconciliation is ever triggered on the child, it uses the same actor. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-08 19:56:15 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:12:39 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:16:04 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 referenced this issue

2026-04-08 20:22:25 +00:00

[Automated] CleverAgents Build Session - 2026-04-08 #4799

HAL9000 added the

labels

2026-04-08 22:59:49 +00:00

HAL9000 commented

2026-04-09 03:02:38 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — spec compliance bug identified by UAT testing
Story Points: 3 (M) — targeted fix to align implementation with spec
MoSCoW: Must Have — spec compliance is required for correct system behavior

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — spec compliance bug identified by UAT testing - **Story Points**: 3 (M) — targeted fix to align implementation with spec - **MoSCoW**: Must Have — spec compliance is required for correct system behavior --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 added

and removed

labels

2026-04-09 03:02:45 +00:00

HAL9000 added this to the v3.5.0 milestone