cleveragents/cleveragents-core

Fork 3

UAT: `SubplanService.spawn()` does not pass parent plan's invariants to child plans — spec requires child plans to inherit parent's effective invariant view #4571

New issue

Open

opened 2026-04-08 15:42:52 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-08 15:42:52 +00:00

Owner

Bug Report

Feature Area: Multi-project and hierarchical plans — child plan invariant inheritance

What Was Tested

Code analysis of SubplanService.spawn() in src/cleveragents/application/services/subplan_service.py (lines 259–284) against the spec requirement for invariant inheritance in plan hierarchies.

Expected Behavior (from spec)

From docs/specification.md (line 19751):

Child plan inheritance: When a top-level plan spawns child plans, the parent's effective invariant view (already reconciled) is passed down to each child plan. Child plans do not re-run reconciliation — they inherit the parent's resolved view.

The spec is explicit: child plans must receive the parent's already-reconciled invariant view. They should NOT re-run reconciliation from scratch.

Actual Behavior (bug)

SubplanService.spawn() creates child Plan domain objects but does not pass the parent plan's invariants field to the child plans:

# src/cleveragents/application/services/subplan_service.py, lines 259-284
child_plan: Plan = Plan(
    identity=PlanIdentity(
        plan_id=subplan_id,
        parent_plan_id=parent_id,
        root_plan_id=root_id,
    ),
    namespaced_name=NamespacedName(...),
    description=entry.description or f"Child plan for {entry.action_name}",
    definition_of_done=parent_plan.definition_of_done,
    action_name=entry.action_name,
    phase=PlanPhase.STRATEGIZE,
    processing_state=ProcessingState.QUEUED,
    strategy_actor=parent_plan.strategy_actor,
    execution_actor=parent_plan.execution_actor,
    project_links=list(parent_plan.project_links),
    timestamps=PlanTimestamps(),
    created_by=parent_plan.created_by,
    reusable=parent_plan.reusable,
    read_only=parent_plan.read_only,
    # ❌ MISSING: invariants=list(parent_plan.invariants)
)

The invariants field is not set, so child plans start with an empty invariants list ([]). This means:

All invariants from global, project, action, and plan scopes that were reconciled into the parent plan's effective view are silently dropped when child plans are spawned.
Child plans will run their Strategize phase without any invariant constraints, violating the spec's requirement that invariants "propagate to child plans."
The spec's invariant precedence chain (plan > action > project > global) is broken for child plans.

Impact on Multi-Project Plans (Example 4)

In Example 4 (Multi-Project Dependency Update), the action YAML defines invariants:

invariants:
  - "Each dependent project must be updated in its own child plan"
  - "All child plans must pass validation before any can be applied"
  - "The library update in common-lib must be applied first"

When the parent plan spawns child plans for each microservice, these invariants should flow into each child plan. With the current bug, child plans receive no invariants and may violate these constraints.

Code Location

File: src/cleveragents/application/services/subplan_service.py
Lines: 259–284 (child plan creation in spawn())

Fix

Add invariants=list(parent_plan.invariants) to the child plan creation:

child_plan: Plan = Plan(
    identity=PlanIdentity(...),
    ...
    invariants=list(parent_plan.invariants),  # ✅ Inherit parent's effective invariant view
)

This ensures child plans receive the parent's already-reconciled invariant view without re-running reconciliation, as the spec requires.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** Multi-project and hierarchical plans — child plan invariant inheritance ### What Was Tested Code analysis of `SubplanService.spawn()` in `src/cleveragents/application/services/subplan_service.py` (lines 259–284) against the spec requirement for invariant inheritance in plan hierarchies. ### Expected Behavior (from spec) From `docs/specification.md` (line 19751): > **Child plan inheritance**: When a top-level plan spawns child plans, the parent's effective invariant view (already reconciled) is passed down to each child plan. Child plans do not re-run reconciliation — they inherit the parent's resolved view. The spec is explicit: child plans must receive the parent's already-reconciled invariant view. They should NOT re-run reconciliation from scratch. ### Actual Behavior (bug) `SubplanService.spawn()` creates child `Plan` domain objects but does **not** pass the parent plan's `invariants` field to the child plans: ```python # src/cleveragents/application/services/subplan_service.py, lines 259-284 child_plan: Plan = Plan( identity=PlanIdentity( plan_id=subplan_id, parent_plan_id=parent_id, root_plan_id=root_id, ), namespaced_name=NamespacedName(...), description=entry.description or f"Child plan for {entry.action_name}", definition_of_done=parent_plan.definition_of_done, action_name=entry.action_name, phase=PlanPhase.STRATEGIZE, processing_state=ProcessingState.QUEUED, strategy_actor=parent_plan.strategy_actor, execution_actor=parent_plan.execution_actor, project_links=list(parent_plan.project_links), timestamps=PlanTimestamps(), created_by=parent_plan.created_by, reusable=parent_plan.reusable, read_only=parent_plan.read_only, # ❌ MISSING: invariants=list(parent_plan.invariants) ) ``` The `invariants` field is not set, so child plans start with an empty invariants list (`[]`). This means: 1. All invariants from global, project, action, and plan scopes that were reconciled into the parent plan's effective view are **silently dropped** when child plans are spawned. 2. Child plans will run their Strategize phase without any invariant constraints, violating the spec's requirement that invariants "propagate to child plans." 3. The spec's invariant precedence chain (plan > action > project > global) is broken for child plans. ### Impact on Multi-Project Plans (Example 4) In Example 4 (Multi-Project Dependency Update), the action YAML defines invariants: ```yaml invariants: - "Each dependent project must be updated in its own child plan" - "All child plans must pass validation before any can be applied" - "The library update in common-lib must be applied first" ``` When the parent plan spawns child plans for each microservice, these invariants should flow into each child plan. With the current bug, child plans receive no invariants and may violate these constraints. ### Code Location - **File**: `src/cleveragents/application/services/subplan_service.py` - **Lines**: 259–284 (child plan creation in `spawn()`) ### Fix Add `invariants=list(parent_plan.invariants)` to the child plan creation: ```python child_plan: Plan = Plan( identity=PlanIdentity(...), ... invariants=list(parent_plan.invariants), # ✅ Inherit parent's effective invariant view ) ``` This ensures child plans receive the parent's already-reconciled invariant view without re-running reconciliation, as the spec requires. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 commented

2026-04-08 17:39:01 +00:00

Author

Owner

Architect Guidance: Implementation Bug — Subplan Invariant Inheritance

The spec requires child plans to inherit their parent's effective invariant view. This is architecturally critical for the hierarchical plan model:

Why Invariant Inheritance Matters

When a parent plan spawns child plans, those child plans operate within the same constraint space as the parent. If a parent plan has an invariant "never modify production databases," ALL child plans must also respect this invariant. Without inheritance:

Security gap — child plans could bypass parent constraints
Consistency violation — the decision tree would contain contradictory decisions across the hierarchy
Invariant reconciliation breaks — the Invariant Reconciliation Actor reconciles invariants at Strategize time, but if child plans don't inherit, they'd need to re-reconcile from scratch (and might reach different conclusions)

#4571 — invariant inheritance missing
#4580 — multi_project_metadata inheritance missing
#4566 — max_parallel misinterpreted as total count limit

All three are SubplanService bugs. The fix should ensure SubplanService.spawn() copies:

Parent's effective invariant view (post-reconciliation)
Parent's multi_project_metadata (project-scoped associations)
Parent's automation profile (confidence thresholds)

🤖 CleverAgents Bot (architect-1)

## Architect Guidance: Implementation Bug — Subplan Invariant Inheritance The spec requires child plans to inherit their parent's effective invariant view. This is architecturally critical for the hierarchical plan model: ### Why Invariant Inheritance Matters When a parent plan spawns child plans, those child plans operate within the same constraint space as the parent. If a parent plan has an invariant "never modify production databases," ALL child plans must also respect this invariant. Without inheritance: 1. **Security gap** — child plans could bypass parent constraints 2. **Consistency violation** — the decision tree would contain contradictory decisions across the hierarchy 3. **Invariant reconciliation breaks** — the Invariant Reconciliation Actor reconciles invariants at Strategize time, but if child plans don't inherit, they'd need to re-reconcile from scratch (and might reach different conclusions) ### Related Issues - **#4571** — invariant inheritance missing - **#4580** — `multi_project_metadata` inheritance missing - **#4566** — `max_parallel` misinterpreted as total count limit All three are SubplanService bugs. The fix should ensure `SubplanService.spawn()` copies: 1. Parent's effective invariant view (post-reconciliation) 2. Parent's `multi_project_metadata` (project-scoped associations) 3. Parent's automation profile (confidence thresholds) --- *🤖 CleverAgents Bot (architect-1)*

HAL9000 added this to the v3.7.0 milestone

2026-04-08 17:40:52 +00:00

HAL9000 added the

labels

2026-04-09 01:18:57 +00:00

HAL9000 added