fix(unit-test): tdd_automation_profile_session_leak — 8 scenario(s) failing #4274

New issue

Closed

opened 2026-04-07 16:25:49 +00:00 by freemo · 1 comment

freemo commented

2026-04-07 16:25:49 +00:00

Owner

Failing Scenarios in `features/tdd_automation_profile_session_leak.feature`

Count: 8

L19: upsert closes session in auto_commit mode on success
L24: delete closes session in auto_commit mode on success
L30: upsert closes session in auto_commit mode on database error
L35: delete closes session in auto_commit mode on database error
L40: get_by_name closes session in auto_commit mode on success
L45: list_all closes session in auto_commit mode on success
L50: get_by_name closes session in auto_commit mode on database error
L55: list_all closes session in auto_commit mode on database error

Context

Tagged with @tdd_expected_fail to allow CI to pass. Fix the underlying issues and remove the tags.

Acceptance Criteria

All listed scenarios pass
Remove tdd tags once fixed

## Failing Scenarios in `features/tdd_automation_profile_session_leak.feature` **Count:** 8 - L19: upsert closes session in auto_commit mode on success - L24: delete closes session in auto_commit mode on success - L30: upsert closes session in auto_commit mode on database error - L35: delete closes session in auto_commit mode on database error - L40: get_by_name closes session in auto_commit mode on success - L45: list_all closes session in auto_commit mode on success - L50: get_by_name closes session in auto_commit mode on database error - L55: list_all closes session in auto_commit mode on database error ## Context Tagged with `@tdd_expected_fail` to allow CI to pass. Fix the underlying issues and remove the tags. ## Acceptance Criteria - [ ] All listed scenarios pass - [ ] Remove tdd tags once fixed

freemo closed this issue

2026-04-08 06:04:07 +00:00

freemo referenced this issue from a commit

2026-04-08 06:14:03 +00:00

fix(tests): apply TDD expected-fail tags to all failing scenarios

freemo commented

2026-04-08 07:15:43 +00:00

Author

Owner

⚠️ CRITICAL: Test Scenarios Currently Skipped

Status: The 8 test scenarios for this issue have been marked with @skip to prevent CI failures in PR #4175.

Test Location: features/tdd_automation_profile_session_leak.feature (lines 20, 26, 33, 39, 45, 51, 57, 63)

🚨 MANDATORY STEP: When implementing this fix, you MUST remove the @skip tag from ALL test scenario tags to re-enable testing.

Complete Implementation Checklist:

✅ Implement the AutomationProfileRepository session leak fix described in this issue
✅ Verify your implementation works as expected
✅ Remove the @skip tag from ALL 8 test scenarios in features/tdd_automation_profile_session_leak.feature
✅ Run the specific tests to confirm they pass: pytest features/tdd_automation_profile_session_leak.feature
✅ Run full test suite to ensure no regressions
✅ Submit PR with both the implementation AND skip tag removal

⚡ WARNING: If you forget to remove the @skip tags, the tests will remain permanently disabled even though the functionality is implemented, and the issue will appear "complete" but the test coverage will be lost.

Skip tags added as part of PR #4175 CI restoration efforts

## ⚠️ CRITICAL: Test Scenarios Currently Skipped **Status**: The 8 test scenarios for this issue have been marked with `@skip` to prevent CI failures in PR #4175. **Test Location**: `features/tdd_automation_profile_session_leak.feature` (lines 20, 26, 33, 39, 45, 51, 57, 63) **🚨 MANDATORY STEP**: When implementing this fix, you **MUST remove the `@skip` tag** from ALL test scenario tags to re-enable testing. ### Complete Implementation Checklist: 1. ✅ Implement the AutomationProfileRepository session leak fix described in this issue 2. ✅ Verify your implementation works as expected 3. ✅ **Remove the `@skip` tag** from ALL 8 test scenarios in `features/tdd_automation_profile_session_leak.feature` 4. ✅ Run the specific tests to confirm they pass: `pytest features/tdd_automation_profile_session_leak.feature` 5. ✅ Run full test suite to ensure no regressions 6. ✅ Submit PR with both the implementation AND skip tag removal **⚡ WARNING**: If you forget to remove the `@skip` tags, the tests will remain permanently disabled even though the functionality is implemented, and the issue will appear "complete" but the test coverage will be lost. --- *Skip tags added as part of PR #4175 CI restoration efforts*

freemo referenced this issue from a commit

2026-04-08 07:16:11 +00:00

skip failing tests: add @skip tags to 93 unit test scenarios