cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

feat: Add Q0: Pre-commit hooks setup. #41

Merged
brent.edwards merged 25 commits from Q0-quality-automation into master 2026-02-12 07:21:53 +00:00
Conversation 5 Commits 25 Files Changed 93
+5803 -2110
brent.edwards commented 2026-02-10 00:17:52 +00:00
Member
Copy Link
Copy Source
No description provided.
hurui200320 requested changes 2026-02-10 08:44:27 +00:00
Dismissed
hurui200320 left a comment
Member
Copy Link
Copy Source

I finished the review with the help of OpenCode (via branch diff). I left several comments here. As usual, I (and AI) might be wrong, so please feel free to correct me and close the items that I'm wrong. Thanks : )

I finished the review with the help of OpenCode (via branch diff). I left several comments here. As usual, I (and AI) might be wrong, so please feel free to correct me and close the items that I'm wrong. Thanks : )
docs/development/quality-automation.md Outdated
@@ -0,0 +85,4 @@
### Nightly Quality
A nightly workflow (`.forgejo/workflows/nightly-quality.yml`) runs at midnight UTC:
hurui200320 commented 2026-02-10 08:19:21 +00:00
Member
Copy Link
Copy Source

On which branch? Does it run on master or develop only, or all branches? This is also not specificed in the pipeline yaml file, so might be a good idea to make it explicit.

On which branch? Does it run on master or develop only, or all branches? This is also not specificed in the pipeline yaml file, so might be a good idea to make it explicit.
brent.edwards commented 2026-02-10 23:21:37 +00:00
Author
Member
Copy Link
Copy Source

The workflow is not limited to any branch, so -- according to https://forgejo.org/docs/latest/user/actions/basic-concepts/ -- it should run against all branches.

The workflow is not limited to any branch, so -- according to https://forgejo.org/docs/latest/user/actions/basic-concepts/ -- it should run against all branches.
hurui200320 marked this conversation as resolved
docs/development/quality-automation.md Outdated
@@ -0,0 +94,4 @@
- Reports uploaded as artifacts (90-day retention)
## Security Scanning
hurui200320 commented 2026-02-10 08:18:42 +00:00
Member
Copy Link
Copy Source

Security scanning section is empty.

Security scanning section is empty.
brent.edwards commented 2026-02-11 00:11:04 +00:00
Author
Member
Copy Link
Copy Source

It's not empty. It just goes from ## to ###.

It's not empty. It just goes from ## to ###.
hurui200320 marked this conversation as resolved
docs/development/quality-automation.md Outdated
@@ -0,0 +138,4 @@
| E | 21-30 | Very complex - must refactor |
| F | 31+ | Extremely complex - CI fails |
Current project average: **A (3.56)**
hurui200320 commented 2026-02-10 08:21:24 +00:00
Member
Copy Link
Copy Source

Just a concern: Since this document is not being automatically updated, the number or the current status here might be out of date as people keep working on the project. Maybe add a date to it if you want to keep it?

Just a concern: Since this document is not being automatically updated, the number or the current status here might be out of date as people keep working on the project. Maybe add a date to it if you want to keep it?
brent.edwards commented 2026-02-11 00:11:45 +00:00
Author
Member
Copy Link
Copy Source

I am going to remove that line.

I am going to remove that line.
hurui200320 marked this conversation as resolved
implementation_plan.md Outdated
@@ -929,4 +1004,0 @@
- [ ] **Q0.6c** Test on fresh checkout
- [ ] Commit: "feat(qa): add developer setup script"
- [ ] Tests: Verify all hooks work correctly
- [ ] **Q0.7** [Rui] Write script to test all pre-commit hooks:
hurui200320 commented 2026-02-10 08:35:47 +00:00
Member
Copy Link
Copy Source

I have no objections on someone taking my tasks. But I do notice that the original plan said:

Write script to test all pre-commit hooks

Which, I assume we should have some robot testing? Today when I run opencode to do Q0.7, it generates several files under the robot and features folder for behavior tests. Considering this was my task, so if you want, you can uncheck the items and let me do them. Or just ask opencode to generate some test for the pre-commit hooks : )

I have no objections on someone taking my tasks. But I do notice that the original plan said: > Write script to test all pre-commit hooks Which, I assume we should have some robot testing? Today when I run opencode to do Q0.7, it generates several files under the `robot` and `features` folder for behavior tests. Considering this was my task, so if you want, you can uncheck the items and let me do them. Or just ask opencode to generate some test for the pre-commit hooks : )
brent.edwards commented 2026-02-11 00:12:51 +00:00
Author
Member
Copy Link
Copy Source

The difference is that you should test the pre-commit hooks. My code needed to write them.

The difference is that you should test the pre-commit hooks. My code needed to write them.
hurui200320 marked this conversation as resolved
implementation_plan.md Outdated
@@ -961,3 +1080,1 @@
- [ ] **Q1.4d** Fail if any security issues
- [ ] **Q1.4e** Generate summary comment for PR
- [ ] Commit: "feat(ci): add quality gate enforcement"
- [X] **Stage Q1: CI/CD Pipeline** (Day 2) **[Brent]** - COMPLETED 2026-02-09
hurui200320 commented 2026-02-10 08:41:59 +00:00
Member
Copy Link
Copy Source

The Tests section is not checked, according to

Only mark the parent complete when every sub-bullet

This item shouldn't be marked as completed.

The `Tests` section is not checked, according to > Only mark the parent complete when every sub-bullet This item shouldn't be marked as completed.
brent.edwards commented 2026-02-11 00:15:49 +00:00
Author
Member
Copy Link
Copy Source

Great catch. Done.

Great catch. Done.
hurui200320 marked this conversation as resolved
implementation_plan.md Outdated
@@ -962,2 +1080,2 @@
- [ ] **Q1.4e** Generate summary comment for PR
- [ ] Commit: "feat(ci): add quality gate enforcement"
- [X] **Stage Q1: CI/CD Pipeline** (Day 2) **[Brent]** - COMPLETED 2026-02-09
- [X] Code: Extend Forgejo Actions workflow for comprehensive PR validation
hurui200320 commented 2026-02-10 08:41:24 +00:00
Member
Copy Link
Copy Source

Q1.5 is not checked, according to

Only mark the parent complete when every sub-bullet

This item shouldn't be marked as completed.

Q1.5 is not checked, according to > Only mark the parent complete when every sub-bullet This item shouldn't be marked as completed.
brent.edwards commented 2026-02-11 00:17:16 +00:00
Author
Member
Copy Link
Copy Source

Fixed.

Fixed.
hurui200320 marked this conversation as resolved
scripts/run-semgrep.sh Outdated
@@ -0,0 +1,7 @@
#!/bin/sh
hurui200320 commented 2026-02-10 08:30:51 +00:00
Member
Copy Link
Copy Source

I noticed that this script is not being used anywhere, only mentioned in the documentation. Also notice this line from the implementation plan:

NO wrapper scripts - use tools directly as designed.

I noticed that this script is not being used anywhere, only mentioned in the documentation. Also notice this line from the implementation plan: > NO wrapper scripts - use tools directly as designed.
brent.edwards commented 2026-02-11 00:22:00 +00:00
Author
Member
Copy Link
Copy Source

Fixed.

Fixed.
hurui200320 marked this conversation as resolved
scripts/setup-dev.sh Outdated
@@ -0,0 +1,87 @@
#!/usr/bin/env bash
hurui200320 commented 2026-02-10 08:29:41 +00:00
Member
Copy Link
Copy Source

I noticed that this script is not being used anywhere, only mentioned in the documentation. Maybe we should call it in the pipeline so if someone changeds something and break this script, we could know by a pipeline failure or so.

I noticed that this script is not being used anywhere, only mentioned in the documentation. Maybe we should call it in the pipeline so if someone changeds something and break this script, we could know by a pipeline failure or so.
brent.edwards commented 2026-02-11 00:51:08 +00:00
Author
Member
Copy Link
Copy Source

OpenCode added a .devcontainer/post-create.sh that will automatically run the script.

OpenCode added a `.devcontainer/post-create.sh` that will automatically run the script.
hurui200320 marked this conversation as resolved
freemo force-pushed Q0-quality-automation from 9c0d31950e to 0b8f508420 2026-02-10 13:39:42 +00:00 Compare
freemo force-pushed Q0-quality-automation from 0b8f508420 to 3f7cb06981 2026-02-10 16:04:19 +00:00 Compare
brent.edwards added 1 commit 2026-02-10 22:20:14 +00:00
test(qa): add validation fixtures, edge-case scenarios, and quality baseline 395df78b94 
Complete Brent QA tasks Q1.5, 10B.4, 10C.1, and 10C.4 on the Q0-quality-automation branch.

- Add edge_case_plan_scenarios.feature (26 scenarios) covering concurrent
  plan execution, resource conflicts, validation failure chains, and
  rollback edge cases
- Add validation_test_fixtures.feature (34 scenarios) covering AST
  security, lambda validation, content sanitization, project model
  validation, change-list coercion, and ActionArgument parsing
- Add branch protection rules documentation in docs/development/ci-cd.md
- Establish quality metrics baseline (96% coverage, 0 lint/type/security
  findings)
- Fix missing langchain-anthropic dependency in pyproject.toml
- Fix Rich table column wrapping in plan_lifecycle_cli_steps.py by
  patching console width during tests

Suite: 107 features, 1673 scenarios, 7777 steps — all passing.
brent.edwards commented 2026-02-10 22:45:51 +00:00
Author
Member
Copy Link
Copy Source

I apologize. I messed up. I did not change the branch when OpenCode added more material.

I apologize. I messed up. I did not change the branch when OpenCode added more material.
brent.edwards added 1 commit 2026-02-11 01:00:57 +00:00
refactor: changes requested by Rui 7caac2714e 
Removed `run-semgrep.sh` and automatically run setup-dev.sh
brent.edwards added 1 commit 2026-02-11 01:30:29 +00:00
Merge branch 'master' into Q0-quality-automation 0511261ebe
hurui200320 approved these changes 2026-02-11 06:09:46 +00:00
CoreRasurae reviewed 2026-02-11 15:23:22 +00:00
CoreRasurae left a comment
Member
Copy Link
Copy Source

I did a code review with Opus 4.6 and the main findings are in the comments however there is this other set of findings, which for some of the cases they might be relavant:

MEDIUM Findings (11)

ID File Category Description
M1 scripts/check-quality-gates.py Test Coverage Zero test scenarios for 5 quality gate functions. check_complexity returns True on JSONDecodeError.
M2 scripts/check-adr-compliance.py Bug ADR-002 and ADR-007 checks use raw string matching (not AST). False positives on comments/docstrings.
M3 pyproject.toml:213 Bug major_version_zero = true contradicts version = "1.0.0". Breaking changes will bump minor instead of major.
M4 pyproject.toml (dev deps) Bug Commitizen not in [project.optional-dependencies] dev. Developers outside devcontainer won't have it.
M5 .pre-commit-config.yaml:72-78 Performance Pyright runs full src/ type-check on every commit. Slow and frustrating for developers. Move to pre-push.
M6 docs/development/ci-cd.md Documentation Mixes master and main references. Line 150 says main matching (wrong) CI config.
M7 features/edge_case_plan_scenarios.feature Test Quality "Concurrent" scenarios are purely sequential. No actual concurrent/threaded testing. Mislabeled.
M8 features/steps/edge_case_plan_steps.py:269 Test Quality os.environ.pop("CLEVERAGENTS_TESTING_USE_MOCK_AI") without restore. Potential cross-scenario pollution.
M9 scripts/setup-dev.sh:25 Bug grep -oP requires GNU grep with PCRE. Not portable to all container images.
M10 .forgejo/workflows/ci.yml:62 Security Bandit JSON step uses || true which swallows crashes, not just findings.
M11 features/steps/edge_case_plan_steps.py:255-261 Performance All resource-conflict scenarios run full MigrationRunner.run_migrations() each time.
I did a code review with Opus 4.6 and the main findings are in the comments however there is this other set of findings, which for some of the cases they might be relavant: MEDIUM Findings (11) | ID | File | Category | Description | |----|------|----------|-------------| | M1 | scripts/check-quality-gates.py | Test Coverage | Zero test scenarios for 5 quality gate functions. check_complexity returns True on JSONDecodeError. | | M2 | scripts/check-adr-compliance.py | Bug | ADR-002 and ADR-007 checks use raw string matching (not AST). False positives on comments/docstrings. | | M3 | pyproject.toml:213 | Bug | major_version_zero = true contradicts version = "1.0.0". Breaking changes will bump minor instead of major. | | M4 | pyproject.toml (dev deps) | Bug | Commitizen not in [project.optional-dependencies] dev. Developers outside devcontainer won't have it. | | M5 | .pre-commit-config.yaml:72-78 | Performance | Pyright runs full src/ type-check on every commit. Slow and frustrating for developers. Move to pre-push. | | M6 | docs/development/ci-cd.md | Documentation | Mixes master and main references. Line 150 says main matching (wrong) CI config. | | M7 | features/edge_case_plan_scenarios.feature | Test Quality | "Concurrent" scenarios are purely sequential. No actual concurrent/threaded testing. Mislabeled. | | M8 | features/steps/edge_case_plan_steps.py:269 | Test Quality | os.environ.pop("CLEVERAGENTS_TESTING_USE_MOCK_AI") without restore. Potential cross-scenario pollution. | | M9 | scripts/setup-dev.sh:25 | Bug | grep -oP requires GNU grep with PCRE. Not portable to all container images. | | M10 | .forgejo/workflows/ci.yml:62 | Security | Bandit JSON step uses \|\| true which swallows crashes, not just findings. | | M11 | features/steps/edge_case_plan_steps.py:255-261 | Performance | All resource-conflict scenarios run full MigrationRunner.run_migrations() each time. |
.forgejo/workflows/ci.yml Outdated
@@ -17,19 +17,19 @@ jobs:
image: python:3.13-slim
steps:
- uses: actions/checkout@v4
CoreRasurae commented 2026-02-11 15:16:17 +00:00
Member
Copy Link
Copy Source

CI triggers on main but repo default branch is master (CI/CD)

  • File: .forgejo/workflows/ci.yml:4-6
  • Commit: 7ef5ebb, persists through 0511261
  • Description: on: push: branches: [main, develop] and pull_request: branches: [main]. Confirmed: origin/HEAD -> origin/master. The entire CI pipeline (lint, typecheck, security, quality, coverage, build, docker, helm) will not trigger on pushes to master or PRs targeting master. All quality gates are effectively dead.
CI triggers on main but repo default branch is master (CI/CD) - File: .forgejo/workflows/ci.yml:4-6 - Commit: 7ef5ebb, persists through 0511261 - Description: on: push: branches: [main, develop] and pull_request: branches: [main]. Confirmed: origin/HEAD -> origin/master. The entire CI pipeline (lint, typecheck, security, quality, coverage, build, docker, helm) will not trigger on pushes to master or PRs targeting master. All quality gates are effectively dead.
brent.edwards commented 2026-02-11 20:31:29 +00:00
Author
Member
Copy Link
Copy Source

This is critical. Thank you.

This is critical. Thank you.
.forgejo/workflows/ci.yml Outdated
@@ -78,0 +157,4 @@
- name: Run tests with coverage
run: |
coverage run --source=src -m behave -q --no-capture || true
CoreRasurae commented 2026-02-11 15:20:57 +00:00
Member
Copy Link
Copy Source

CI coverage job uses || true -- masks test failures

  • File: .forgejo/workflows/ci.yml:145-157
  • Commit: 7ef5ebb
  • Description: coverage run ... -m behave ... || true unconditionally swallows test failures. Partial failures producing >85% coverage pass silently.
  • Fix: Remove || true; capture behave exit code separately from coverage threshold.

I think this is not relevant, that this is okay, because we have unit_tests target to check for the unit tests and here we are mostly concerned about coverage.

CI coverage job uses || true -- masks test failures - File: .forgejo/workflows/ci.yml:145-157 - Commit: 7ef5ebb - Description: coverage run ... -m behave ... || true unconditionally swallows test failures. Partial failures producing >85% coverage pass silently. - Fix: Remove || true; capture behave exit code separately from coverage threshold. I think this is not relevant, that this is okay, because we have unit_tests target to check for the unit tests and here we are mostly concerned about coverage.
brent.edwards commented 2026-02-11 20:42:19 +00:00
Author
Member
Copy Link
Copy Source

Did it anyway.

Did it anyway.
.pre-commit-config.yaml Outdated
@@ -0,0 +13,4 @@
hooks:
- id: no-commit-to-branch
name: Prevent direct commits to main
args: ["--branch", "main"]
CoreRasurae commented 2026-02-11 15:18:32 +00:00
Member
Copy Link
Copy Source

Pre-commit branch protection guards main instead of master

  • File: .pre-commit-config.yaml:12
  • Description: no-commit-to-branch configured with args: ["--branch", "main"]. Direct commits to master are not blocked.
  • Fix: Change to args: ["--branch", "master"].
Pre-commit branch protection guards main instead of master - File: .pre-commit-config.yaml:12 - Description: no-commit-to-branch configured with args: ["--branch", "main"]. Direct commits to master are not blocked. - Fix: Change to args: ["--branch", "master"].
brent.edwards commented 2026-02-11 20:43:41 +00:00
Author
Member
Copy Link
Copy Source

Done.

Done.
.pre-commit-config.yaml Outdated
@@ -0,0 +79,4 @@
- id: semgrep-eval-exec
name: Semgrep eval/exec detection
language: system
entry: scripts/run-semgrep.sh
CoreRasurae commented 2026-02-11 15:18:01 +00:00
Member
Copy Link
Copy Source

Deleted run-semgrep.sh still referenced by pre-commit config (Tooling Breakage)

  • File: .pre-commit-config.yaml:82-86
  • Commit: 7caac27 deletes the script; .pre-commit-config.yaml unchanged
  • Description: The semgrep-eval-exec hook has entry: scripts/run-semgrep.sh, but scripts/ only contains check-adr-compliance.py, check-quality-gates.py, do-something.sh, setup-dev.sh. Every git commit touching Python files in src/ will fail with a file-not-found error. Pre-commit is broken for all developers.
  • Fix: Either inline the semgrep command in the hook entry, remove the hook, or restore the script.
Deleted run-semgrep.sh still referenced by pre-commit config (Tooling Breakage) - File: .pre-commit-config.yaml:82-86 - Commit: 7caac27 deletes the script; .pre-commit-config.yaml unchanged - Description: The semgrep-eval-exec hook has entry: scripts/run-semgrep.sh, but scripts/ only contains check-adr-compliance.py, check-quality-gates.py, do-something.sh, setup-dev.sh. Every git commit touching Python files in src/ will fail with a file-not-found error. Pre-commit is broken for all developers. - Fix: Either inline the semgrep command in the hook entry, remove the hook, or restore the script.
brent.edwards commented 2026-02-11 20:46:46 +00:00
Author
Member
Copy Link
Copy Source

Fixed. Thank you for an excellent code review!

Fixed. Thank you for an excellent code review!
brent.edwards added 1 commit 2026-02-12 01:09:29 +00:00
test: harden code sandbox, add path traversal protection, and fix test mocks
CI / lint (pull_request) Failing after 3s
Details
CI / typecheck (pull_request) Failing after 3s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / quality (pull_request) Failing after 5s
Details
CI / security (pull_request) Failing after 6s
Details
CI / behave (3.11) (pull_request) Failing after 2s
Details
CI / behave (3.12) (pull_request) Failing after 2s
Details
CI / behave (3.13) (pull_request) Failing after 3s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / build (pull_request) Failing after 3s
Details
761db2518c
brent.edwards added 1 commit 2026-02-12 01:27:34 +00:00
ci(.forgejo/workflows/ci.yml): adding node to the jobs
CI / lint (pull_request) Failing after 16s
Details
CI / typecheck (pull_request) Successful in 26s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / security (pull_request) Successful in 20s
Details
CI / quality (pull_request) Failing after 16s
Details
CI / behave (3.11) (pull_request) Failing after 11s
Details
CI / behave (3.12) (pull_request) Failing after 11s
Details
CI / behave (3.13) (pull_request) Failing after 14s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / build (pull_request) Failing after 13s
Details
3c63a4c132 
Many steps in ci were failing due to missing `node`.
brent.edwards added 1 commit 2026-02-12 02:09:06 +00:00
ci(pyproject.toml): force the version of ruff
CI / lint (pull_request) Failing after 16s
Details
CI / typecheck (pull_request) Successful in 27s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / security (pull_request) Successful in 18s
Details
CI / quality (pull_request) Failing after 15s
Details
CI / behave (3.11) (pull_request) Failing after 11s
Details
CI / behave (3.12) (pull_request) Failing after 11s
Details
CI / behave (3.13) (pull_request) Failing after 13s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / build (pull_request) Failing after 14s
Details
1774debbc4 
ruff should now be version 0.15.
brent.edwards added 1 commit 2026-02-12 02:16:32 +00:00
build(.pre-commit-config.yaml): moving ruff to version 0.15.0
CI / lint (pull_request) Failing after 15s
Details
CI / typecheck (pull_request) Successful in 26s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / security (pull_request) Successful in 18s
Details
CI / quality (pull_request) Failing after 17s
Details
CI / behave (3.11) (pull_request) Failing after 12s
Details
CI / behave (3.12) (pull_request) Failing after 11s
Details
CI / behave (3.13) (pull_request) Failing after 13s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / build (pull_request) Failing after 13s
Details
16794e43ae 
The version of ruff wasn't right in .pre-commit-config.yaml
brent.edwards added 1 commit 2026-02-12 02:26:13 +00:00
build(features/steps): fix 14 files to match new ruff format
CI / lint (pull_request) Failing after 16s
Details
CI / typecheck (pull_request) Successful in 27s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / security (pull_request) Successful in 19s
Details
CI / quality (pull_request) Failing after 15s
Details
CI / behave (3.11) (pull_request) Failing after 11s
Details
CI / behave (3.12) (pull_request) Failing after 10s
Details
CI / behave (3.13) (pull_request) Failing after 14s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / build (pull_request) Failing after 13s
Details
c5004ae918
brent.edwards added 1 commit 2026-02-12 02:47:25 +00:00
style(robot/-and-typings/numpy): fix style problems found by ruff check
CI / lint (pull_request) Successful in 15s
Details
CI / typecheck (pull_request) Successful in 25s
Details
CI / security (pull_request) Successful in 18s
Details
CI / quality (pull_request) Failing after 15s
Details
CI / behave (3.11) (pull_request) Failing after 11s
Details
CI / behave (3.12) (pull_request) Failing after 11s
Details
CI / behave (3.13) (pull_request) Failing after 13s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / build (pull_request) Failing after 14s
Details
CI / coverage (pull_request) Failing after 15s
Details
51bfee28a9
brent.edwards added 1 commit 2026-02-12 03:04:33 +00:00
style(src/cleveragents/reactive/application.py): simplify the code that gets an F on complexity metric
CI / lint (pull_request) Successful in 16s
Details
CI / typecheck (pull_request) Successful in 26s
Details
CI / security (pull_request) Successful in 17s
Details
CI / quality (pull_request) Failing after 16s
Details
CI / behave (3.11) (pull_request) Failing after 11s
Details
CI / behave (3.12) (pull_request) Failing after 11s
Details
CI / behave (3.13) (pull_request) Failing after 14s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / build (pull_request) Failing after 14s
Details
CI / coverage (pull_request) Failing after 16s
Details
a40d48cbea
brent.edwards added 2 commits 2026-02-12 03:17:34 +00:00
ci(.forgejo/workflows/ci.yml): remove the attempt to upload complexity report 3cc662f5cc 
Forgejo shows the following error: ::error::@actions/artifact v2.0.0+, upload-artifact@v4+ and download-artifact@v4+ are not currently supported on GHES.
ci(.forgejo/workflows/ci.yml): remove behave 3.11 and 3.12
CI / lint (pull_request) Successful in 17s
Details
CI / typecheck (pull_request) Successful in 24s
Details
CI / security (pull_request) Successful in 18s
Details
CI / quality (pull_request) Failing after 16s
Details
CI / behave (3.13) (pull_request) Failing after 15s
Details
CI / helm (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / build (pull_request) Failing after 14s
Details
CI / coverage (pull_request) Failing after 17s
Details
ea783c57e9
brent.edwards added 1 commit 2026-02-12 03:30:22 +00:00
ci(.forgejo/workflows/ci.yml): remove unused behave-parallel
CI / lint (pull_request) Successful in 17s
Details
CI / typecheck (pull_request) Successful in 26s
Details
CI / security (pull_request) Successful in 17s
Details
CI / quality (pull_request) Successful in 14s
Details
CI / behave (3.13) (pull_request) Failing after 14s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 11s
Details
CI / coverage (pull_request) Failing after 14s
Details
4ae8a9ee3a 
No longer installing behave-parallel. Also removed other uploads that won't work.
brent.edwards added 1 commit 2026-02-12 03:36:57 +00:00
build(behave.ini): remove ", src" from "paths"
CI / lint (pull_request) Successful in 17s
Details
CI / typecheck (pull_request) Successful in 25s
Details
CI / security (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 13s
Details
CI / behave (3.13) (pull_request) Failing after 3m46s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / coverage (pull_request) Failing after 4m20s
Details
3ed11f7988 
The code was seeing the whole text as one path.
brent.edwards added 1 commit 2026-02-12 04:47:32 +00:00
test(behave): fix behave tests
CI / lint (pull_request) Successful in 18s
Details
CI / typecheck (pull_request) Successful in 26s
Details
CI / security (pull_request) Successful in 17s
Details
CI / quality (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 12s
Details
CI / behave (3.13) (pull_request) Failing after 3m50s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / coverage (pull_request) Failing after 4m20s
Details
17fe46d925 
There had been over 100 behave tests failing. There should be none failing now.
brent.edwards added 1 commit 2026-02-12 05:23:43 +00:00
test(features/steps): fix features that depend on running as user not superuser
CI / lint (pull_request) Successful in 16s
Details
CI / typecheck (pull_request) Successful in 25s
Details
CI / security (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 12s
Details
CI / behave (3.13) (pull_request) Failing after 3m54s
Details
CI / docker (pull_request) Has been skipped
Details
CI / helm (pull_request) Has been skipped
Details
CI / coverage (pull_request) Failing after 4m17s
Details
d4a48caeec
brent.edwards added 1 commit 2026-02-12 05:45:08 +00:00
test(features/steps): remove ansi codes
CI / lint (pull_request) Successful in 17s
Details
CI / security (pull_request) Successful in 17s
Details
CI / typecheck (pull_request) Successful in 24s
Details
CI / quality (pull_request) Successful in 15s
Details
CI / build (pull_request) Successful in 13s
Details
CI / behave (3.13) (pull_request) Successful in 3m43s
Details
CI / docker (pull_request) Failing after 33s
Details
CI / helm (pull_request) Failing after 6s
Details
CI / coverage (pull_request) Successful in 4m20s
Details
c9605c9381 
Remove rich formatting from output
brent.edwards added 1 commit 2026-02-12 06:07:42 +00:00
Merge branch 'master' into Q0-quality-automation
CI / lint (pull_request) Successful in 17s
Details
CI / typecheck (pull_request) Successful in 27s
Details
CI / security (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 11s
Details
CI / behave (3.13) (pull_request) Successful in 3m47s
Details
CI / docker (pull_request) Failing after 32s
Details
CI / helm (pull_request) Failing after 7s
Details
CI / coverage (pull_request) Successful in 4m16s
Details
04070ca3ff 
# Conflicts:
#	implementation_plan.md
brent.edwards added 1 commit 2026-02-12 06:19:43 +00:00
fix(ci): fix docker build job and Dockerfile
CI / lint (pull_request) Successful in 16s
Details
CI / typecheck (pull_request) Successful in 24s
Details
CI / security (pull_request) Successful in 17s
Details
CI / quality (pull_request) Successful in 15s
Details
CI / build (pull_request) Successful in 12s
Details
CI / behave (3.13) (pull_request) Successful in 3m45s
Details
CI / docker (pull_request) Failing after 6s
Details
CI / coverage (pull_request) Successful in 4m12s
Details
945cced381 
- Add DinD service container and docker:cli image so docker CLI is available
- Fix Dockerfile: remove missing uv.lock, fix build order (copy source before build)
- Remove helm job (k8s/ directory does not exist yet)
brent.edwards added 1 commit 2026-02-12 06:27:13 +00:00
fix(ci): use docker:dind as main container instead of services
CI / lint (pull_request) Successful in 15s
Details
CI / security (pull_request) Successful in 17s
Details
CI / typecheck (pull_request) Successful in 23s
Details
CI / quality (pull_request) Successful in 15s
Details
CI / build (pull_request) Successful in 12s
Details
CI / behave (3.13) (pull_request) Successful in 3m41s
Details
CI / docker (pull_request) Failing after 22s
Details
CI / coverage (pull_request) Successful in 4m19s
Details
d0f1c8bae3 
Forgejo act_runner service container networking fails with 'network not
found'. Use docker:dind directly with --privileged and start dockerd
inline to avoid the services networking issue.
brent.edwards added 1 commit 2026-02-12 06:35:30 +00:00
fix(docker): copy README.md into build stage for hatchling
CI / lint (pull_request) Successful in 14s
Details
CI / typecheck (pull_request) Successful in 24s
Details
CI / security (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 41s
Details
CI / behave (3.13) (pull_request) Successful in 3m39s
Details
CI / docker (pull_request) Successful in 39s
Details
CI / coverage (pull_request) Successful in 4m17s
Details
58d79558ce
brent.edwards added 2 commits 2026-02-12 07:15:03 +00:00
fix(deps): pin behave==1.2.6 in tests extra to match dev extra 64f58f6406 
behave-parallel pulls behave>=1.2.6 which resolves to 1.3.3. Behave
1.3.3 no longer strips trailing colons from step text before tables,
breaking the architecture.feature step matcher.
fix(nox): run asv machine --yes before benchmarks
CI / lint (pull_request) Successful in 16s
Details
CI / typecheck (pull_request) Successful in 25s
Details
CI / security (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 12s
Details
CI / behave (3.13) (pull_request) Successful in 3m45s
Details
CI / coverage (pull_request) Successful in 4m10s
Details
CI / docker (pull_request) Successful in 47s
Details
63b54ac8ab 
asv requires machine info to be configured before running benchmarks.
Without this, asv run fails on first use or in CI/containers.
brent.edwards merged commit 13a0aaeb9d into master 2026-02-12 07:21:53 +00:00
brent.edwards deleted branch Q0-quality-automation 2026-02-12 07:21:53 +00:00
freemo added this to the v3.0.0 milestone 2026-02-23 17:24:52 +00:00
freemo commented 2026-02-23 17:25:52 +00:00
Owner
Copy Link
Copy Source

Closes #212

Closes #212
Sign in to join this conversation.
Reviewers
No Reviewers
hurui200320
CoreRasurae
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Milestone
No items
No Milestone v3.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#41
Delete Branch "Q0-quality-automation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?