feat: Add Q0: Pre-commit hooks setup. #41
No reviewers
Labels
No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
cleveragents/cleveragents-core!41
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "Q0-quality-automation"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I finished the review with the help of OpenCode (via branch diff). I left several comments here. As usual, I (and AI) might be wrong, so please feel free to correct me and close the items that I'm wrong. Thanks : )
@ -0,0 +85,4 @@### Nightly QualityA nightly workflow (`.forgejo/workflows/nightly-quality.yml`) runs at midnight UTC:On which branch? Does it run on master or develop only, or all branches? This is also not specificed in the pipeline yaml file, so might be a good idea to make it explicit.
The workflow is not limited to any branch, so -- according to https://forgejo.org/docs/latest/user/actions/basic-concepts/ -- it should run against all branches.
@ -0,0 +94,4 @@- Reports uploaded as artifacts (90-day retention)## Security ScanningSecurity scanning section is empty.
It's not empty. It just goes from ## to ###.
@ -0,0 +138,4 @@| E | 21-30 | Very complex - must refactor || F | 31+ | Extremely complex - CI fails |Current project average: **A (3.56)**Just a concern: Since this document is not being automatically updated, the number or the current status here might be out of date as people keep working on the project. Maybe add a date to it if you want to keep it?
I am going to remove that line.
@ -929,4 +1004,0 @@- [ ] **Q0.6c** Test on fresh checkout- [ ] Commit: "feat(qa): add developer setup script"- [ ] Tests: Verify all hooks work correctly- [ ] **Q0.7** [Rui] Write script to test all pre-commit hooks:I have no objections on someone taking my tasks. But I do notice that the original plan said:
Which, I assume we should have some robot testing? Today when I run opencode to do Q0.7, it generates several files under the
robotandfeaturesfolder for behavior tests. Considering this was my task, so if you want, you can uncheck the items and let me do them. Or just ask opencode to generate some test for the pre-commit hooks : )The difference is that you should test the pre-commit hooks. My code needed to write them.
@ -961,3 +1080,1 @@- [ ] **Q1.4d** Fail if any security issues- [ ] **Q1.4e** Generate summary comment for PR- [ ] Commit: "feat(ci): add quality gate enforcement"- [X] **Stage Q1: CI/CD Pipeline** (Day 2) **[Brent]** - COMPLETED 2026-02-09The
Testssection is not checked, according toThis item shouldn't be marked as completed.
Great catch. Done.
@ -962,2 +1080,2 @@- [ ] **Q1.4e** Generate summary comment for PR- [ ] Commit: "feat(ci): add quality gate enforcement"- [X] **Stage Q1: CI/CD Pipeline** (Day 2) **[Brent]** - COMPLETED 2026-02-09- [X] Code: Extend Forgejo Actions workflow for comprehensive PR validationQ1.5 is not checked, according to
This item shouldn't be marked as completed.
Fixed.
@ -0,0 +1,7 @@#!/bin/shI noticed that this script is not being used anywhere, only mentioned in the documentation. Also notice this line from the implementation plan:
Fixed.
@ -0,0 +1,87 @@#!/usr/bin/env bashI noticed that this script is not being used anywhere, only mentioned in the documentation. Maybe we should call it in the pipeline so if someone changeds something and break this script, we could know by a pipeline failure or so.
OpenCode added a
.devcontainer/post-create.shthat will automatically run the script.9c0d31950eto0b8f5084200b8f508420to3f7cb06981I apologize. I messed up. I did not change the branch when OpenCode added more material.
I did a code review with Opus 4.6 and the main findings are in the comments however there is this other set of findings, which for some of the cases they might be relavant:
MEDIUM Findings (11)
@ -17,19 +17,19 @@ jobs:image: python:3.13-slimsteps:- uses: actions/checkout@v4CI triggers on main but repo default branch is master (CI/CD)
7ef5ebb, persists through0511261This is critical. Thank you.
@ -78,0 +157,4 @@- name: Run tests with coveragerun: |coverage run --source=src -m behave -q --no-capture || trueCI coverage job uses || true -- masks test failures
7ef5ebbI think this is not relevant, that this is okay, because we have unit_tests target to check for the unit tests and here we are mostly concerned about coverage.
Did it anyway.
@ -0,0 +13,4 @@hooks:- id: no-commit-to-branchname: Prevent direct commits to mainargs: ["--branch", "main"]Pre-commit branch protection guards main instead of master
Done.
@ -0,0 +79,4 @@- id: semgrep-eval-execname: Semgrep eval/exec detectionlanguage: systementry: scripts/run-semgrep.shDeleted run-semgrep.sh still referenced by pre-commit config (Tooling Breakage)
7caac27deletes the script; .pre-commit-config.yaml unchangedFixed. Thank you for an excellent code review!
ruff checkCloses #212