cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

develop-aditya-2 #382

Closed
aditya wants to merge 3 commits from develop-aditya-2 into master
pull from: develop-aditya-2
merge into: cleveragents:master
Conversation 2 Commits 3 Files changed 17 +3320 -13
aditya commented 2026-02-23 13:28:20 +00:00
Member
Copy link

Metadata

  • Commit Message: feat(skill): add MCP adapter for external tools
  • Branch: develop-aditya-2

Background

This PR implements the MCP (Model Context Protocol) adapter for external tool integration as part of Milestone 2 (v3.1.0). It enables CleverAgents to discover and route external tools via the MCP protocol.

Related issue: #159

Expected Behavior

The MCP adapter can connect to external MCP servers, discover available tools, and route tool invocations through the skill system. Tool results are properly marshalled back to the actor execution pipeline.

Acceptance Criteria

  • MCP adapter connects to external MCP servers
  • Tool discovery works via MCP protocol
  • Tool invocations route correctly through skill system
  • Tool results marshal back to actor pipeline
  • Existing tests pass with no regressions
  • Coverage remains >=97%

Definition of Done

This PR is complete when:

  • All acceptance criteria above are met.
  • Code review is approved.
  • CI passes (nox full suite, coverage >=97%).
  • PR is merged to master.
## Metadata - **Commit Message**: `feat(skill): add MCP adapter for external tools` - **Branch**: `develop-aditya-2` ## Background This PR implements the MCP (Model Context Protocol) adapter for external tool integration as part of Milestone 2 (v3.1.0). It enables CleverAgents to discover and route external tools via the MCP protocol. Related issue: #159 ## Expected Behavior The MCP adapter can connect to external MCP servers, discover available tools, and route tool invocations through the skill system. Tool results are properly marshalled back to the actor execution pipeline. ## Acceptance Criteria - [ ] MCP adapter connects to external MCP servers - [ ] Tool discovery works via MCP protocol - [ ] Tool invocations route correctly through skill system - [ ] Tool results marshal back to actor pipeline - [ ] Existing tests pass with no regressions - [ ] Coverage remains >=97% ## Definition of Done This PR is complete when: - All acceptance criteria above are met. - Code review is approved. - CI passes (nox full suite, coverage >=97%). - PR is merged to master.
feat(skill): add MCP adapter for external tools
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 15s
Details
CI / build (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 21s
Details
CI / security (pull_request) Successful in 33s
Details
CI / typecheck (pull_request) Successful in 47s
Details
CI / integration_tests (pull_request) Successful in 2m54s
Details
CI / unit_tests (pull_request) Successful in 6m13s
Details
CI / docker (pull_request) Successful in 39s
Details
CI / benchmark-regression (pull_request) Successful in 19m58s
Details
CI / coverage (pull_request) Failing after 22m0s
Details
a6e56fe96e
freemo added this to the v3.1.0 milestone 2026-02-23 17:26:21 +00:00
Merge branch 'master' into develop-aditya-2
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 17s
Details
CI / quality (pull_request) Successful in 20s
Details
CI / typecheck (pull_request) Successful in 47s
Details
CI / security (pull_request) Successful in 50s
Details
CI / integration_tests (pull_request) Successful in 3m41s
Details
CI / unit_tests (pull_request) Successful in 7m9s
Details
CI / docker (pull_request) Successful in 38s
Details
CI / benchmark-regression (pull_request) Successful in 20m12s
Details
CI / coverage (pull_request) Successful in 24m15s
Details
80a56846fe
 
# Conflicts:
#	implementation_plan.md
brent.edwards approved these changes 2026-02-24 19:32:13 +00:00
brent.edwards left a comment
Copy link

This passes all tests, and it's been merged with master since Jeff's changes. So I approve it.

This passes all tests, and it's been merged with master since Jeff's changes. So I approve it.
freemo requested changes 2026-02-24 22:27:25 +00:00
Dismissed
freemo left a comment
Copy link

Code Review: PR #382 — develop-aditya-2

This PR has several structural and process issues that prevent it from meeting the project's merge requirements. Additionally, it appears to overlap significantly with PR #416 (which contains the same MCP adapter and actor hierarchy code).

Critical Issues

1. Non-descriptive PR title (CONTRIBUTING.md §5)
The title "develop-aditya-2" is simply a branch name and does not follow the Conventional Changelog format. The title should describe the change (e.g., feat(mcp): add MCP adapter for external tools).

2. Wrong branch name (issue #159 mismatch)
Issue #159 specifies the branch should be feature/m3-mcp-adapter, but this PR uses develop-aditya-2. Per the issue's Definition of Done: "The commit is pushed to the remote on the branch matching the Branch in Metadata exactly."

3. Multiple unrelated features bundled (CONTRIBUTING.md §2)
This PR bundles two independent features with no code dependency between them:

  • MCP Tool Adapter (src/cleveragents/mcp/*, features, robot tests, docs, benchmarks) — 7 files
  • Hierarchical Actor YAML Schema Extensions (src/cleveragents/actor/schema.py, features, robot tests, docs, benchmarks) — 8 files

These should be separate PRs, each scoped to one issue.

4. Overlap with PR #416
This PR contains the same MCP adapter and actor hierarchy code that is also in PR #416. This duplication needs to be resolved — the work should exist in exactly one PR.

5. Improper labels on PR (CONTRIBUTING.md §12)
This PR carries MoSCoW/Must have, Points/8, and enhancement labels. Per guidelines:

  • "No other label scopes (State/, Priority/, MoSCoW/) are applied to Pull Requests; those scopes are reserved for issues only."
  • enhancement is not part of the defined label system. PRs should have exactly one Type/ label.
  • Points/ labels are not defined in CONTRIBUTING.md and should be on issues only.

6. No issue references in commit footers (CONTRIBUTING.md §4)
Neither commit has a Refs:, Closes:, or ISSUES CLOSED: reference in its footer. All commits must reference their associated issues.

7. No CHANGELOG update (CONTRIBUTING.md §6) — Two new features with no CHANGELOG entries.

8. No CONTRIBUTORS.md update (CONTRIBUTING.md §8)

Code Quality Issues

9. Mock placement violation (CONTRIBUTING.md — Mock Placement)
MockMCPTransport is embedded inline in features/steps/mcp_adapter_steps.py and robot/helper_mcp_adapter.py has its own _MockTransport. Per guidelines: "ALL mocks, test doubles, and mock implementations must exist only in the features/ directory" — specifically features/mocks/. Extract shared mocks to features/mocks/mock_mcp_transport.py.

10. registry: Any type annotation
MCPToolAdapter.register_tools() uses registry: Any instead of the concrete type. Use a TYPE_CHECKING forward reference.

11. Constructor validation gap
MCPToolAdapter.__init__ does not validate transport configuration (stdio requires command, sse requires url) — only from_server_config does. Direct constructor callers skip validation.

12. Misleading commit scope
Commit a6e56fe uses feat(skill) scope but the feature is an MCP adapter under src/cleveragents/mcp/. The scope should be feat(mcp).

Recommended Path Forward

  1. Close this PR and create properly scoped PRs from correctly named branches matching the issue metadata.
  2. For the MCP adapter: use branch feature/m3-mcp-adapter as specified in issue #159.
  3. For the actor hierarchy: create a separate issue and branch.
  4. Extract mocks to features/mocks/.
  5. Add CHANGELOG, CONTRIBUTORS.md entries.
  6. Fix labels to use only Type/Feature.
## Code Review: PR #382 — `develop-aditya-2` This PR has several structural and process issues that prevent it from meeting the project's merge requirements. Additionally, it appears to overlap significantly with PR #416 (which contains the same MCP adapter and actor hierarchy code). ### Critical Issues **1. Non-descriptive PR title (CONTRIBUTING.md §5)** The title "develop-aditya-2" is simply a branch name and does not follow the Conventional Changelog format. The title should describe the change (e.g., `feat(mcp): add MCP adapter for external tools`). **2. Wrong branch name (issue #159 mismatch)** Issue #159 specifies the branch should be `feature/m3-mcp-adapter`, but this PR uses `develop-aditya-2`. Per the issue's Definition of Done: "The commit is pushed to the remote on the branch matching the Branch in Metadata exactly." **3. Multiple unrelated features bundled (CONTRIBUTING.md §2)** This PR bundles **two independent features** with no code dependency between them: - **MCP Tool Adapter** (`src/cleveragents/mcp/*`, features, robot tests, docs, benchmarks) — 7 files - **Hierarchical Actor YAML Schema Extensions** (`src/cleveragents/actor/schema.py`, features, robot tests, docs, benchmarks) — 8 files These should be separate PRs, each scoped to one issue. **4. Overlap with PR #416** This PR contains the same MCP adapter and actor hierarchy code that is also in PR #416. This duplication needs to be resolved — the work should exist in exactly one PR. **5. Improper labels on PR (CONTRIBUTING.md §12)** This PR carries `MoSCoW/Must have`, `Points/8`, and `enhancement` labels. Per guidelines: - "No other label scopes (`State/`, `Priority/`, `MoSCoW/`) are applied to Pull Requests; those scopes are reserved for issues only." - `enhancement` is not part of the defined label system. PRs should have exactly one `Type/` label. - `Points/` labels are not defined in CONTRIBUTING.md and should be on issues only. **6. No issue references in commit footers (CONTRIBUTING.md §4)** Neither commit has a `Refs:`, `Closes:`, or `ISSUES CLOSED:` reference in its footer. All commits must reference their associated issues. **7. No CHANGELOG update (CONTRIBUTING.md §6)** — Two new features with no CHANGELOG entries. **8. No CONTRIBUTORS.md update (CONTRIBUTING.md §8)** ### Code Quality Issues **9. Mock placement violation (CONTRIBUTING.md — Mock Placement)** `MockMCPTransport` is embedded inline in `features/steps/mcp_adapter_steps.py` and `robot/helper_mcp_adapter.py` has its own `_MockTransport`. Per guidelines: "ALL mocks, test doubles, and mock implementations must exist only in the `features/` directory" — specifically `features/mocks/`. Extract shared mocks to `features/mocks/mock_mcp_transport.py`. **10. `registry: Any` type annotation** `MCPToolAdapter.register_tools()` uses `registry: Any` instead of the concrete type. Use a `TYPE_CHECKING` forward reference. **11. Constructor validation gap** `MCPToolAdapter.__init__` does not validate transport configuration (stdio requires `command`, sse requires `url`) — only `from_server_config` does. Direct constructor callers skip validation. **12. Misleading commit scope** Commit `a6e56fe` uses `feat(skill)` scope but the feature is an MCP adapter under `src/cleveragents/mcp/`. The scope should be `feat(mcp)`. ### Recommended Path Forward 1. Close this PR and create properly scoped PRs from correctly named branches matching the issue metadata. 2. For the MCP adapter: use branch `feature/m3-mcp-adapter` as specified in issue #159. 3. For the actor hierarchy: create a separate issue and branch. 4. Extract mocks to `features/mocks/`. 5. Add CHANGELOG, CONTRIBUTORS.md entries. 6. Fix labels to use only `Type/Feature`.
freemo dismissed freemo's review 2026-02-24 22:45:20 +00:00
Reason:

dont want hard block

aditya closed this pull request 2026-02-25 14:19:43 +00:00
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Required
Details
CI / build (pull_request) Successful in 17s
Required
Details
CI / quality (pull_request) Successful in 20s
Required
Details
CI / typecheck (pull_request) Successful in 47s
Required
Details
CI / security (pull_request) Successful in 50s
Required
Details
CI / integration_tests (pull_request) Successful in 3m41s
Required
Details
CI / unit_tests (pull_request) Successful in 7m9s
Required
Details
CI / docker (pull_request) Successful in 38s
Required
Details
CI / benchmark-regression (pull_request) Successful in 20m12s
Details
CI / coverage (pull_request) Successful in 24m15s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
brent.edwards
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.1.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
aditya
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!382
No description provided.