TEST-INFRA: [missing-test-levels] Add Robot integration tests for the acp module #3719

Open
opened 2026-04-05 22:17:52 +00:00 by freemo · 1 comment
Owner

Metadata

  • Branch: test/missing-test-levels-acp-robot-integration-tests
  • Commit Message: test(acp): add Robot Framework integration tests for the acp module
  • Milestone: (none — backlog)
  • Parent Epic: (see orphan note below)

Backlog note: This issue was discovered during autonomous operation
on milestone v3.7.0. It does not block milestone completion and has been
placed in the backlog for human review and future milestone assignment.

⚠️ Architectural Note — ACP Deprecation: Per docs/specification.md, the acp module is deprecated and has been superseded by the Agent-to-Agent (A2A) Protocol (ADR-047). Before implementing this issue, the assignee should confirm with the project owner whether:

  1. Robot integration tests should be added to the legacy acp module as-is (for coverage compliance), or
  2. This work should be redirected to adding Robot integration tests for the a2a module instead.
    The A2A protocol is the sole communication protocol for all client-server interactions going forward.

🔗 Relationship to existing issues: This issue is a focused split of #3577 ("Add missing tests for acp module"), which covers all three test levels (Behave, Robot, ASV) for the acp module in a single issue. The companion Behave unit tests split is tracked in #3703. This issue covers only the Robot Framework integration test layer, keeping each issue to a single atomic commit per project conventions.

Description

The acp module in src/cleveragents/acp is missing Robot Framework integration tests. Per the project testing strategy, every module must have integration tests written using the Robot Framework, located under the robot/ directory. Integration tests must exercise the module against real services and dependencies — mocks are not permitted in Robot tests.

This issue tracks the work to bring the acp module into compliance with the integration test requirement.

Subtasks

  • Confirm with project owner whether to test the legacy acp module or redirect to the a2a module (see architectural note above).
  • Audit the acp module's public API and integration points to identify all behaviours requiring Robot test coverage.
  • Create a new Robot test suite at robot/acp/ for the acp module.
  • Add Robot test cases covering the key integration scenarios of the acp module.
  • Implement any required Robot keywords and resource files (no mocks — real dependencies only).
  • Run nox -e integration_tests and confirm all new Robot tests pass.
  • Run nox -e coverage_report and confirm coverage remains >= 97%.
  • Run nox (all default sessions) and fix any errors.

Definition of Done

  • Robot Framework test suite for the acp module exists under robot/acp/.
  • All new Robot tests pass (nox -e integration_tests).
  • The new tests provide adequate coverage for the acp module's integration points.
  • No mocks or test doubles are used in the Robot test suite.
  • All nox stages pass.
  • Coverage >= 97%.
  • Commit created with message: test(acp): add Robot Framework integration tests for the acp module
  • PR merged and issue closed.

Automated by CleverAgents Bot
Supervisor: Test Infrastructure | Agent: ca-new-issue-creator

## Metadata - **Branch**: `test/missing-test-levels-acp-robot-integration-tests` - **Commit Message**: `test(acp): add Robot Framework integration tests for the acp module` - **Milestone**: *(none — backlog)* - **Parent Epic**: *(see orphan note below)* > **Backlog note:** This issue was discovered during autonomous operation > on milestone v3.7.0. It does not block milestone completion and has been > placed in the backlog for human review and future milestone assignment. > ⚠️ **Architectural Note — ACP Deprecation:** Per `docs/specification.md`, the `acp` module is **deprecated** and has been superseded by the **Agent-to-Agent (A2A) Protocol** (ADR-047). Before implementing this issue, the assignee should confirm with the project owner whether: > 1. Robot integration tests should be added to the legacy `acp` module as-is (for coverage compliance), or > 2. This work should be redirected to adding Robot integration tests for the `a2a` module instead. > The A2A protocol is the sole communication protocol for all client-server interactions going forward. > 🔗 **Relationship to existing issues:** This issue is a focused split of #3577 ("Add missing tests for acp module"), which covers all three test levels (Behave, Robot, ASV) for the `acp` module in a single issue. The companion Behave unit tests split is tracked in #3703. This issue covers only the Robot Framework integration test layer, keeping each issue to a single atomic commit per project conventions. ## Description The `acp` module in `src/cleveragents/acp` is missing Robot Framework integration tests. Per the project testing strategy, every module must have integration tests written using the Robot Framework, located under the `robot/` directory. Integration tests must exercise the module against real services and dependencies — mocks are not permitted in Robot tests. This issue tracks the work to bring the `acp` module into compliance with the integration test requirement. ## Subtasks - [ ] Confirm with project owner whether to test the legacy `acp` module or redirect to the `a2a` module (see architectural note above). - [ ] Audit the `acp` module's public API and integration points to identify all behaviours requiring Robot test coverage. - [ ] Create a new Robot test suite at `robot/acp/` for the `acp` module. - [ ] Add Robot test cases covering the key integration scenarios of the `acp` module. - [ ] Implement any required Robot keywords and resource files (no mocks — real dependencies only). - [ ] Run `nox -e integration_tests` and confirm all new Robot tests pass. - [ ] Run `nox -e coverage_report` and confirm coverage remains >= 97%. - [ ] Run `nox` (all default sessions) and fix any errors. ## Definition of Done - [ ] Robot Framework test suite for the `acp` module exists under `robot/acp/`. - [ ] All new Robot tests pass (`nox -e integration_tests`). - [ ] The new tests provide adequate coverage for the `acp` module's integration points. - [ ] No mocks or test doubles are used in the Robot test suite. - [ ] All nox stages pass. - [ ] Coverage >= 97%. - [ ] Commit created with message: `test(acp): add Robot Framework integration tests for the acp module` - [ ] PR merged and issue closed. --- **Automated by CleverAgents Bot** Supervisor: Test Infrastructure | Agent: ca-new-issue-creator
Author
Owner

⚠️ Orphan Issue — Manual Linking Required

No parent Epic was provided when this issue was created. Per CONTRIBUTING.md, every issue must be linked to a parent Epic via Forgejo's dependency system (child blocks parent).

Recommended action: A project owner should identify or create the appropriate parent Epic for the [missing-test-levels] workstream and link this issue to it using:

  • This issue blocks the parent Epic (i.e., the Epic cannot be complete until this issue is done)

Related issues for context:

  • #3577 — "Add missing tests for acp module" (comprehensive issue covering all three test levels for acp; this issue is a focused atomic split of that work)
  • #3703 — "Add Behave unit tests for the acp module" (companion Behave split)
  • #3398 — "Massive number of modules are missing all test levels" (broader tracking issue)

Automated by CleverAgents Bot
Supervisor: Test Infrastructure | Agent: ca-new-issue-creator

⚠️ **Orphan Issue — Manual Linking Required** No parent Epic was provided when this issue was created. Per CONTRIBUTING.md, every issue must be linked to a parent Epic via Forgejo's dependency system (child **blocks** parent). **Recommended action:** A project owner should identify or create the appropriate parent Epic for the `[missing-test-levels]` workstream and link this issue to it using: - This issue **blocks** the parent Epic (i.e., the Epic cannot be complete until this issue is done) **Related issues for context:** - #3577 — "Add missing tests for acp module" (comprehensive issue covering all three test levels for `acp`; this issue is a focused atomic split of that work) - #3703 — "Add Behave unit tests for the acp module" (companion Behave split) - #3398 — "Massive number of modules are missing all test levels" (broader tracking issue) --- **Automated by CleverAgents Bot** Supervisor: Test Infrastructure | Agent: ca-new-issue-creator
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#3719
No description provided.