TEST-INFRA: [missing-test-levels] Add Behave unit tests for the acp module #3703

Open
opened 2026-04-05 22:14:54 +00:00 by freemo · 1 comment
Owner

Metadata

  • Branch: test/missing-test-levels-acp-behave-unit-tests
  • Commit Message: test(acp): add Behave unit tests for the acp module
  • Milestone: N/A — Backlog (see note below)
  • Parent Epic: TBD — see orphan note below

Backlog note: This issue was discovered during autonomous operation
on milestone v3.7.0. It does not block milestone completion and has been
placed in the backlog for human review and future milestone assignment.

⚠️ Architectural Note — ACP Deprecation: Per docs/specification.md, the acp module is deprecated and has been superseded by the Agent-to-Agent (A2A) Protocol (ADR-047). Before implementing this issue, the assignee should confirm with the project owner whether:

  1. Tests should be added to the legacy acp module as-is (for coverage compliance), or
  2. This work should be redirected to adding Behave unit tests for the a2a module instead.
    The A2A protocol is the sole communication protocol for all client-server interactions going forward.

Description

The acp module in src/cleveragents/acp is missing Behave unit tests. Per the project testing strategy, every module must have unit tests written in Gherkin/Behave (located under features/). This issue tracks the work to bring the acp module into compliance with the >=97% coverage requirement.

Subtasks

  • Confirm with project owner whether to test the legacy acp module or redirect to the a2a module (see architectural note above).
  • Create a new feature file at features/acp/ for the acp module.
  • Add BDD scenarios in Gherkin syntax to cover the public interface and key functionality of the acp module.
  • Implement the corresponding step definitions under features/acp/steps/.
  • Place any required test doubles or mocks exclusively in features/mocks/ (no mocks in production code).
  • Run nox -e unit_tests and confirm all new scenarios pass.
  • Run nox -e coverage_report and confirm coverage remains >= 97%.
  • Run nox (all default sessions) and fix any errors.

Definition of Done

  • Behave feature file(s) for the acp module exist under features/acp/.
  • All new Behave scenarios pass (nox -e unit_tests).
  • The new tests provide adequate coverage for the acp module's public interface.
  • No pytest-style (xUnit) unit tests have been introduced.
  • All mocks and test doubles are placed in features/mocks/ only.
  • All nox stages pass.
  • Coverage >= 97%.

Automated by CleverAgents Bot
Supervisor: Test Infrastructure | Agent: ca-new-issue-creator

## Metadata - **Branch**: `test/missing-test-levels-acp-behave-unit-tests` - **Commit Message**: `test(acp): add Behave unit tests for the acp module` - **Milestone**: N/A — Backlog (see note below) - **Parent Epic**: TBD — see orphan note below > **Backlog note:** This issue was discovered during autonomous operation > on milestone v3.7.0. It does not block milestone completion and has been > placed in the backlog for human review and future milestone assignment. > ⚠️ **Architectural Note — ACP Deprecation:** Per `docs/specification.md`, the `acp` module is **deprecated** and has been superseded by the **Agent-to-Agent (A2A) Protocol** (ADR-047). Before implementing this issue, the assignee should confirm with the project owner whether: > 1. Tests should be added to the legacy `acp` module as-is (for coverage compliance), or > 2. This work should be redirected to adding Behave unit tests for the `a2a` module instead. > The A2A protocol is the sole communication protocol for all client-server interactions going forward. ## Description The `acp` module in `src/cleveragents/acp` is missing Behave unit tests. Per the project testing strategy, every module must have unit tests written in Gherkin/Behave (located under `features/`). This issue tracks the work to bring the `acp` module into compliance with the >=97% coverage requirement. ## Subtasks - [ ] Confirm with project owner whether to test the legacy `acp` module or redirect to the `a2a` module (see architectural note above). - [ ] Create a new feature file at `features/acp/` for the `acp` module. - [ ] Add BDD scenarios in Gherkin syntax to cover the public interface and key functionality of the `acp` module. - [ ] Implement the corresponding step definitions under `features/acp/steps/`. - [ ] Place any required test doubles or mocks exclusively in `features/mocks/` (no mocks in production code). - [ ] Run `nox -e unit_tests` and confirm all new scenarios pass. - [ ] Run `nox -e coverage_report` and confirm coverage remains >= 97%. - [ ] Run `nox` (all default sessions) and fix any errors. ## Definition of Done - [ ] Behave feature file(s) for the `acp` module exist under `features/acp/`. - [ ] All new Behave scenarios pass (`nox -e unit_tests`). - [ ] The new tests provide adequate coverage for the `acp` module's public interface. - [ ] No pytest-style (xUnit) unit tests have been introduced. - [ ] All mocks and test doubles are placed in `features/mocks/` only. - [ ] All nox stages pass. - [ ] Coverage >= 97%. --- **Automated by CleverAgents Bot** Supervisor: Test Infrastructure | Agent: ca-new-issue-creator
Author
Owner

⚠️ Orphan Issue — Manual Linking Required

This issue was created without a known parent Epic. Per CONTRIBUTING.md, regular issues must not be orphans — they must be linked to a parent Epic using Forgejo's dependency system (child blocks parent).

Action required for a human reviewer:

  1. Identify the appropriate parent Epic for this issue. Candidates include:
    • #946 — Epic: Stub Package Cleanup (if the acp module is being cleaned up/deprecated)
    • #933 — Epic: A2A Protocol Compliance (if this work is redirected to a2a tests)
    • A new "Missing Test Levels" Epic (if one needs to be created for systematic test coverage gaps)
  2. Create the dependency link so that this issue blocks the parent Epic.
  3. Update the ## Metadata section of this issue to reflect the correct **Parent Epic**.

Automated by CleverAgents Bot
Supervisor: Test Infrastructure | Agent: ca-new-issue-creator

⚠️ **Orphan Issue — Manual Linking Required** This issue was created without a known parent Epic. Per `CONTRIBUTING.md`, regular issues must not be orphans — they must be linked to a parent Epic using Forgejo's dependency system (child **blocks** parent). **Action required for a human reviewer:** 1. Identify the appropriate parent Epic for this issue. Candidates include: - **#946** — Epic: Stub Package Cleanup (if the `acp` module is being cleaned up/deprecated) - **#933** — Epic: A2A Protocol Compliance (if this work is redirected to `a2a` tests) - A new "Missing Test Levels" Epic (if one needs to be created for systematic test coverage gaps) 2. Create the dependency link so that this issue **blocks** the parent Epic. 3. Update the `## Metadata` section of this issue to reflect the correct `**Parent Epic**`. --- **Automated by CleverAgents Bot** Supervisor: Test Infrastructure | Agent: ca-new-issue-creator
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#3703
No description provided.