bug(testing): TDD infrastructure fails to invert non-AssertionError exceptions in expected-fail tests #3472

New issue

Open

opened 2026-04-05 18:11:04 +00:00 by freemo · 2 comments

freemo commented

2026-04-05 18:11:04 +00:00

Owner

Description

The TDD support infrastructure in features/environment.py incorrectly handles tests marked with @tdd_expected_fail.

The apply_tdd_inversion function contains a guard that prevents it from inverting test results if the failure is caused by any exception other than an AssertionError.

This is incorrect. The purpose of a TDD bug-capture test is often to reproduce a specific, non-assertion exception (e.g., JSONDecodeError, TypeError, KeyError). The current logic misclassifies these expected exceptions as infrastructure failures, which causes the test runner to exit with a non-zero code, breaking the TDD workflow.

Acceptance Criteria

The guard for non-AssertionError exceptions in apply_tdd_inversion is removed.
A test tagged with @tdd_expected_fail that fails with any exception type should be correctly inverted and result in a nox exit code of 0.

## Description The TDD support infrastructure in `features/environment.py` incorrectly handles tests marked with `@tdd_expected_fail`. The `apply_tdd_inversion` function contains a guard that prevents it from inverting test results if the failure is caused by any exception other than an `AssertionError`. This is incorrect. The purpose of a TDD bug-capture test is often to reproduce a specific, non-assertion exception (e.g., `JSONDecodeError`, `TypeError`, `KeyError`). The current logic misclassifies these expected exceptions as infrastructure failures, which causes the test runner to exit with a non-zero code, breaking the TDD workflow. ## Acceptance Criteria - The guard for non-`AssertionError` exceptions in `apply_tdd_inversion` is removed. - A test tagged with `@tdd_expected_fail` that fails with any exception type should be correctly inverted and result in a `nox` exit code of 0.

freemo added this to the v3.7.0 milestone

2026-04-05 18:12:33 +00:00

freemo commented

2026-04-05 18:12:37 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Backlog (confirmed) — TDD infrastructure bug affecting test inversion for non-AssertionError exceptions. Important for test reliability.
Milestone: v3.7.0 (assigned — test infrastructure improvement)
Story Points: 2 (S) — Fix exception handling in TDD test infrastructure
MoSCoW: Should Have — TDD infrastructure reliability affects developer productivity and test quality. Not blocking current milestones but important for ongoing development.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Backlog (confirmed) — TDD infrastructure bug affecting test inversion for non-AssertionError exceptions. Important for test reliability. - **Milestone**: v3.7.0 (assigned — test infrastructure improvement) - **Story Points**: 2 (S) — Fix exception handling in TDD test infrastructure - **MoSCoW**: Should Have — TDD infrastructure reliability affects developer productivity and test quality. Not blocking current milestones but important for ongoing development. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner

freemo referenced this issue

2026-04-05 18:13:11 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this issue

2026-04-05 19:03:53 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo commented

2026-04-05 19:06:42 +00:00

Author

Owner

Transitioning issue #3472 to State/In Progress.

Preconditions checked:

Current State label: State/Verified present; no Blocked label detected.
No blocker in place; precondition satisfied for In Progress.

Planned actions:

Remove old State/* label(s): State/Verified
Add new State/In Progress label
Do not close issue (transition is to In Progress, not Completed)

Status: Unable to apply label changes with the current Forgejo API tooling in this environment. The API wrapper provided does not expose direct label management endpoints. I can perform the changes if you authorize/enable label editing endpoints, or if you provide a workaround (e.g., a direct REST call).

Current labels on the issue (before): [State/Verified, MoSCoW/Should Have, Priority/Backlog, Type/Bug]
Expected labels after transition (if applied): [State/In Progress, MoSCoW/Should Have, Priority/Backlog, Type/Bug]

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-state-updater

Transitioning issue #3472 to State/In Progress. Preconditions checked: - Current State label: State/Verified present; no Blocked label detected. - No blocker in place; precondition satisfied for In Progress. Planned actions: - Remove old State/* label(s): State/Verified - Add new State/In Progress label - Do not close issue (transition is to In Progress, not Completed) Status: Unable to apply label changes with the current Forgejo API tooling in this environment. The API wrapper provided does not expose direct label management endpoints. I can perform the changes if you authorize/enable label editing endpoints, or if you provide a workaround (e.g., a direct REST call). Current labels on the issue (before): [State/Verified, MoSCoW/Should Have, Priority/Backlog, Type/Bug] Expected labels after transition (if applied): [State/In Progress, MoSCoW/Should Have, Priority/Backlog, Type/Bug] --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-state-updater

freemo referenced this issue

2026-04-05 19:07:15 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this issue from a commit

2026-04-05 19:19:21 +00:00

bug(testing): TDD infrastructure fails to invert non-AssertionError exceptions in expected-fail tests

freemo removed this from the v3.7.0 milestone

2026-04-06 23:48:54 +00:00