cleveragents/cleveragents-core

Fork 3

fix(cli): correct session show rich output Session Summary panel field labels and fields #3302

Merged

freemo merged 1 commit from fix/session-show-summary-panel-fields into master

2026-04-05 21:12:16 +00:00

freemo commented

2026-04-05 09:27:05 +00:00

Owner

Summary

Fixes three spec violations in the agents session show rich output Session Summary panel: the session identifier label was Session ID: instead of ID:, an extraneous Namespace: field was present that is not defined in the spec, and the required Automation: field was missing entirely. All deviations are corrected to bring the panel into exact conformance with docs/specification.md.

Changes

Renamed Session ID: label to ID: in src/cleveragents/cli/commands/session.py show() function — the spec defines the session identifier field label as ID: only; the longer form was a spec violation.
Removed Namespace: field from the Session Summary panel — this field has no entry in the docs/specification.md rich output definition for agents session show and must not appear in the panel.
Added Automation: field to the Session Summary panel, sourced from session.metadata.get('automation_profile', '(none)') — this field is required by the spec and was previously absent from the rendered output.
Corrected field order to match the spec exactly: ID → Actor → Messages → Created → Updated → Automation.
Updated features/session_cli.feature with new BDD assertions verifying the presence of the corrected field labels (ID:, Actor:, Messages:, Created:, Updated:, Automation:) and the absence of the removed/renamed labels (Session ID:, Namespace:).
Added a should not contain step definition to features/steps/session_cli_steps.py to support the new negative assertions in the feature file.

The plain, json, yaml, and color output formats are unaffected by this change; only the rich panel string construction in the show() function was modified.

Design Decisions

Source for Automation: value: The automation profile name is read from session.metadata.get('automation_profile', '(none)') rather than a dedicated top-level attribute. This matches the existing metadata storage pattern used elsewhere in the session model and avoids a schema migration. The fallback value (none) is consistent with how other optional string fields are rendered in the panel (e.g., Actor).
Negative test assertions: A new should not contain Behave step was added rather than relying solely on positive assertions. This ensures that the old incorrect labels (Session ID:, Namespace:) cannot silently reappear in a future refactor without a test failure.
No changes to other output formats: The bug is isolated to the rich panel string in show(); the plain, json, yaml, and color renderers have separate code paths and were verified to be unaffected.

Testing

Unit tests (Behave): PASSED — 23 scenarios, 0 failed (nox -s unit_tests -- features/session_cli.feature)
Lint: PASSED (nox -s lint — all checks passed)
Type check: PASSED (nox -s typecheck — 0 errors, 0 warnings)
Security scan: PASSED (nox -s security_scan — no issues identified)

Modules Affected

src/cleveragents/cli/commands/session.py — show() function: Session Summary panel string corrected
features/session_cli.feature — BDD scenarios updated with corrected field label assertions and new negative assertions
features/steps/session_cli_steps.py — New should not contain step definition added

Closes #3040

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

## Summary Fixes three spec violations in the `agents session show` rich output Session Summary panel: the session identifier label was `Session ID:` instead of `ID:`, an extraneous `Namespace:` field was present that is not defined in the spec, and the required `Automation:` field was missing entirely. All deviations are corrected to bring the panel into exact conformance with `docs/specification.md`. ## Changes - **Renamed `Session ID:` label to `ID:`** in `src/cleveragents/cli/commands/session.py` `show()` function — the spec defines the session identifier field label as `ID:` only; the longer form was a spec violation. - **Removed `Namespace:` field** from the Session Summary panel — this field has no entry in the `docs/specification.md` rich output definition for `agents session show` and must not appear in the panel. - **Added `Automation:` field** to the Session Summary panel, sourced from `session.metadata.get('automation_profile', '(none)')` — this field is required by the spec and was previously absent from the rendered output. - **Corrected field order** to match the spec exactly: `ID` → `Actor` → `Messages` → `Created` → `Updated` → `Automation`. - **Updated `features/session_cli.feature`** with new BDD assertions verifying the presence of the corrected field labels (`ID:`, `Actor:`, `Messages:`, `Created:`, `Updated:`, `Automation:`) and the absence of the removed/renamed labels (`Session ID:`, `Namespace:`). - **Added a `should not contain` step definition** to `features/steps/session_cli_steps.py` to support the new negative assertions in the feature file. The `plain`, `json`, `yaml`, and `color` output formats are unaffected by this change; only the rich panel string construction in the `show()` function was modified. ## Design Decisions - **Source for `Automation:` value**: The automation profile name is read from `session.metadata.get('automation_profile', '(none)')` rather than a dedicated top-level attribute. This matches the existing metadata storage pattern used elsewhere in the session model and avoids a schema migration. The fallback value `(none)` is consistent with how other optional string fields are rendered in the panel (e.g., `Actor`). - **Negative test assertions**: A new `should not contain` Behave step was added rather than relying solely on positive assertions. This ensures that the old incorrect labels (`Session ID:`, `Namespace:`) cannot silently reappear in a future refactor without a test failure. - **No changes to other output formats**: The bug is isolated to the rich panel string in `show()`; the `plain`, `json`, `yaml`, and `color` renderers have separate code paths and were verified to be unaffected. ## Testing - **Unit tests (Behave):** PASSED — 23 scenarios, 0 failed (`nox -s unit_tests -- features/session_cli.feature`) - **Lint:** PASSED (`nox -s lint` — all checks passed) - **Type check:** PASSED (`nox -s typecheck` — 0 errors, 0 warnings) - **Security scan:** PASSED (`nox -s security_scan` — no issues identified) ## Modules Affected - `src/cleveragents/cli/commands/session.py` — `show()` function: Session Summary panel string corrected - `features/session_cli.feature` — BDD scenarios updated with corrected field label assertions and new negative assertions - `features/steps/session_cli_steps.py` — New `should not contain` step definition added ## Related Issues Closes #3040 --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo added this to the v3.7.0 milestone

2026-04-05 09:31:06 +00:00

freemo referenced this pull request

2026-04-05 09:46:02 +00:00

UAT: agents session show rich output Session Summary panel uses wrong field labels — "Session ID:" instead of "ID:", includes "Namespace:" not in spec, missing "Automation:" field #3040

freemo reviewed

2026-04-05 16:27:40 +00:00

freemo left a comment

Review Summary

Reviewed PR #3302 with focus on code-maintainability, readability, and documentation.

This is a clean, well-scoped bug fix that corrects three spec violations in the agents session show rich output Session Summary panel. The changes are minimal, targeted, and well-tested.

Reviewer verdict: APPROVED — This PR meets all quality criteria. Posting as COMMENT because Forgejo prevents self-approval; a non-author reviewer should formally approve.

Files Reviewed

File	Change
`src/cleveragents/cli/commands/session.py`	`show()` function: Session Summary panel fields corrected
`features/session_cli.feature`	BDD assertions updated for corrected field labels
`features/steps/session_cli_steps.py`	New `should not contain` step definition added

✅ Specification Compliance

All three deviations identified in issue #3040 are correctly addressed:

Session ID: → ID: — matches spec exactly
Namespace: removed — field not defined in spec
Automation: added — required field now present, sourced from session.metadata.get("automation_profile", "(none)")
Field order matches spec: ID → Actor → Messages → Created → Updated → Automation

The inline comment # Session summary panel — field order per spec: ID, Actor, Messages, Created, Updated, Automation (docs/specification.md §agents session show) is an excellent addition for maintainability — it makes the spec contract visible at the point of use.

✅ CONTRIBUTING.md Compliance

Commit message: Follows Conventional Changelog format exactly: fix(cli): correct session show rich output Session Summary panel field labels and fields
Commit footer: ISSUES CLOSED: #3040 ✓
PR body: Contains Closes #3040 ✓
Milestone: v3.7.0 (matches issue) ✓
Label: Type/Bug present ✓
Branch name: fix/session-show-summary-panel-fields (matches issue metadata) ✓
Single atomic commit: ✓
No forbidden patterns: No # type: ignore or similar suppressions ✓

✅ Test Quality

The test changes are well-crafted:

Positive assertions verify all six corrected field labels: ID:, Actor:, Messages:, Created:, Updated:, Automation:
Negative assertions ensure removed labels cannot silently reappear: Session ID:, Namespace:
The new should not contain step definition is clean, reusable, and follows the same pattern as the existing should contain step
Good assertion error messages that include the actual output for debugging

✅ Code Correctness

The automation variable extraction (session.metadata.get("automation_profile", "(none)")) correctly uses the metadata dict pattern with a sensible fallback
The fallback value (none) is consistent with how other optional fields (e.g., Actor) are rendered
No logic errors, no type safety issues

Deep Dive: Code Maintainability, Readability, Documentation

Maintainability:

The spec-referencing comment makes future maintenance easier — anyone modifying this panel will know to check the spec
The change is isolated to the show() function as claimed; create(), import, and non-rich formats are unaffected
The design decision to source Automation: from session.metadata rather than a dedicated attribute avoids a schema migration — pragmatic and well-documented in the PR description

Readability:

The f-string panel construction is clean and easy to scan
Field order is visually obvious in the code, matching the spec order

Documentation:

PR description is exceptionally thorough: summary, changes, design decisions, testing results, modules affected
The "Design Decisions" section explaining the metadata source and negative test rationale is valuable

Minor Suggestions (Non-blocking)

Pre-existing duplicate "✓ OK" line — The show() function contains two identical lines at the end:
```
console.print("[green bold]✓ OK[/green bold] Session details loaded")
console.print("[green bold]✓ OK[/green bold] Session details loaded")
```
This is a pre-existing bug (present on master), not introduced by this PR. Consider filing a separate issue to remove the duplicate.
Potential false-positive on "ID:" assertion — The test assertion output should contain "ID:" could theoretically match other occurrences of "ID:" in the rich output (e.g., if another panel contains that text). The negative assertion should not contain "Session ID:" is the stronger guard. This is acceptable as-is given the current output structure, but worth noting if the output format evolves.

Decision: APPROVED ✅

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Review Summary Reviewed PR #3302 with focus on **code-maintainability**, **readability**, and **documentation**. This is a clean, well-scoped bug fix that corrects three spec violations in the `agents session show` rich output Session Summary panel. The changes are minimal, targeted, and well-tested. **Reviewer verdict: APPROVED** — This PR meets all quality criteria. Posting as COMMENT because Forgejo prevents self-approval; a non-author reviewer should formally approve. ### Files Reviewed | File | Change | |------|--------| | `src/cleveragents/cli/commands/session.py` | `show()` function: Session Summary panel fields corrected | | `features/session_cli.feature` | BDD assertions updated for corrected field labels | | `features/steps/session_cli_steps.py` | New `should not contain` step definition added | ### ✅ Specification Compliance All three deviations identified in issue #3040 are correctly addressed: 1. **`Session ID:` → `ID:`** — matches spec exactly 2. **`Namespace:` removed** — field not defined in spec 3. **`Automation:` added** — required field now present, sourced from `session.metadata.get("automation_profile", "(none)")` 4. **Field order** matches spec: ID → Actor → Messages → Created → Updated → Automation The inline comment `# Session summary panel — field order per spec: ID, Actor, Messages, Created, Updated, Automation (docs/specification.md §agents session show)` is an excellent addition for maintainability — it makes the spec contract visible at the point of use. ### ✅ CONTRIBUTING.md Compliance - **Commit message**: Follows Conventional Changelog format exactly: `fix(cli): correct session show rich output Session Summary panel field labels and fields` - **Commit footer**: `ISSUES CLOSED: #3040` ✓ - **PR body**: Contains `Closes #3040` ✓ - **Milestone**: v3.7.0 (matches issue) ✓ - **Label**: `Type/Bug` present ✓ - **Branch name**: `fix/session-show-summary-panel-fields` (matches issue metadata) ✓ - **Single atomic commit**: ✓ - **No forbidden patterns**: No `# type: ignore` or similar suppressions ✓ ### ✅ Test Quality The test changes are well-crafted: - **Positive assertions** verify all six corrected field labels: `ID:`, `Actor:`, `Messages:`, `Created:`, `Updated:`, `Automation:` - **Negative assertions** ensure removed labels cannot silently reappear: `Session ID:`, `Namespace:` - The new `should not contain` step definition is clean, reusable, and follows the same pattern as the existing `should contain` step - Good assertion error messages that include the actual output for debugging ### ✅ Code Correctness - The `automation` variable extraction (`session.metadata.get("automation_profile", "(none)")`) correctly uses the metadata dict pattern with a sensible fallback - The fallback value `(none)` is consistent with how other optional fields (e.g., `Actor`) are rendered - No logic errors, no type safety issues ### Deep Dive: Code Maintainability, Readability, Documentation **Maintainability:** - The spec-referencing comment makes future maintenance easier — anyone modifying this panel will know to check the spec - The change is isolated to the `show()` function as claimed; `create()`, `import`, and non-rich formats are unaffected - The design decision to source `Automation:` from `session.metadata` rather than a dedicated attribute avoids a schema migration — pragmatic and well-documented in the PR description **Readability:** - The f-string panel construction is clean and easy to scan - Field order is visually obvious in the code, matching the spec order **Documentation:** - PR description is exceptionally thorough: summary, changes, design decisions, testing results, modules affected - The "Design Decisions" section explaining the metadata source and negative test rationale is valuable ### Minor Suggestions (Non-blocking) 1. **Pre-existing duplicate "✓ OK" line** — The `show()` function contains two identical lines at the end: ```python console.print("[green bold]✓ OK[/green bold] Session details loaded") console.print("[green bold]✓ OK[/green bold] Session details loaded") ``` This is a pre-existing bug (present on `master`), not introduced by this PR. Consider filing a separate issue to remove the duplicate. 2. **Potential false-positive on `"ID:"` assertion** — The test assertion `output should contain "ID:"` could theoretically match other occurrences of "ID:" in the rich output (e.g., if another panel contains that text). The negative assertion `should not contain "Session ID:"` is the stronger guard. This is acceptable as-is given the current output structure, but worth noting if the output format evolves. **Decision: APPROVED** ✅ --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo added a new dependency

2026-04-05 17:40:54 +00:00

#3040 UAT: agents session show rich output Session Summary panel uses wrong field labels — "Session ID:" instead of "ID:", includes "Namespace:" not in spec, missing "Automation:" field

freemo referenced this pull request

2026-04-05 17:41:21 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this pull request

2026-04-05 17:51:24 +00:00

UAT: agents session show rich output Session Summary panel uses wrong field labels — "Session ID:" instead of "ID:", includes "Namespace:" not in spec, missing "Automation:" field #3040

freemo referenced this pull request

2026-04-05 17:51:27 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo commented

2026-04-05 19:43:47 +00:00

Author

Owner

🔍 Code Review — REQUEST CHANGES

Reviewed PR #3302 with focus on specification-compliance, requirements-coverage, and behavior-correctness.

This PR aims to fix three spec violations in the agents session show rich output Session Summary panel (issue #3040): renaming Session ID: → ID:, removing Namespace:, and adding Automation:. The intent is correct and the issue requirements are well-understood. However, the PR branch appears to have been forked from an older version of master and introduces several regressions against the current master codebase, plus a clear duplicate output bug. The PR is also currently not mergeable due to conflicts with master.

Required Changes

1. 🐛 Duplicate "✓ OK Session details loaded" output in `show()`

Location: src/cleveragents/cli/commands/session.py, show() function — near the end of the try block

Issue: The success message is printed twice:

console.print("[green bold]✓ OK[/green bold] Session details loaded")
console.print("[green bold]✓ OK[/green bold] Session details loaded")

Required: Remove the duplicate line. The spec shows a single ✓ OK Session details loaded message.
Reference: docs/specification.md §agents session show — Rich format example shows exactly one status line.

2. 📋 [SPEC/REGRESSION] Linked Plans rendering reverted from table to flat list

Location: src/cleveragents/cli/commands/session.py, show() function — Linked Plans section
Issue: The PR branch uses session.linked_plan_ids with a flat bullet list, but the specification requires a table with Plan ID, Phase, and State columns. The current master already implements this correctly using session.linked_plans with a proper Table widget. This PR reverts that improvement.

Spec requirement (line 1752–1756):

╭─ Linked Plans ────────────────────────────╮
│ Plan ID                     Phase   State     │
│ 01HXM8C2ZK4Q7C2B3F2R4VYV6J  execute  complete │
╰───────────────────────────────────────────╯

Required: Preserve the master's table-based Linked Plans rendering using session.linked_plans with Plan ID/Phase/State columns.

3. 📋 [SPEC/REGRESSION] Token usage formatting lost comma separators

Location: src/cleveragents/cli/commands/session.py, show() function — Token Usage section
Issue: The PR uses {tu.input_tokens} and {tu.output_tokens} without comma formatting. The spec shows 3,420 and 1,185 (comma-separated thousands). Master correctly uses {tu.input_tokens:,}.
Required: Restore comma formatting: {tu.input_tokens:,} and {tu.output_tokens:,}.
Reference: docs/specification.md line 1759–1761.

4. ⚠️ [REGRESSION] Import command rich output reverted to simpler version

Location: src/cleveragents/cli/commands/session.py, import_session() function
Issue: The PR branch reverts the import command's rich output from the current master's 3-panel layout (Session Import + Validation + Merge panels with detailed fields) back to a single simple "Session Imported" panel. This is a significant regression — the master's import output is substantially more informative.
Required: The import command changes are out of scope for this bug fix (which targets only show()). The import function should not be modified. After rebasing onto current master, ensure the import function is preserved as-is.

5. ⚠️ [BEHAVIOR] Automation field source — `session.metadata` vs `session.automation`

Location: src/cleveragents/cli/commands/session.py, show() function
Issue: The PR reads automation from session.metadata.get("automation_profile", "(none)"), but the current master uses session.automation (a proper attribute). Using the metadata dict is fragile and bypasses any domain model validation. The PR description acknowledges this as a design decision to "avoid a schema migration," but session.automation already exists on master.
Required: After rebasing, use session.automation (the domain model attribute) rather than raw metadata dict access.

6. 🔀 Branch needs rebase onto current master

Issue: The PR is marked mergeable: false. The branch was forked from an older master and many of the regressions above stem from this staleness. Several improvements have been merged to master since this branch was created (linked plans table, token formatting, import panels).
Required: Rebase onto current master and resolve conflicts. After rebase, the only changes needed should be isolated to the show() function's Session Summary panel construction — specifically the three fixes from issue #3040.

Good Aspects

✅ Commit message follows Conventional Changelog format exactly as specified in issue metadata
✅ PR metadata is complete: Closes #3040, milestone v3.7.0, Type/Bug label
✅ Branch name matches issue metadata exactly
✅ Test additions are well-designed — the new should not contain step and negative assertions for Session ID: and Namespace: are excellent regression guards
✅ Field order in the Session Summary panel matches the spec: ID → Actor → Messages → Created → Updated → Automation
✅ Issue understanding is correct — all three deviations identified in #3040 are addressed in the PR

Minor Suggestions (Non-blocking)

The test mock in _make_session() does not set metadata with an automation_profile key, so the Automation field will always show (none) in tests. Consider adding a test case where automation has a real value to verify positive rendering.
The _session_summary_dict() helper still includes namespace in its output dict — if Namespace is being removed from the show panel, consider whether it should also be removed from the structured dict output for consistency (though this may be intentional for JSON/YAML formats).

Decision: REQUEST CHANGES 🔄

The core intent of this PR is correct and the issue requirements are well-understood. However, the branch is stale and introduces multiple regressions against current master. After rebasing and preserving master's existing improvements, the actual diff should be quite small — limited to the Session Summary panel field labels/order in the show() function and the corresponding test updates.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## 🔍 Code Review — REQUEST CHANGES Reviewed PR #3302 with focus on **specification-compliance**, **requirements-coverage**, and **behavior-correctness**. This PR aims to fix three spec violations in the `agents session show` rich output Session Summary panel (issue #3040): renaming `Session ID:` → `ID:`, removing `Namespace:`, and adding `Automation:`. The intent is correct and the issue requirements are well-understood. However, the PR branch appears to have been forked from an older version of master and introduces several **regressions** against the current master codebase, plus a clear **duplicate output bug**. The PR is also currently **not mergeable** due to conflicts with master. --- ### Required Changes #### 1. 🐛 **Duplicate "✓ OK Session details loaded" output in `show()`** - **Location:** `src/cleveragents/cli/commands/session.py`, `show()` function — near the end of the try block - **Issue:** The success message is printed **twice**: ```python console.print("[green bold]✓ OK[/green bold] Session details loaded") console.print("[green bold]✓ OK[/green bold] Session details loaded") ``` - **Required:** Remove the duplicate line. The spec shows a single `✓ OK Session details loaded` message. - **Reference:** `docs/specification.md` §agents session show — Rich format example shows exactly one status line. #### 2. 📋 **[SPEC/REGRESSION] Linked Plans rendering reverted from table to flat list** - **Location:** `src/cleveragents/cli/commands/session.py`, `show()` function — Linked Plans section - **Issue:** The PR branch uses `session.linked_plan_ids` with a flat bullet list, but the specification requires a **table** with `Plan ID`, `Phase`, and `State` columns. The current master already implements this correctly using `session.linked_plans` with a proper `Table` widget. This PR reverts that improvement. - **Spec requirement (line 1752–1756):** ``` ╭─ Linked Plans ────────────────────────────╮ │ Plan ID Phase State │ │ 01HXM8C2ZK4Q7C2B3F2R4VYV6J execute complete │ ╰───────────────────────────────────────────╯ ``` - **Required:** Preserve the master's table-based Linked Plans rendering using `session.linked_plans` with Plan ID/Phase/State columns. #### 3. 📋 **[SPEC/REGRESSION] Token usage formatting lost comma separators** - **Location:** `src/cleveragents/cli/commands/session.py`, `show()` function — Token Usage section - **Issue:** The PR uses `{tu.input_tokens}` and `{tu.output_tokens}` without comma formatting. The spec shows `3,420` and `1,185` (comma-separated thousands). Master correctly uses `{tu.input_tokens:,}`. - **Required:** Restore comma formatting: `{tu.input_tokens:,}` and `{tu.output_tokens:,}`. - **Reference:** `docs/specification.md` line 1759–1761. #### 4. ⚠️ **[REGRESSION] Import command rich output reverted to simpler version** - **Location:** `src/cleveragents/cli/commands/session.py`, `import_session()` function - **Issue:** The PR branch reverts the import command's rich output from the current master's 3-panel layout (Session Import + Validation + Merge panels with detailed fields) back to a single simple "Session Imported" panel. This is a significant regression — the master's import output is substantially more informative. - **Required:** The import command changes are **out of scope** for this bug fix (which targets only `show()`). The import function should not be modified. After rebasing onto current master, ensure the import function is preserved as-is. #### 5. ⚠️ **[BEHAVIOR] Automation field source — `session.metadata` vs `session.automation`** - **Location:** `src/cleveragents/cli/commands/session.py`, `show()` function - **Issue:** The PR reads automation from `session.metadata.get("automation_profile", "(none)")`, but the current master uses `session.automation` (a proper attribute). Using the metadata dict is fragile and bypasses any domain model validation. The PR description acknowledges this as a design decision to "avoid a schema migration," but `session.automation` already exists on master. - **Required:** After rebasing, use `session.automation` (the domain model attribute) rather than raw metadata dict access. #### 6. 🔀 **Branch needs rebase onto current master** - **Issue:** The PR is marked `mergeable: false`. The branch was forked from an older master and many of the regressions above stem from this staleness. Several improvements have been merged to master since this branch was created (linked plans table, token formatting, import panels). - **Required:** Rebase onto current master and resolve conflicts. After rebase, the only changes needed should be isolated to the `show()` function's Session Summary panel construction — specifically the three fixes from issue #3040. --- ### Good Aspects - ✅ **Commit message** follows Conventional Changelog format exactly as specified in issue metadata - ✅ **PR metadata** is complete: `Closes #3040`, milestone v3.7.0, `Type/Bug` label - ✅ **Branch name** matches issue metadata exactly - ✅ **Test additions** are well-designed — the new `should not contain` step and negative assertions for `Session ID:` and `Namespace:` are excellent regression guards - ✅ **Field order** in the Session Summary panel matches the spec: ID → Actor → Messages → Created → Updated → Automation - ✅ **Issue understanding** is correct — all three deviations identified in #3040 are addressed in the PR ### Minor Suggestions (Non-blocking) 1. The test mock in `_make_session()` does not set `metadata` with an `automation_profile` key, so the Automation field will always show `(none)` in tests. Consider adding a test case where automation has a real value to verify positive rendering. 2. The `_session_summary_dict()` helper still includes `namespace` in its output dict — if Namespace is being removed from the show panel, consider whether it should also be removed from the structured dict output for consistency (though this may be intentional for JSON/YAML formats). --- **Decision: REQUEST CHANGES** 🔄 The core intent of this PR is correct and the issue requirements are well-understood. However, the branch is stale and introduces multiple regressions against current master. After rebasing and preserving master's existing improvements, the actual diff should be quite small — limited to the Session Summary panel field labels/order in the `show()` function and the corresponding test updates. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo force-pushed fix/session-show-summary-panel-fields from 2e606cd3a4

CI / benchmark-publish (pull_request) Waiting to run

Details

CI / lint (pull_request) Successful in 27s

Details

CI / quality (pull_request) Successful in 36s

Details

CI / typecheck (pull_request) Successful in 1m3s

Details

CI / security (pull_request) Successful in 1m0s

Details

CI / benchmark-regression (pull_request) Waiting to run

Details

CI / build (pull_request) Successful in 31s

Details

CI / helm (pull_request) Successful in 25s

Details

CI / unit_tests (pull_request) Successful in 6m47s

Details

CI / e2e_tests (pull_request) Successful in 18m37s

Details

CI / integration_tests (pull_request) Successful in 22m56s

Details

CI / docker (pull_request) Successful in 1m24s

Details

CI / coverage (pull_request) Successful in 10m22s

Details

CI / status-check (pull_request) Successful in 1s

Details

to e4493e8978

CI / lint (pull_request) Successful in 21s

Details

CI / typecheck (pull_request) Successful in 52s

Details

CI / quality (pull_request) Successful in 35s

Details

CI / security (pull_request) Successful in 1m8s

Details

CI / build (pull_request) Successful in 29s

Details

CI / helm (pull_request) Successful in 22s

Details

CI / unit_tests (pull_request) Failing after 6m49s

Details

CI / docker (pull_request) Has been skipped

Details

CI / e2e_tests (pull_request) Successful in 17m4s

Details

CI / integration_tests (pull_request) Failing after 22m47s

Details

CI / coverage (pull_request) Successful in 10m57s

Details

CI / status-check (pull_request) Failing after 1s

Details

CI / benchmark-publish (pull_request) Has been skipped

Details

CI / benchmark-regression (pull_request) Successful in 57m8s

Details

2026-04-05 19:44:15 +00:00

Compare

freemo commented

2026-04-05 19:44:34 +00:00

Author

Owner

Rebased onto latest master and resolved merge conflicts.

Conflict details:

File: src/cleveragents/cli/commands/session.py
The conflict was in the Session Summary panel construction (lines ~376-393)
Master had partially applied the fix (renamed Session ID: → ID:, removed Namespace:) but used session.automation conditionally (only shown when not None)
The PR branch used session.metadata.get("automation_profile", "(none)") and always showed Automation:

Resolution:

Used session.automation (the proper domain model attribute, not metadata dict)
Always shows Automation: field with (none) fallback when the attribute is None
This satisfies the spec requirement that Automation: always appears in the Session Summary panel
Kept the spec-reference comment from the PR branch

The branch is now rebased on 01472648 (latest master) and the PR is mergeable.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

Rebased onto latest master and resolved merge conflicts. **Conflict details:** - File: `src/cleveragents/cli/commands/session.py` - The conflict was in the Session Summary panel construction (lines ~376-393) - Master had partially applied the fix (renamed `Session ID:` → `ID:`, removed `Namespace:`) but used `session.automation` conditionally (only shown when not None) - The PR branch used `session.metadata.get("automation_profile", "(none)")` and always showed `Automation:` **Resolution:** - Used `session.automation` (the proper domain model attribute, not metadata dict) - Always shows `Automation:` field with `(none)` fallback when the attribute is None - This satisfies the spec requirement that `Automation:` always appears in the Session Summary panel - Kept the spec-reference comment from the PR branch The branch is now rebased on `01472648` (latest master) and the PR is mergeable. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo referenced this pull request

2026-04-05 19:48:58 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this pull request

2026-04-05 20:07:24 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3572

freemo referenced this pull request

2026-04-05 20:54:57 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this pull request

2026-04-05 21:00:52 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377