cleveragents/cleveragents-core

Fork 3

fix(a2a): rename A2aErrorDetail.details to data per JSON-RPC 2.0 spec #3281

Merged

freemo merged 1 commit from fix/a2a-error-detail-data-field into master

2026-04-05 21:08:46 +00:00

freemo commented

2026-04-05 09:05:11 +00:00

Owner

Summary

Renames the A2aErrorDetail.details field to data to comply with the JSON-RPC 2.0 specification (§5.1), which mandates that the optional error detail field be named data. This was a wire-format bug causing serialized A2A error responses to emit a non-standard details key instead of the spec-required data key.

Changes

src/cleveragents/a2a/models.py: Renamed the details field to data on the A2aErrorDetail model. This is the sole change required to bring the serialized JSON-RPC error object into compliance — no other call sites needed updating because all existing usages only set code and message on A2aErrorDetail, leaving the optional detail field unpopulated.
features/a2a_jsonrpc_wire_format.feature: Added 3 new BDD scenarios (TDD-first) that assert A2aErrorDetail serializes with a data field and does not emit a details field, covering: presence of data key, absence of details key, and correct round-trip value fidelity.
features/steps/a2a_jsonrpc_wire_format_steps.py: Added corresponding Behave step definitions to support the new feature scenarios.

Design Decisions

Surgical fix only: The rename is confined to the single field definition in models.py. No cascading changes were needed because the optional field was not being set at any existing call site.
transport.py and events.py left unchanged: The details= keyword arguments in those files are constructor parameters to A2aNotAvailableError (a separate exception class), not to A2aErrorDetail. They are unrelated to this bug and were correctly left untouched to avoid unintended side effects.
TDD approach: Failing BDD scenarios were written first to pin the expected wire format, then the model was fixed to make them pass. This ensures the regression is captured in the test suite and cannot silently re-emerge.
No version bump to the model schema: The field rename is a bug fix to match the already-published JSON-RPC 2.0 standard; it is not a new feature or a breaking change to any internal contract, since the field was previously unused at all call sites.

Testing

Unit tests (Behave): 3 new scenarios added and passing; 26 pre-existing scenario failures confirmed unrelated to this change
Integration tests (Robot): not applicable to this isolated model field rename
Coverage: maintained at existing level (no net-new logic paths introduced)
nox -e typecheck: 0 errors, 0 warnings
Direct Python verification: all 5 field-level assertions pass (key presence, key absence, value round-trip, model instantiation, serialization output)

Modules Affected

src/cleveragents/a2a/models.py — A2aErrorDetail model definition
features/a2a_jsonrpc_wire_format.feature — BDD feature file (3 scenarios added)
features/steps/a2a_jsonrpc_wire_format_steps.py — Behave step definitions

Closes #2745

Checklist

Typecheck passes (0 errors, 0 warnings)
No references to A2aErrorDetail.details remain in production code
TDD scenarios added and verified
Commit message follows Conventional Changelog format
Implementation aligns with docs/specification.md

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

## Summary Renames the `A2aErrorDetail.details` field to `data` to comply with the JSON-RPC 2.0 specification (§5.1), which mandates that the optional error detail field be named `data`. This was a wire-format bug causing serialized A2A error responses to emit a non-standard `details` key instead of the spec-required `data` key. ## Changes - **`src/cleveragents/a2a/models.py`**: Renamed the `details` field to `data` on the `A2aErrorDetail` model. This is the sole change required to bring the serialized JSON-RPC error object into compliance — no other call sites needed updating because all existing usages only set `code` and `message` on `A2aErrorDetail`, leaving the optional detail field unpopulated. - **`features/a2a_jsonrpc_wire_format.feature`**: Added 3 new BDD scenarios (TDD-first) that assert `A2aErrorDetail` serializes with a `data` field and does **not** emit a `details` field, covering: presence of `data` key, absence of `details` key, and correct round-trip value fidelity. - **`features/steps/a2a_jsonrpc_wire_format_steps.py`**: Added corresponding Behave step definitions to support the new feature scenarios. ## Design Decisions - **Surgical fix only**: The rename is confined to the single field definition in `models.py`. No cascading changes were needed because the optional field was not being set at any existing call site. - **`transport.py` and `events.py` left unchanged**: The `details=` keyword arguments in those files are constructor parameters to `A2aNotAvailableError` (a separate exception class), not to `A2aErrorDetail`. They are unrelated to this bug and were correctly left untouched to avoid unintended side effects. - **TDD approach**: Failing BDD scenarios were written first to pin the expected wire format, then the model was fixed to make them pass. This ensures the regression is captured in the test suite and cannot silently re-emerge. - **No version bump to the model schema**: The field rename is a bug fix to match the already-published JSON-RPC 2.0 standard; it is not a new feature or a breaking change to any internal contract, since the field was previously unused at all call sites. ## Testing - Unit tests (Behave): 3 new scenarios added and passing; 26 pre-existing scenario failures confirmed unrelated to this change - Integration tests (Robot): not applicable to this isolated model field rename - Coverage: maintained at existing level (no net-new logic paths introduced) - `nox -e typecheck`: 0 errors, 0 warnings - Direct Python verification: all 5 field-level assertions pass (key presence, key absence, value round-trip, model instantiation, serialization output) ## Modules Affected - `src/cleveragents/a2a/models.py` — `A2aErrorDetail` model definition - `features/a2a_jsonrpc_wire_format.feature` — BDD feature file (3 scenarios added) - `features/steps/a2a_jsonrpc_wire_format_steps.py` — Behave step definitions ## Related Issues Closes #2745 --- ## Checklist - [x] Typecheck passes (0 errors, 0 warnings) - [x] No references to `A2aErrorDetail.details` remain in production code - [x] TDD scenarios added and verified - [x] Commit message follows Conventional Changelog format - [x] Implementation aligns with docs/specification.md --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo added 1 commit

2026-04-05 09:05:11 +00:00

fix(a2a): rename A2aErrorDetail.details to data per JSON-RPC 2.0 spec

CI / lint (pull_request) Successful in 27s

Details

CI / typecheck (pull_request) Successful in 51s

Details

CI / quality (pull_request) Successful in 30s

Details

CI / security (pull_request) Successful in 1m3s

Details

CI / build (pull_request) Successful in 17s

Details

CI / helm (pull_request) Successful in 28s

Details

CI / unit_tests (pull_request) Successful in 6m57s

Details

CI / e2e_tests (pull_request) Successful in 18m7s

Details

CI / integration_tests (pull_request) Successful in 22m32s

Details

CI / docker (pull_request) Successful in 1m20s

Details

CI / coverage (pull_request) Successful in 10m56s

Details

CI / status-check (pull_request) Successful in 1s

Details

CI / benchmark-publish (pull_request) Has been skipped

Details

CI / benchmark-regression (pull_request) Successful in 58m46s

Details

c1ebacd1b9

The A2aErrorDetail model used a field named 'details' for the optional
error payload, but JSON-RPC 2.0 §5.1 and the project specification both
require this field to be named 'data'.

Changes:
- Rename A2aErrorDetail.details -> data in src/cleveragents/a2a/models.py
- Add TDD BDD scenarios to features/a2a_jsonrpc_wire_format.feature that
  verify A2aErrorDetail serializes with 'data' field (not 'details')
- Add corresponding step definitions in a2a_jsonrpc_wire_format_steps.py

No call sites used the 'details' keyword argument when constructing
A2aErrorDetail instances (all existing usages only set code and message),
so no other files required changes.

ISSUES CLOSED: #2745

freemo added the

MoSCoW

Must have

label

2026-04-05 09:11:25 +00:00

freemo commented

2026-04-05 09:11:44 +00:00

Author

Owner

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3281-1775374200]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3281-1775374200] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

freemo referenced this pull request

2026-04-05 09:13:34 +00:00

UAT: A2aErrorDetail uses 'details' field instead of JSON-RPC 2.0 required 'data' field #2745

freemo commented

2026-04-05 09:20:00 +00:00

Author

Owner

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3281-1775373000]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3281-1775373000] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

freemo added this to the v3.8.0 milestone

2026-04-05 09:53:19 +00:00

freemo commented

2026-04-05 09:57:26 +00:00

Author

Owner

✅ Independent Code Review — Approved

Summary

This PR correctly renames A2aErrorDetail.details → data to comply with JSON-RPC 2.0 §5.1, which mandates the optional error detail field be named data. The fix is surgical, well-scoped, and properly tested.

Review Findings

Specification Alignment ✅

JSON-RPC 2.0 §5.1 requires code, message, and optionally data on error objects
The project's own docs/reference/a2a.md §Error Code Taxonomy shows "data" in the wire format example
The A2aResponse docstring already documented the correct "data" field name — only the model field was wrong
Fix brings the implementation into alignment with both specs

Code Correctness ✅

Single-line field rename in models.py — minimal blast radius
Verified no remaining references to A2aErrorDetail.details in production code (git grep confirms)
transport.py and events.py details= kwargs are correctly left untouched — they pass to A2aNotAvailableError (a separate exception class), not to A2aErrorDetail
Mutable default data: dict[str, Any] = {} is safe because Pydantic v2 creates fresh copies per instance

Test Quality ✅

3 new BDD scenarios cover meaningful behavior:
1. Serialization produces data key (not details) with populated data
2. Default empty data key present (not details) when no data provided
3. Round-trip value fidelity of the data payload
Step definitions have clear assertion messages for debugging
Tests are regression-proof — they pin the wire format so this bug cannot silently re-emerge

Commit Message ✅

Follows Conventional Changelog: fix(a2a): rename A2aErrorDetail.details to data per JSON-RPC 2.0 spec
Body explains the "why" clearly
Footer: ISSUES CLOSED: #2745

Process Compliance ✅

PR body has Closes #2745
Type/Bug label present
Milestone v3.8.0 set (was missing, corrected during review)
Single commit — will use merge style

Minor Observations (non-blocking)

import json is redundantly repeated inside step_create_error_detail_with_data() when it's already imported at the file's top level. Harmless but unnecessary.
The # type: ignore comments in the step file's except ImportError fallback block are pre-existing (not introduced by this PR) and are in test code, not production code.

Verdict

Clean, correct, well-tested bug fix. No concerns. Approved for merge.

CI is currently pending — scheduling merge for when all checks pass.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## ✅ Independent Code Review — Approved ### Summary This PR correctly renames `A2aErrorDetail.details` → `data` to comply with JSON-RPC 2.0 §5.1, which mandates the optional error detail field be named `data`. The fix is surgical, well-scoped, and properly tested. ### Review Findings #### Specification Alignment ✅ - JSON-RPC 2.0 §5.1 requires `code`, `message`, and optionally `data` on error objects - The project's own `docs/reference/a2a.md` §Error Code Taxonomy shows `"data"` in the wire format example - The `A2aResponse` docstring already documented the correct `"data"` field name — only the model field was wrong - Fix brings the implementation into alignment with both specs #### Code Correctness ✅ - Single-line field rename in `models.py` — minimal blast radius - Verified no remaining references to `A2aErrorDetail.details` in production code (`git grep` confirms) - `transport.py` and `events.py` `details=` kwargs are correctly left untouched — they pass to `A2aNotAvailableError` (a separate exception class), not to `A2aErrorDetail` - Mutable default `data: dict[str, Any] = {}` is safe because Pydantic v2 creates fresh copies per instance #### Test Quality ✅ - 3 new BDD scenarios cover meaningful behavior: 1. Serialization produces `data` key (not `details`) with populated data 2. Default empty `data` key present (not `details`) when no data provided 3. Round-trip value fidelity of the `data` payload - Step definitions have clear assertion messages for debugging - Tests are regression-proof — they pin the wire format so this bug cannot silently re-emerge #### Commit Message ✅ - Follows Conventional Changelog: `fix(a2a): rename A2aErrorDetail.details to data per JSON-RPC 2.0 spec` - Body explains the "why" clearly - Footer: `ISSUES CLOSED: #2745` #### Process Compliance ✅ - PR body has `Closes #2745` - `Type/Bug` label present - Milestone v3.8.0 set (was missing, corrected during review) - Single commit — will use `merge` style #### Minor Observations (non-blocking) - `import json` is redundantly repeated inside `step_create_error_detail_with_data()` when it's already imported at the file's top level. Harmless but unnecessary. - The `# type: ignore` comments in the step file's `except ImportError` fallback block are pre-existing (not introduced by this PR) and are in test code, not production code. ### Verdict Clean, correct, well-tested bug fix. No concerns. Approved for merge. CI is currently pending — scheduling merge for when all checks pass. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo scheduled this pull request to auto merge when all checks succeed

2026-04-05 10:00:15 +00:00

freemo referenced this pull request

2026-04-05 10:00:39 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3124

freemo referenced this pull request

2026-04-05 10:02:58 +00:00

UAT: A2aErrorDetail uses 'details' field instead of JSON-RPC 2.0 required 'data' field #2745

freemo reviewed

2026-04-05 10:17:59 +00:00

freemo left a comment

Self-Review: APPROVED ✅

Note

: Cannot formally approve via Forgejo API since the PR was authored by the same account. Posting as a COMMENT review instead. The review conclusion is APPROVE.

Summary

What was reviewed

src/cleveragents/a2a/models.py — Single-field rename from details to data on A2aErrorDetail. Clean and correct.
features/a2a_jsonrpc_wire_format.feature — 3 new BDD scenarios covering: key presence (data), key absence (details), and value round-trip fidelity. Well-structured TDD approach.
features/steps/a2a_jsonrpc_wire_format_steps.py — Corresponding step definitions. Correct use of regex step matcher consistent with the rest of the file.
Cross-references verified: Checked errors.py, facade.py, __init__.py, and all step files. The details= parameters in errors.py are exception constructor args (for A2aError subclasses), not A2aErrorDetail model fields — correctly left untouched.
Spec alignment: docs/reference/a2a.md §Error Code Taxonomy confirms the wire format uses "data" in the error object. This fix brings the model into compliance.

Findings

Category	Status
Spec alignment	✅ Matches JSON-RPC 2.0 and `docs/reference/a2a.md`
Correctness	✅ Field rename is complete; no stale references remain
Test quality	✅ 3 meaningful BDD scenarios with good coverage of the fix
API consistency	✅ No breaking changes to call sites (field was unused)
Code quality	✅ Clean, minimal diff
Security	✅ No concerns

Minor note (non-blocking)

step_create_error_detail_with_data has a redundant import json inside the function body — json is already imported at the top of the file. Cosmetic only.
PR is missing a milestone (issue #2745 has v3.8.0). Consider adding for tracking consistency.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Self-Review: APPROVED ✅ > **Note**: Cannot formally approve via Forgejo API since the PR was authored by the same account. Posting as a COMMENT review instead. The review conclusion is **APPROVE**. ### Summary This PR correctly renames `A2aErrorDetail.details` → `data` to comply with JSON-RPC 2.0 §5.1, which mandates the optional error detail field be named `data`. The fix is surgical, well-scoped, and properly tested. ### What was reviewed - **`src/cleveragents/a2a/models.py`** — Single-field rename from `details` to `data` on `A2aErrorDetail`. Clean and correct. - **`features/a2a_jsonrpc_wire_format.feature`** — 3 new BDD scenarios covering: key presence (`data`), key absence (`details`), and value round-trip fidelity. Well-structured TDD approach. - **`features/steps/a2a_jsonrpc_wire_format_steps.py`** — Corresponding step definitions. Correct use of regex step matcher consistent with the rest of the file. - **Cross-references verified**: Checked `errors.py`, `facade.py`, `__init__.py`, and all step files. The `details=` parameters in `errors.py` are exception constructor args (for `A2aError` subclasses), not `A2aErrorDetail` model fields — correctly left untouched. - **Spec alignment**: `docs/reference/a2a.md` §Error Code Taxonomy confirms the wire format uses `"data"` in the error object. This fix brings the model into compliance. ### Findings | Category | Status | |---|---| | Spec alignment | ✅ Matches JSON-RPC 2.0 and `docs/reference/a2a.md` | | Correctness | ✅ Field rename is complete; no stale references remain | | Test quality | ✅ 3 meaningful BDD scenarios with good coverage of the fix | | API consistency | ✅ No breaking changes to call sites (field was unused) | | Code quality | ✅ Clean, minimal diff | | Security | ✅ No concerns | ### Minor note (non-blocking) - `step_create_error_detail_with_data` has a redundant `import json` inside the function body — `json` is already imported at the top of the file. Cosmetic only. - PR is missing a milestone (issue #2745 has v3.8.0). Consider adding for tracking consistency. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

features/steps/a2a_jsonrpc_wire_format_steps.py

Minor nit (non-blocking): json is already imported at the top of this file (line 3). This inner import json is redundant and can be removed.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

Minor nit (non-blocking): `json` is already imported at the top of this file (line 3). This inner `import json` is redundant and can be removed. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo referenced this pull request

2026-04-05 10:21:33 +00:00

UAT: A2aErrorDetail uses 'details' field instead of JSON-RPC 2.0 required 'data' field #2745

freemo referenced this pull request

2026-04-05 10:25:57 +00:00

UAT: A2aErrorDetail uses 'details' field instead of JSON-RPC 2.0 required 'data' field #2745

freemo reviewed

2026-04-05 19:47:30 +00:00

freemo left a comment

Independent Code Review — PR #3281

Note

: Cannot formally approve via Forgejo API since the PR was authored by the same account. Posting as a COMMENT review instead. The review conclusion is APPROVE.

Review Focus Areas

api-consistency, naming-conventions, code-patterns

Summary

This PR renames A2aErrorDetail.details → data to comply with JSON-RPC 2.0 §5.1, which mandates the optional error detail field be named data. The fix is surgical, correct, and well-tested.

Specification Alignment ✅

JSON-RPC 2.0 §5.1 requires error objects to have code, message, and optionally data — not details.
docs/reference/a2a.md §Error Code Taxonomy explicitly shows "data" in the example error response wire format:
```
{"error": {"code": -32001, "message": "Plan not found", "data": {"plan_id": "01HXRCF1..."}}}
```
The A2aResponse docstring already documented the correct "data" field name — only the model field was wrong.
Fix brings the implementation into alignment with both the external spec and the project's own reference documentation.

Deep Dive: API Consistency ✅

Cross-model consistency: A2aEvent already uses data: dict[str, Any] = {} for its payload field. The rename brings A2aErrorDetail into naming consistency with sibling models in the same file.
Docstring consistency: The A2aErrorDetail docstring already read {"code": ..., "message": ..., "data": {...}} — the field name was the only inconsistency.
No call-site breakage: Verified that no existing code passes details= to A2aErrorDetail. The details= kwargs in transport.py and events.py are constructor parameters to A2aNotAvailableError (a separate exception class), correctly left untouched.

Deep Dive: Naming Conventions ✅

data aligns with the JSON-RPC 2.0 standard field name.
Consistent with the project's existing naming pattern (A2aEvent.data, A2aRequest.params).
Branch name fix/a2a-error-detail-data-field matches the issue metadata exactly.
Commit message follows Conventional Changelog format precisely.

Deep Dive: Code Patterns ✅

The mutable default data: dict[str, Any] = {} is safe with Pydantic v2 (creates fresh copies per instance) — consistent with the same pattern used by A2aRequest.params and A2aEvent.data in the same file.
Field validators and model structure remain unchanged and correct.
The __all__ export list is unaffected (exports the class, not individual fields).

Test Quality ✅

3 new BDD scenarios added to features/a2a_jsonrpc_wire_format.feature:

"A2aErrorDetail serialises with data field not details" — Asserts data key present AND details key absent with populated data. Good positive+negative coverage.
"A2aErrorDetail serialises with empty data by default" — Tests the default (no data provided) case. Ensures the default empty dict still serializes as data, not details.
"A2aErrorDetail data field preserves payload values" — Round-trip value fidelity test. Ensures the data payload content is preserved through serialization.

Step definitions are well-structured with clear assertion messages for debugging. The TDD approach (tests written first) is documented and appropriate.

Process Compliance ✅

Criterion	Status
Commit message format	✅ `fix(a2a): rename A2aErrorDetail.details to data per JSON-RPC 2.0 spec`
Commit footer	✅ `ISSUES CLOSED: #2745`
PR closing keyword	✅ `Closes #2745`
Milestone	✅ v3.8.0 (matches issue)
`Type/` label	✅ `Type/Bug`
Single atomic commit	✅ One commit, clean history
Branch name matches issue	✅ `fix/a2a-error-detail-data-field`

Minor Observations (Non-blocking)

Redundant import json in step_create_error_detail_with_data() (line ~280 of steps file) — json is already imported at the top of the file. Harmless but unnecessary duplication.
Pre-existing # type: ignore comments in the except ImportError fallback block — these are present on master and were not introduced by this PR. They exist in test code (not production code) as a fallback for when the module isn't installed. Not a concern for this review, but worth noting for future cleanup.

Verdict

Clean, correct, spec-aligned bug fix with meaningful test coverage. The rename brings A2aErrorDetail into consistency with both the JSON-RPC 2.0 standard and sibling models in the same file. No issues found that would block merge.

Decision: APPROVED ✅

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Code Review — PR #3281 > **Note**: Cannot formally approve via Forgejo API since the PR was authored by the same account. Posting as a COMMENT review instead. The review conclusion is **APPROVE**. ### Review Focus Areas **api-consistency**, **naming-conventions**, **code-patterns** ### Summary This PR renames `A2aErrorDetail.details` → `data` to comply with JSON-RPC 2.0 §5.1, which mandates the optional error detail field be named `data`. The fix is surgical, correct, and well-tested. --- ### Specification Alignment ✅ - **JSON-RPC 2.0 §5.1** requires error objects to have `code`, `message`, and optionally `data` — not `details`. - **`docs/reference/a2a.md` §Error Code Taxonomy** explicitly shows `"data"` in the example error response wire format: ```json {"error": {"code": -32001, "message": "Plan not found", "data": {"plan_id": "01HXRCF1..."}}} ``` - The `A2aResponse` docstring already documented the correct `"data"` field name — only the model field was wrong. - Fix brings the implementation into alignment with both the external spec and the project's own reference documentation. ### Deep Dive: API Consistency ✅ - **Cross-model consistency**: `A2aEvent` already uses `data: dict[str, Any] = {}` for its payload field. The rename brings `A2aErrorDetail` into naming consistency with sibling models in the same file. - **Docstring consistency**: The `A2aErrorDetail` docstring already read `{"code": ..., "message": ..., "data": {...}}` — the field name was the only inconsistency. - **No call-site breakage**: Verified that no existing code passes `details=` to `A2aErrorDetail`. The `details=` kwargs in `transport.py` and `events.py` are constructor parameters to `A2aNotAvailableError` (a separate exception class), correctly left untouched. ### Deep Dive: Naming Conventions ✅ - `data` aligns with the JSON-RPC 2.0 standard field name. - Consistent with the project's existing naming pattern (`A2aEvent.data`, `A2aRequest.params`). - Branch name `fix/a2a-error-detail-data-field` matches the issue metadata exactly. - Commit message follows Conventional Changelog format precisely. ### Deep Dive: Code Patterns ✅ - The mutable default `data: dict[str, Any] = {}` is safe with Pydantic v2 (creates fresh copies per instance) — consistent with the same pattern used by `A2aRequest.params` and `A2aEvent.data` in the same file. - Field validators and model structure remain unchanged and correct. - The `__all__` export list is unaffected (exports the class, not individual fields). ### Test Quality ✅ 3 new BDD scenarios added to `features/a2a_jsonrpc_wire_format.feature`: 1. **"A2aErrorDetail serialises with data field not details"** — Asserts `data` key present AND `details` key absent with populated data. Good positive+negative coverage. 2. **"A2aErrorDetail serialises with empty data by default"** — Tests the default (no data provided) case. Ensures the default empty dict still serializes as `data`, not `details`. 3. **"A2aErrorDetail data field preserves payload values"** — Round-trip value fidelity test. Ensures the data payload content is preserved through serialization. Step definitions are well-structured with clear assertion messages for debugging. The TDD approach (tests written first) is documented and appropriate. ### Process Compliance ✅ | Criterion | Status | |---|---| | Commit message format | ✅ `fix(a2a): rename A2aErrorDetail.details to data per JSON-RPC 2.0 spec` | | Commit footer | ✅ `ISSUES CLOSED: #2745` | | PR closing keyword | ✅ `Closes #2745` | | Milestone | ✅ v3.8.0 (matches issue) | | `Type/` label | ✅ `Type/Bug` | | Single atomic commit | ✅ One commit, clean history | | Branch name matches issue | ✅ `fix/a2a-error-detail-data-field` | ### Minor Observations (Non-blocking) 1. **Redundant `import json`** in `step_create_error_detail_with_data()` (line ~280 of steps file) — `json` is already imported at the top of the file. Harmless but unnecessary duplication. 2. **Pre-existing `# type: ignore` comments** in the `except ImportError` fallback block — these are present on `master` and were not introduced by this PR. They exist in test code (not production code) as a fallback for when the module isn't installed. Not a concern for this review, but worth noting for future cleanup. ### Verdict Clean, correct, spec-aligned bug fix with meaningful test coverage. The rename brings `A2aErrorDetail` into consistency with both the JSON-RPC 2.0 standard and sibling models in the same file. No issues found that would block merge. **Decision: APPROVED** ✅ --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo referenced this pull request

2026-04-05 19:48:58 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo referenced this pull request

2026-04-05 21:00:52 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo merged commit 62f90d4db2 into master

2026-04-05 21:08:37 +00:00

freemo referenced this pull request

2026-04-05 22:16:28 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 (Resumed) #3654

freemo removed this from the v3.8.0 milestone