fix(cli): remove --namespace/-n option from agents plan list per spec #3267
No reviewers
Labels
No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
cleveragents/cleveragents-core!3267
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/plan-list-remove-namespace-option"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Removes the incorrectly implemented
--namespace/-noption from theagents plan listCLI command, which deviated from the specification. The spec definesagents plan listwith only--phase,--state,--project,--action, and an optional<REGEX>positional argument — namespace filtering is already achievable via the<REGEX>argument (e.g.agents plan list "^myteam/").Changes
namespaceparameter fromlifecycle_list_plans()insrc/cleveragents/cli/commands/plan.py— the--namespace/-nClick option and its corresponding function parameter have been deletednamespace=namespacefromservice.list_plans()call — the CLI no longer passes a namespace argument to the service layerNamespace:row from TUI Filters panel — the filter display panel no longer renders a namespace filter entry, keeping the UI consistent with the speclifecycle_list_plans()to remove all--namespaceflag referencesfeatures/plan_cli_spec_alignment.featurethat were testing the now-removed optionfeatures/steps/plan_cli_spec_alignment_steps.pyfor the deleted scenariosDesign Decisions
The
--namespace/-noption was an undocumented deviation fromdocs/specification.md, which defines theagents plan listsignature as:No
--namespaceoption appears in the spec. Namespace-scoped listing is already supported by the positional<REGEX>argument — users can pass a regex anchored to a namespace prefix (e.g."^myteam/") to achieve the same filtering without a dedicated flag.The service layer's
list_plans()method intentionally retains itsnamespaceparameter, as other internal callers (non-CLI) may rely on it. Only the CLI surface is corrected here, keeping the fix minimal and non-breaking for programmatic consumers.Testing
Modules Affected
src/cleveragents/cli/commands/plan.py— CLI command definition and TUI filter panelfeatures/plan_cli_spec_alignment.feature— Behave feature file (4 scenarios removed)features/steps/plan_cli_spec_alignment_steps.py— Behave step definitions (namespace steps removed)Closes #2986
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker
Remove the --namespace/-n option from the agents plan list CLI command as it is not defined in the specification. The spec defines: agents plan list [--phase <PHASE>] [--state <STATE>] [--project <PROJECT>] [--action <ACTION>] [<REGEX>] Namespace filtering is already supported via the positional <REGEX> argument (e.g. 'agents plan list "^myteam/"'). Changes: - Remove namespace parameter from lifecycle_list_plans() function - Remove namespace=namespace from service.list_plans() call - Remove Namespace row from TUI Filters panel - Update docstring examples to remove --namespace references - Update filter panel condition to exclude namespace check - Remove 4 namespace-related scenarios from plan_cli_spec_alignment.feature - Remove corresponding step definitions from plan_cli_spec_alignment_steps.py ISSUES CLOSED: #2986🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3267-1775373600]
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3267-1775373000]
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
Self-Review: APPROVED ✅
(Posted as COMMENT because Forgejo prevents self-approval — this PR was authored by the same account.)
Summary
This PR correctly removes the
--namespace/-noption fromagents plan list, which was an undocumented deviation from the specification. The spec defines the command signature as:No
--namespaceoption appears in the spec, and namespace filtering is already achievable via the<REGEX>positional argument (e.g."^myteam/").What was reviewed
list_plans()retainsnamespaceparam for internal callers@when+ 1@thencleanly removedType/Buglabel, has milestoneDesign decision endorsement
The choice to only remove the CLI surface while preserving the service layer's
namespaceparameter is the right call — it keeps the fix minimal and non-breaking for any internal programmatic consumers.Verdict
Clean, well-scoped fix. No issues found. Code review complete — ready for merge once CI passes and approval requirements are met.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer
✅ Independent Review — Approved (Self-Review)
What was reviewed
All three changed files were reviewed against the specification and project conventions:
src/cleveragents/cli/commands/plan.py— CLI command definitionfeatures/plan_cli_spec_alignment.feature— Behave scenariosfeatures/steps/plan_cli_spec_alignment_steps.py— Step definitionsSpecification Alignment ✓
The spec defines
agents plan listwith only--phase,--state,--project,--action, and<REGEX>. The--namespace/-noption was an undocumented deviation. This PR correctly removes it, and the docstring examples now show the regex-based alternative ("^myteam/").API Consistency ✓
Good design decision to retain the
namespaceparameter in the service layer'slist_plans()method for internal callers while removing only the CLI surface. This keeps the fix minimal and non-breaking for programmatic consumers.Test Quality ✓
Four namespace-related Behave scenarios and their step definitions are properly removed. No orphaned steps remain. Remaining scenarios are unaffected.
Correctness ✓
namespacereferences in plan.py are fornamespaced_nameplan properties — completely unrelated)active_filterslist no longer includes the Namespace rowCode Quality ✓
Clean, focused removal. No unnecessary changes. Diff is minimal and well-scoped.
Commit Format ✓
fix(cli): remove --namespace/-n from agents plan list commandISSUES CLOSED: #2986footer presentPR Metadata ✓
Type/Buglabel ✓Closes #2986in body ✓No concerns. Clean spec-alignment fix.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer
Independent Code Review — APPROVED ✅
Review Focus Areas
Files Reviewed
src/cleveragents/cli/commands/plan.py--namespace/-noption, service call arg, TUI filter row, docstring examples, filter conditionfeatures/plan_cli_spec_alignment.featurefeatures/steps/plan_cli_spec_alignment_steps.py@when+ 1@then)Specification Compliance ✅
The formal command synopsis in
docs/specification.md(lines 323–324 and 12109–12112) defines:No
--namespaceoption appears in the authoritative synopsis. Thedocs/reference/plan_cli.mdoptions table (lines 110–117) also omits--namespace. This PR correctly aligns the CLI implementation with the spec.Requirements Coverage ✅
All subtasks from issue #2986 are addressed:
namespaceparameter removed fromlifecycle_list_plans()function signaturenamespace=namespaceremoved fromservice.list_plans()callNamespace:row removed from TUI Filters panel--namespacereferencesBehavior Correctness ✅
list_plans()method retains itsnamespaceparameter for internal/programmatic callers — correct design decision to keep the fix minimal and non-breaking.agents plan list "^myteam/"per the spec's<REGEX>positional argument.namespacereferences inplan.py(e.g.,namespaced_name,validate_namespaced_actor) are unrelated to the removed CLI option.namespace.Code Quality ✅
ISSUES CLOSED: #2986Type/Buglabel presentObservations (Non-blocking)
Milestone Discrepancy: Issue #2986 is on milestone v3.2.0, but this PR is on milestone v3.7.0. Per CONTRIBUTING.md, PRs should be assigned to the same milestone as their linked issue. This metadata should be reconciled.
Spec Internal Contradiction (Informational): The specification itself contains contradictory content — the formal command synopsis (lines 323–324, 12109–12112) omits
--namespace, but the "Multi-User Workflow" examples (lines 41938, 41971) still useagents plan list --namespace myteamand show aNamespace:row in the Filters panel (line 41953). A follow-up issue should be filed to update those spec examples to use the regex approach instead (e.g.,agents plan list "^myteam/").Verdict
Clean, well-scoped spec-alignment fix. All requirements met. No code correctness issues found. The two observations above are non-blocking metadata/documentation items.
Recommendation: APPROVE ✅
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer
Independent Code Review — PR #3267
Review Focus Areas
specification-compliance | behavior-correctness | api-consistency
PR Summary
Removes the
--namespace/-nCLI option fromagents plan list, which was an undocumented deviation from the specification. The spec defines:No
--namespaceoption appears in the authoritative command synopsis. Namespace filtering is already achievable via the<REGEX>positional argument (e.g."^myteam/").Files Reviewed
src/cleveragents/cli/commands/plan.py--namespace/-noption, service call arg, TUI filter row, docstring examples, filter conditionfeatures/plan_cli_spec_alignment.featurefeatures/steps/plan_cli_spec_alignment_steps.py1. Specification Compliance ✅
The spec's
agents plan listcommand synopsis omits--namespace. This PR correctly removes the non-spec option from the CLI surface. The regex alternative (agents plan list "^myteam/") provides equivalent functionality through the spec-defined<REGEX>positional argument.2. Behavior Correctness ✅
Feature file analysis (fully verified via base64 decode):
Plan list with --namespace filter (long form)Plan list with -n namespace filter (short form)Plan list with --namespace shows Namespace in Filters panelPlan list with --namespace combined with --state--phase,--state,--processing-state,--project,--action,<REGEX>, and combined filters--namespaceoptionStep definitions analysis (fully verified via base64 decode):
step_plan_list_namespace(@when— long form--namespace)step_plan_list_short_namespace(@when— short form-n)step_plan_list_namespace_and_state(@when— combined namespace + state)step_plan_list_namespace_passed(@then— verify namespace passed to service)@when/@thenhas a corresponding scenario in the feature file3. API Consistency ✅
Good design decision to retain the
namespaceparameter in the service layer'slist_plans()method while removing only the CLI surface. This:4. Commit & PR Metadata ✅
fix(cli): remove --namespace/-n from agents plan list commandISSUES CLOSED: #2986footerCloses #2986in PR bodyType/Buglabel# type: ignore5. Observations (Non-blocking)
Milestone Discrepancy: Issue #2986 is assigned to milestone v3.2.0, but this PR is assigned to milestone v3.7.0. Per CONTRIBUTING.md, PRs should be assigned to the same milestone as their linked issue. This metadata should be reconciled — either the PR milestone should be updated to v3.2.0, or the issue milestone should be updated to v3.7.0 if the scope has shifted.
Spec Internal Contradiction (Informational): The specification's formal command synopsis omits
--namespace, but the "Multi-User Workflow" narrative examples elsewhere in the spec still referenceagents plan list --namespace myteamand show aNamespace:row in the Filters panel. A follow-up issue should be filed to update those spec examples to use the regex approach (e.g.agents plan list "^myteam/") for full internal consistency.Coverage Impact: The PR removes 4 test scenarios without adding replacements. This is correct since the tested functionality is being removed, but the coverage report should be verified to ensure the ≥97% threshold is maintained after the removal of both code and tests.
Verdict
Clean, well-scoped spec-alignment fix. All three focus areas (specification-compliance, behavior-correctness, api-consistency) pass review. The removal is consistent across CLI code, feature file, and step definitions. No code correctness issues found.
Recommendation: APPROVE ✅ (posted as COMMENT due to review policy)
Automated by CleverAgents Bot
Reviewer: Code Quality | Agent: ca-pr-self-reviewer
Independent Code Review — PR #3267 — APPROVED ✅
Review Focus Areas
specification-compliance | requirements-coverage | behavior-correctness
PR Summary
Removes the
--namespace/-nCLI option fromagents plan list, which was an undocumented deviation from the specification. The spec's authoritative command synopsis (lines 12109–12112) defines:No
--namespaceoption appears. Namespace filtering is already achievable via the<REGEX>positional argument (e.g."^myteam/").Files Reviewed
src/cleveragents/cli/commands/plan.py--namespace/-noption,namespace=namespaceservice call arg,Namespace:TUI filter row, docstring examples, filter conditionfeatures/plan_cli_spec_alignment.featurefeatures/steps/plan_cli_spec_alignment_steps.py@when+ 1@then)1. Specification Compliance ✅
The formal command synopsis in
docs/specification.md(lines 323–324 and 12109–12112) omits--namespace. The Arguments section (lines 12119–12122) lists only--phase,--state,--project, and--action. This PR correctly removes the non-spec option from the CLI surface.The updated docstring examples now show the regex-based alternative (
agents plan list "^myteam/") which is the spec-intended approach for namespace filtering.2. Requirements Coverage ✅
All subtasks from issue #2986 are addressed:
namespaceparameter removed fromlifecycle_list_plans()function signaturenamespace=namespaceremoved fromservice.list_plans()callNamespace:row removed from TUI Filters panel--namespacereferences3. Behavior Correctness ✅
CLI code analysis (verified via full commit diff):
namespaceparameter cleanly removed from function signature (lines 2314–2321)service.list_plans()call no longer passesnamespace=namespace— now only passesphase=phase_filter, project_name=project_idNamespace:row removed from active_filters list (lines 2505–2508)if phase_filter or state_filter or project_id or action_filter:(namespace removed)namespacereferences in plan.py are fornamespaced_nameplan properties andvalidate_namespaced_actor, which are completely unrelatedFeature file analysis (verified via base64 decode and comparison with master):
--namespace, short form-n, Filters panel display, combined--namespace+--state--phase,--state,--processing-state,--project,--action,<REGEX>, and combined filtersStep definitions analysis (verified via base64 decode and comparison with master):
step_plan_list_namespace,step_plan_list_short_namespace,step_plan_list_namespace_and_state,step_plan_list_namespace_passedService layer preserved: The
list_plans()method retains itsnamespaceparameter for internal/programmatic callers — correct design decision to keep the fix minimal and non-breaking.4. Code Quality & Conventions ✅
fix(cli): remove --namespace/-n from agents plan list commandISSUES CLOSED: #2986footerCloses #2986in PR bodyType/Buglabel# type: ignore5. Observations (Non-blocking)
Milestone Discrepancy: Issue #2986 is assigned to milestone v3.2.0, but this PR is assigned to milestone v3.7.0. Per CONTRIBUTING.md, PRs should be assigned to the same milestone as their linked issue. This metadata should be reconciled.
Spec Internal Contradiction: The specification's formal command synopsis omits
--namespace, but the "Multi-User Workflow" narrative examples elsewhere in the spec (lines 41938, 41953, 41971) still referenceagents plan list --namespace myteamand show aNamespace:row in the Filters panel. A follow-up issue should be filed to update those spec examples to use the regex approach (e.g.agents plan list "^myteam/") for full internal consistency. Without this follow-up, the spec will continue to contain contradictory content that could confuse future implementers.Coverage Impact: 4 test scenarios removed without replacements. This is correct since the tested functionality is being removed, but the coverage report should be verified to ensure the ≥97% threshold is maintained.
Verdict
Clean, well-scoped spec-alignment fix. All three focus areas (specification-compliance, requirements-coverage, behavior-correctness) pass review. The removal is consistent across CLI code, feature file, and step definitions. No code correctness issues found. The non-blocking observations above are metadata/documentation items that should be addressed separately.
Decision: APPROVED ✅
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer