fix(sandbox): use spec-required cleveragents/plan-<plan_id> branch naming in GitWorktreeSandbox #3263
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#3263
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "fix/git-worktree-branch-naming"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Fixes a branch naming convention bug in
GitWorktreeSandbox.create()where sandbox branches were being created assandbox/<plan_id>instead of the spec-requiredcleveragents/plan-<plan_id>format. This ensures all CleverAgents-managed git branches are correctly namespaced under thecleveragents/prefix as defined in the specification.Changes
src/cleveragents/infrastructure/sandbox/git_worktree.py:f"sandbox/{safe_plan_id}"tof"cleveragents/plan-{safe_plan_id}"to match the spec-required naming format.cleveragents/plan-<plan_id>instead ofsandbox/<plan_id>), keeping documentation in sync with the implementation.features/steps/git_worktree_coverage_boost_steps.py:sandbox/test→cleveragents/plan-testsandbox/cleanup-test→cleveragents/plan-cleanup-testsandbox/branch-delete-fail→cleveragents/plan-branch-delete-failfeatures/garbage_collection.feature:sandbox/test-plantocleveragents/plan-test-planto align with the corrected naming convention.Design Decisions
cleveragents/namespace prefix: The spec designatescleveragents/as the authoritative namespace for all branches managed by CleverAgents tooling. Using this prefix ensures branches are visually grouped in git clients, avoids collisions with user-created branches, and makes automated cleanup (garbage collection) unambiguous.plan-infix: Theplan-segment distinguishes plan-execution branches from any other future branch types that may be introduced under thecleveragents/namespace. This matches the format shown inagents plan executeoutput in the specification.Testing
cleveragents/plan-{safe_plan_id}is the branch name producedRelated Issues
Closes #2601
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker
- Implemented branch naming change in GitWorktreeSandbox.create() from sandbox/<plan_id> to cleveragents/plan-<plan_id>, located in src/cleveragents/infrastructure/sandbox/git_worktree.py - Updated the create() method docstring to reflect the new branch naming convention - Updated test fixtures: - features/steps/git_worktree_coverage_boost_steps.py: sandbox/test -> cleveragents/plan-test, sandbox/cleanup-test -> cleveragents/plan-cleanup-test, sandbox/branch-delete-fail -> cleveragents/plan-branch-delete-fail - Updated scenario: - features/garbage_collection.feature: sandbox/test-plan -> cleveragents/plan-test-plan - Design rationale: - Adopted the spec-required format: cleveragents/plan-{safe_plan_id} to align with the spec-defined namespace for all CleverAgents-managed git branches - Ensures consistent branch naming across code, tests, and features for easier policy enforcement and maintainability ISSUES CLOSED: #2601🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3263-1775374200]
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3263-1775373000]
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
✅ Review Complete — Clean, spec-aligned bug fix
Review Summary
Scope: Single-line production fix + test fixture updates (3 files, 7 insertions, 7 deletions)
Specification Alignment ✅
agents plan executeoutput clearly showsBranch: cleveragents/plan-01HXM8C2— this fix aligns the implementation with that requirement.cleveragents/namespace prefix is the spec-defined namespace for all CleverAgents-managed git branches.plan-infix correctly distinguishes plan-execution branches from other potential future branch types.Correctness ✅
f"sandbox/{safe_plan_id}"→f"cleveragents/plan-{safe_plan_id}"._sanitise_branch_name()function already handles slashes in its allowed character set, so thecleveragents/plan-prefix won't be mangled._sanitise_branch_name()(empty input →"sandbox") would producecleveragents/plan-sandbox, which is still correctly namespaced.sandbox/branch prefix — the change is self-contained.Test Quality ✅
git_worktree_coverage_boost_steps.pycorrectly mirror the new naming convention.garbage_collection.featurescenario fixture is updated to match.sandbox/<plan_id>branch name references remain in test files on this branch.PR Metadata ✅
fix(sandbox): ...) withISSUES CLOSED: #2601footer ✓Closes #2601✓Type/Bug✓v3.3.0✓CI Status
Scheduling merge for when all checks complete.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer
Review Summary — LGTM ✅ (Self-Review)
Reviewed PR #3263 with focus on specification-compliance, requirements-coverage, and behavior-correctness.
Scope
Single-line production fix + docstring update in
git_worktree.py, plus 4 test fixture updates across 2 test files. Clean, minimal blast radius.Deep Dive Results
Specification Compliance ✅
agents plan executeoutput clearly showsBranch: cleveragents/plan-01HXM8C2— this fix aligns the implementation with that requirement.cleveragents/namespace prefix is the spec-defined namespace for all CleverAgents-managed git branches.plan-infix correctly distinguishes plan-execution branches from other potential future branch types under thecleveragents/namespace.src/reference the oldsandbox/branch prefix pattern — the change is self-contained.Requirements Coverage ✅
sandbox/<plan_id>tocleveragents/plan-<plan_id>create()docstring updated to reflect new namingBehavior Correctness ✅
_sanitise_branch_name()regex ([^a-zA-Z0-9/_.\-]+) already allows slashes in its character set, so thecleveragents/plan-prefix will not be mangled by sanitisation — verified by reading the regex definition._sanitise_branch_name()fallback (empty input →"sandbox") would producecleveragents/plan-sandbox, which is still correctly namespaced under thecleveragents/prefix. Theplan_idvalidation at the top ofcreate()already rejects empty strings, so this fallback only triggers for strings composed entirely of disallowed characters — an extreme edge case.Test Quality ✅
git_worktree_coverage_boost_steps.pycorrectly updated:sandbox/test→cleveragents/plan-testsandbox/cleanup-test→cleveragents/plan-cleanup-testsandbox/branch-delete-fail→cleveragents/plan-branch-delete-failgarbage_collection.featurescenario fixture updated:sandbox/test-plan→cleveragents/plan-test-planrobot/container_tool_exec.robot) reference/tmp/sandbox/as a filesystem path, not a branch name — correctly left unchanged.PR Metadata & Commit Standards ✅
fix(sandbox): ...) withISSUES CLOSED: #2601footer ✓Closes #2601✓Type/Bug✓v3.3.0(matches issue) ✓fix/git-worktree-branch-naming✓Minor Observations (Non-blocking)
_sanitise_branch_name()fallback value — The fallback value on line ~51 is still the string"sandbox", a leftover from the old naming convention. While this is not introduced by this PR and the resulting branch name (cleveragents/plan-sandbox) is still correctly namespaced, a future cleanup could change this to something more semantically appropriate like"unknown"or"default". Consider filing a low-priority follow-up issue.Decision: APPROVED ✅
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer