docs(qa): add review playbook and priority matrix #314

Closed
opened 2026-02-22 23:41:13 +00:00 by freemo · 1 comment
Owner

Metadata

  • Commit: docs(qa): add review playbook and priority matrix
  • Branch: feature/m6-review-playbook

Subtasks

  • Create docs/development/review_playbook.md with focus areas and skip rules.
  • Add priority matrix and review SLA guidance.
  • Add checklist templates for architecture review, CLI review, and DB migration review.
  • Add review checklists for security-sensitive changes (secrets, auth, server stubs) and schema migrations.
  • Add a PR review routing table (which reviewer for which subsystem).
  • Add examples of acceptable vs blocking findings with remediation guidance.
  • Add a required test matrix section for reviewers (nox sessions + coverage).
  • Tests (Behave): Add scenarios validating review playbook references exist.
  • Tests (Robot): Add docs build smoke test covering the new guide.
  • Tests (ASV): Add benchmarks/docs_build_bench.py for docs build baseline.
  • Verify coverage >=97% via nox -s coverage_report. If coverage is <97% then review the current unit test coverage report at build/coverage.xml and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun nox -s coverage_report to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
  • Run nox (all default sessions, including benchmark).

Section: ### Section 8: Large Project Autonomy & Context [M6]
Status: Completed

## Metadata - **Commit**: `docs(qa): add review playbook and priority matrix` - **Branch**: `feature/m6-review-playbook` ## Subtasks - [x] Create `docs/development/review_playbook.md` with focus areas and skip rules. - [x] Add priority matrix and review SLA guidance. - [x] Add checklist templates for architecture review, CLI review, and DB migration review. - [x] Add review checklists for security-sensitive changes (secrets, auth, server stubs) and schema migrations. - [x] Add a PR review routing table (which reviewer for which subsystem). - [x] Add examples of acceptable vs blocking findings with remediation guidance. - [x] Add a required test matrix section for reviewers (nox sessions + coverage). - [x] Tests (Behave): Add scenarios validating review playbook references exist. - [x] Tests (Robot): Add docs build smoke test covering the new guide. - [x] Tests (ASV): Add `benchmarks/docs_build_bench.py` for docs build baseline. - [x] Verify coverage >=97% via `nox -s coverage_report`. If coverage is <97% then review the current unit test coverage report at `build/coverage.xml` and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `nox -s coverage_report` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [x] Run `nox` (all default sessions, including benchmark). **Section**: ### Section 8: Large Project Autonomy & Context [M6] **Status**: Completed
freemo added this to the v3.5.0 milestone 2026-02-22 23:41:13 +00:00
Author
Owner

Implementation Notes — Q1.5 Branch Protection Rules

2026-02-10: Task Q1.5 Complete - Branch Protection Rules Documentation [Brent]

  • Created docs/development/ci-cd.md (224 lines) documenting branch protection rules, review priority matrix, CI job dependency graph, quality gates summary.

(Migrated from docs/implementation-notes.md)

## Implementation Notes — Q1.5 Branch Protection Rules **2026-02-10**: Task Q1.5 Complete - Branch Protection Rules Documentation [Brent] - Created `docs/development/ci-cd.md` (224 lines) documenting branch protection rules, review priority matrix, CI job dependency graph, quality gates summary. *(Migrated from `docs/implementation-notes.md`)*
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#369 Epic: Large Project Autonomy & Context
cleveragents/cleveragents-core
Depends on
#132 develop-brent-2
cleveragents/cleveragents-core
Reference
cleveragents/cleveragents-core#314
No description provided.