cleveragents/cleveragents-core

Fork 3

UAT: `agents plan correct --mode=append` is a stub — generates random ULIDs but does not create a real child plan or decision in the system #3114

New issue

Open

opened 2026-04-05 06:23:34 +00:00 by freemo · 2 comments

freemo commented

2026-04-05 06:23:34 +00:00

Owner

Summary

CorrectionService.execute_append() generates random ULIDs for child_plan_id and new_decision_id but does not create any actual plan or decision in the system. The returned spawned_child_plan_id and new_decisions are phantom IDs that do not correspond to any real entities. The append correction mode is effectively a no-op stub.

Metadata

Prescribed commit message: feat(correction): implement append correction — spawn real child plan and record correction decision
Branch name: feat/correction-append-real-child-plan

Subtasks

Wire PlanLifecycleService into CorrectionService (or use a protocol/port)
In execute_append(), call the plan lifecycle service to create a real child plan linked to the parent plan
Record a user_intervention decision in the decision tree with the correction guidance
Update DI container to inject the required service
Add Behave unit test verifying a real child plan is created
Add Robot Framework integration test verifying the child plan appears in agents plan list

Definition of Done

After agents plan correct <id> --mode append --guidance "...", a real child plan exists that can be found via agents plan list
The spawned_child_plan_id in the result corresponds to a real plan in the system
All existing tests pass

Bug Details

What was tested

Code analysis of src/cleveragents/application/services/correction_service.py, method execute_append(), lines 563–640

Expected behavior (from spec § Two Correction Modes, Append)

Leave history intact and append a new plan at the end that fixes the outcome. Does not rewrite history.
Creates a new child plan to fix the outcome without rewriting history.

Actual behavior

execute_append() is a stub that only generates random ULIDs:

# correction_service.py lines 598-613
try:
    child_plan_id = str(ULID())      # ← random ULID, no real plan created
    new_decision_id = str(ULID())    # ← random ULID, no real decision created

    result = CorrectionResult(
        correction_id=correction_id,
        status=CorrectionStatus.APPLIED,
        new_decisions=[new_decision_id],
        spawned_child_plan_id=child_plan_id,
    )
    # No call to PlanLifecycleService, DecisionService, or any persistence layer

No plan is created, no decision is recorded, no guidance is stored. The returned IDs are phantom references.

Code location

src/cleveragents/application/services/correction_service.py, method execute_append(), lines 563–640

Steps to reproduce

Create a plan with a decision
Run: agents plan correct <decision_id> --mode append --guidance "Add rate limiting"
Run: agents plan list or agents plan status <spawned_child_plan_id>
Observe that the spawned child plan ID does not correspond to any real plan

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-new-issue-creator

## Summary `CorrectionService.execute_append()` generates random ULIDs for `child_plan_id` and `new_decision_id` but does not create any actual plan or decision in the system. The returned `spawned_child_plan_id` and `new_decisions` are phantom IDs that do not correspond to any real entities. The append correction mode is effectively a no-op stub. ## Metadata **Prescribed commit message**: `feat(correction): implement append correction — spawn real child plan and record correction decision` **Branch name**: `feat/correction-append-real-child-plan` ## Subtasks - [ ] Wire `PlanLifecycleService` into `CorrectionService` (or use a protocol/port) - [ ] In `execute_append()`, call the plan lifecycle service to create a real child plan linked to the parent plan - [ ] Record a `user_intervention` decision in the decision tree with the correction guidance - [ ] Update DI container to inject the required service - [ ] Add Behave unit test verifying a real child plan is created - [ ] Add Robot Framework integration test verifying the child plan appears in `agents plan list` ## Definition of Done - After `agents plan correct <id> --mode append --guidance "..."`, a real child plan exists that can be found via `agents plan list` - The `spawned_child_plan_id` in the result corresponds to a real plan in the system - All existing tests pass ## Bug Details ### What was tested Code analysis of `src/cleveragents/application/services/correction_service.py`, method `execute_append()`, lines 563–640 ### Expected behavior (from spec § Two Correction Modes, Append) > Leave history intact and append a new plan at the end that fixes the outcome. Does not rewrite history. > Creates a new child plan to fix the outcome without rewriting history. ### Actual behavior `execute_append()` is a stub that only generates random ULIDs: ```python # correction_service.py lines 598-613 try: child_plan_id = str(ULID()) # ← random ULID, no real plan created new_decision_id = str(ULID()) # ← random ULID, no real decision created result = CorrectionResult( correction_id=correction_id, status=CorrectionStatus.APPLIED, new_decisions=[new_decision_id], spawned_child_plan_id=child_plan_id, ) # No call to PlanLifecycleService, DecisionService, or any persistence layer ``` No plan is created, no decision is recorded, no guidance is stored. The returned IDs are phantom references. ### Code location `src/cleveragents/application/services/correction_service.py`, method `execute_append()`, lines 563–640 ### Steps to reproduce 1. Create a plan with a decision 2. Run: `agents plan correct <decision_id> --mode append --guidance "Add rate limiting"` 3. Run: `agents plan list` or `agents plan status <spawned_child_plan_id>` 4. Observe that the spawned child plan ID does not correspond to any real plan --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-new-issue-creator

freemo added this to the v3.3.0 milestone

2026-04-05 06:23:57 +00:00

freemo added a new dependency

2026-04-05 06:26:13 +00:00

#394 Epic: Decision Framework

freemo added the

MoSCoW

Must have

label

2026-04-05 06:32:51 +00:00

freemo referenced this issue

2026-04-05 06:33:14 +00:00

UAT: execute_revert never supersedes decisions in the tree — CorrectionService not wired to DecisionService, affected decisions remain active after correction #3113

freemo referenced this issue

2026-04-05 06:33:33 +00:00

UAT: agents plan correct --mode revert never restores actor reasoning state — decisions parameter not passed to execute_correction, actor_state_ref always empty #3108

freemo commented

2026-04-05 06:33:33 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Critical (keeping existing — append correction mode is a core v3.3.0 deliverable)
Milestone: v3.3.0 (already assigned, keeping)
MoSCoW: Must Have — v3.3.0 acceptance criteria requires "Correction flow functional (plan correct --mode revert and --mode append)." The append mode is currently a no-op stub that generates phantom IDs.
Parent Epic: #394 (Decision Framework) — note: issue body doesn't specify parent Epic, linking to #394 as the correction system is part of the Decision Framework

Part of the correction-flow bug cluster (#3107, #3108, #3109, #3113, #3114).

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Critical (keeping existing — append correction mode is a core v3.3.0 deliverable) - **Milestone**: v3.3.0 (already assigned, keeping) - **MoSCoW**: Must Have — v3.3.0 acceptance criteria requires "Correction flow functional (`plan correct --mode revert` and `--mode append`)." The append mode is currently a no-op stub that generates phantom IDs. - **Parent Epic**: #394 (Decision Framework) — note: issue body doesn't specify parent Epic, linking to #394 as the correction system is part of the Decision Framework Part of the correction-flow bug cluster (#3107, #3108, #3109, #3113, #3114). --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner

freemo referenced this issue

2026-04-05 06:33:49 +00:00

UAT: agents plan correct JSON output format does not match spec — flat structure instead of nested correction/affected_subtree/sandbox_rollback/recompute/history #3107

freemo referenced this issue

2026-04-05 06:34:14 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo referenced this issue

2026-04-05 06:43:52 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo referenced this issue

2026-04-05 06:53:54 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo referenced this issue

2026-04-05 07:06:08 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3124

freemo referenced this issue

2026-04-05 07:06:25 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3124

freemo referenced this issue

2026-04-05 07:44:47 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo referenced this issue

2026-04-05 07:58:21 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo commented

2026-04-05 08:05:16 +00:00

Author

Owner

Starting implementation on branch feat/correction-append-real-child-plan.

Plan:

Wire PlanLifecycleService and DecisionService into CorrectionService
Implement execute_append() to create a real child plan via PlanLifecycleService
Record a user_intervention decision via DecisionService
Update DI container to inject the required services
Add Behave unit tests verifying real child plan creation
Add Robot Framework integration test

Difficulty assessment: Medium → starting at sonnet tier.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

Starting implementation on branch `feat/correction-append-real-child-plan`. **Plan:** - Wire `PlanLifecycleService` and `DecisionService` into `CorrectionService` - Implement `execute_append()` to create a real child plan via `PlanLifecycleService` - Record a `user_intervention` decision via `DecisionService` - Update DI container to inject the required services - Add Behave unit tests verifying real child plan creation - Add Robot Framework integration test Difficulty assessment: Medium → starting at sonnet tier. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo referenced this issue

2026-04-05 09:01:27 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo referenced this issue

2026-04-05 09:18:23 +00:00

[CA-AUTO] System Watchdog — Session Tracker — watchdog-1 — 2026-04-05 #3197

freemo referenced this issue

2026-04-05 10:20:58 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094