feat(dod): enforce definition-of-done gating #178

Closed
opened 2026-02-22 23:39:52 +00:00 by freemo · 1 comment
Owner

Metadata

  • Commit Message: feat(dod): enforce definition-of-done gating
  • Branch: feature/m4-definition-of-done

Background

definition_of_done is evaluated before apply; unmet conditions block apply with a clear error. DoD templating uses plan arguments and preserves the template in plan metadata. A DoD evaluation hook captures pass/fail reasoning and stores it in the plan validation summary.

Acceptance Criteria

  • Implement DoD gating that blocks phase transitions when required validations are incomplete.
  • Wire DoD checks into plan phase transitions and CLI output.
  • Update docs/reference/definition_of_done.md with gating behavior and overrides.

Definition of Done

This issue is complete when:

  • All subtasks below are completed and checked off.
  • A Git commit is created where the first line of the commit message matches
    the Commit Message in Metadata exactly, followed by a blank line, then
    additional lines providing relevant details about the implementation. The
    commit body should be appropriate in size for a commit message and relatively
    complete in describing what was done.
  • The commit is pushed to the remote on the branch matching the Branch in
    Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and
    merged before this issue is marked done.

Subtasks

  • Implement DoD gating that blocks phase transitions when required validations are incomplete.
  • Wire DoD checks into plan phase transitions and CLI output.
  • Update docs/reference/definition_of_done.md with gating behavior and overrides.
  • Tests (Behave): Add scenarios for DoD gate pass, fail, and override.
  • Tests (Robot): Add Robot test covering DoD CLI output.
  • Tests (ASV): Add benchmarks/dod_bench.py for gating overhead.
  • Verify coverage >=97% via nox -s coverage_report. If coverage is <97% then review the current unit test coverage report at build/coverage.xml and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun nox -s coverage_report to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
  • Run nox (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Section: #### M3: Decisions + Validations + Invariants (Day 18)
Status: Open

## Metadata - **Commit Message**: `feat(dod): enforce definition-of-done gating` - **Branch**: `feature/m4-definition-of-done` ## Background `definition_of_done` is evaluated before apply; unmet conditions block apply with a clear error. DoD templating uses plan arguments and preserves the template in plan metadata. A DoD evaluation hook captures pass/fail reasoning and stores it in the plan validation summary. ## Acceptance Criteria - [ ] Implement DoD gating that blocks phase transitions when required validations are incomplete. - [ ] Wire DoD checks into plan phase transitions and CLI output. - [ ] Update `docs/reference/definition_of_done.md` with gating behavior and overrides. ## Definition of Done This issue is complete when: - All subtasks below are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. The commit body should be appropriate in size for a commit message and relatively complete in describing what was done. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. ## Subtasks - [ ] Implement DoD gating that blocks phase transitions when required validations are incomplete. - [ ] Wire DoD checks into plan phase transitions and CLI output. - [ ] Update `docs/reference/definition_of_done.md` with gating behavior and overrides. - [ ] Tests (Behave): Add scenarios for DoD gate pass, fail, and override. - [ ] Tests (Robot): Add Robot test covering DoD CLI output. - [ ] Tests (ASV): Add `benchmarks/dod_bench.py` for gating overhead. - [ ] Verify coverage >=97% via `nox -s coverage_report`. If coverage is <97% then review the current unit test coverage report at `build/coverage.xml` and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `nox -s coverage_report` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Run `nox` (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. **Section**: #### M3: Decisions + Validations + Invariants (Day 18) **Status**: Open
freemo added this to the v3.2.0 milestone 2026-02-22 23:39:52 +00:00
Author
Owner

Expected completion updated (Day 15 rebaseline): Day 30 / 2026-03-10 (previously Day 26 / 2026-03-06)

**Expected completion updated (Day 15 rebaseline):** Day 30 / 2026-03-10 (previously Day 26 / 2026-03-06)
freemo added the due date 2026-03-06 2026-02-23 18:41:27 +00:00
freemo self-assigned this 2026-02-24 21:53:08 +00:00
CoreRasurae added reference develop-luis-2 2026-02-25 07:40:30 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

2026-03-06

Reference
cleveragents/cleveragents-core#178
No description provided.