feat(validation): add validation runner and apply gating #176

Closed
opened 2026-02-22 23:39:51 +00:00 by freemo · 1 comment
Owner

Metadata

  • Commit Message: feat(validation): add validation runner and apply gating
  • Branch: feature/m3-validation-apply

Background

The validation runner executes validation attachments and aggregates required/informational results. Wrapped tool validations support transform mappings with consistent output schema normalization. The Apply pipeline is gated to block on required validation failures and record summaries on the plan.

Acceptance Criteria

  • Implement validation runner executing validation attachments and aggregating required/informational results.
  • Support wrapped tool validations with transform mappings and consistent output schema normalization.
  • Wire Apply pipeline gating to block on required validation failures and record summaries on the plan.
  • Surface validation summary fields in plan status/plan diff outputs (required vs informational counts, failures).
  • Update docs/reference/validation_runner.md with lifecycle and result schema.

Definition of Done

This issue is complete when:

  • All subtasks below are completed and checked off.
  • A Git commit is created where the first line of the commit message matches
    the Commit Message in Metadata exactly, followed by a blank line, then
    additional lines providing relevant details about the implementation. The
    commit body should be appropriate in size for a commit message and relatively
    complete in describing what was done.
  • The commit is pushed to the remote on the branch matching the Branch in
    Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and
    merged before this issue is marked done.

Subtasks

  • Implement validation runner executing validation attachments and aggregating required/informational results.
  • Support wrapped tool validations with transform mappings and consistent output schema normalization.
  • Wire Apply pipeline gating to block on required validation failures and record summaries on the plan.
  • Surface validation summary fields in plan status/plan diff outputs (required vs informational counts, failures).
  • Update docs/reference/validation_runner.md with lifecycle and result schema.
  • Tests (Behave): Add scenarios for validation runner success/failure and required vs informational behavior.
  • Tests (Robot): Add Robot test validating apply gating with required validations.
  • Tests (ASV): Add benchmarks/validation_runner_bench.py for runner overhead.
  • Verify coverage >=97% via nox -s coverage_report. If coverage is <97% then review the current unit test coverage report at build/coverage.xml and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun nox -s coverage_report to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
  • Run nox (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Section: #### M3: Decisions + Validations + Invariants (Day 18)
Status: Open

## Metadata - **Commit Message**: `feat(validation): add validation runner and apply gating` - **Branch**: `feature/m3-validation-apply` ## Background The validation runner executes validation attachments and aggregates required/informational results. Wrapped tool validations support transform mappings with consistent output schema normalization. The Apply pipeline is gated to block on required validation failures and record summaries on the plan. ## Acceptance Criteria - [ ] Implement validation runner executing validation attachments and aggregating required/informational results. - [ ] Support wrapped tool validations with transform mappings and consistent output schema normalization. - [ ] Wire Apply pipeline gating to block on required validation failures and record summaries on the plan. - [ ] Surface validation summary fields in `plan status`/`plan diff` outputs (required vs informational counts, failures). - [ ] Update `docs/reference/validation_runner.md` with lifecycle and result schema. ## Definition of Done This issue is complete when: - All subtasks below are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. The commit body should be appropriate in size for a commit message and relatively complete in describing what was done. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. ## Subtasks - [ ] Implement validation runner executing validation attachments and aggregating required/informational results. - [ ] Support wrapped tool validations with transform mappings and consistent output schema normalization. - [ ] Wire Apply pipeline gating to block on required validation failures and record summaries on the plan. - [ ] Surface validation summary fields in `plan status`/`plan diff` outputs (required vs informational counts, failures). - [ ] Update `docs/reference/validation_runner.md` with lifecycle and result schema. - [ ] Tests (Behave): Add scenarios for validation runner success/failure and required vs informational behavior. - [ ] Tests (Robot): Add Robot test validating apply gating with required validations. - [ ] Tests (ASV): Add `benchmarks/validation_runner_bench.py` for runner overhead. - [ ] Verify coverage >=97% via `nox -s coverage_report`. If coverage is <97% then review the current unit test coverage report at `build/coverage.xml` and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `nox -s coverage_report` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Run `nox` (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. **Section**: #### M3: Decisions + Validations + Invariants (Day 18) **Status**: Open
freemo added this to the v3.2.0 milestone 2026-02-22 23:39:51 +00:00
Author
Owner

Expected completion updated (Day 15 rebaseline): Day 29 / 2026-03-09 (previously Day 22 / 2026-03-02)

**Expected completion updated (Day 15 rebaseline):** Day 29 / 2026-03-09 (previously Day 22 / 2026-03-02)
freemo added the due date 2026-02-28 2026-02-23 18:41:27 +00:00
freemo self-assigned this 2026-02-24 21:53:07 +00:00
CoreRasurae added reference develop-luis-2 2026-02-25 07:40:29 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

2026-02-28

Reference
cleveragents/cleveragents-core#176
No description provided.