feat(validation): add validation pipeline and results model #175

Closed
opened 2026-02-22 23:39:50 +00:00 by freemo · 1 comment
Owner

Metadata

  • Commit Message: feat(validation): add validation pipeline and results model
  • Branch: feature/m3-validation-pipeline

Background

ValidationCommand, ValidationResult, and ValidationPipeline are implemented using Validation attachments from the Tool Registry. Validations run at the end of the Execute phase only (not during Apply). Required vs informational validation modes and fix-then-revalidate loop hooks are enforced.

Acceptance Criteria

  • Implement ValidationCommand, ValidationResult, and ValidationPipeline using Validation attachments from Tool Registry.
  • Run validations at end of Execute phase only; do not re-run during Apply per spec.
  • Enforce required vs informational validation modes and fix-then-revalidate loop hooks.
  • Persist validation summary into Plan metadata for later review.
  • Sort validations by (resource, mode, validation name) for deterministic execution order.

Definition of Done

This issue is complete when:

  • All subtasks below are completed and checked off.
  • A Git commit is created where the first line of the commit message matches
    the Commit Message in Metadata exactly, followed by a blank line, then
    additional lines providing relevant details about the implementation. The
    commit body should be appropriate in size for a commit message and relatively
    complete in describing what was done.
  • The commit is pushed to the remote on the branch matching the Branch in
    Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and
    merged before this issue is marked done.

Subtasks

  • Implement ValidationCommand, ValidationResult, and ValidationPipeline using Validation attachments from Tool Registry.
  • Run validations at end of Execute phase only; do not re-run during Apply per spec.
  • Enforce required vs informational validation modes and fix-then-revalidate loop hooks.
  • Persist validation summary into Plan metadata for later review.
  • Sort validations by (resource, mode, validation name) for deterministic execution order.
  • Add per-validation timeout and capture stdout/stderr in ValidationResult for troubleshooting.
  • Group validations by resource and cap parallel validation concurrency per resource type.
  • Normalize validation output to passed/message/data schema even for tool errors.
  • Add aggregation helper to compute counts (required_passed, required_failed, info_failed) for CLI display.
  • Add guard to skip validations on read-only resources when validation requires write access (should never happen).
  • Add docs/reference/validation_pipeline.md with ordering, timeouts, and failure handling.
  • Document concurrency limits and output normalization rules.
  • Tests (Behave): Add features/validation_pipeline.feature for pass/fail paths and required/informational modes.
  • Tests (Robot): Add robot/validation_pipeline.robot for pipeline smoke tests.
  • Tests (ASV): Add benchmarks/validation_pipeline_bench.py for pipeline runtime.
  • Verify coverage >=97% via nox -s coverage_report. If coverage is <97% then review the current unit test coverage report at build/coverage.xml and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun nox -s coverage_report to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
  • Run nox (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Section: #### M3: Decisions + Validations + Invariants (Day 18)
Status: Open

## Metadata - **Commit Message**: `feat(validation): add validation pipeline and results model` - **Branch**: `feature/m3-validation-pipeline` ## Background ValidationCommand, ValidationResult, and ValidationPipeline are implemented using Validation attachments from the Tool Registry. Validations run at the end of the Execute phase only (not during Apply). Required vs informational validation modes and fix-then-revalidate loop hooks are enforced. ## Acceptance Criteria - [ ] Implement ValidationCommand, ValidationResult, and ValidationPipeline using Validation attachments from Tool Registry. - [ ] Run validations at end of Execute phase only; do not re-run during Apply per spec. - [ ] Enforce required vs informational validation modes and fix-then-revalidate loop hooks. - [ ] Persist validation summary into Plan metadata for later review. - [ ] Sort validations by (resource, mode, validation name) for deterministic execution order. ## Definition of Done This issue is complete when: - All subtasks below are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. The commit body should be appropriate in size for a commit message and relatively complete in describing what was done. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. ## Subtasks - [ ] Implement ValidationCommand, ValidationResult, and ValidationPipeline using Validation attachments from Tool Registry. - [ ] Run validations at end of Execute phase only; do not re-run during Apply per spec. - [ ] Enforce required vs informational validation modes and fix-then-revalidate loop hooks. - [ ] Persist validation summary into Plan metadata for later review. - [ ] Sort validations by (resource, mode, validation name) for deterministic execution order. - [ ] Add per-validation timeout and capture stdout/stderr in ValidationResult for troubleshooting. - [ ] Group validations by resource and cap parallel validation concurrency per resource type. - [ ] Normalize validation output to `passed/message/data` schema even for tool errors. - [ ] Add aggregation helper to compute counts (required_passed, required_failed, info_failed) for CLI display. - [ ] Add guard to skip validations on read-only resources when validation requires write access (should never happen). - [ ] Add `docs/reference/validation_pipeline.md` with ordering, timeouts, and failure handling. - [ ] Document concurrency limits and output normalization rules. - [ ] Tests (Behave): Add `features/validation_pipeline.feature` for pass/fail paths and required/informational modes. - [ ] Tests (Robot): Add `robot/validation_pipeline.robot` for pipeline smoke tests. - [ ] Tests (ASV): Add `benchmarks/validation_pipeline_bench.py` for pipeline runtime. - [ ] Verify coverage >=97% via `nox -s coverage_report`. If coverage is <97% then review the current unit test coverage report at `build/coverage.xml` and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `nox -s coverage_report` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Run `nox` (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. **Section**: #### M3: Decisions + Validations + Invariants (Day 18) **Status**: Open
freemo added this to the v3.2.0 milestone 2026-02-22 23:39:50 +00:00
Author
Owner

Expected completion updated (Day 15 rebaseline): Day 28 / 2026-03-08 (previously Day 22 / 2026-03-02)

**Expected completion updated (Day 15 rebaseline):** Day 28 / 2026-03-08 (previously Day 22 / 2026-03-02)
freemo added the due date 2026-03-01 2026-02-23 18:41:27 +00:00
CoreRasurae added reference develop-luis-2 2026-02-25 07:40:28 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

2026-03-01

Reference
cleveragents/cleveragents-core#175
No description provided.