fix(di): get_container() permanently caches failed audit subscriber in Singleton provider #1223

Merged

freemo merged 1 commit from bugfix/m7-di-audit-cache-failure into master 2026-04-02 16:51:29 +00:00

Conversation 5 Commits 1 Files changed 4 +184 -3

brent.edwards commented 2026-03-31 08:37:25 +00:00

Member

Copy link

Summary

Fixes bug #992: get_container() permanently caches a failed audit subscriber initialization, preventing retry in long-lived server processes.

• Introduced a module-level _audit_subscriber_initialized flag that tracks whether audit_event_subscriber() has succeeded
• get_container() now retries audit subscriber initialization on every call until it succeeds, instead of permanently caching the failure
• reset_container() resets the flag to ensure clean state for tests
• Updated the log message from "will be registered on first AuditEventSubscriber access" to "will be retried on next get_container() call" to accurately reflect the new retry behavior

Motivation

In the CLI, each invocation creates a new process so the cached failure is discarded naturally. In a long-lived server process, however, the audit subscriber would remain uninitialized for the process lifetime because _container is None is False after the first call, skipping all retry logic.

Approach

The simplest and most backward-compatible approach: separate container creation (still happens only once) from audit subscriber initialization (retried until successful). A boolean flag _audit_subscriber_initialized guards the retry — when False, each get_container() call reattempts the initialization.

Alternatives considered:

• Lazy callback when DB becomes available — overly complex for this fix
• Explicit reinitialize_audit() method — shifts responsibility to callers

TDD Test

Includes the TDD regression test from issue #1096 (branch tdd/m6-di-audit-cache-failure) with the @tdd_expected_fail tag removed per the Bug Fix Workflow in CONTRIBUTING.md. The test verifies that get_container() retries audit subscriber initialization after an initial failure.

Test Results

All 11 nox sessions pass:

• lint: ✅
• format: ✅
• typecheck: ✅
• security_scan: ✅
• dead_code: ✅
• unit_tests: ✅
• integration_tests: ✅
• docs: ✅
• build: ✅
• benchmark: ✅
• coverage_report: ✅ (97.0% — meets ≥97% threshold)

Files Changed

• src/cleveragents/application/container.py — Bug fix: retry audit subscriber init
• features/tdd_di_audit_cache_failure.feature — TDD regression test (from #1096, @tdd_expected_fail removed)
• features/steps/tdd_di_audit_cache_failure_steps.py — Step definitions for the regression test
• benchmarks/bench_audit_subscriber_retry.py — ASV benchmark for retry-path performance

Closes #992

## Summary Fixes bug #992: `get_container()` permanently caches a failed audit subscriber initialization, preventing retry in long-lived server processes. - Introduced a module-level `_audit_subscriber_initialized` flag that tracks whether `audit_event_subscriber()` has succeeded - `get_container()` now retries audit subscriber initialization on every call until it succeeds, instead of permanently caching the failure - `reset_container()` resets the flag to ensure clean state for tests - Updated the log message from "will be registered on first AuditEventSubscriber access" to "will be retried on next get_container() call" to accurately reflect the new retry behavior ## Motivation In the CLI, each invocation creates a new process so the cached failure is discarded naturally. In a long-lived server process, however, the audit subscriber would remain uninitialized for the process lifetime because `_container is None` is `False` after the first call, skipping all retry logic. ## Approach The simplest and most backward-compatible approach: separate container creation (still happens only once) from audit subscriber initialization (retried until successful). A boolean flag `_audit_subscriber_initialized` guards the retry — when `False`, each `get_container()` call reattempts the initialization. Alternatives considered: - Lazy callback when DB becomes available — overly complex for this fix - Explicit `reinitialize_audit()` method — shifts responsibility to callers ## TDD Test Includes the TDD regression test from issue #1096 (branch `tdd/m6-di-audit-cache-failure`) with the `@tdd_expected_fail` tag removed per the Bug Fix Workflow in `CONTRIBUTING.md`. The test verifies that `get_container()` retries audit subscriber initialization after an initial failure. ## Test Results All 11 nox sessions pass: - `lint`: ✅ - `format`: ✅ - `typecheck`: ✅ - `security_scan`: ✅ - `dead_code`: ✅ - `unit_tests`: ✅ - `integration_tests`: ✅ - `docs`: ✅ - `build`: ✅ - `benchmark`: ✅ - `coverage_report`: ✅ (97.0% — meets ≥97% threshold) ## Files Changed - `src/cleveragents/application/container.py` — Bug fix: retry audit subscriber init - `features/tdd_di_audit_cache_failure.feature` — TDD regression test (from #1096, `@tdd_expected_fail` removed) - `features/steps/tdd_di_audit_cache_failure_steps.py` — Step definitions for the regression test - `benchmarks/bench_audit_subscriber_retry.py` — ASV benchmark for retry-path performance Closes #992

brent.edwards added this to the v3.6.0 milestone 2026-03-31 08:37:31 +00:00

brent.edwards added the

Type

Bug

label 2026-03-31 08:37:32 +00:00

brent.edwards referenced this pull request 2026-03-31 08:38:00 +00:00

bug(di): get_container() permanently caches failed audit subscriber initialization #992

freemo approved these changes 2026-04-02 04:21:08 +00:00

Dismissed

freemo left a comment

Copy link

Review: APPROVED ✅

PR #1223 — fix(di): get_container() permanently caches failed audit subscriber in Singleton provider

What was reviewed

• src/cleveragents/application/container.py — Added _audit_subscriber_initialized flag with retry logic
• features/tdd_di_audit_cache_failure.feature — TDD regression test (from #1096)
• features/steps/tdd_di_audit_cache_failure_steps.py — Step definitions with FakeContainer mock
• benchmarks/bench_audit_subscriber_retry.py — ASV benchmark for retry-path performance

Assessment

• Spec alignment: ✅ Fixes long-lived server process behavior per the DI container design
• Code quality: ✅
  • Simple boolean flag approach — minimal and clean
  • global _container, _audit_subscriber_initialized — correct usage
  • Retry only when not _audit_subscriber_initialized — avoids unnecessary work on hot path
  • reset_container() properly resets both globals
  • Log message updated to reflect retry behavior ("will be retried on next get_container() call")
  • No # type: ignore suppressions
• Test coverage: ✅
  • FakeContainer with audit_init_attempts counter — good mock design
  • Verifies singleton behavior AND retry count
  • ASV benchmark included for performance regression tracking
• Design note: The _audit_subscriber_initialized flag is not thread-safe, but this is acceptable because get_container() is called during startup (single-threaded), and PR #1224 addresses thread safety for the audit service itself.
• Quality gates: All 11 nox sessions pass (97% coverage)

Clean, well-scoped fix with proper separation of concerns from the thread-safety fix in PR #1224.

## Review: APPROVED ✅ **PR #1223 — fix(di): get_container() permanently caches failed audit subscriber in Singleton provider** ### What was reviewed - `src/cleveragents/application/container.py` — Added `_audit_subscriber_initialized` flag with retry logic - `features/tdd_di_audit_cache_failure.feature` — TDD regression test (from #1096) - `features/steps/tdd_di_audit_cache_failure_steps.py` — Step definitions with FakeContainer mock - `benchmarks/bench_audit_subscriber_retry.py` — ASV benchmark for retry-path performance ### Assessment - **Spec alignment**: ✅ Fixes long-lived server process behavior per the DI container design - **Code quality**: ✅ - Simple boolean flag approach — minimal and clean - `global _container, _audit_subscriber_initialized` — correct usage - Retry only when `not _audit_subscriber_initialized` — avoids unnecessary work on hot path - `reset_container()` properly resets both globals - Log message updated to reflect retry behavior ("will be retried on next get_container() call") - No `# type: ignore` suppressions - **Test coverage**: ✅ - FakeContainer with `audit_init_attempts` counter — good mock design - Verifies singleton behavior AND retry count - ASV benchmark included for performance regression tracking - **Design note**: The `_audit_subscriber_initialized` flag is not thread-safe, but this is acceptable because `get_container()` is called during startup (single-threaded), and PR #1224 addresses thread safety for the audit service itself. - **Quality gates**: All 11 nox sessions pass (97% coverage) Clean, well-scoped fix with proper separation of concerns from the thread-safety fix in PR #1224.

freemo referenced this pull request 2026-04-02 04:22:05 +00:00

bug(di): get_container() permanently caches failed audit subscriber initialization #992

freemo referenced this pull request 2026-04-02 04:25:14 +00:00

[Automated] Product Build Session State #1259

freemo self-assigned this 2026-04-02 06:15:13 +00:00

freemo force-pushed bugfix/m7-di-audit-cache-failure from 14e882e855 to 734ad2a162 2026-04-02 07:09:20 +00:00 Compare

freemo commented 2026-04-02 08:03:13 +00:00

Owner

Copy link

🔒 Claimed by pr-reviewer-3. Starting independent code review.

🔒 Claimed by pr-reviewer-3. Starting independent code review.

freemo approved these changes 2026-04-02 08:06:06 +00:00

Dismissed

freemo left a comment

Copy link

Independent Code Review: APPROVED ✅

Reviewer: pr-reviewer-3 (independent perspective)

Changes Reviewed

1. src/cleveragents/application/container.py — Core bug fix: retry audit subscriber initialization
2. features/tdd_di_audit_cache_failure.feature — BDD regression test (from TDD issue #1096)
3. features/steps/tdd_di_audit_cache_failure_steps.py — Step definitions with FakeContainer mock
4. benchmarks/bench_audit_subscriber_retry.py — ASV benchmark for retry-path performance

Specification Alignment ✅

The fix correctly addresses bug #992 as described in the issue. The approach — separating container creation (happens once) from audit subscriber initialization (retried until successful) — is the simplest and most backward-compatible of the three options listed in the issue's Expected Behavior section. The DI container's singleton semantics are preserved: _container is still created exactly once, while _audit_subscriber_initialized guards the retry loop independently.

Correctness Analysis ✅

• Before: audit_event_subscriber() was called inside if _container is None:, so a failure was permanently cached — subsequent calls returned the container without retrying
• After: The retry logic is outside the container-creation guard, controlled by _audit_subscriber_initialized. On success, the flag is set True (no further attempts). On failure, it remains False (next call retries)
• reset_container() properly resets both _container and _audit_subscriber_initialized
• The global statement correctly declares both variables
• Log message updated from misleading "will be registered on first AuditEventSubscriber access" to accurate "will be retried on next get_container() call"
• No thread-safety concern: get_container() is called during startup (single-threaded), and PR #1224 addresses thread safety separately

Test Quality ✅

• BDD scenario directly tests the bug's behavior: first call fails, second call retries and succeeds
• FakeContainer with audit_init_attempts counter is a clean, minimal mock
• Assertions verify both singleton identity (first is second) AND retry count (attempts == 2)
• Proper cleanup via context.add_cleanup() restores original Container class
• ASV benchmark provides performance regression tracking for the retry path

Code Quality ✅

• Minimal change footprint — only the necessary lines modified
• Clean boolean flag approach — no over-engineering
• Docstring updated to document retry behavior and reference bug #992
• Comments explain the "why" clearly

Commit Standards ✅

• Single atomic commit with Conventional Changelog format
• ISSUES CLOSED: #992 footer present
• Clean commit message explaining both the fix and the TDD test inclusion

PR Metadata ✅

• Type/Bug label ✓
• v3.6.0 milestone ✓
• Closes #992 in body ✓
• No needs feedback label ✓

Minor Note (non-blocking)

The step definitions and benchmark use # type: ignore[assignment] for monkey-patching the Container class. This is a pragmatic necessity for this type of testing (assigning a FakeContainer to a typed module attribute) and is consistent with existing patterns in the codebase (e.g., get_ai_provider() in the same file already uses # type: ignore for mock loading).

Verdict: Clean, well-scoped bug fix with proper TDD regression test. Approved for merge.

## Independent Code Review: APPROVED ✅ **Reviewer**: pr-reviewer-3 (independent perspective) ### Changes Reviewed 1. **`src/cleveragents/application/container.py`** — Core bug fix: retry audit subscriber initialization 2. **`features/tdd_di_audit_cache_failure.feature`** — BDD regression test (from TDD issue #1096) 3. **`features/steps/tdd_di_audit_cache_failure_steps.py`** — Step definitions with FakeContainer mock 4. **`benchmarks/bench_audit_subscriber_retry.py`** — ASV benchmark for retry-path performance ### Specification Alignment ✅ The fix correctly addresses bug #992 as described in the issue. The approach — separating container creation (happens once) from audit subscriber initialization (retried until successful) — is the simplest and most backward-compatible of the three options listed in the issue's Expected Behavior section. The DI container's singleton semantics are preserved: `_container` is still created exactly once, while `_audit_subscriber_initialized` guards the retry loop independently. ### Correctness Analysis ✅ - **Before**: `audit_event_subscriber()` was called inside `if _container is None:`, so a failure was permanently cached — subsequent calls returned the container without retrying - **After**: The retry logic is outside the container-creation guard, controlled by `_audit_subscriber_initialized`. On success, the flag is set `True` (no further attempts). On failure, it remains `False` (next call retries) - `reset_container()` properly resets both `_container` and `_audit_subscriber_initialized` - The `global` statement correctly declares both variables - Log message updated from misleading "will be registered on first AuditEventSubscriber access" to accurate "will be retried on next get_container() call" - No thread-safety concern: `get_container()` is called during startup (single-threaded), and PR #1224 addresses thread safety separately ### Test Quality ✅ - BDD scenario directly tests the bug's behavior: first call fails, second call retries and succeeds - `FakeContainer` with `audit_init_attempts` counter is a clean, minimal mock - Assertions verify both singleton identity (`first is second`) AND retry count (`attempts == 2`) - Proper cleanup via `context.add_cleanup()` restores original Container class - ASV benchmark provides performance regression tracking for the retry path ### Code Quality ✅ - Minimal change footprint — only the necessary lines modified - Clean boolean flag approach — no over-engineering - Docstring updated to document retry behavior and reference bug #992 - Comments explain the "why" clearly ### Commit Standards ✅ - Single atomic commit with Conventional Changelog format - `ISSUES CLOSED: #992` footer present - Clean commit message explaining both the fix and the TDD test inclusion ### PR Metadata ✅ - `Type/Bug` label ✓ - v3.6.0 milestone ✓ - `Closes #992` in body ✓ - No `needs feedback` label ✓ ### Minor Note (non-blocking) The step definitions and benchmark use `# type: ignore[assignment]` for monkey-patching the Container class. This is a pragmatic necessity for this type of testing (assigning a FakeContainer to a typed module attribute) and is consistent with existing patterns in the codebase (e.g., `get_ai_provider()` in the same file already uses `# type: ignore` for mock loading). **Verdict**: Clean, well-scoped bug fix with proper TDD regression test. Approved for merge.

freemo referenced this pull request 2026-04-02 08:06:21 +00:00

bug(di): get_container() permanently caches failed audit subscriber initialization #992

freemo commented 2026-04-02 16:47:58 +00:00

Owner

Copy link

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.

freemo approved these changes 2026-04-02 16:51:11 +00:00

freemo left a comment

Copy link

Independent Code Review: APPROVED ✅

Reviewer: reviewer-pool-1 (independent perspective)

Files Reviewed

1. src/cleveragents/application/container.py — Core bug fix: retry audit subscriber initialization via _audit_subscriber_initialized flag
2. features/tdd_di_audit_cache_failure.feature — BDD regression test (from TDD issue #1096, @tdd_expected_fail removed)
3. features/steps/tdd_di_audit_cache_failure_steps.py — Step definitions with FakeContainer mock
4. benchmarks/bench_audit_subscriber_retry.py — ASV benchmark for retry-path performance

Specification Alignment ✅

The fix correctly addresses bug #992. The approach — separating container creation (happens once via if _container is None:) from audit subscriber initialization (retried until successful via if not _audit_subscriber_initialized:) — is the simplest and most backward-compatible option from the issue's Expected Behavior. The DI container's singleton semantics are fully preserved.

Correctness Analysis ✅

• Before (master): audit_event_subscriber() was called inside if _container is None:, so a failure was permanently cached — subsequent calls returned the container without retrying.
• After (this PR): The retry logic is outside the container-creation guard, controlled by _audit_subscriber_initialized. On success, the flag is set True (no further attempts). On failure, it remains False (next call retries).
• reset_container() properly resets both _container and _audit_subscriber_initialized — correct for test isolation.
• The global statement correctly declares both variables.
• Log message updated from misleading "will be registered on first AuditEventSubscriber access" to accurate "will be retried on next get_container() call".
• Docstring updated to document retry behavior and reference bug #992.

Test Quality ✅

• BDD scenario directly tests the bug's core behavior: first call fails, second call retries and succeeds.
• FakeContainer with audit_init_attempts counter is a clean, minimal mock.
• Assertions verify both singleton identity (first is second) AND retry count (attempts == 2).
• Proper cleanup via context.add_cleanup() restores original Container class.
• ASV benchmark provides performance regression tracking for the retry path.

Code Quality ✅

• Minimal change footprint — only the necessary lines modified in production code.
• Clean boolean flag approach — no over-engineering.
• Comments explain the "why" clearly.

Commit Standards ✅

• Single atomic commit with Conventional Changelog format: fix(di): ...
• ISSUES CLOSED: #992 footer present.
• Clean commit message explaining both the fix and the TDD test inclusion.

PR Metadata ✅

• Type/Bug label ✓
• v3.6.0 milestone ✓
• Closes #992 in body ✓
• No needs feedback label ✓

Minor Note (non-blocking)

The step definitions and benchmark use # type: ignore[assignment] for monkey-patching the Container class. This is a pragmatic necessity for test doubles (assigning a FakeContainer to a typed module attribute) and is consistent with existing patterns in the same file (get_ai_provider() on master already uses # type: ignore for mock loading). Not blocking since this is test/benchmark code only.

Thread Safety Note (non-blocking)

The _audit_subscriber_initialized flag is not thread-safe, but this is acceptable because get_container() is called during startup (single-threaded), and PR #1224 addresses thread safety for the audit service separately.

Verdict: Clean, well-scoped bug fix with proper TDD regression test. Approved for merge.

## Independent Code Review: APPROVED ✅ **Reviewer**: reviewer-pool-1 (independent perspective) ### Files Reviewed 1. **`src/cleveragents/application/container.py`** — Core bug fix: retry audit subscriber initialization via `_audit_subscriber_initialized` flag 2. **`features/tdd_di_audit_cache_failure.feature`** — BDD regression test (from TDD issue #1096, `@tdd_expected_fail` removed) 3. **`features/steps/tdd_di_audit_cache_failure_steps.py`** — Step definitions with FakeContainer mock 4. **`benchmarks/bench_audit_subscriber_retry.py`** — ASV benchmark for retry-path performance ### Specification Alignment ✅ The fix correctly addresses bug #992. The approach — separating container creation (happens once via `if _container is None:`) from audit subscriber initialization (retried until successful via `if not _audit_subscriber_initialized:`) — is the simplest and most backward-compatible option from the issue's Expected Behavior. The DI container's singleton semantics are fully preserved. ### Correctness Analysis ✅ - **Before (master)**: `audit_event_subscriber()` was called inside `if _container is None:`, so a failure was permanently cached — subsequent calls returned the container without retrying. - **After (this PR)**: The retry logic is outside the container-creation guard, controlled by `_audit_subscriber_initialized`. On success, the flag is set `True` (no further attempts). On failure, it remains `False` (next call retries). - `reset_container()` properly resets both `_container` and `_audit_subscriber_initialized` — correct for test isolation. - The `global` statement correctly declares both variables. - Log message updated from misleading "will be registered on first AuditEventSubscriber access" to accurate "will be retried on next get_container() call". - Docstring updated to document retry behavior and reference bug #992. ### Test Quality ✅ - BDD scenario directly tests the bug's core behavior: first call fails, second call retries and succeeds. - `FakeContainer` with `audit_init_attempts` counter is a clean, minimal mock. - Assertions verify both singleton identity (`first is second`) AND retry count (`attempts == 2`). - Proper cleanup via `context.add_cleanup()` restores original Container class. - ASV benchmark provides performance regression tracking for the retry path. ### Code Quality ✅ - Minimal change footprint — only the necessary lines modified in production code. - Clean boolean flag approach — no over-engineering. - Comments explain the "why" clearly. ### Commit Standards ✅ - Single atomic commit with Conventional Changelog format: `fix(di): ...` - `ISSUES CLOSED: #992` footer present. - Clean commit message explaining both the fix and the TDD test inclusion. ### PR Metadata ✅ - `Type/Bug` label ✓ - v3.6.0 milestone ✓ - `Closes #992` in body ✓ - No `needs feedback` label ✓ ### Minor Note (non-blocking) The step definitions and benchmark use `# type: ignore[assignment]` for monkey-patching the Container class. This is a pragmatic necessity for test doubles (assigning a FakeContainer to a typed module attribute) and is consistent with existing patterns in the same file (`get_ai_provider()` on master already uses `# type: ignore` for mock loading). Not blocking since this is test/benchmark code only. ### Thread Safety Note (non-blocking) The `_audit_subscriber_initialized` flag is not thread-safe, but this is acceptable because `get_container()` is called during startup (single-threaded), and PR #1224 addresses thread safety for the audit service separately. **Verdict**: Clean, well-scoped bug fix with proper TDD regression test. Approved for merge.

freemo merged commit a0c6ecd3ad into master 2026-04-02 16:51:29 +00:00

freemo deleted branch bugfix/m7-di-audit-cache-failure 2026-04-02 16:51:30 +00:00

freemo referenced this pull request 2026-04-02 16:51:38 +00:00

bug(di): get_container() permanently caches failed audit subscriber initialization #992

freemo referenced this pull request 2026-04-02 16:52:37 +00:00

bug(di): get_container() permanently caches failed audit subscriber initialization #992

freemo referenced this pull request 2026-04-02 17:11:30 +00:00

[Automated] Product Build Session State #1314

freemo referenced this pull request 2026-04-02 17:34:52 +00:00

[Automated] Product Build Session State #1393

Sign in to join this conversation.

Reviewers

No reviewers

freemo

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.6.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

freemo

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!1223

No description provided.