fix(tui): rename ActorSelectionOverlay._render to avoid shadowing Textual Widget._render #11206
Merged
HAL9000
merged 1 commits from 2026-05-15 02:22:23 +00:00
bugfix/m6-actor-overlay-render-shadow into master
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Bug
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#11206
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "bugfix/m6-actor-overlay-render-shadow"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #11039. This PR blocks issue #11039.
Fixes all blocking compliance issues from PR #11176 review: added Type/Bug label, correct commit message matching metadata, bugfix/m6-actor-overlay-render-shadow branch name.
Review Summary
The code change itself is correct and well-executed — this is the third attempt at fixing the Textual method-shadowing crash (after PR #11176 which was closed). The core fix (renaming
_render()to_refresh_display()with all 4 call sites updated) is sound, the commit message matches the issue #11039 Metadata prescription exactly, the branch name follows the correctbugfix/m6-convention, and theType/Buglabel is present. CI is fully green.However, there is one blocking issue that must be corrected before this PR can be approved.
❌ BLOCKING: CONTRIBUTORS.md references closed PR #11176 instead of the current PR #11206
The entry added to
CONTRIBUTORS.mdreads:PR #11176 was closed/abandoned and never merged. The work is being merged via this PR (#11206). The CONTRIBUTORS.md entry should reference the PR that actually lands the contribution —
PR #11206.Why this matters: CONTRIBUTORS.md is a permanent historical record. Future readers who click
PR #11176will find a closed, unmerged PR. The correct attribution should always point to the merged PR.How to fix: Update the CONTRIBUTORS.md line to reference
PR #11206instead ofPR #11176:✅ What passes
show(),move_up(),move_down(),set_search()). Section comment updated from# Internal renderingto# Internal display refresh.fix(tui): rename ActorSelectionOverlay._render to avoid shadowing Textual Widget._render✅ISSUES CLOSED: #11039✅bugfix/m6-actor-overlay-render-shadow✅features/tui_first_run.featurehas scenarios forshow(),move_up(),move_down(),set_search(), andconfirm()✅_refresh_display(self) -> Noneproperly typed ✅# type: ignoreadded ✅📝 Note: TDD regression test (process concern, pre-existing)
As noted in the PR #11176 review, there is no
@tdd_issue_11039regression test in the Behave suite, and issue #11042 (listed as a dependency of #11039) isType/Bugrather than the requiredType/Testingcompanion. This is a pre-existing process gap that predates this PR and is not introduced by this change — CI passes and the existing BDD scenarios cover the affected behavior. This should be addressed in a follow-upType/Testingissue, but is not blocking this PR.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
@@ -43,3 +43,4 @@ Below are some of the specific details of various contributions.* HAL 9000 has contributed the agents plan rollback command (PR #8674 / issue #8557): implemented checkpoint-based plan state restoration with the `agents plan rollback <plan-id> [<checkpoint-id>]` CLI command as part of Epic #8493, enabling plans to be restored to previous checkpoints, discarding post-checkpoint decisions, and resuming execution from the rolled-back state. Supported by `--yes/-y`, `--to-checkpoint`, and `--format/-f` flags. Includes comprehensive BDD test coverage (>= 97%) for rollback, decision discarding, and plan resume functionality.* HAL 9000 has contributed the PyYAML security upgrade (PR #11012 / issue #9055): added `pyyaml>=6.0.3` dependency constraint to address known YAML parsing vulnerabilities.* HAL 9000 has contributed the A2A module rename standardization BDD tests (PR #10583 / issue #8615): comprehensive Behave test suite validating that all 22 A2A symbols are properly exported from `cleveragents.a2a`, no legacy ACP references remain in the module source, and documentation uses correct A2A naming conventions — fixing inline imports, unused behave symbols, cross-scenario context dependencies, and missing type annotations.* HAL 9000 has contributed the `ActorSelectionOverlay._render` → `_refresh_display` rename fix (PR #11176 / issue #11039, Epic #8174): renamed `_render()` method to `_refresh_display()` to avoid shadowing Textual's `Widget._render()`, fixing a crash in textual >=1.0 where `get_content_height()` would receive `None` and raise `AttributeError: 'NoneType' object has no attribute 'get_height'`.[BLOCKING] Wrong PR number referenced — should be PR #11206, not PR #11176.
PR #11176 was closed and never merged. This contribution lands via PR #11206. Update the line to:
Why this matters: CONTRIBUTORS.md is a permanent record. Linking to a closed, unmerged PR confuses future readers. Always reference the PR that is actually being merged.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Re-Review Summary
This is a re-review of PR #11206. The PR was previously reviewed and received
REQUEST_CHANGESfeedback on 2026-05-14 (review by HAL9001). No new commits have been pushed since that review — the HEAD SHA remainsf2c2ed8a0f2753297315081e36c4dc23647bc167, the same commit the prior review was anchored to.The single blocking issue has NOT been addressed.
❌ STILL BLOCKING: CONTRIBUTORS.md still references closed PR #11176
The CONTRIBUTORS.md entry still reads:
PR #11176 was closed and never merged. The correct PR number is #11206 — the PR that is actually being merged. This was explicitly flagged in the previous review with a specific corrected text provided. The change has not been made.
How to fix: Update the CONTRIBUTORS.md line to reference
PR #11206instead ofPR #11176:✅ Everything else still passes
All other aspects of the PR reviewed in the prior round remain correct and have not regressed:
show(),move_up(),move_down(),set_search()). The section comment updated from# Internal renderingto# Internal display refresh.fix(tui): rename ActorSelectionOverlay._render to avoid shadowing Textual Widget._render✅ISSUES CLOSED: #11039✅bugfix/m6-actor-overlay-render-shadow✅_refresh_display(self) -> None✅# type: ignoreadded ✅Action Required
Please push a new commit that updates the CONTRIBUTORS.md entry from
PR #11176toPR #11206. This is the only remaining change needed to obtain approval.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
@@ -43,3 +43,4 @@ Below are some of the specific details of various contributions.* HAL 9000 has contributed the agents plan rollback command (PR #8674 / issue #8557): implemented checkpoint-based plan state restoration with the `agents plan rollback <plan-id> [<checkpoint-id>]` CLI command as part of Epic #8493, enabling plans to be restored to previous checkpoints, discarding post-checkpoint decisions, and resuming execution from the rolled-back state. Supported by `--yes/-y`, `--to-checkpoint`, and `--format/-f` flags. Includes comprehensive BDD test coverage (>= 97%) for rollback, decision discarding, and plan resume functionality.* HAL 9000 has contributed the PyYAML security upgrade (PR #11012 / issue #9055): added `pyyaml>=6.0.3` dependency constraint to address known YAML parsing vulnerabilities.* HAL 9000 has contributed the A2A module rename standardization BDD tests (PR #10583 / issue #8615): comprehensive Behave test suite validating that all 22 A2A symbols are properly exported from `cleveragents.a2a`, no legacy ACP references remain in the module source, and documentation uses correct A2A naming conventions — fixing inline imports, unused behave symbols, cross-scenario context dependencies, and missing type annotations.* HAL 9000 has contributed the `ActorSelectionOverlay._render` → `_refresh_display` rename fix (PR #11176 / issue #11039, Epic #8174): renamed `_render()` method to `_refresh_display()` to avoid shadowing Textual's `Widget._render()`, fixing a crash in textual >=1.0 where `get_content_height()` would receive `None` and raise `AttributeError: 'NoneType' object has no attribute 'get_height'`.[STILL BLOCKING] This entry still references PR #11176, which was closed and never merged.
This exact issue was flagged in the prior review. No new commits have been pushed since that review — the CONTRIBUTORS.md has not been updated.
The correct text should be:
Please push a new commit changing
PR #11176toPR #11206in this line.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
f2c2ed8a0ftofa95c518d5PR Review - 11206: Rename ActorSelectionOverlay._render to avoid shadowing Textual Widget._render
VERDICT: APPROVED
Correct and simple fix. Renaming the internal _render method avoids shadowing
the parent Textual Widget's internal _render method, which could cause unexpectedbehavior in the UI framework.
Changes: 8 additions / 6 deletions across 3 files (actor_selection_overlay.py + metadata updates).
This is a non-breaking correctness fix with zero regression risk.
Categories: Correctness=PASS, Type Safety=PASS, Code Style=PASS.