cli/session: add BDD tests for --format flag and JSON envelope output to session tell #11148
Merged
HAL9000
merged 3 commits from 2026-06-14 18:36:15 +00:00
fix/cli-session-tell-format-flag into master
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#11148
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "fix/cli-session-tell-format-flag"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR adds BDD/Behave test coverage for the --format/-f flag on agents session tell. Added 6 Behave scenarios (json, yaml, plain, table, -f short flag, Rich regression), 6 step definitions, CHANGELOG.md and CONTRIBUTORS.md entries. Closes #10466
Review Summary
This is a first review of PR #11148. The PR adds 6 Behave scenarios and 6 step definitions for the
--format/-fflag onagents session tell, plusCHANGELOG.mdandCONTRIBUTORS.mdentries. The intent is sound, but there are multiple blocking issues preventing merge.CI Gate — FAILING (Blocking)
All required CI gates must be green before a PR can be merged. The following are currently failing:
CI / lintCI / unit_testsCI / integration_testsCI / tdd_quality_gateCI / status-checkCI / coveragePer company policy, all CI gates must pass before a PR is reviewed or merged. The code-level issues below likely explain the CI failures. Fix all of them and let CI go green before requesting re-review.
BLOCKER 1 — Wrong branch name prefix
The branch is named
fix/cli-session-tell-format-flag. Issue #10466 isType/Bugon milestonev3.2.0(m2), so the correct prefix per CONTRIBUTING.md isbugfix/with milestone shorthandm2. The required branch name is:Only
feature/,bugfix/, andtdd/prefixes are valid. Thefix/prefix is not recognised. Fix by renaming the branch.BLOCKER 2 — Missing
Type/label on PRThe PR has no labels at all. Per CONTRIBUTING.md, every PR must have exactly one
Type/label. Since this addresses bug #10466, the required label isType/Bug. Please add it.BLOCKER 3 — TDD workflow not followed
Issue #10466 is
Type/Bug. The project requires the TDD bug-fix workflow:tdd/mN-*branch with a failing test tagged@tdd_bug_10466(with@expected_fail)tdd/PR is merged first, putting a known-failing test intomasterbugfix/mN-*PR implements the fix and removes@expected_failfrom the testThis PR skips that workflow:
@format_flag, not@tdd_bug_10466@expected_faildecorator in the difftdd_quality_gateCI failure is a direct consequenceFix: re-tag the TDD scenario(s)
@tdd_bug_10466and ensure the TDD PR (with@expected_fail) was submitted and merged before this bugfix PR.BLOCKER 4 — Commit message has leading whitespace
The commit message first line begins with a space:
This violates the Conventional Changelog format. The correct first line (verbatim from issue Metadata) is:
Please amend the commit to remove the leading space.
BLOCKER 5 —
CHANGELOG.mdhas duplicate# ChangelogheaderCHANGELOG.mdnow begins:There are two identical top-level headings. Remove the duplicate so there is exactly one
# Changelog.BLOCKER 6 — Inconsistent CHANGELOG section headers
The PR adds its entry under a new
## [Unreleased]section (with square brackets), while the existing unreleased section is headed## Unreleased(without). This creates two separate unreleased sections. Merge the new entry into the existing## Unreleasedsection.Non-blocking Suggestions
Suggestion: The
@format_flagtag on scenarios has no role in the TDD or CI workflow — after fixing BLOCKER 3, consider whether it serves a useful purpose for selective Behave runs. If not, remove it to keep scenario tags minimal.Suggestion: The PR title says "add BDD tests" but the commit message describes an implementation change. Clarify the title to accurately reflect that this PR adds BDD test coverage for an already-implemented feature.
10-Category Checklist
@tdd_bug_10466tag; TDD workflow skipped# type: ignoreAction required: Fix all 6 blockers, run
noxlocally until fully green, then request re-review.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
BLOCKER — Duplicate
# ChangelogheaderThe file now opens with two consecutive
# Changelogheadings. Remove the second duplicate.BLOCKER — Two
Unreleasedsections with inconsistent namingThere is an existing
## Unreleasedsection (no brackets) higher in the file, and this PR adds a## [Unreleased]section (with brackets) further down. Merge the new entry into the existing## Unreleasedsection instead of creating a second one.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
BLOCKER — Wrong scenario tag (TDD workflow violation)
These 6 new scenarios carry
@format_flagbut the TDD bug-fix workflow requires@tdd_bug_10466. Thetdd_quality_gateCI job searches specifically for this tag pattern and its paired@expected_failremoval in the PR diff. Both are absent, which is whytdd_quality_gateis failing.How to fix:
bugfix/m2-cli-session-tell-format-flagtdd/m2-cli-session-tell-format-flag) was submitted with@expected_fail @tdd_bug_10466on the test and merged first@tdd_bug_10466(drop@format_flagunless it serves a distinct purpose)@expected_faildecorator removedAutomated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
[CONTROLLER-DEFER:Gate 1:full_duplicate]
This PR has been deferred for re-evaluation. The controller has stepped back
from processing it. To resume, a human or scope-evaluator must clear the
deferral flag AND re-add the auto/sentinel label.
Decision:
To clear the deferral (SQL):
UPDATE workflows SET deferred_reason=NULL,
deferred_at=NULL,
deferred_target_workflow_id=NULL
WHERE workflow_id = 500;
Audit ID: 172342
Automated by the CleverAgents controller pipeline.
Identity: HAL9000 (pipeline action)
📋 Estimate: tier 1.
PR adds 6 BDD scenarios and step definitions for the --format flag on
agents session tell(+201/-0, 4 files). Three CI issues require non-mechanical fixes: (1) ruff format reformat of the steps file, (2) missing @tdd_bug_10466 tag — applying the TDD bug-fix workflow convention correctly, (3) a newly-added scenario (Tell table format outputs ASCII table) that is failing in unit_tests, requiring diagnosis of the assertion mismatch against actual CLI output. Integration/status-check failures appear pre-existing and unrelated. Scope is limited to 2–3 test files but requires TDD workflow knowledge and test debugging.a0d154f072to9cf1a14969(attempt #9, tier 2)
🔧 Implementer attempt —
ci-not-ready.✅ Approved
Reviewed at commit
8d62a51.Confidence: high.
Claimed by
merge_drive.py(pid 2329255) until2026-06-14T20:06:11.203585+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
Approved by the controller reviewer stage (workflow 500).