cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

test(plan): add tdd issue-capture test for cleanup_stale destroying execute output before apply #11123

Closed
hurui200320 wants to merge 1 commit from tdd/m3-cleanup-stale-destroys-execute-output into master
pull from: tdd/m3-cleanup-stale-destroys-execute-output
merge into: cleveragents:master
Conversation 8 Commits 1 Files changed 10 +467 -77
hurui200320 commented 2026-05-11 09:18:45 +00:00
Member
Copy link

Summary

This PR adds the TDD issue-capture test for bug #11121 per the project's Bug Fix Workflow. A failing test must be committed to master before the fix is implemented.

Additionally, this PR fixes two CI failures that were blocking the PR:

  • tdd_quality_gate: Renamed tag convention from @tdd_bug_N to @tdd_issue_N (matching CONTRIBUTING.md) and added TDD issue-capture PR detection so the gate correctly recognizes PRs that add @tdd_expected_fail (rather than requiring its removal as a bug fix PR would).

  • integration_tests: Fixed a GraphRecursionError in PlanGenerationGraph caused by _should_retry() attempting in-place state mutation in a LangGraph conditional edge function (which cannot persist mutations). Replaced with a proper _handle_retry() node that increments retry_count via state returns.

What was changed

TDD issue-capture test (issue #11120)

Added two Behave scenarios in features/tdd_cleanup_stale_destroys_execute_output.feature with step definitions in features/steps/tdd_cleanup_stale_destroys_execute_output_steps.py.

PlanGenerationGraph fix

  • src/cleveragents/agents/graphs/plan_generation.py: Removed in-place state mutation from _should_retry(), added _handle_retry() node, updated _build_graph() to include the 5th node with proper routing.

TDD quality gate fix

  • scripts/tdd_quality_gate.py: Renamed @tdd_bug_N → @tdd_issue_N, added _diff_is_tdd_issue_capture() for detecting issue-capture PRs, updated run_quality_gate() and main().
  • Updated all related tests and test helpers (features/tdd_quality_gate.feature, features/steps/tdd_quality_gate_steps.py, robot/helper_tdd_quality_gate.py, features/steps/plan_generation_uncovered_lines_steps.py, robot/plan_generation_graph.robot).

The Bug Being Captured

_create_sandbox_for_plan() in plan.py calls GitWorktreeSandbox.cleanup_stale() unconditionally on every agents plan execute invocation — including when the plan is already in execute/complete state (awaiting apply). This silently destroys the cleveragents/plan-<id> git branch that holds all execution output, causing agents plan apply to find zero artifacts and produce an empty changeset.

Root cause location: plan.py → _create_sandbox_for_plan() → GitWorktreeSandbox.cleanup_stale(resource.location, plan_id) (unconditional call)

Quality Gates

  • nox -e lint: ✅ All checks passed
  • nox -e typecheck: ✅ 0 errors
  • nox -e unit_tests: ✅ 693 features passed, 15679 scenarios passed
  • nox -e integration_tests: ✅ 2013 tests passed, 0 failed
  • nox -e coverage_report: ✅ 96.52% (threshold: 96.5%)
  • nox -e tdd_quality_gate: ✅ Issue-capture PR detected for bug #11121
  • nox -e e2e_tests: Pre-existing failure on master (unrelated)

Closes

Closes #11120

Unblocks

Bug fix issue #11121 is now unblocked. Once the fix is merged, @tdd_expected_fail is removed and these scenarios become permanent regression guards.

## Summary This PR adds the TDD issue-capture test for bug #11121 per the project's Bug Fix Workflow. A failing test must be committed to `master` before the fix is implemented. Additionally, this PR fixes two CI failures that were blocking the PR: - **`tdd_quality_gate`**: Renamed tag convention from `@tdd_bug_N` to `@tdd_issue_N` (matching CONTRIBUTING.md) and added TDD issue-capture PR detection so the gate correctly recognizes PRs that *add* `@tdd_expected_fail` (rather than requiring its removal as a bug fix PR would). - **`integration_tests`**: Fixed a `GraphRecursionError` in `PlanGenerationGraph` caused by `_should_retry()` attempting in-place state mutation in a LangGraph conditional edge function (which cannot persist mutations). Replaced with a proper `_handle_retry()` node that increments `retry_count` via state returns. ## What was changed ### TDD issue-capture test (issue #11120) Added two Behave scenarios in `features/tdd_cleanup_stale_destroys_execute_output.feature` with step definitions in `features/steps/tdd_cleanup_stale_destroys_execute_output_steps.py`. ### PlanGenerationGraph fix - `src/cleveragents/agents/graphs/plan_generation.py`: Removed in-place state mutation from `_should_retry()`, added `_handle_retry()` node, updated `_build_graph()` to include the 5th node with proper routing. ### TDD quality gate fix - `scripts/tdd_quality_gate.py`: Renamed `@tdd_bug_N` → `@tdd_issue_N`, added `_diff_is_tdd_issue_capture()` for detecting issue-capture PRs, updated `run_quality_gate()` and `main()`. - Updated all related tests and test helpers (`features/tdd_quality_gate.feature`, `features/steps/tdd_quality_gate_steps.py`, `robot/helper_tdd_quality_gate.py`, `features/steps/plan_generation_uncovered_lines_steps.py`, `robot/plan_generation_graph.robot`). ## The Bug Being Captured `_create_sandbox_for_plan()` in `plan.py` calls `GitWorktreeSandbox.cleanup_stale()` unconditionally on every `agents plan execute` invocation — including when the plan is already in `execute/complete` state (awaiting apply). This silently destroys the `cleveragents/plan-<id>` git branch that holds all execution output, causing `agents plan apply` to find zero artifacts and produce an empty changeset. **Root cause location:** `plan.py` → `_create_sandbox_for_plan()` → `GitWorktreeSandbox.cleanup_stale(resource.location, plan_id)` (unconditional call) ## Quality Gates - `nox -e lint`: ✅ All checks passed - `nox -e typecheck`: ✅ 0 errors - `nox -e unit_tests`: ✅ 693 features passed, 15679 scenarios passed - `nox -e integration_tests`: ✅ 2013 tests passed, 0 failed - `nox -e coverage_report`: ✅ 96.52% (threshold: 96.5%) - `nox -e tdd_quality_gate`: ✅ Issue-capture PR detected for bug #11121 - `nox -e e2e_tests`: Pre-existing failure on master (unrelated) ## Closes Closes #11120 ## Unblocks Bug fix issue #11121 is now unblocked. Once the fix is merged, `@tdd_expected_fail` is removed and these scenarios become permanent regression guards.
hurui200320 added this to the v3.2.0 milestone 2026-05-11 09:18:58 +00:00
hurui200320 force-pushed tdd/m3-cleanup-stale-destroys-execute-output from 176e1c3a5f
Some checks failed
CI / coverage (pull_request) Blocked by required conditions
Details
CI / docker (pull_request) Blocked by required conditions
Details
CI / status-check (pull_request) Blocked by required conditions
Details
CI / unit_tests (pull_request) Has started running
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / helm (pull_request) Successful in 55s
Details
CI / push-validation (pull_request) Successful in 1m0s
Details
CI / build (pull_request) Successful in 1m53s
Details
CI / benchmark-regression (pull_request) Failing after 2m12s
Details
CI / typecheck (pull_request) Successful in 2m21s
Details
CI / quality (pull_request) Successful in 2m20s
Details
CI / lint (pull_request) Failing after 2m29s
Details
CI / security (pull_request) Successful in 2m39s
Details
CI / integration_tests (pull_request) Successful in 4m42s
Details
CI / e2e_tests (pull_request) Successful in 4m43s
Details
to a297a385aa
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / helm (pull_request) Successful in 46s
Details
CI / push-validation (pull_request) Successful in 23s
Details
CI / build (pull_request) Successful in 1m10s
Details
CI / lint (pull_request) Successful in 1m20s
Details
CI / benchmark-regression (pull_request) Failing after 1m23s
Details
CI / quality (pull_request) Successful in 1m25s
Details
CI / typecheck (pull_request) Successful in 1m34s
Details
CI / security (pull_request) Successful in 1m36s
Details
CI / e2e_tests (pull_request) Successful in 4m15s
Details
CI / integration_tests (pull_request) Successful in 4m17s
Details
CI / unit_tests (pull_request) Successful in 4m52s
Details
CI / docker (pull_request) Successful in 1m27s
Details
CI / coverage (pull_request) Successful in 10m41s
Details
CI / status-check (pull_request) Successful in 3s
Details
2026-05-11 09:26:50 +00:00 Compare
hurui200320 force-pushed tdd/m3-cleanup-stale-destroys-execute-output from a297a385aa
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / helm (pull_request) Successful in 46s
Details
CI / push-validation (pull_request) Successful in 23s
Details
CI / build (pull_request) Successful in 1m10s
Details
CI / lint (pull_request) Successful in 1m20s
Details
CI / benchmark-regression (pull_request) Failing after 1m23s
Details
CI / quality (pull_request) Successful in 1m25s
Details
CI / typecheck (pull_request) Successful in 1m34s
Details
CI / security (pull_request) Successful in 1m36s
Details
CI / e2e_tests (pull_request) Successful in 4m15s
Details
CI / integration_tests (pull_request) Successful in 4m17s
Details
CI / unit_tests (pull_request) Successful in 4m52s
Details
CI / docker (pull_request) Successful in 1m27s
Details
CI / coverage (pull_request) Successful in 10m41s
Details
CI / status-check (pull_request) Successful in 3s
Details
to 963aa77647
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / helm (pull_request) Successful in 45s
Details
CI / push-validation (pull_request) Successful in 45s
Details
CI / build (pull_request) Successful in 1m2s
Details
CI / lint (pull_request) Successful in 1m10s
Details
CI / benchmark-regression (pull_request) Failing after 1m34s
Details
CI / quality (pull_request) Successful in 1m46s
Details
CI / security (pull_request) Successful in 1m47s
Details
CI / typecheck (pull_request) Successful in 1m46s
Details
CI / integration_tests (pull_request) Successful in 3m42s
Details
CI / e2e_tests (pull_request) Successful in 4m18s
Details
CI / unit_tests (pull_request) Successful in 5m18s
Details
CI / docker (pull_request) Successful in 1m29s
Details
CI / coverage (pull_request) Successful in 10m32s
Details
CI / status-check (pull_request) Successful in 3s
Details
2026-05-11 10:17:34 +00:00 Compare
hurui200320 scheduled this pull request to auto merge when all checks succeed 2026-05-11 14:13:11 +00:00
HAL9001 requested changes 2026-05-11 22:47:55 +00:00
Dismissed
HAL9001 left a comment
Copy link

CI Checks Required

This PR cannot be approved until all CI checks are passing. Currently, no CI checks have been reported as passing for this PR — the CI status is failing.

Per company policy, all CI gates must pass before a PR can be approved and merged. The required gates are:

  • lint — code style and formatting
  • typecheck — static type checking (Pyright)
  • security — security scanning
  • unit_tests — BDD unit test suite (Behave)
  • coverage — minimum 97% coverage threshold

Please ensure:

  1. CI is correctly configured for this branch
  2. All required CI gates are passing
  3. Any test failures are resolved before re-requesting review

A full code review will be conducted once CI checks are in place and passing.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## CI Checks Required This PR cannot be approved until all CI checks are passing. Currently, no CI checks have been reported as passing for this PR — the CI status is **failing**. Per company policy, all CI gates must pass before a PR can be approved and merged. The required gates are: - `lint` — code style and formatting - `typecheck` — static type checking (Pyright) - `security` — security scanning - `unit_tests` — BDD unit test suite (Behave) - `coverage` — minimum 97% coverage threshold Please ensure: 1. CI is correctly configured for this branch 2. All required CI gates are passing 3. Any test failures are resolved before re-requesting review A full code review will be conducted once CI checks are in place and passing. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-05-11 22:47:59 +00:00
Owner
Copy link

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
hurui200320 force-pushed tdd/m3-cleanup-stale-destroys-execute-output from 963aa77647
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / helm (pull_request) Successful in 45s
Details
CI / push-validation (pull_request) Successful in 45s
Details
CI / build (pull_request) Successful in 1m2s
Details
CI / lint (pull_request) Successful in 1m10s
Details
CI / benchmark-regression (pull_request) Failing after 1m34s
Details
CI / quality (pull_request) Successful in 1m46s
Details
CI / security (pull_request) Successful in 1m47s
Details
CI / typecheck (pull_request) Successful in 1m46s
Details
CI / integration_tests (pull_request) Successful in 3m42s
Details
CI / e2e_tests (pull_request) Successful in 4m18s
Details
CI / unit_tests (pull_request) Successful in 5m18s
Details
CI / docker (pull_request) Successful in 1m29s
Details
CI / coverage (pull_request) Successful in 10m32s
Details
CI / status-check (pull_request) Successful in 3s
Details
to 68ad3c1ed6
Some checks failed
CI / push-validation (pull_request) Successful in 50s
Details
CI / helm (pull_request) Successful in 53s
Details
CI / build (pull_request) Successful in 1m15s
Details
CI / tdd_quality_gate (pull_request) Failing after 1m23s
Details
CI / lint (pull_request) Successful in 1m36s
Details
CI / quality (pull_request) Successful in 1m35s
Details
CI / typecheck (pull_request) Successful in 1m38s
Details
CI / security (pull_request) Successful in 2m16s
Details
CI / e2e_tests (pull_request) Successful in 4m17s
Details
CI / integration_tests (pull_request) Failing after 6m54s
Details
CI / unit_tests (pull_request) Successful in 9m12s
Details
CI / docker (pull_request) Successful in 1m46s
Details
CI / coverage (pull_request) Successful in 12m29s
Details
CI / status-check (pull_request) Failing after 4s
Details
2026-05-12 03:09:12 +00:00 Compare
HAL9001 requested changes 2026-05-12 03:26:45 +00:00
HAL9001 left a comment
Copy link

CI Failure — Blocking Merge

This PR has failing CI checks that must be resolved before it can be approved and merged.

Failing Checks

Check Status Details
CI / tdd_quality_gate ❌ Failing Failing after 1m23s
CI / integration_tests ❌ Failing Failing after 6m54s

Action Required

Per company policy, all CI gates must pass before a PR can be approved and merged. Please investigate and fix both failing checks:

  • tdd_quality_gate: This gate enforces TDD tag rules (@tdd_issue_N must exist, @tdd_expected_fail must be present on issue-capture tests, assertion failure types must be used rather than runtime exceptions). Since this is a TDD issue-capture test PR, verify the tags are correctly applied and that the test uses AssertionError (not RuntimeError or similar) to produce its expected failure.
  • integration_tests: Review the Robot Framework integration test failure. The new TDD test may be interfering with the integration suite, or an existing integration test may have broken.

A full code review will be conducted once all CI checks are green.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## CI Failure — Blocking Merge This PR has failing CI checks that must be resolved before it can be approved and merged. ### Failing Checks | Check | Status | Details | |-------|--------|---------| | `CI / tdd_quality_gate` | ❌ Failing | Failing after 1m23s | | `CI / integration_tests` | ❌ Failing | Failing after 6m54s | ### Action Required Per company policy, **all CI gates must pass** before a PR can be approved and merged. Please investigate and fix both failing checks: - **`tdd_quality_gate`**: This gate enforces TDD tag rules (`@tdd_issue_N` must exist, `@tdd_expected_fail` must be present on issue-capture tests, assertion failure types must be used rather than runtime exceptions). Since this is a TDD issue-capture test PR, verify the tags are correctly applied and that the test uses `AssertionError` (not `RuntimeError` or similar) to produce its expected failure. - **`integration_tests`**: Review the Robot Framework integration test failure. The new TDD test may be interfering with the integration suite, or an existing integration test may have broken. A full code review will be conducted once all CI checks are green. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
hurui200320 force-pushed tdd/m3-cleanup-stale-destroys-execute-output from 68ad3c1ed6
Some checks failed
CI / push-validation (pull_request) Successful in 50s
Details
CI / helm (pull_request) Successful in 53s
Details
CI / build (pull_request) Successful in 1m15s
Details
CI / tdd_quality_gate (pull_request) Failing after 1m23s
Details
CI / lint (pull_request) Successful in 1m36s
Details
CI / quality (pull_request) Successful in 1m35s
Details
CI / typecheck (pull_request) Successful in 1m38s
Details
CI / security (pull_request) Successful in 2m16s
Details
CI / e2e_tests (pull_request) Successful in 4m17s
Details
CI / integration_tests (pull_request) Failing after 6m54s
Details
CI / unit_tests (pull_request) Successful in 9m12s
Details
CI / docker (pull_request) Successful in 1m46s
Details
CI / coverage (pull_request) Successful in 12m29s
Details
CI / status-check (pull_request) Failing after 4s
Details
to e23126b8a1
All checks were successful
CI / helm (pull_request) Successful in 42s
Details
CI / push-validation (pull_request) Successful in 41s
Details
CI / build (pull_request) Successful in 1m9s
Details
CI / quality (pull_request) Successful in 1m19s
Details
CI / lint (pull_request) Successful in 1m21s
Details
CI / typecheck (pull_request) Successful in 1m25s
Details
CI / tdd_quality_gate (pull_request) Successful in 1m25s
Details
CI / security (pull_request) Successful in 1m39s
Details
CI / e2e_tests (pull_request) Successful in 3m46s
Details
CI / integration_tests (pull_request) Successful in 4m0s
Details
CI / unit_tests (pull_request) Successful in 6m22s
Details
CI / docker (pull_request) Successful in 1m24s
Details
CI / coverage (pull_request) Successful in 9m47s
Details
CI / status-check (pull_request) Successful in 2s
Details
2026-05-12 04:54:05 +00:00 Compare
hurui200320 commented 2026-05-12 04:55:38 +00:00
Author
Member
Copy link

CI Fixes Applied

Both failing CI checks reported in the review have been resolved:

tdd_quality_gate

Root cause: The quality gate used @tdd_bug_N tag naming (mismatched with CONTRIBUTING.md's @tdd_issue_N) and had no logic to distinguish TDD issue-capture PRs (which add @tdd_expected_fail) from bug fix PRs (which remove it).

Fix:

  • scripts/tdd_quality_gate.py: Renamed @tdd_bug_N → @tdd_issue_N throughout, added _diff_is_tdd_issue_capture() for issue-capture PR detection
  • Updated features/tdd_quality_gate.feature, features/steps/tdd_quality_gate_steps.py, robot/helper_tdd_quality_gate.py to match
  • Gate now correctly passes for this PR: "TDD issue-capture PR detected: adding expected-fail test for bug(s) [11121]"

integration_tests

Root cause: PlanGenerationGraph._should_retry() mutated state["retry_count"] in-place, but LangGraph conditional edge functions cannot persist state mutations. The retry_count never incremented, so validation failures caused infinite looping until the GraphRecursionError (~10k iterations).

Fix in src/cleveragents/agents/graphs/plan_generation.py:

  • Added _handle_retry() node that increments retry_count via proper state return
  • Made _should_retry() read-only (routes only, no state mutation)
  • Added routing: validate → should_retry → handle_retry → analyze_requirements
  • Updated robot/plan_generation_graph.robot (node count 4→5, removed in-place mutation assertion)

Both Workflow Invoke and Workflow Stream integration tests now pass. The 2 remaining failures on master (Plan Generation Graph.Workflow Invoke / Workflow Stream) were pre-existing and unrelated to this PR.

Current CI Status

All quality gates pass on this branch:

  • ✅ lint
  • ✅ typecheck
  • ✅ unit_tests (693 features, 15679 scenarios)
  • ✅ integration_tests (2013 tests, 0 failures)
  • ✅ coverage_report (96.52%)
  • ✅ tdd_quality_gate (issue-capture PR detected)
## CI Fixes Applied Both failing CI checks reported in the review have been resolved: ### `tdd_quality_gate` **Root cause**: The quality gate used `@tdd_bug_N` tag naming (mismatched with CONTRIBUTING.md's `@tdd_issue_N`) and had no logic to distinguish TDD issue-capture PRs (which *add* `@tdd_expected_fail`) from bug fix PRs (which *remove* it). **Fix**: - `scripts/tdd_quality_gate.py`: Renamed `@tdd_bug_N` → `@tdd_issue_N` throughout, added `_diff_is_tdd_issue_capture()` for issue-capture PR detection - Updated `features/tdd_quality_gate.feature`, `features/steps/tdd_quality_gate_steps.py`, `robot/helper_tdd_quality_gate.py` to match - Gate now correctly passes for this PR: "TDD issue-capture PR detected: adding expected-fail test for bug(s) [11121]" ### `integration_tests` **Root cause**: `PlanGenerationGraph._should_retry()` mutated `state["retry_count"]` in-place, but LangGraph conditional edge functions cannot persist state mutations. The retry_count never incremented, so validation failures caused infinite looping until the GraphRecursionError (~10k iterations). **Fix** in `src/cleveragents/agents/graphs/plan_generation.py`: - Added `_handle_retry()` node that increments retry_count via proper state return - Made `_should_retry()` read-only (routes only, no state mutation) - Added routing: `validate → should_retry → handle_retry → analyze_requirements` - Updated `robot/plan_generation_graph.robot` (node count 4→5, removed in-place mutation assertion) Both `Workflow Invoke` and `Workflow Stream` integration tests now pass. The 2 remaining failures on master (`Plan Generation Graph.Workflow Invoke` / `Workflow Stream`) were pre-existing and unrelated to this PR. ### Current CI Status All quality gates pass on this branch: - ✅ `lint` - ✅ `typecheck` - ✅ `unit_tests` (693 features, 15679 scenarios) - ✅ `integration_tests` (2013 tests, 0 failures) - ✅ `coverage_report` (96.52%) - ✅ `tdd_quality_gate` (issue-capture PR detected)
hurui200320 commented 2026-05-12 06:24:38 +00:00
Author
Member
Copy link

@HAL9000 @HAL9001 please re-review, now all CI passed

@HAL9000 @HAL9001 please re-review, now all CI passed
hurui200320 commented 2026-05-12 06:58:18 +00:00
Author
Member
Copy link

Closing this PR as superseded by PR #11127. The TDD test file features/tdd_cleanup_stale_destroys_execute_output.feature and its step definitions are now provided directly in PR #11127 without the @tdd_expected_fail tag, since the bug is now fixed.

The test scenarios from this PR have been incorporated (and expanded with an additional execute/queued scenario) in the fix PR.

Closing this PR as superseded by PR #11127. The TDD test file `features/tdd_cleanup_stale_destroys_execute_output.feature` and its step definitions are now provided directly in PR #11127 without the `@tdd_expected_fail` tag, since the bug is now fixed. The test scenarios from this PR have been incorporated (and expanded with an additional `execute/queued` scenario) in the fix PR.
hurui200320 commented 2026-05-12 06:58:18 +00:00
Author
Member
Copy link

Closing this PR as superseded by PR #11127. The TDD test file features/tdd_cleanup_stale_destroys_execute_output.feature and its step definitions are now provided directly in PR #11127 without the @tdd_expected_fail tag, since the bug is now fixed.

The test scenarios from this PR have been incorporated (and expanded with an additional execute/queued scenario) in the fix PR.

Closing this PR as superseded by PR #11127. The TDD test file `features/tdd_cleanup_stale_destroys_execute_output.feature` and its step definitions are now provided directly in PR #11127 without the `@tdd_expected_fail` tag, since the bug is now fixed. The test scenarios from this PR have been incorporated (and expanded with an additional `execute/queued` scenario) in the fix PR.
hurui200320 commented 2026-05-12 08:38:23 +00:00
Author
Member
Copy link

Closing this PR since the tdd commit is now part of PR !11127

Closing this PR since the tdd commit is now part of PR !11127
hurui200320 closed this pull request 2026-05-12 08:38:32 +00:00
hurui200320 deleted branch tdd/m3-cleanup-stale-destroys-execute-output 2026-05-12 11:31:04 +00:00
All checks were successful
CI / helm (pull_request) Successful in 42s
Details
CI / push-validation (pull_request) Successful in 41s
Details
CI / build (pull_request) Successful in 1m9s
Required
Details
CI / quality (pull_request) Successful in 1m19s
Required
Details
CI / lint (pull_request) Successful in 1m21s
Required
Details
CI / typecheck (pull_request) Successful in 1m25s
Required
Details
CI / tdd_quality_gate (pull_request) Successful in 1m25s
Details
CI / security (pull_request) Successful in 1m39s
Required
Details
CI / e2e_tests (pull_request) Successful in 3m46s
Details
CI / integration_tests (pull_request) Successful in 4m0s
Required
Details
CI / unit_tests (pull_request) Successful in 6m22s
Required
Details
CI / docker (pull_request) Successful in 1m24s
Required
Details
CI / coverage (pull_request) Successful in 9m47s
Required
Details
CI / status-check (pull_request) Successful in 2s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
HAL9000
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#11120 TDD: cleanup_stale destroys git worktree branch on re-invoked execute, causing plan apply to find zero artifacts
cleveragents/cleveragents-core
#11127 fix(plan): guard cleanup_stale against execute/processing and execute/complete plans
cleveragents/cleveragents-core
Reference
cleveragents/cleveragents-core!11123
No description provided.