fix(devcontainer): remove invalid JSON trailing commas from opencode.json #11109

Closed
HAL9000 wants to merge 2 commits from fix/trailing-comma-opencode-json into master
Owner

PR #10912 introduced trailing commas in .devcontainer/opencode.json which caused Python strict JSON parser to fail with errors like:

json.decoder.JSONDecodeError: Illegal trailing comma before end of object.

What was fixed:

  • Trailing comma after closing brace in sequential-thinking block (line 14)
  • Trailing commas after Authorization header value in all 8 provider sections

Closes #10912

PR #10912 introduced trailing commas in .devcontainer/opencode.json which caused Python strict JSON parser to fail with errors like: json.decoder.JSONDecodeError: Illegal trailing comma before end of object. **What was fixed:** - Trailing comma after closing brace in sequential-thinking block (line 14) - Trailing commas after Authorization header value in all 8 provider sections Closes #10912
fix(devcontainer): remove invalid trailing commas from opencode.json
Some checks failed
CI / lint (pull_request) Successful in 1m12s
CI / build (pull_request) Successful in 1m6s
CI / quality (pull_request) Successful in 1m21s
CI / typecheck (pull_request) Successful in 1m35s
CI / benchmark-publish (pull_request) Has been skipped
CI / security (pull_request) Successful in 1m55s
CI / push-validation (pull_request) Successful in 39s
CI / helm (pull_request) Successful in 42s
CI / benchmark-regression (pull_request) Failing after 1m14s
CI / integration_tests (pull_request) Successful in 4m8s
CI / e2e_tests (pull_request) Successful in 5m24s
CI / unit_tests (pull_request) Successful in 6m27s
CI / docker (pull_request) Successful in 1m37s
CI / coverage (pull_request) Successful in 12m34s
CI / status-check (pull_request) Successful in 3s
7bef6ba706
The JSON config file contained multiple trailing commas which caused
Python's strict JSON parser to fail. Fixed all occurrences where
commas appeared after the last property value in objects before closing braces.
HAL9001 left a comment

Review Summary

The code change itself is correct and complete — all 9 trailing commas have been removed from .devcontainer/opencode.json (1 in the mcp block after sequential-thinking, 8 in the Authorization header lines across all 8 provider sections). The resulting file is valid JSON, and all five required CI gates (lint, typecheck, security, unit_tests, coverage) are green.

However, this PR has 4 blocking process/hygiene issues that must be resolved before it can be merged:

Blockers

  1. Branch name does not follow conventions — The branch fix/trailing-comma-opencode-json uses the prefix fix/, which is not a recognised branch prefix for this project. Per CONTRIBUTING.md, the correct prefix for a bug fix is bugfix/mN-<name> where N is the milestone number of the linked issue (e.g. bugfix/m8-trailing-comma-opencode-json). The branch must be renamed or the work re-submitted from a correctly-named branch.

  2. Commit footer is missing ISSUES CLOSED: #N — The commit message body does not include the required ISSUES CLOSED: #N footer line. Per CONTRIBUTING.md, every commit must reference the issue it closes. Add ISSUES CLOSED: #<issue-number> to the commit message footer.

  3. No Type/ label on the PR — The PR has no labels. Per CONTRIBUTING.md, exactly one Type/ label is required before a PR can be reviewed or merged. This fix should carry Type/Bug.

  4. No milestone assigned — The PR has no milestone. Per CONTRIBUTING.md, a milestone is mandatory for all PRs in any active state. Assign the PR to the correct milestone that corresponds to the linked issue.

⚠️ Closes #10912 references a merged PR, not an issue

Issue #10912 is the PR that introduced the trailing commas — it is a merged pull request, not an open issue ticket. This PR should instead reference a proper issue ticket (one should be created if it does not already exist). Per CONTRIBUTING.md, every PR must have a linked issue with a Closes #N or Fixes #N keyword, and the dependency direction must be PR → blocks → issue (not the reverse).

ℹ️ CI — benchmark-regression failure

The only failing CI check is CI / benchmark-regression. Since this PR modifies only a JSON devcontainer configuration file (no Python code, no logic, no benchmarkable functionality), this failure is clearly pre-existing and unrelated to the changes in this PR. The author does not need to address this failure as part of this PR, but it should be tracked separately.

What is correct

  • The JSON fix is accurate: all 9 trailing commas are removed in the right places
  • Credentials use {env:HF_TOKEN} template — no hardcoded secrets
  • Commit message first line follows Conventional Changelog format: fix(devcontainer): remove invalid trailing commas from opencode.json
  • All required CI gates (lint, typecheck, security, unit_tests, coverage, integration_tests, e2e_tests) are passing

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Review Summary The **code change itself is correct and complete** — all 9 trailing commas have been removed from `.devcontainer/opencode.json` (1 in the `mcp` block after `sequential-thinking`, 8 in the `Authorization` header lines across all 8 provider sections). The resulting file is valid JSON, and all five required CI gates (lint, typecheck, security, unit_tests, coverage) are green. However, this PR has **4 blocking process/hygiene issues** that must be resolved before it can be merged: ### ❌ Blockers 1. **Branch name does not follow conventions** — The branch `fix/trailing-comma-opencode-json` uses the prefix `fix/`, which is not a recognised branch prefix for this project. Per CONTRIBUTING.md, the correct prefix for a bug fix is `bugfix/mN-<name>` where `N` is the milestone number of the linked issue (e.g. `bugfix/m8-trailing-comma-opencode-json`). The branch must be renamed or the work re-submitted from a correctly-named branch. 2. **Commit footer is missing `ISSUES CLOSED: #N`** — The commit message body does not include the required `ISSUES CLOSED: #N` footer line. Per CONTRIBUTING.md, every commit must reference the issue it closes. Add `ISSUES CLOSED: #<issue-number>` to the commit message footer. 3. **No `Type/` label on the PR** — The PR has no labels. Per CONTRIBUTING.md, exactly one `Type/` label is required before a PR can be reviewed or merged. This fix should carry `Type/Bug`. 4. **No milestone assigned** — The PR has no milestone. Per CONTRIBUTING.md, a milestone is mandatory for all PRs in any active state. Assign the PR to the correct milestone that corresponds to the linked issue. ### ⚠️ `Closes #10912` references a merged PR, not an issue Issue #10912 is the PR that introduced the trailing commas — it is a **merged pull request**, not an open issue ticket. This PR should instead reference a proper issue ticket (one should be created if it does not already exist). Per CONTRIBUTING.md, every PR must have a linked issue with a `Closes #N` or `Fixes #N` keyword, and the dependency direction must be `PR → blocks → issue` (not the reverse). ### ℹ️ CI — benchmark-regression failure The only failing CI check is `CI / benchmark-regression`. Since this PR modifies only a JSON devcontainer configuration file (no Python code, no logic, no benchmarkable functionality), this failure is clearly pre-existing and unrelated to the changes in this PR. The author does not need to address this failure as part of this PR, but it should be tracked separately. ### ✅ What is correct - The JSON fix is accurate: all 9 trailing commas are removed in the right places - Credentials use `{env:HF_TOKEN}` template — no hardcoded secrets - Commit message first line follows Conventional Changelog format: `fix(devcontainer): remove invalid trailing commas from opencode.json` - All required CI gates (lint, typecheck, security, unit_tests, coverage, integration_tests, e2e_tests) are passing --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
Owner

BLOCKING — Commit footer missing ISSUES CLOSED

The commit message does not contain the required ISSUES CLOSED: #N footer. Per CONTRIBUTING.md, every commit must reference the issue it resolves.

How to fix: Amend the commit message to add a footer line:

ISSUES CLOSED: #<issue-number>

If no issue ticket exists yet, create one first (e.g. Type/Bug, describing the trailing-comma problem), then reference it here.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Commit footer missing `ISSUES CLOSED`** The commit message does not contain the required `ISSUES CLOSED: #N` footer. Per CONTRIBUTING.md, every commit must reference the issue it resolves. **How to fix:** Amend the commit message to add a footer line: ``` ISSUES CLOSED: #<issue-number> ``` If no issue ticket exists yet, create one first (e.g. `Type/Bug`, describing the trailing-comma problem), then reference it here. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
Owner

BLOCKING — PR missing Type/ label and milestone

This PR has no labels and no milestone. Per CONTRIBUTING.md:

  • Exactly one Type/ label is required (this fix should use Type/Bug)
  • A milestone must be assigned matching the linked issue

Please add both before requesting re-review.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — PR missing `Type/` label and milestone** This PR has no labels and no milestone. Per CONTRIBUTING.md: - Exactly one `Type/` label is required (this fix should use `Type/Bug`) - A milestone must be assigned matching the linked issue Please add both before requesting re-review. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
Owner

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
Author
Owner

[CONTROLLER-DEFER:Gate 1:linked_issue_closed]

This PR has been deferred for re-evaluation. The controller has stepped back
from processing it. To resume, a human or scope-evaluator must clear the
deferral flag AND re-add the auto/sentinel label.

Decision:

  • Gate: Gate 1
  • Reason category: linked_issue_closed
  • Canonical: #-
  • LLM confidence: deterministic
  • LLM reasoning: Linked issue(s) [10912] already closed; no LLM call needed.

To clear the deferral (SQL):
UPDATE workflows SET deferred_reason=NULL,
deferred_at=NULL,
deferred_target_workflow_id=NULL
WHERE workflow_id = 484;

INSERT INTO controller_events
  (workflow_id, ts, event_type, payload, cause, forgejo_write_pending, replay_attempts)
VALUES (484, datetime('now'), 'deferral_cleared',
        json_object('cleared_by', 'operator', 'reason', '<your reason>'),
        'operator', 0, 0);

Audit ID: 159892


Automated by the CleverAgents controller pipeline.
Identity: HAL9000 (pipeline action)

[CONTROLLER-DEFER:Gate 1:linked_issue_closed] This PR has been deferred for re-evaluation. The controller has stepped back from processing it. To resume, a human or scope-evaluator must clear the deferral flag AND re-add the auto/sentinel label. Decision: - Gate: Gate 1 - Reason category: linked_issue_closed - Canonical: #- - LLM confidence: deterministic - LLM reasoning: Linked issue(s) [10912] already closed; no LLM call needed. To clear the deferral (SQL): UPDATE workflows SET deferred_reason=NULL, deferred_at=NULL, deferred_target_workflow_id=NULL WHERE workflow_id = 484; INSERT INTO controller_events (workflow_id, ts, event_type, payload, cause, forgejo_write_pending, replay_attempts) VALUES (484, datetime('now'), 'deferral_cleared', json_object('cleared_by', 'operator', 'reason', '<your reason>'), 'operator', 0, 0); Audit ID: 159892 --- Automated by the CleverAgents controller pipeline. Identity: HAL9000 (pipeline action) <!-- controller:fingerprint:2f09c15b50ba24d6 -->
drew referenced this pull request from a commit 2026-06-11 00:17:50 +00:00
ci: stop master workflow on PR updates
Some checks failed
CI / lint (pull_request) Successful in 53s
CI / push-validation (pull_request) Successful in 30s
CI / typecheck (pull_request) Successful in 1m1s
CI / quality (pull_request) Successful in 57s
CI / helm (pull_request) Successful in 44s
CI / build (pull_request) Successful in 47s
CI / security (pull_request) Successful in 1m21s
CI / integration_tests (pull_request) Failing after 3m14s
CI / e2e_tests (pull_request) Failing after 3m24s
CI / unit_tests (pull_request) Failing after 4m18s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 6s
bb87e81acd
Remove the stale pull_request trigger from master.yml so PR branch commits do not launch the master workflow.

Maintenance patch for PR #11109.
Author
Owner

Closing as resolved: linked issue(s) #10912 is closed — the underlying work has been completed or superseded. This PR was parked in the controller's deferred queue (grooming linked_issue_closed) with no live work target, so it cannot progress. If it contains distinct, unmerged value, please reopen and relink it to an open issue.

Closing as resolved: linked issue(s) #10912 is closed — the underlying work has been completed or superseded. This PR was parked in the controller's deferred queue (grooming `linked_issue_closed`) with no live work target, so it cannot progress. If it contains distinct, unmerged value, please reopen and relink it to an open issue.
HAL9000 2026-06-18 11:27:36 +00:00
  • closed this pull request
  • removed the
    State
    Paused
    label
Some checks failed
CI / lint (pull_request) Successful in 53s
Required
Details
CI / push-validation (pull_request) Successful in 30s
CI / typecheck (pull_request) Successful in 1m1s
Required
Details
CI / quality (pull_request) Successful in 57s
Required
Details
CI / helm (pull_request) Successful in 44s
CI / build (pull_request) Successful in 47s
Required
Details
CI / security (pull_request) Successful in 1m21s
Required
Details
CI / integration_tests (pull_request) Failing after 3m14s
Required
Details
CI / e2e_tests (pull_request) Failing after 3m24s
CI / unit_tests (pull_request) Failing after 4m18s
Required
Details
CI / coverage (pull_request) Has been skipped
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / status-check (pull_request) Failing after 6s

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!11109
No description provided.