fix(tui): extract @token text correctly in on_input_submitted suggestions query #11004

HAL9000 · 2026-05-07T16:29:43Z

HAL9000 commented

2026-05-07 16:29:43 +00:00

SUMMARY

Fix TUI on_input_submitted handler to extract only the last @token text (without surrounding non-reference words) as the query for suggestions(), preventing garbage fuzzy matches.

PROBLEM

Previously, a prompt like "analyse @proj" would pass "analyse proj" as the query to suggestions(), producing garbage fuzzy matches because all @ characters were stripped and surrounding words were included.

SOLUTION

Replaced text.replace("@", "").strip() with re.findall(r"@(\S+)", text) in src/cleveragents/tui/app.py. Extracts only the last @token as the query (e.g. "analyse @proj" -> "proj").
Added TDD regression test suite covering 4 scenarios: single-token, category-prefixed, multi-token, standalone-token.

FILES CHANGED

src/cleveragents/tui/app.py - core fix: regex-based @token extraction
features/tdd_tui_suggestions_query_extraction_4741.feature - new TDD BDD test
features/steps/tdd_tui_suggestions_query_extraction_4741_steps.py - new step definitions
CHANGELOG.md - added entry under [Unreleased]/Fixed
CONTRIBUTORS.md - added contribution entry

COMMIT FOOTER

ISSUES CLOSED: #4741

# SUMMARY Fix TUI `on_input_submitted` handler to extract only the last @token text (without surrounding non-reference words) as the query for suggestions(), preventing garbage fuzzy matches. # PROBLEM Previously, a prompt like "analyse @proj" would pass "analyse proj" as the query to `suggestions()`, producing garbage fuzzy matches because all @ characters were stripped and surrounding words were included. # SOLUTION - Replaced `text.replace("@", "").strip()` with `re.findall(r"@(\S+)", text)` in `src/cleveragents/tui/app.py`. Extracts only the last @token as the query (e.g. "analyse @proj" -> "proj"). - Added TDD regression test suite covering 4 scenarios: single-token, category-prefixed, multi-token, standalone-token. # FILES CHANGED - `src/cleveragents/tui/app.py` - core fix: regex-based @token extraction - `features/tdd_tui_suggestions_query_extraction_4741.feature` - new TDD BDD test - `features/steps/tdd_tui_suggestions_query_extraction_4741_steps.py` - new step definitions - `CHANGELOG.md` - added entry under [Unreleased]/Fixed - `CONTRIBUTORS.md` - added contribution entry # COMMIT FOOTER ISSUES CLOSED: #4741

HAL9000 added 1 commit

2026-05-07 16:29:44 +00:00

fix(tui): extract @token text correctly in on_input_submitted suggestions query

CI / benchmark-publish (pull_request) Has been skipped

Details

CI / build (pull_request) Successful in 52s

Details

CI / lint (pull_request) Failing after 59s

Details

CI / helm (pull_request) Successful in 56s

Details

CI / push-validation (pull_request) Successful in 30s

Details

CI / quality (pull_request) Successful in 1m17s

Details

CI / typecheck (pull_request) Successful in 1m22s

Details

CI / security (pull_request) Successful in 1m30s

Details

CI / integration_tests (pull_request) Successful in 3m53s

Details

CI / e2e_tests (pull_request) Successful in 4m22s

Details

CI / unit_tests (pull_request) Failing after 4m42s

Details

CI / coverage (pull_request) Has been skipped

Details

CI / docker (pull_request) Has been skipped

Details

CI / status-check (pull_request) Failing after 3s

Details

CI / benchmark-regression (pull_request) Failing after 1m17s

Details

f435022f4c

Replace text.replace("@", "").strip() with re.findall(r"@(\S+)", text) to
extract only the last @token text (without the @ sign and without surrounding
non-reference words) as the query passed to suggestions().

Previously, a prompt like "analyse @proj" would pass "analyse proj" as the
query to suggestions(), producing garbage fuzzy matches. Now it correctly
passes "proj".

Add TDD regression tests with scenarios covering:
- Single @token in multi-word prompt
- @token with category prefix
- Multiple @tokens (uses last token)
- Standalone @token at start of prompt

ISSUES CLOSED: #4741

HAL9000 added this to the v3.2.0 milestone

2026-05-07 17:35:46 +00:00

HAL9000 added the

labels

2026-05-07 17:46:49 +00:00

HAL9001 requested changes

2026-05-07 23:22:00 +00:00

Dismissed

HAL9001 left a comment

Code Review — PR #11004

Outcome: REQUEST_CHANGES

The core logic fix itself is correct and well-targeted — replacing text.replace("@", "").strip() with re.findall(r"@(\S+)", text) is exactly the right approach for extracting the last @token as the suggestions() query. However, this PR has multiple blocking issues that must be resolved before it can merge.

CI Gate Failures (BLOCKING)

The following required CI jobs are currently failing:

Job	Status
`CI / lint`	FAILURE (59s)
`CI / unit_tests`	FAILURE (4m42s)
`CI / benchmark-regression`	FAILURE (1m17s)
`CI / status-check`	FAILURE (gate aggregator)
`CI / coverage`	SKIPPED (blocked by unit_tests failure — coverage gate unverified)

Per CONTRIBUTING.md, all required CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be merged. The coverage job did not run because unit_tests failed, so the >=97% coverage gate is also unverified.

Prohibited `# type: ignore` Comments (BLOCKING)

The step definitions file adds 6 # type: ignore[attr-defined] suppressions (lines 94–99). Per CONTRIBUTING.md, # type: ignore is absolutely prohibited — zero tolerance, no exceptions. Pyright strict mode must be satisfied without any suppressions.

Why: These suppressions mask Pyright errors that result from assigning attributes to ModuleType objects. The correct fix is to avoid using bare ModuleType objects — use SimpleNamespace with typed initialisation, typed dataclasses, or look at how existing step files handle mock Textual without suppressions.

How to fix: Remove all 6 # type: ignore lines. Replace the bare ModuleType objects with SimpleNamespace or typed classes.

Wrong CHANGELOG Entry (BLOCKING)

The CHANGELOG diff adds an entry for "Project delete JSON/YAML output now includes deleted_at timestamp (PR #8192)" — this is content from a completely different PR and has nothing to do with this fix. This entry appears to have been accidentally included during rebase.

How to fix: Remove the spurious PR #8192 entry from CHANGELOG.md. Add the correct entry for this fix under ### Fixed in [Unreleased], describing the @token extraction fix for issue #4741.

Spurious CONTRIBUTORS.md Entry (BLOCKING)

The CONTRIBUTORS.md diff adds two new lines instead of one. The second entry describes "the specs alignment fix for agents project delete output (PR #8192)" — content from a different PR.

How to fix: Keep only the TUI @token extraction fix entry (PR #10911 / issue #4741) and remove the spurious PR #8192 entry.

Branch Naming Violation (BLOCKING)

The branch name fix/10911-tui-suggestions-query-extraction does not follow the required convention. Per CONTRIBUTING.md:

Bug fix branches must use bugfix/mN-<name> prefix (not fix/)
Issue #4741 is in v3.7.0 which is m8
Correct name: bugfix/m8-tui-suggestions-query-extraction

How to fix: Rename the branch to bugfix/m8-tui-suggestions-query-extraction and resubmit the PR from that branch.

PR Missing Type/ Label (BLOCKING)

The PR has no Type/ label. Per CONTRIBUTING.md, every PR must have exactly one Type/ label. This PR fixes a Type/Bug issue, so it should be labelled Type/Bug.

PR Assigned to Wrong Milestone (BLOCKING)

The PR is assigned to v3.2.0 but linked issue #4741 is in v3.7.0. Per CONTRIBUTING.md, PRs must be assigned to the same milestone as the linked issue.

How to fix: Change PR milestone from v3.2.0 to v3.7.0.

Scenario 4 Test Defect — Trivially True Assertion (NON-BLOCKING, suggestion)

In Scenario 4 ("Standalone @token at start of prompt"), the Then step reads:

Then the suggestions query should be "actor:local/dev" not "actor:local/dev"

Both the expected and wrong values are identical. For input "@actor:local/dev", the old buggy code and the new fixed code both produce "actor:local/dev" — so this scenario passes with both broken and fixed implementations and does not detect the regression.

Suggestion: Change the scenario to use an input that exposes the old bug, e.g. use "find @actor:local/dev" with expected "actor:local/dev" and wrong "find actor:local/dev".

What Is Correct

The core fix in app.py is correct: re.findall(r"@(\S+)", text) followed by at_tokens[-1] correctly extracts the last @token text.
The import re placement is correct (top of file, stdlib imports section).
Three of the four TDD scenarios (1, 2, 3) correctly validate the regression fix.
The feature file tags @tdd_issue @tdd_issue_4741 are correctly applied to all scenarios.
The step file mock infrastructure architecture (mock Textual, app instantiation, patch-based query capture) is sound.
The commit message first line follows Conventional Changelog format and the commit body explains WHY.
The commit footer ISSUES CLOSED: #4741 is present.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Code Review — PR #11004 **Outcome: REQUEST_CHANGES** The core logic fix itself is correct and well-targeted — replacing `text.replace("@", "").strip()` with `re.findall(r"@(\S+)", text)` is exactly the right approach for extracting the last `@token` as the `suggestions()` query. However, this PR has multiple blocking issues that must be resolved before it can merge. --- ### CI Gate Failures (BLOCKING) The following required CI jobs are currently failing: | Job | Status | |---|---| | `CI / lint` | FAILURE (59s) | | `CI / unit_tests` | FAILURE (4m42s) | | `CI / benchmark-regression` | FAILURE (1m17s) | | `CI / status-check` | FAILURE (gate aggregator) | | `CI / coverage` | SKIPPED (blocked by unit_tests failure — coverage gate unverified) | Per CONTRIBUTING.md, all required CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be merged. The `coverage` job did not run because `unit_tests` failed, so the >=97% coverage gate is also unverified. --- ### Prohibited `# type: ignore` Comments (BLOCKING) The step definitions file adds 6 `# type: ignore[attr-defined]` suppressions (lines 94–99). Per CONTRIBUTING.md, `# type: ignore` is absolutely prohibited — zero tolerance, no exceptions. Pyright strict mode must be satisfied without any suppressions. Why: These suppressions mask Pyright errors that result from assigning attributes to `ModuleType` objects. The correct fix is to avoid using bare `ModuleType` objects — use `SimpleNamespace` with typed initialisation, typed dataclasses, or look at how existing step files handle mock Textual without suppressions. How to fix: Remove all 6 `# type: ignore` lines. Replace the bare `ModuleType` objects with `SimpleNamespace` or typed classes. --- ### Wrong CHANGELOG Entry (BLOCKING) The CHANGELOG diff adds an entry for "Project delete JSON/YAML output now includes `deleted_at` timestamp (PR #8192)" — this is content from a completely different PR and has nothing to do with this fix. This entry appears to have been accidentally included during rebase. How to fix: Remove the spurious PR #8192 entry from CHANGELOG.md. Add the correct entry for this fix under `### Fixed` in `[Unreleased]`, describing the @token extraction fix for issue #4741. --- ### Spurious CONTRIBUTORS.md Entry (BLOCKING) The CONTRIBUTORS.md diff adds two new lines instead of one. The second entry describes "the specs alignment fix for `agents project delete` output (PR #8192)" — content from a different PR. How to fix: Keep only the TUI @token extraction fix entry (PR #10911 / issue #4741) and remove the spurious PR #8192 entry. --- ### Branch Naming Violation (BLOCKING) The branch name `fix/10911-tui-suggestions-query-extraction` does not follow the required convention. Per CONTRIBUTING.md: - Bug fix branches must use `bugfix/mN-<name>` prefix (not `fix/`) - Issue #4741 is in `v3.7.0` which is `m8` - Correct name: `bugfix/m8-tui-suggestions-query-extraction` How to fix: Rename the branch to `bugfix/m8-tui-suggestions-query-extraction` and resubmit the PR from that branch. --- ### PR Missing Type/ Label (BLOCKING) The PR has no `Type/` label. Per CONTRIBUTING.md, every PR must have exactly one `Type/` label. This PR fixes a Type/Bug issue, so it should be labelled `Type/Bug`. --- ### PR Assigned to Wrong Milestone (BLOCKING) The PR is assigned to `v3.2.0` but linked issue #4741 is in `v3.7.0`. Per CONTRIBUTING.md, PRs must be assigned to the same milestone as the linked issue. How to fix: Change PR milestone from `v3.2.0` to `v3.7.0`. --- ### Scenario 4 Test Defect — Trivially True Assertion (NON-BLOCKING, suggestion) In Scenario 4 ("Standalone @token at start of prompt"), the Then step reads: Then the suggestions query should be "actor:local/dev" not "actor:local/dev" Both the expected and wrong values are identical. For input `"@actor:local/dev"`, the old buggy code and the new fixed code both produce `"actor:local/dev"` — so this scenario passes with both broken and fixed implementations and does not detect the regression. Suggestion: Change the scenario to use an input that exposes the old bug, e.g. use `"find @actor:local/dev"` with expected `"actor:local/dev"` and wrong `"find actor:local/dev"`. --- ### What Is Correct - The core fix in `app.py` is correct: `re.findall(r"@(\S+)", text)` followed by `at_tokens[-1]` correctly extracts the last @token text. - The `import re` placement is correct (top of file, stdlib imports section). - Three of the four TDD scenarios (1, 2, 3) correctly validate the regression fix. - The feature file tags `@tdd_issue @tdd_issue_4741` are correctly applied to all scenarios. - The step file mock infrastructure architecture (mock Textual, app instantiation, patch-based query capture) is sound. - The commit message first line follows Conventional Changelog format and the commit body explains WHY. - The commit footer `ISSUES CLOSED: #4741` is present. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

CHANGELOG.md Outdated

					
				@ -5,6 +5,13 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

				## [Unreleased]

				- **Project delete JSON/YAML output now includes `deleted_at` timestamp** (PR #8192):

BLOCKING — Wrong CHANGELOG Entry (Unrelated PR #8192 Content)

This entry describes 'Project delete JSON/YAML output now includes deleted_at timestamp (PR #8192)' which belongs to a completely different PR. It appears to have been accidentally included during a rebase or merge.

How to fix: Remove this entire entry. Add the correct entry for this PR's fix under ### Fixed in [Unreleased], e.g.:

- **TUI `on_input_submitted` now extracts correct `@token` text as suggestions query** (#4741): Replaced `text.replace("@", "").strip()` with `re.findall(r"@(\S+)", text)` to extract only the last `@token` text as the query passed to `suggestions()`. A prompt like `"analyse @proj"` now correctly uses `"proj"` as the query instead of `"analyse proj"`.

**BLOCKING — Wrong CHANGELOG Entry (Unrelated PR #8192 Content)** This entry describes 'Project delete JSON/YAML output now includes `deleted_at` timestamp (PR #8192)' which belongs to a completely different PR. It appears to have been accidentally included during a rebase or merge. How to fix: Remove this entire entry. Add the correct entry for this PR's fix under `### Fixed` in `[Unreleased]`, e.g.: ```markdown - **TUI `on_input_submitted` now extracts correct `@token` text as suggestions query** (#4741): Replaced `text.replace("@", "").strip()` with `re.findall(r"@(\S+)", text)` to extract only the last `@token` text as the query passed to `suggestions()`. A prompt like `"analyse @proj"` now correctly uses `"proj"` as the query instead of `"analyse proj"`. ```

CONTRIBUTORS.md Outdated

					
				@ -32,2 +32,4 @@

				* HAL 9000 has contributed the LLMTraceRepository data-integrity fix (PR #8185 / issue #7505): replaced the unconditional `session.commit()` in `LLMTraceRepository.save()` with a dual-path implementation that respects the UnitOfWork pattern — flushing only when an external session is provided, and flushing + committing + closing when operating standalone. This eliminates premature transaction commits, loss of rollback capability, and a docstring/implementation mismatch.

				* HAL 9000 has contributed the ACMS Index Data Model and File Traversal Engine (PR #9664 / issue #9579): foundational data structures for indexed context entries with hot/warm/cold/archive storage tier classification, tag system, and a timeout-safe chunked file traversal engine for large projects with 10,000+ files.

				* HAL 9000 has contributed the TUI @token extraction fix (PR #10911 / issue #4741): replaced `text.replace("@", "").strip()` with `re.findall(r"@(\S+)", text)` in `on_input_submitted` to extract only the last @token as the suggestions query, preventing garbage fuzzy matches when prompts contain non-reference words before tokens (e.g. "analyse @proj" → `"proj"` instead of `"analyse proj"`). Added TDD regression test suite covering single-token, category-prefixed, multi-token, and standalone-token scenarios.

				 * HAL 9000 has contributed the specs alignment fix for `agents project delete` output

BLOCKING — Spurious Second Entry for Unrelated PR #8192

This adds a second CONTRIBUTORS.md entry (lines 35–37) describing 'the specs alignment fix for agents project delete output (PR #8192)' — this is for a completely different PR and should not be in this commit.

How to fix: Remove the second entry (the one referencing PR #8192). Keep only the first new entry about the TUI @token extraction fix (PR #10911 / issue #4741).

**BLOCKING — Spurious Second Entry for Unrelated PR #8192** This adds a second CONTRIBUTORS.md entry (lines 35–37) describing 'the specs alignment fix for `agents project delete` output (PR #8192)' — this is for a completely different PR and should not be in this commit. How to fix: Remove the second entry (the one referencing PR #8192). Keep only the first new entry about the TUI @token extraction fix (PR #10911 / issue #4741).

features/steps/tdd_tui_suggestions_query_extraction_4741_steps.py Outdated

					
				@ -0,0 +91,4 @@

				        def __init__(self, *args: object, **kwargs: object) -> None:

				            self.text = ""

				    mock_textual_app.App = MockApp  # type: ignore[attr-defined]

BLOCKING — Prohibited # type: ignore Comments

Lines 94–99 add 6 # type: ignore[attr-defined] suppressions. Per CONTRIBUTING.md, # type: ignore is absolutely prohibited — zero tolerance, no exceptions.

These suppressions result from assigning attributes to bare ModuleType objects, which Pyright strict mode rejects because ModuleType does not declare those attributes.

How to fix: Replace the bare ModuleType objects with SimpleNamespace initialised with the mock classes as named attributes. For example:

from types import SimpleNamespace
mock_textual_app = SimpleNamespace(App=MockApp)
mock_textual_containers = SimpleNamespace(Vertical=MockVertical)
mock_textual_widgets = SimpleNamespace(
    Header=MockHeader,
    Footer=MockFooter,
    Static=MockStatic,
    TextArea=MockTextArea,
)

This satisfies Pyright without any suppression. Update sys.modules and all downstream references accordingly.

**BLOCKING — Prohibited `# type: ignore` Comments** Lines 94–99 add 6 `# type: ignore[attr-defined]` suppressions. Per CONTRIBUTING.md, `# type: ignore` is absolutely prohibited — zero tolerance, no exceptions. These suppressions result from assigning attributes to bare `ModuleType` objects, which Pyright strict mode rejects because `ModuleType` does not declare those attributes. How to fix: Replace the bare `ModuleType` objects with `SimpleNamespace` initialised with the mock classes as named attributes. For example: ```python from types import SimpleNamespace mock_textual_app = SimpleNamespace(App=MockApp) mock_textual_containers = SimpleNamespace(Vertical=MockVertical) mock_textual_widgets = SimpleNamespace( Header=MockHeader, Footer=MockFooter, Static=MockStatic, TextArea=MockTextArea, ) ``` This satisfies Pyright without any suppression. Update `sys.modules` and all downstream references accordingly.

features/tdd_tui_suggestions_query_extraction_4741.feature Outdated

					
				@ -0,0 +34,4 @@

				    Then the suggestions query should be "plan2" not "compare plan1 with plan2"

				  @tdd_issue @tdd_issue_4741

				  Scenario: Standalone @token at start of prompt uses only the token text as query

NON-BLOCKING Suggestion — Scenario 4 Assertion Is Trivially True

The Then step reads:

Then the suggestions query should be "actor:local/dev" not "actor:local/dev"

Both the expected and wrong values are identical. For input "@actor:local/dev", both the old buggy code (text.replace("@", "").strip()) and the new fixed code (re.findall(r"@(\S+)", text)[-1]) produce "actor:local/dev". This scenario therefore passes with both broken and fixed implementations and does not detect the regression.

Suggested fix: Change to an input where the old code would return a different (wrong) value, e.g.:

Scenario: Standalone @token preceded by words uses only the token text as query
  ...
  And I submit "find @actor:local/dev" to the app for issue 4741 and capture the suggestions query
  Then the suggestions query should be "actor:local/dev" not "find actor:local/dev"

**NON-BLOCKING Suggestion — Scenario 4 Assertion Is Trivially True** The `Then` step reads: ```gherkin Then the suggestions query should be "actor:local/dev" not "actor:local/dev" ``` Both the `expected` and `wrong` values are identical. For input `"@actor:local/dev"`, both the old buggy code (`text.replace("@", "").strip()`) and the new fixed code (`re.findall(r"@(\S+)", text)[-1]`) produce `"actor:local/dev"`. This scenario therefore passes with both broken and fixed implementations and does not detect the regression. Suggested fix: Change to an input where the old code would return a different (wrong) value, e.g.: ```gherkin Scenario: Standalone @token preceded by words uses only the token text as query ... And I submit "find @actor:local/dev" to the app for issue 4741 and capture the suggestions query Then the suggestions query should be "actor:local/dev" not "find actor:local/dev" ```

src/cleveragents/tui/app.py

					
				@ -7,3 +7,4 @@

				import re

				from dataclasses import dataclass

				from typing import TYPE_CHECKING, Any, ClassVar, Protocol

BLOCKING — Line Exceeds 88-Character ruff Limit

This line is 92 characters, exceeding the project ruff line-length limit of 88. This is almost certainly the cause of the CI / lint failure.

How to fix:

                    ref_picker = self.query_one(
                        "#reference-picker", ReferencePickerOverlay
                    )

**BLOCKING — Line Exceeds 88-Character ruff Limit** This line is 92 characters, exceeding the project ruff line-length limit of 88. This is almost certainly the cause of the `CI / lint` failure. How to fix: ```python ref_picker = self.query_one( "#reference-picker", ReferencePickerOverlay ) ```

HAL9001 commented

2026-05-07 23:22:06 +00:00

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9000 force-pushed fix/10911-tui-suggestions-query-extraction from f435022f4c

CI / benchmark-publish (pull_request) Has been skipped

Details

CI / build (pull_request) Successful in 52s

Details

CI / lint (pull_request) Failing after 59s

Details

CI / helm (pull_request) Successful in 56s

Details

CI / push-validation (pull_request) Successful in 30s

Details

CI / quality (pull_request) Successful in 1m17s

Details

CI / typecheck (pull_request) Successful in 1m22s

Details

CI / security (pull_request) Successful in 1m30s

Details

CI / integration_tests (pull_request) Successful in 3m53s

Details

CI / e2e_tests (pull_request) Successful in 4m22s

Details

CI / unit_tests (pull_request) Failing after 4m42s

Details

CI / coverage (pull_request) Has been skipped

Details

CI / docker (pull_request) Has been skipped

Details

CI / status-check (pull_request) Failing after 3s

Details

CI / benchmark-regression (pull_request) Failing after 1m17s

Details

to 0ce2e14f2d

CI / status-check (push) Blocked by required conditions

Details

CI / benchmark-regression (push) Has been skipped

Details

CI / helm (push) Successful in 45s

Details

CI / push-validation (push) Successful in 43s

Details

CI / quality (push) Successful in 1m29s

Details

CI / build (push) Successful in 1m7s

Details

CI / lint (push) Successful in 1m39s

Details

CI / typecheck (push) Successful in 1m54s

Details

CI / security (push) Successful in 1m55s

Details

CI / e2e_tests (push) Successful in 4m48s

Details

CI / unit_tests (push) Successful in 5m45s

Details

CI / integration_tests (push) Successful in 6m13s

Details

CI / docker (push) Successful in 1m32s

Details

CI / coverage (push) Failing after 19m57s

Details

CI / benchmark-publish (push) Successful in 1h18m32s

Details

CI / benchmark-publish (pull_request) Has been skipped

Details

CI / lint (pull_request) Successful in 56s

Details

CI / quality (pull_request) Successful in 1m14s

Details

CI / typecheck (pull_request) Successful in 1m24s

Details

CI / security (pull_request) Successful in 1m25s

Details

CI / helm (pull_request) Successful in 38s

Details

CI / push-validation (pull_request) Successful in 38s

Details

CI / build (pull_request) Successful in 1m6s

Details

CI / benchmark-regression (pull_request) Failing after 1m36s

Details

CI / unit_tests (pull_request) Successful in 4m51s

Details

CI / integration_tests (pull_request) Successful in 4m15s

Details

CI / e2e_tests (pull_request) Failing after 4m35s

Details

CI / coverage (pull_request) Has been cancelled

Details

CI / docker (pull_request) Has been cancelled

Details

CI / status-check (pull_request) Has been cancelled

Details

2026-05-08 01:27:08 +00:00

Compare

HAL9001 requested changes

2026-05-08 02:01:20 +00:00

Dismissed

HAL9001 left a comment

Re-Review — PR #11004

Outcome: REQUEST_CHANGES

This re-review was triggered because the PR head SHA now equals the master base SHA (0ce2e14f2d144e825c7efb6d0975e6f8173d3795). The PR shows 0 additions, 0 deletions, 0 changed files — the branch has been rebased flat onto master and contains no changes whatsoever relative to it.

CRITICAL: PR Is Empty — Branch Has No Changes (BLOCKING)

The PR branch fix/10911-tui-suggestions-query-extraction currently points to the exact same commit as master. There is no diff, no code to review, and nothing to merge. This means:

All prior feedback from the previous review (anchored at commit f435022f...) remains unaddressed — the fixes that were originally in that commit are now lost from the branch.
The PR cannot be merged in its current state. Merging would be a no-op and would not deliver the intended fix for issue #4741.

The author must restore the branch to a state that contains the actual fix. The recommended path is:

Create a new branch with the correct name bugfix/m8-tui-suggestions-query-extraction from master.
Cherry-pick or re-apply the original commit that contained the fix (commit f435022f... or equivalent).
Address all the blocking issues identified in the previous review before pushing.
Submit a new PR from the correctly-named branch.

Outstanding Blocking Issues from Previous Review (Still Unresolved)

All seven blocking issues raised in the previous review remain open because the branch no longer contains any code. For reference, they are:

Branch naming violation — Branch must be bugfix/m8-tui-suggestions-query-extraction, not fix/10911-tui-suggestions-query-extraction.
Prohibited # type: ignore comments — Six # type: ignore[attr-defined] suppressions must be removed from the step definitions file. Use SimpleNamespace or typed classes instead of bare ModuleType objects.
Wrong CHANGELOG entry — The spurious PR #8192 entry ("Project delete JSON/YAML output now includes deleted_at timestamp") must be removed; add only the correct @token extraction fix entry for issue #4741.
Spurious CONTRIBUTORS.md entry — Remove the spurious PR #8192 contributor entry; keep only the TUI @token extraction entry.
Missing Type/ label — The PR must have exactly one Type/ label; apply Type/Bug.
Wrong milestone — Change from v3.2.0 to v3.7.0 (to match linked issue #4741).
CI failures — The coverage check is failing on this SHA (the master HEAD itself). When the branch is restored with the fix, all required CI gates (lint, typecheck, security, unit_tests, coverage) must pass.

CI Status on Current Head

The current head SHA is the master HEAD. The following CI statuses are observed:

Job	Status
`CI / lint (pull_request)`	SUCCESS
`CI / typecheck (pull_request)`	SUCCESS
`CI / security (pull_request)`	SUCCESS
`CI / unit_tests (pull_request)`	PENDING
`CI / coverage (push)`	FAILURE
`CI / benchmark-regression (pull_request)`	FAILURE
`CI / status-check (pull_request)`	PENDING/BLOCKED

Note: The coverage and benchmark-regression failures on the master HEAD SHA are not introduced by this PR (the branch has no changes), but the coverage gate must pass when the actual fix is restored.

What to Do Next

The fix itself (as it existed at commit f435022f...) was architecturally correct — re.findall(r"@(\\S+)", text) is the right approach. The work is not being discarded, only the branch state is broken. Please:

Restore the branch content (cherry-pick or re-apply the original fix commit).
Fix all 7 blocking issues from the previous review before pushing.
Push to the correctly-named branch and update (or re-open) the PR.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Re-Review — PR #11004 **Outcome: REQUEST_CHANGES** This re-review was triggered because the PR head SHA now equals the master base SHA (`0ce2e14f2d144e825c7efb6d0975e6f8173d3795`). The PR shows **0 additions, 0 deletions, 0 changed files** — the branch has been rebased flat onto master and contains no changes whatsoever relative to it. --- ### CRITICAL: PR Is Empty — Branch Has No Changes (BLOCKING) The PR branch `fix/10911-tui-suggestions-query-extraction` currently points to the exact same commit as `master`. There is no diff, no code to review, and nothing to merge. This means: - **All prior feedback from the previous review (anchored at commit `f435022f...`) remains unaddressed** — the fixes that were originally in that commit are now lost from the branch. - **The PR cannot be merged in its current state.** Merging would be a no-op and would not deliver the intended fix for issue #4741. The author must restore the branch to a state that contains the actual fix. The recommended path is: 1. Create a new branch with the correct name `bugfix/m8-tui-suggestions-query-extraction` from `master`. 2. Cherry-pick or re-apply the original commit that contained the fix (commit `f435022f...` or equivalent). 3. Address all the blocking issues identified in the previous review before pushing. 4. Submit a new PR from the correctly-named branch. --- ### Outstanding Blocking Issues from Previous Review (Still Unresolved) All seven blocking issues raised in the previous review remain open because the branch no longer contains any code. For reference, they are: 1. **Branch naming violation** — Branch must be `bugfix/m8-tui-suggestions-query-extraction`, not `fix/10911-tui-suggestions-query-extraction`. 2. **Prohibited `# type: ignore` comments** — Six `# type: ignore[attr-defined]` suppressions must be removed from the step definitions file. Use `SimpleNamespace` or typed classes instead of bare `ModuleType` objects. 3. **Wrong CHANGELOG entry** — The spurious PR #8192 entry ("Project delete JSON/YAML output now includes `deleted_at` timestamp") must be removed; add only the correct @token extraction fix entry for issue #4741. 4. **Spurious CONTRIBUTORS.md entry** — Remove the spurious PR #8192 contributor entry; keep only the TUI @token extraction entry. 5. **Missing `Type/` label** — The PR must have exactly one `Type/` label; apply `Type/Bug`. 6. **Wrong milestone** — Change from `v3.2.0` to `v3.7.0` (to match linked issue #4741). 7. **CI failures** — The `coverage` check is failing on this SHA (the master HEAD itself). When the branch is restored with the fix, all required CI gates (lint, typecheck, security, unit_tests, coverage) must pass. --- ### CI Status on Current Head The current head SHA is the master HEAD. The following CI statuses are observed: | Job | Status | |---|---| | `CI / lint (pull_request)` | SUCCESS | | `CI / typecheck (pull_request)` | SUCCESS | | `CI / security (pull_request)` | SUCCESS | | `CI / unit_tests (pull_request)` | PENDING | | `CI / coverage (push)` | **FAILURE** | | `CI / benchmark-regression (pull_request)` | **FAILURE** | | `CI / status-check (pull_request)` | PENDING/BLOCKED | Note: The `coverage` and `benchmark-regression` failures on the master HEAD SHA are not introduced by this PR (the branch has no changes), but the coverage gate must pass when the actual fix is restored. --- ### What to Do Next The fix itself (as it existed at commit `f435022f...`) was architecturally correct — `re.findall(r"@(\\S+)", text)` is the right approach. The work is not being discarded, only the branch state is broken. Please: 1. Restore the branch content (cherry-pick or re-apply the original fix commit). 2. Fix all 7 blocking issues from the previous review before pushing. 3. Push to the correctly-named branch and update (or re-open) the PR. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9001 commented

2026-05-08 02:01:25 +00:00

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9001 requested changes

2026-05-08 02:09:21 +00:00

HAL9001 left a comment

Re-Review — PR #11004

Outcome: REQUEST_CHANGES

Thank you for the updated push — however, this re-review has uncovered a critical new blocker that makes the PR unresolvable in its current state: the branch has been accidentally reset to master HEAD and now contains zero changes.

🔴 CRITICAL — Branch Is Empty: All PR Content Lost

git diff master...HEAD on fix/10911-tui-suggestions-query-extraction produces no output. The branch tip (0ce2e14f) is the master commit titled "style: fix ruff format violations in devcontainer_autodiscovery_wiring_steps.py", which is completely unrelated to this PR. The Forgejo API confirms this: additions: 0, deletions: 0, changed_files: 0.

What happened: It appears the branch was either rebased onto master in a way that dropped the feature commits, or master was force-pushed onto the branch head. Either way, the PR currently contains no code changes.

How to fix:

Recover your feature commits (e.g. via git reflog or the previous commit SHA f435022f4cc01dd6e411f08e94b8f6ad15fe1366 referenced in the prior review)
Recreate the branch with the proper name bugfix/m7-tui-suggestions-query-extraction (see branch naming issue below)
Rebase those commits onto current master
Push to the new branch and update or recreate this PR

Previous Feedback Status

Because the branch is now empty, it is impossible to verify whether any of the previous blocking issues were addressed. The prior review requested the following fixes:

#	Issue	Status
1	CI lint failure (line too long in app.py)	Cannot verify — branch is empty
2	CI unit_tests failure	Cannot verify — branch is empty
3	Prohibited `# type: ignore` suppressions in step definitions	Cannot verify — branch is empty
4	Wrong CHANGELOG entry (spurious PR #8192 content)	Cannot verify — branch is empty
5	Spurious CONTRIBUTORS.md entry (PR #8192 content)	Cannot verify — branch is empty
6	Branch naming violation (`fix/` prefix, wrong milestone number)	Still unresolved (see below)
7	Missing `Type/` label on PR	Still unresolved
8	Wrong milestone (v3.2.0 → should be v3.7.0)	Still unresolved

❌ Branch Naming Violation (BLOCKING — Still Unresolved)

The branch name fix/10911-tui-suggestions-query-extraction still violates CONTRIBUTING.md in two ways:

Wrong prefix: Bug fix branches must use bugfix/ not fix/
Wrong milestone number: Issue #4741 is in milestone v3.7.0 which maps to m7

Required name: bugfix/m7-tui-suggestions-query-extraction

❌ Missing `Type/` Label (BLOCKING — Still Unresolved)

The PR still has no Type/ label. This PR fixes a Type/Bug issue and must be labelled Type/Bug.

❌ Wrong Milestone Assigned (BLOCKING — Still Unresolved)

The PR is assigned to milestone v3.2.0. Linked issue #4741 is in v3.7.0. Per CONTRIBUTING.md, PRs must be assigned to the same milestone as their linked issues.

How to fix: Change the PR milestone from v3.2.0 to v3.7.0.

CI Status (Current)

CI is running against the current (empty) branch, which is effectively just master. The only failure currently confirmed for the push context is CI / coverage — this is a pre-existing master issue not introduced by this PR. Most PR-context jobs are still in progress.

What Was Correct (From Prior Review — Still Acknowledged)

The core logic fix in app.py (replacing text.replace("@", "").strip() with re.findall(r"@(\\S+)", text)) was the right approach
The import re placement was correct
Three of the four TDD scenarios correctly validated the regression fix
The @tdd_issue @tdd_issue_4741 feature file tags were correct
The commit message format was correct
The commit footer ISSUES CLOSED: #4741 was present

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Re-Review — PR #11004 **Outcome: REQUEST_CHANGES** Thank you for the updated push — however, this re-review has uncovered a critical new blocker that makes the PR unresolvable in its current state: **the branch has been accidentally reset to master HEAD and now contains zero changes**. --- ### 🔴 CRITICAL — Branch Is Empty: All PR Content Lost `git diff master...HEAD` on `fix/10911-tui-suggestions-query-extraction` produces no output. The branch tip (`0ce2e14f`) is the master commit titled "style: fix ruff format violations in devcontainer_autodiscovery_wiring_steps.py", which is completely unrelated to this PR. The Forgejo API confirms this: `additions: 0`, `deletions: 0`, `changed_files: 0`. What happened: It appears the branch was either rebased onto master in a way that dropped the feature commits, or master was force-pushed onto the branch head. Either way, the PR currently contains no code changes. **How to fix:** 1. Recover your feature commits (e.g. via `git reflog` or the previous commit SHA `f435022f4cc01dd6e411f08e94b8f6ad15fe1366` referenced in the prior review) 2. Recreate the branch with the proper name `bugfix/m7-tui-suggestions-query-extraction` (see branch naming issue below) 3. Rebase those commits onto current master 4. Push to the new branch and update or recreate this PR --- ### Previous Feedback Status Because the branch is now empty, it is impossible to verify whether any of the previous blocking issues were addressed. The prior review requested the following fixes: | # | Issue | Status | |---|---|---| | 1 | CI lint failure (line too long in app.py) | Cannot verify — branch is empty | | 2 | CI unit_tests failure | Cannot verify — branch is empty | | 3 | Prohibited `# type: ignore` suppressions in step definitions | Cannot verify — branch is empty | | 4 | Wrong CHANGELOG entry (spurious PR #8192 content) | Cannot verify — branch is empty | | 5 | Spurious CONTRIBUTORS.md entry (PR #8192 content) | Cannot verify — branch is empty | | 6 | Branch naming violation (`fix/` prefix, wrong milestone number) | Still unresolved (see below) | | 7 | Missing `Type/` label on PR | Still unresolved | | 8 | Wrong milestone (v3.2.0 → should be v3.7.0) | Still unresolved | --- ### ❌ Branch Naming Violation (BLOCKING — Still Unresolved) The branch name `fix/10911-tui-suggestions-query-extraction` still violates CONTRIBUTING.md in two ways: - **Wrong prefix**: Bug fix branches must use `bugfix/` not `fix/` - **Wrong milestone number**: Issue #4741 is in milestone `v3.7.0` which maps to `m7` Required name: `bugfix/m7-tui-suggestions-query-extraction` --- ### ❌ Missing `Type/` Label (BLOCKING — Still Unresolved) The PR still has no `Type/` label. This PR fixes a `Type/Bug` issue and must be labelled `Type/Bug`. --- ### ❌ Wrong Milestone Assigned (BLOCKING — Still Unresolved) The PR is assigned to milestone `v3.2.0`. Linked issue #4741 is in `v3.7.0`. Per CONTRIBUTING.md, PRs must be assigned to the same milestone as their linked issues. How to fix: Change the PR milestone from `v3.2.0` to `v3.7.0`. --- ### CI Status (Current) CI is running against the current (empty) branch, which is effectively just master. The only failure currently confirmed for the push context is `CI / coverage` — this is a pre-existing master issue not introduced by this PR. Most PR-context jobs are still in progress. --- ### What Was Correct (From Prior Review — Still Acknowledged) - The core logic fix in `app.py` (replacing `text.replace("@", "").strip()` with `re.findall(r"@(\\S+)", text)`) was the right approach - The `import re` placement was correct - Three of the four TDD scenarios correctly validated the regression fix - The `@tdd_issue @tdd_issue_4741` feature file tags were correct - The commit message format was correct - The commit footer `ISSUES CLOSED: #4741` was present --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9001 commented

2026-05-08 02:09:25 +00:00

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9000 referenced this pull request from a commit

2026-05-08 11:04:09 +00:00

fix(tui): extract @token text correctly in on_input_submitted suggestions query

HAL9000 referenced this pull request

2026-05-08 20:34:09 +00:00

fix(tui): extract @token text correctly in on_input_submitted suggestions query #11055

HAL9000 referenced this pull request from a commit

2026-05-08 20:34:10 +00:00

fix(tui): extract @token text correctly in on_input_submitted suggestions query

HAL9000 referenced this pull request from a commit

2026-05-08 21:42:28 +00:00

fix(tui): extract @token text correctly in on_input_submitted suggestions query

CI / benchmark-publish (push) Has started running

Details

CI / helm (push) Successful in 40s

Details

CI / push-validation (push) Successful in 39s

Details

CI / benchmark-regression (push) Failing after 49s

Details

CI / build (push) Successful in 1m12s

Required

Details

CI / lint (push) Successful in 1m29s

Required

Details

CI / quality (push) Successful in 1m35s

Required

Details

CI / typecheck (push) Successful in 1m44s

Required

Details

CI / security (push) Successful in 2m4s

Required

Details

CI / e2e_tests (push) Successful in 52s

Details

CI / integration_tests (push) Successful in 5m23s

Required

Details

CI / unit_tests (push) Successful in 6m25s

Required

Details

CI / docker (push) Successful in 1m39s

Required

Details

CI / coverage (push) Successful in 11m21s

Required

Details

CI / status-check (push) Successful in 7s

Details

CI / lint (pull_request) Successful in 1m45s

Required

Details

CI / quality (pull_request) Successful in 1m41s

Required

Details

CI / security (pull_request) Successful in 2m19s

Required

Details

CI / typecheck (pull_request) Successful in 2m46s

Required

Details

CI / build (pull_request) Successful in 38s

Required

Details

CI / helm (pull_request) Successful in 38s

Details

CI / push-validation (pull_request) Successful in 25s

Details

CI / integration_tests (pull_request) Successful in 3m58s

Required

Details

CI / unit_tests (pull_request) Successful in 7m35s

Required

Details

CI / docker (pull_request) Successful in 1m55s

Required

Details

CI / coverage (pull_request) Successful in 15m21s

Required

Details

CI / status-check (pull_request) Successful in 10s

Details

This pull request has changes conflicting with the target branch.

CHANGELOG.md
CONTRIBUTORS.md

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'fix(tui): extract @token text correctly in on_input_submitted suggestions query' (#11004) from fix/10911-tui-suggestions-query-extraction into master

Merge commit body

Reviewed-on: https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/11004

Merge pull request 'fix(tui): extract @token text correctly in on_input_submitted suggestions query' (#11004) from fix/10911-tui-suggestions-query-extraction into master

Reviewed-on: https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/11004