`.opencode/scripts` do not meet `ruff check` requirements. #10848

New issue

Open

opened 2026-04-23 21:49:04 +00:00 by brent.edwards · 2 comments

brent.edwards commented

2026-04-23 21:49:04 +00:00

Member

Summary

The Python scripts in .opencode/scripts fail the ruff check requirements.

Metadata

Commit Message: style(.opencode/scripts): make ruff checkpass on.opencode/scripts`
Branch: m7-opencode-ruff

Details

From the root of the source code, type ruff check .. Here is the current output:

➜  /app git:(master) ✗ ruff check .
I001 [*] Import block is un-sorted or un-formatted
 --> .opencode/scripts/apply_tracking_updates.py:6:1
  |
4 |   """
5 |
6 | / import re
7 | | import os
  | |_________^
8 |
9 |   # Agent configurations
  |
help: Organize imports

UP015 [*] Unnecessary mode argument
  --> .opencode/scripts/apply_tracking_updates.py:60:25
   |
58 |     print(f"\nProcessing {filepath}...")
59 |
60 |     with open(filepath, "r") as f:
   |                         ^^^
61 |         content = f.read()
   |
help: Remove mode argument

E501 Line too long (110 > 88)
  --> .opencode/scripts/apply_tracking_updates.py:86:89
   |
84 |     new_section = f"""## Automation Tracking System
85 |
86 | **Updated**: This agent uses the centralized automation-tracking-manager subagent for all tracking operations.
   |                                                                                         ^^^^^^^^^^^^^^^^^^^^^^
87 |
88 | ### Tracking Issue Format
   |

W293 Blank line contains whitespace
   --> .opencode/scripts/apply_tracking_updates.py:159:1
    |
157 |           --repo-owner "$owner" \\
158 |           --repo-name "$repo")
159 |         
    | ^^^^^^^^
160 |         # Extract issue number and cycle from result
161 |         issue_number=$(echo "$result" | grep "ISSUE_NUMBER=" | cut -d'=' -f2)
    |
help: Remove whitespace from blank line

W293 Blank line contains whitespace
   --> .opencode/scripts/apply_tracking_updates.py:163:1
    |
161 |         issue_number=$(echo "$result" | grep "ISSUE_NUMBER=" | cut -d'=' -f2)
162 |         cycle_number=$(echo "$result" | grep "CYCLE_NUMBER=" | cut -d'=' -f2)
163 |         
    | ^^^^^^^^
164 |         # Update cycle for next iteration
165 |         cycle=$cycle_number"""
    |
help: Remove whitespace from blank line

Found 5 errors.
[*] 2 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

# Summary The Python scripts in `.opencode/scripts` fail the `ruff check` requirements. # Metadata Commit Message: `style(.opencode/scripts): make `ruff check` pass on `.opencode/scripts` Branch: m7-opencode-ruff # Details From the root of the source code, type `ruff check .`. Here is the current output: ``` ➜ /app git:(master) ✗ ruff check . I001 [*] Import block is un-sorted or un-formatted --> .opencode/scripts/apply_tracking_updates.py:6:1 | 4 | """ 5 | 6 | / import re 7 | | import os | |_________^ 8 | 9 | # Agent configurations | help: Organize imports UP015 [*] Unnecessary mode argument --> .opencode/scripts/apply_tracking_updates.py:60:25 | 58 | print(f"\nProcessing {filepath}...") 59 | 60 | with open(filepath, "r") as f: | ^^^ 61 | content = f.read() | help: Remove mode argument E501 Line too long (110 > 88) --> .opencode/scripts/apply_tracking_updates.py:86:89 | 84 | new_section = f"""## Automation Tracking System 85 | 86 | **Updated**: This agent uses the centralized automation-tracking-manager subagent for all tracking operations. | ^^^^^^^^^^^^^^^^^^^^^^ 87 | 88 | ### Tracking Issue Format | W293 Blank line contains whitespace --> .opencode/scripts/apply_tracking_updates.py:159:1 | 157 | --repo-owner "$owner" \\ 158 | --repo-name "$repo") 159 | | ^^^^^^^^ 160 | # Extract issue number and cycle from result 161 | issue_number=$(echo "$result" | grep "ISSUE_NUMBER=" | cut -d'=' -f2) | help: Remove whitespace from blank line W293 Blank line contains whitespace --> .opencode/scripts/apply_tracking_updates.py:163:1 | 161 | issue_number=$(echo "$result" | grep "ISSUE_NUMBER=" | cut -d'=' -f2) 162 | cycle_number=$(echo "$result" | grep "CYCLE_NUMBER=" | cut -d'=' -f2) 163 | | ^^^^^^^^ 164 | # Update cycle for next iteration 165 | cycle=$cycle_number""" | help: Remove whitespace from blank line Found 5 errors. [*] 2 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option). ```

brent.edwards added this to the v3.7.0 milestone

2026-04-23 21:49:04 +00:00

brent.edwards added the

labels

2026-04-23 21:49:04 +00:00

HAL9000 commented

2026-04-28 08:14:29 +00:00

Owner

Note: The file .opencode/scripts/apply_tracking_updates.py referenced in this issue was deleted in commit 18859900 ("build: auto opencode agents rewritten"). The .opencode/scripts/ directory no longer exists in master. Running ruff check . from the repo root now produces no errors from this path.

This issue appears to be already resolved by the deletion. Recommend closing as State/Wont Do or State/Completed.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

**Note**: The file `.opencode/scripts/apply_tracking_updates.py` referenced in this issue was deleted in commit `18859900` ("build: auto opencode agents rewritten"). The `.opencode/scripts/` directory no longer exists in master. Running `ruff check .` from the repo root now produces no errors from this path. This issue appears to be already resolved by the deletion. Recommend closing as `State/Wont Do` or `State/Completed`. --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor

HAL9000 referenced this issue from a commit

2026-04-28 09:19:39 +00:00

style(.opencode/scripts): make ruff check pass on .opencode/scripts

HAL9000 referenced this issue from a pull request that will close it,

2026-04-28 09:20:26 +00:00

style(.opencode/scripts): make ruff check pass on .opencode/scripts #10901

HAL9000 commented

2026-04-28 09:21:23 +00:00

Owner

Implementation Attempt — Tier 3: sonnet — Success

Implemented fix for issue #10848.

What was done:

Added .opencode/ to the nox -s lint session ruff check target list in noxfile.py
The previously failing .opencode/scripts/apply_tracking_updates.py was already removed in an earlier commit (commit 18859900); this change closes the gap by making the lint gate enforce ruff style on the entire .opencode/ directory going forward
Updated CHANGELOG.md with a new entry under [Unreleased] > Changed
PR #10901 created: #10901

Quality gate status:

lint ✓ (nox -e lint — ruff check passes including .opencode/)
format ✓ (nox -s format -- --check passes)
typecheck ✓ (0 errors, 3 warnings from third-party imports)
unit_tests: Not run locally (test suite requires extended time)
integration_tests: Not run locally
e2e_tests: Not run locally
coverage_report: Not run locally

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

**Implementation Attempt** — Tier 3: sonnet — Success Implemented fix for issue #10848. **What was done:** - Added `.opencode/` to the `nox -s lint` session ruff check target list in `noxfile.py` - The previously failing `.opencode/scripts/apply_tracking_updates.py` was already removed in an earlier commit (commit `18859900`); this change closes the gap by making the lint gate enforce ruff style on the entire `.opencode/` directory going forward - Updated `CHANGELOG.md` with a new entry under `[Unreleased] > Changed` - PR #10901 created: https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/10901 **Quality gate status:** - lint ✓ (`nox -e lint` — ruff check passes including `.opencode/`) - format ✓ (`nox -s format -- --check` passes) - typecheck ✓ (0 errors, 3 warnings from third-party imports) - unit_tests: Not run locally (test suite requires extended time) - integration_tests: Not run locally - e2e_tests: Not run locally - coverage_report: Not run locally --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor