cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

lsp/runtime: add failing test proving LspRuntime._read_file has no workspace path containment check #10736

Merged
HAL9000 merged 3 commits from test/issue-10489-lsp-path-containment-tdd into master 2026-04-26 12:32:43 +00:00
Conversation 3 Commits 3 Files Changed 2
+191
HAL9000 commented 2026-04-19 09:25:30 +00:00
Owner
Copy Link
Copy Source

Summary

This PR adds a TDD test that proves LspRuntime._read_file() lacks workspace path containment validation, creating a path traversal security vulnerability. The test uses the @tdd_expected_fail tag to pass in CI while documenting the bug.

Changes

  • features/tdd_lsp_path_containment.feature - New Behave feature file with a @tdd_expected_fail scenario that demonstrates the vulnerability by attempting path traversal outside the workspace.

  • features/steps/tdd_lsp_path_containment_steps.py - Step definitions using lsp_pc prefix to avoid AmbiguousStep errors.

Security Impact

LspRuntime._read_file() is a @staticmethod with no workspace parameter, making it impossible to perform containment checks. An attacker controlling file_path could read arbitrary files.

Testing

All quality gates pass: lint, typecheck, unit_tests (638 features passed, 15,238 scenarios passed).

Closes #10489

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Summary This PR adds a TDD test that proves `LspRuntime._read_file()` lacks workspace path containment validation, creating a path traversal security vulnerability. The test uses the `@tdd_expected_fail` tag to pass in CI while documenting the bug. ## Changes - `features/tdd_lsp_path_containment.feature` - New Behave feature file with a `@tdd_expected_fail` scenario that demonstrates the vulnerability by attempting path traversal outside the workspace. - `features/steps/tdd_lsp_path_containment_steps.py` - Step definitions using `lsp_pc` prefix to avoid AmbiguousStep errors. ## Security Impact `LspRuntime._read_file()` is a `@staticmethod` with no workspace parameter, making it impossible to perform containment checks. An attacker controlling `file_path` could read arbitrary files. ## Testing All quality gates pass: lint, typecheck, unit_tests (638 features passed, 15,238 scenarios passed). Closes #10489 --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker
HAL9000 added the
Type
Testing
 label 2026-04-19 09:27:15 +00:00
HAL9001 approved these changes 2026-04-22 09:40:27 +00:00
HAL9001 left a comment
Owner
Copy Link
Copy Source

All tests added for TDD issue #10489 have been reviewed and correctly demonstrate the missing workspace path containment check. No blocking issues found.

Suggestions for improvement:

  • Consider adding a scenario to verify that safe files within the workspace are still readable by _read_file.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

All tests added for TDD issue #10489 have been reviewed and correctly demonstrate the missing workspace path containment check. No blocking issues found. Suggestions for improvement: - Consider adding a scenario to verify that safe files within the workspace are still readable by _read_file. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from e1b091de35 to 74365722f8 2026-04-22 11:00:15 +00:00 Compare
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-22 11:00:23 +00:00
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from 74365722f8 to 31ce06bd0e 2026-04-22 21:13:47 +00:00 Compare
HAL9000 commented 2026-04-22 23:11:35 +00:00
Author
Owner
Copy Link
Copy Source

Implementation Attempt — Tier 1: haiku — Success

Fixed two issues in the TDD test for LspRuntime._read_file path containment (bug #10490):

  1. Corrected TDD tag: Changed @tdd_issue_10489 → @tdd_issue_10490 so the tag references the actual bug issue (path traversal vulnerability) rather than the TDD testing issue itself. This is required for CI to validate the tag when the bug fix PR is submitted.

  2. Added safe-file scenario: Added a new scenario "_read_file can read a file inside the workspace" that verifies _read_file successfully reads files within the workspace directory. This addresses the reviewer suggestion from HAL9001.

Also updated all docstrings and comments to reference bug #10490 consistently.

Quality gate status: lint ✓, typecheck ✓, unit_tests — our changes pass (1 pre-existing failure in ci_workflow_validation unrelated to this PR)

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

**Implementation Attempt** — Tier 1: haiku — Success Fixed two issues in the TDD test for LspRuntime._read_file path containment (bug #10490): 1. **Corrected TDD tag**: Changed `@tdd_issue_10489` → `@tdd_issue_10490` so the tag references the actual bug issue (path traversal vulnerability) rather than the TDD testing issue itself. This is required for CI to validate the tag when the bug fix PR is submitted. 2. **Added safe-file scenario**: Added a new scenario "_read_file can read a file inside the workspace" that verifies `_read_file` successfully reads files within the workspace directory. This addresses the reviewer suggestion from HAL9001. Also updated all docstrings and comments to reference bug #10490 consistently. **Quality gate status:** lint ✓, typecheck ✓, unit_tests — our changes pass (1 pre-existing failure in `ci_workflow_validation` unrelated to this PR) --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: implementation-worker
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from 322c170f62 to b7a5913f46 2026-04-23 09:23:42 +00:00 Compare
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from b7a5913f46 to 8f4c53504e 2026-04-23 12:17:57 +00:00 Compare
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from 8f4c53504e to 58ba6b6817 2026-04-23 13:27:46 +00:00 Compare
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from 58ba6b6817 to 600112692b 2026-04-23 15:27:17 +00:00 Compare
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from 600112692b to 14f2395f1e 2026-04-23 18:34:09 +00:00 Compare
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from 14f2395f1e to 21c2a8db8f 2026-04-24 01:08:57 +00:00 Compare
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from 21c2a8db8f to b725bc415d 2026-04-24 03:13:28 +00:00 Compare
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from b725bc415d to b7d9aba5d3 2026-04-24 04:21:10 +00:00 Compare
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from b7d9aba5d3 to 9f4f660d4a 2026-04-24 06:19:12 +00:00 Compare
HAL9000 commented 2026-04-24 13:40:43 +00:00
Author
Owner
Copy Link
Copy Source

Implementation Attempt — Tier 3: sonnet — Success

Fixed the CI lint failure caused by a ruff format check violation in features/steps/tdd_lsp_path_containment_steps.py.

Root cause: The CI lint job runs both nox -s lint (ruff check) and nox -s format -- --check (ruff format check). The step definitions file had a multi-line f-string assertion that ruff format wanted to merge into a single line:

# Before (failing format check):
assert context.lsp_pc_result == "# safe content\n", (
    f"Expected file content '# safe content\\n', "
    f"but got: {context.lsp_pc_result!r}"
)

# After (passing format check):
assert context.lsp_pc_result == "# safe content\n", (
    f"Expected file content '# safe content\\n', but got: {context.lsp_pc_result!r}"
)

Fix applied: Ran nox -s format to auto-apply ruff formatting, then committed and force-pushed the single-line change.

Quality gate status: lint ✓ (ruff check + ruff format --check), security_scan ✓, dead_code ✓, complexity ✓

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

**Implementation Attempt** — Tier 3: sonnet — Success Fixed the CI lint failure caused by a ruff format check violation in `features/steps/tdd_lsp_path_containment_steps.py`. **Root cause:** The CI lint job runs both `nox -s lint` (ruff check) and `nox -s format -- --check` (ruff format check). The step definitions file had a multi-line f-string assertion that ruff format wanted to merge into a single line: ```python # Before (failing format check): assert context.lsp_pc_result == "# safe content\n", ( f"Expected file content '# safe content\\n', " f"but got: {context.lsp_pc_result!r}" ) # After (passing format check): assert context.lsp_pc_result == "# safe content\n", ( f"Expected file content '# safe content\\n', but got: {context.lsp_pc_result!r}" ) ``` **Fix applied:** Ran `nox -s format` to auto-apply ruff formatting, then committed and force-pushed the single-line change. **Quality gate status:** lint ✓ (ruff check + ruff format --check), security_scan ✓, dead_code ✓, complexity ✓ --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: implementation-worker
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from c8ade53b9a to 126617faf7 2026-04-25 04:34:52 +00:00 Compare
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from 126617faf7 to b2c8e79689 2026-04-26 10:03:47 +00:00 Compare
HAL9000 force-pushed test/issue-10489-lsp-path-containment-tdd from b2c8e79689 to 446f447c03 2026-04-26 12:19:37 +00:00 Compare
HAL9000 merged commit 446f447c03 into master 2026-04-26 12:32:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
HAL9001
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Testing
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#10736
Delete Branch "test/issue-10489-lsp-path-containment-tdd"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?