fix(plugins): implement EXECUTING state in PluginManager lifecycle #10646
No reviewers
Labels
No labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
cleveragents/cleveragents-core!10646
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/v360/plugin-state-executing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Implement the
PluginState.EXECUTINGstate in the plugin lifecycle state machine by adding theexecute_plugin()method toPluginManager. This completes the plugin lifecycle, allowing plugins to transition through the ACTIVATED → EXECUTING → ACTIVATED (or ERRORED) states during execution, with full observability and error handling.Changes
src/cleveragents/infrastructure/plugins/manager.pyexecute_plugin()method toPluginManagerclassACTIVATEDstate before executionPluginState.EXECUTINGbefore invoking the plugin methodACTIVATEDon successful executionERROREDon exceptionthreading.RLockfeatures/plugin_executing_state.feature(new)features/steps/plugin_executing_state_steps.py(new)Testing
All scenarios in
features/plugin_executing_state.featurevalidate:Closes #5691
Automated by CleverAgents Bot
Agent: pr-creator
PluginState.EXECUTINGstate defined but never set byPluginManager— lifecycle state machine incomplete #5691PluginState.EXECUTINGstate defined but never set byPluginManager— lifecycle state machine incomplete #5691Implementation Attempt — Tier 1: haiku — Success
Fixed missing step definitions for the EXECUTING state feature tests. The original PR had incomplete step definitions that were causing test failures.
Changes made:
Quality gate status: lint ✓, typecheck ✓, unit_tests (pending), integration_tests (pending), e2e_tests (pending), coverage_report (pending)
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker
This PR cannot be approved because CI checks are failing. The following critical gates are not passing:
Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved and merged. Please fix the failing tests and ensure all checks pass.
Once CI is green, a full code review will be conducted.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
🌱 Grooming: proceed — PR cleared for processing.
(check
semantic_contradiction, categorysemantic_contradiction)Anchor PR #10646 details describe "fix(plugins): implement EXECUTING state in PluginManager lifecycle" (head: fix/v360/plugin-state-executing), but open_prs entry for #10646 shows "fix(resources): fix resource_kind field..." (head: fix/v360/resource-kind-field) — completely different PR. The PR described in anchor details does not appear in open_prs list. Cannot perform duplicate detection with inconsistent PR identity across input sources.
📋 Estimate: tier 1.
Multi-file addition: execute_plugin() method in manager.py + new BDD feature file + new step definitions (372 LOC added). Real CI failure is AmbiguousStep collision — @then('a PluginError should be raised') duplicated between plugin_executing_state_steps.py and existing plugin_architecture_steps.py:522. Fix requires cross-file Behave step sharing knowledge (import/reuse or rename). Core implementation involves thread-safe state transitions (RLock), state machine correctness (ACTIVATED→EXECUTING→ACTIVATED/ERRORED), and 10 BDD scenarios. lint/push-validation/status-check failures are Docker pull rate limit (infrastructure noise). Standard tier-1 engineering work: new feature logic + test fixture fix across multiple files.
b5b7ba7a3005b718d2e5(attempt #3, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
05b718d.05b718d2e505821c13d5(attempt #4, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
05821c1.05821c13d5326ddedd82(attempt #5, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
326dded.AmbiguousStep error caused all 8 features to error: plugin_executing_state_steps.py re-defined 6 steps already present in plugin_architecture_steps.py: - @then("a PluginError should be raised") - @then("a PluginNotFoundError should be raised") - @then('the plugin error message should contain "{text}"') - @when('I attempt to deactivate the plugin "{name}"') - @given("the PluginState enum is available") - @then('it should have values ...') Remove all duplicates, keeping only the 6 new steps unique to this feature. Also fix the last scenario where `And I attempt to execute method on unknown plugin` followed a `Given` step (so behave treated it as `given` context, not matching the `@when` definition). Changed `And` to `When`. ISSUES CLOSED: #5691(attempt #6, tier 1)
🔧 Implementer attempt —
resolved.Pushed 1 commit:
48ac3fa.Files touched:
features/plugin_executing_state.feature,features/steps/plugin_executing_state_steps.py.✅ Approved
Reviewed at commit
48ac3fa.Confidence: high.
Claimed by
merge_drive.py(pid 15960) until2026-06-05T02:06:50.474203+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
48ac3fa73d552dcb15b0Approved by the controller reviewer stage (workflow 276).