fix(plugins): implement EXECUTING state in PluginManager lifecycle #10646
Merged
HAL9000
merged 6 commits from 2026-06-05 00:58:32 +00:00
fix/v360/plugin-state-executing into master
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#10646
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "fix/v360/plugin-state-executing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Implement the
PluginState.EXECUTINGstate in the plugin lifecycle state machine by adding theexecute_plugin()method toPluginManager. This completes the plugin lifecycle, allowing plugins to transition through the ACTIVATED → EXECUTING → ACTIVATED (or ERRORED) states during execution, with full observability and error handling.Changes
src/cleveragents/infrastructure/plugins/manager.pyexecute_plugin()method toPluginManagerclassACTIVATEDstate before executionPluginState.EXECUTINGbefore invoking the plugin methodACTIVATEDon successful executionERROREDon exceptionthreading.RLockfeatures/plugin_executing_state.feature(new)features/steps/plugin_executing_state_steps.py(new)Testing
All scenarios in
features/plugin_executing_state.featurevalidate:Closes #5691
Automated by CleverAgents Bot
Agent: pr-creator
Implementation Attempt — Tier 1: haiku — Success
Fixed missing step definitions for the EXECUTING state feature tests. The original PR had incomplete step definitions that were causing test failures.
Changes made:
Quality gate status: lint ✓, typecheck ✓, unit_tests (pending), integration_tests (pending), e2e_tests (pending), coverage_report (pending)
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker
This PR cannot be approved because CI checks are failing. The following critical gates are not passing:
Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved and merged. Please fix the failing tests and ensure all checks pass.
Once CI is green, a full code review will be conducted.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
🌱 Grooming: proceed — PR cleared for processing.
(check
semantic_contradiction, categorysemantic_contradiction)Anchor PR #10646 details describe "fix(plugins): implement EXECUTING state in PluginManager lifecycle" (head: fix/v360/plugin-state-executing), but open_prs entry for #10646 shows "fix(resources): fix resource_kind field..." (head: fix/v360/resource-kind-field) — completely different PR. The PR described in anchor details does not appear in open_prs list. Cannot perform duplicate detection with inconsistent PR identity across input sources.
📋 Estimate: tier 1.
Multi-file addition: execute_plugin() method in manager.py + new BDD feature file + new step definitions (372 LOC added). Real CI failure is AmbiguousStep collision — @then('a PluginError should be raised') duplicated between plugin_executing_state_steps.py and existing plugin_architecture_steps.py:522. Fix requires cross-file Behave step sharing knowledge (import/reuse or rename). Core implementation involves thread-safe state transitions (RLock), state machine correctness (ACTIVATED→EXECUTING→ACTIVATED/ERRORED), and 10 BDD scenarios. lint/push-validation/status-check failures are Docker pull rate limit (infrastructure noise). Standard tier-1 engineering work: new feature logic + test fixture fix across multiple files.
b5b7ba7a30to05b718d2e5(attempt #3, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
05b718d.05b718d2e5to05821c13d5(attempt #4, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
05821c1.05821c13d5to326ddedd82(attempt #5, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
326dded.AmbiguousStep error caused all 8 features to error: plugin_executing_state_steps.py re-defined 6 steps already present in plugin_architecture_steps.py: - @then("a PluginError should be raised") - @then("a PluginNotFoundError should be raised") - @then('the plugin error message should contain "{text}"') - @when('I attempt to deactivate the plugin "{name}"') - @given("the PluginState enum is available") - @then('it should have values ...') Remove all duplicates, keeping only the 6 new steps unique to this feature. Also fix the last scenario where `And I attempt to execute method on unknown plugin` followed a `Given` step (so behave treated it as `given` context, not matching the `@when` definition). Changed `And` to `When`. ISSUES CLOSED: #5691(attempt #6, tier 1)
🔧 Implementer attempt —
resolved.Pushed 1 commit:
48ac3fa.Files touched:
features/plugin_executing_state.feature,features/steps/plugin_executing_state_steps.py.✅ Approved
Reviewed at commit
48ac3fa.Confidence: high.
Claimed by
merge_drive.py(pid 15960) until2026-06-05T02:06:50.474203+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
48ac3fa73dto552dcb15b0Approved by the controller reviewer stage (workflow 276).