cleveragents/cleveragents-core

Fork 3

UAT: screens/ directory missing from src/cleveragents/tui/ — spec requires dedicated screens module #10505

New issue

Open

opened 2026-04-18 10:18:50 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-18 10:18:50 +00:00

Owner

Metadata

Branch: fix/tui-screens-directory-missing
Commit Message: feat(tui): create screens/ directory with __init__.py for TUI screen modules
Milestone: v3.7.0
Parent Epic: #868

Bug Report

What Was Tested

Directory structure inspection of src/cleveragents/tui/.

Expected Behavior (from spec)

Per the specification (§TUI > Architecture), the TUI module must have a screens/ subdirectory containing the screen implementations (SettingsScreen, SessionsScreen, PlanDetailModal, ProjectDetailModal, PersonaEditorModal, etc.). This directory must NOT be empty — it must contain at least the screen module files.

Actual Behavior

The src/cleveragents/tui/ directory does not contain a screens/ subdirectory at all. The current directory structure is:

src/cleveragents/tui/
├── __init__.py
├── app.py
├── cleveragents.tcss
├── commands.py
├── first_run.py
├── input/
├── permissions/
├── persona/
├── search/
├── shell_safety/
├── slash_catalog.py
└── widgets/

There is no screens/ directory. All screen-related code that does exist (PermissionsScreen) is incorrectly placed in permissions/screen.py and is implemented as a Static widget rather than a proper Screen subclass.

Steps to Reproduce

Run ls src/cleveragents/tui/ — no screens/ directory is present.
The spec requires screens/ to contain SettingsScreen, SessionsScreen, PlanDetailModal, ProjectDetailModal, and PersonaEditorModal.

Impact

The entire screen navigation architecture is missing. All spec-required screens and modals are absent. The TUI cannot navigate between screens as specified.

Subtasks

Create src/cleveragents/tui/screens/ directory
Create src/cleveragents/tui/screens/__init__.py with exports for all screen classes
Create src/cleveragents/tui/screens/settings.py — SettingsScreen
Create src/cleveragents/tui/screens/sessions.py — SessionsScreen
Create src/cleveragents/tui/screens/plan_detail_modal.py — PlanDetailModal
Create src/cleveragents/tui/screens/project_detail_modal.py — ProjectDetailModal
Create src/cleveragents/tui/screens/persona_editor_modal.py — PersonaEditorModal
Move PermissionsScreen from permissions/screen.py to screens/permissions.py and convert to proper Screen subclass
Tests (Behave): Add TDD scenario tagged @tdd_issue, @tdd_expected_fail asserting screens/ directory exists and is non-empty
Remove @tdd_expected_fail once implemented and verify scenario passes
Verify coverage >= 97% via nox -s coverage_report
Run nox (all default sessions), fix any errors

Definition of Done

src/cleveragents/tui/screens/ directory exists and is non-empty
screens/__init__.py exports all screen classes
All 5 required screen/modal classes exist in the screens/ directory
TDD scenario passes without @tdd_expected_fail
All nox stages pass
Coverage >= 97%
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

Automated by CleverAgents Bot
Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

## Metadata - **Branch**: `fix/tui-screens-directory-missing` - **Commit Message**: `feat(tui): create screens/ directory with __init__.py for TUI screen modules` - **Milestone**: v3.7.0 - **Parent Epic**: #868 ## Bug Report ### What Was Tested Directory structure inspection of `src/cleveragents/tui/`. ### Expected Behavior (from spec) Per the specification (§TUI > Architecture), the TUI module must have a `screens/` subdirectory containing the screen implementations (`SettingsScreen`, `SessionsScreen`, `PlanDetailModal`, `ProjectDetailModal`, `PersonaEditorModal`, etc.). This directory must NOT be empty — it must contain at least the screen module files. ### Actual Behavior The `src/cleveragents/tui/` directory does not contain a `screens/` subdirectory at all. The current directory structure is: ``` src/cleveragents/tui/ ├── __init__.py ├── app.py ├── cleveragents.tcss ├── commands.py ├── first_run.py ├── input/ ├── permissions/ ├── persona/ ├── search/ ├── shell_safety/ ├── slash_catalog.py └── widgets/ ``` There is no `screens/` directory. All screen-related code that does exist (`PermissionsScreen`) is incorrectly placed in `permissions/screen.py` and is implemented as a `Static` widget rather than a proper `Screen` subclass. ### Steps to Reproduce 1. Run `ls src/cleveragents/tui/` — no `screens/` directory is present. 2. The spec requires `screens/` to contain `SettingsScreen`, `SessionsScreen`, `PlanDetailModal`, `ProjectDetailModal`, and `PersonaEditorModal`. ### Impact The entire screen navigation architecture is missing. All spec-required screens and modals are absent. The TUI cannot navigate between screens as specified. ## Subtasks - [ ] Create `src/cleveragents/tui/screens/` directory - [ ] Create `src/cleveragents/tui/screens/__init__.py` with exports for all screen classes - [ ] Create `src/cleveragents/tui/screens/settings.py` — `SettingsScreen` - [ ] Create `src/cleveragents/tui/screens/sessions.py` — `SessionsScreen` - [ ] Create `src/cleveragents/tui/screens/plan_detail_modal.py` — `PlanDetailModal` - [ ] Create `src/cleveragents/tui/screens/project_detail_modal.py` — `ProjectDetailModal` - [ ] Create `src/cleveragents/tui/screens/persona_editor_modal.py` — `PersonaEditorModal` - [ ] Move `PermissionsScreen` from `permissions/screen.py` to `screens/permissions.py` and convert to proper `Screen` subclass - [ ] Tests (Behave): Add TDD scenario tagged `@tdd_issue`, `@tdd_expected_fail` asserting `screens/` directory exists and is non-empty - [ ] Remove `@tdd_expected_fail` once implemented and verify scenario passes - [ ] Verify coverage >= 97% via `nox -s coverage_report` - [ ] Run `nox` (all default sessions), fix any errors ## Definition of Done - [ ] `src/cleveragents/tui/screens/` directory exists and is non-empty - [ ] `screens/__init__.py` exports all screen classes - [ ] All 5 required screen/modal classes exist in the `screens/` directory - [ ] TDD scenario passes without `@tdd_expected_fail` - [ ] All nox stages pass - [ ] Coverage >= 97% - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. --- **Automated by CleverAgents Bot** Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

HAL9000 added the

labels

2026-04-18 10:19:36 +00:00

HAL9000 added this to the v3.7.0 milestone

2026-04-18 10:27:33 +00:00

HAL9000 commented

2026-04-18 10:28:27 +00:00

Author

Owner

[GROOMED] Quality Analysis & Triage Report

⚠️ PRIORITY/CRITICAL FLAG

This issue is marked Priority/Critical and currently in State/Unverified. Per triage rules, Priority/Critical issues require immediate attention and should be moved to State/Verified or State/Wont Do.

Issue Validity Assessment: ✅ VALID & ACTIONABLE

Validity Criteria:

✅ Real, reproducible issue: Directory structure inspection confirms screens/ directory is missing
✅ Clear expected behavior: Spec (§TUI > Architecture) requires screens/ subdirectory with screen implementations
✅ Clear actual behavior: Directory does not exist; screen code is misplaced in permissions/screen.py
✅ Reproducible steps: ls src/cleveragents/tui/ confirms absence
✅ Well-defined impact: Entire screen navigation architecture is missing

Label Verification: ✅ ALL REQUIRED LABELS PRESENT

Label	Status	ID
State/Unverified	✅ Present	846
Type/Bug	✅ Present	849
Priority/Critical	✅ Present	858
MoSCoW/Must have	✅ Present	883

Note: MoSCoW/Must have label is already applied (presumably by AUTO-OWNR per CONTRIBUTING.md rules).

Epic & Milestone Assignment: ✅ VERIFIED

Parent Epic: #868 (referenced in issue body) — not an orphan ✅
Milestone: v3.7.0 (M8: TUI Implementation) — NOW ASSIGNED ✅

Triage Recommendation: MOVE TO STATE/VERIFIED

Reasoning:

Issue is valid and actionable
All required labels are present
Properly assigned to epic and milestone
Clear subtasks and Definition of Done provided
Spec-referenced requirements are well-documented

Actions Completed

✅ Milestone Assignment: Issue #10505 has been assigned to v3.7.0 milestone (M8: TUI Implementation)

⚠️ State Label Update: Requires label API access to change from State/Unverified → State/Verified. This should be completed by a maintainer with full label management permissions.

Quality Assessment: ⭐⭐⭐⭐⭐

Strengths:

Comprehensive issue description with clear spec references
Well-structured subtasks and DoD criteria
Proper branch and commit message metadata
Clear impact statement
Proper epic linkage

No Issues Found: This is a well-groomed issue ready for implementation.

Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor

## [GROOMED] Quality Analysis & Triage Report ### ⚠️ PRIORITY/CRITICAL FLAG This issue is marked **Priority/Critical** and currently in **State/Unverified**. Per triage rules, Priority/Critical issues require immediate attention and should be moved to State/Verified or State/Wont Do. ### Issue Validity Assessment: ✅ VALID & ACTIONABLE **Validity Criteria:** - ✅ Real, reproducible issue: Directory structure inspection confirms `screens/` directory is missing - ✅ Clear expected behavior: Spec (§TUI > Architecture) requires `screens/` subdirectory with screen implementations - ✅ Clear actual behavior: Directory does not exist; screen code is misplaced in `permissions/screen.py` - ✅ Reproducible steps: `ls src/cleveragents/tui/` confirms absence - ✅ Well-defined impact: Entire screen navigation architecture is missing ### Label Verification: ✅ ALL REQUIRED LABELS PRESENT | Label | Status | ID | |-------|--------|-----| | State/Unverified | ✅ Present | 846 | | Type/Bug | ✅ Present | 849 | | Priority/Critical | ✅ Present | 858 | | MoSCoW/Must have | ✅ Present | 883 | **Note:** MoSCoW/Must have label is already applied (presumably by AUTO-OWNR per CONTRIBUTING.md rules). ### Epic & Milestone Assignment: ✅ VERIFIED - **Parent Epic:** #868 (referenced in issue body) — not an orphan ✅ - **Milestone:** v3.7.0 (M8: TUI Implementation) — **NOW ASSIGNED** ✅ ### Triage Recommendation: MOVE TO STATE/VERIFIED **Reasoning:** 1. Issue is valid and actionable 2. All required labels are present 3. Properly assigned to epic and milestone 4. Clear subtasks and Definition of Done provided 5. Spec-referenced requirements are well-documented ### Actions Completed ✅ **Milestone Assignment:** Issue #10505 has been assigned to **v3.7.0** milestone (M8: TUI Implementation) ⚠️ **State Label Update:** Requires label API access to change from State/Unverified → State/Verified. This should be completed by a maintainer with full label management permissions. ### Quality Assessment: ⭐⭐⭐⭐⭐ **Strengths:** - Comprehensive issue description with clear spec references - Well-structured subtasks and DoD criteria - Proper branch and commit message metadata - Clear impact statement - Proper epic linkage **No Issues Found:** This is a well-groomed issue ready for implementation. --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor

HAL9000 added

and removed

labels

2026-04-18 10:29:53 +00:00