cleveragents/cleveragents-core

Fork 3

TDD: PersonaState.set_active_persona() does not reset preset to "default" when switching personas #10500

New issue

Open

opened 2026-04-18 10:15:03 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-18 10:15:03 +00:00

Owner

Metadata

Commit message: test(tui): add failing behave scenario for set_active_persona preset reset bug
Branch name: bugfix/m8-set-active-persona-preset-reset

Background and Context

This is the TDD counterpart to issue #10499 (UAT: PersonaState.set_active_persona() does not reset preset to "default" when switching personas).

Per TDD discipline, a failing test must be written first to prove the bug exists before the fix is implemented. This issue tracks that failing Behave scenario.

The bug: PersonaState.set_active_persona() does not reset preset_by_session[session_id] to "default" when a session already has a non-default preset and the user switches personas. The old preset carries over to the new persona.

Expected Behavior

The failing test below should:

Fail (expected failure) on the current buggy implementation — proving the bug exists.
Pass once the fix from #10499 is applied — proving the bug is resolved.

Acceptance Criteria

The Behave scenario below is added to the appropriate feature file under features/tui/persona/
The scenario is tagged with @tdd_issue, @tdd_issue_10499, and @tdd_expected_fail
The scenario fails on the current (unfixed) implementation
Step definitions are implemented for any new steps
The scenario passes after the fix from #10499 is applied
Coverage >= 97%

Subtasks

Add the failing Behave scenario to features/tui/persona/state.feature (or equivalent)
Implement step definitions for any new steps in features/tui/persona/steps/
Confirm the scenario fails on the current implementation (nox -s behave -- --tags=tdd_issue_10499)
Verify coverage >= 97% via nox -s coverage_report

Failing Behave Scenario

@tdd_issue @tdd_issue_10499 @tdd_expected_fail
Scenario: set_active_persona resets preset to "default" when session already has a non-default preset
  Given a PersonaState instance with personas "persona-a" and "persona-b"
  And the active persona for session "session-1" is set to "persona-a"
  And the preset for session "session-1" is cycled to "high-effort"
  When the active persona for session "session-1" is switched to "persona-b"
  Then the current preset for session "session-1" should be "default"

Why This Test Fails (Current Buggy Behaviour)

In the current implementation of set_active_persona():

if session_id not in self.preset_by_session:  # BUG
    self.preset_by_session[session_id] = "default"

Because "session-1" already has preset_by_session["session-1"] = "high-effort" after the cycle step, the condition session_id not in self.preset_by_session evaluates to False. The preset is not reset. The final assertion current_preset("session-1") == "default" therefore fails, confirming the bug.

Why This Test Passes After the Fix

After replacing the conditional with an unconditional assignment:

self.preset_by_session[session_id] = "default"  # Always reset

The preset is always reset to "default" on persona switch, so current_preset("session-1") returns "default" and the assertion passes.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
The failing scenario is committed on branch bugfix/m8-set-active-persona-preset-reset.
The scenario transitions from failing → passing after the fix in #10499 is merged.
This issue is closed alongside #10499.

Automated by CleverAgents Bot
Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

## Metadata - **Commit message:** `test(tui): add failing behave scenario for set_active_persona preset reset bug` - **Branch name:** `bugfix/m8-set-active-persona-preset-reset` ## Background and Context This is the TDD counterpart to issue #10499 (`UAT: PersonaState.set_active_persona() does not reset preset to "default" when switching personas`). Per TDD discipline, a **failing test** must be written first to prove the bug exists before the fix is implemented. This issue tracks that failing Behave scenario. The bug: `PersonaState.set_active_persona()` does not reset `preset_by_session[session_id]` to `"default"` when a session already has a non-default preset and the user switches personas. The old preset carries over to the new persona. ## Expected Behavior The failing test below should: 1. **Fail** (expected failure) on the current buggy implementation — proving the bug exists. 2. **Pass** once the fix from #10499 is applied — proving the bug is resolved. ## Acceptance Criteria - [ ] The Behave scenario below is added to the appropriate feature file under `features/tui/persona/` - [ ] The scenario is tagged with `@tdd_issue`, `@tdd_issue_10499`, and `@tdd_expected_fail` - [ ] The scenario **fails** on the current (unfixed) implementation - [ ] Step definitions are implemented for any new steps - [ ] The scenario **passes** after the fix from #10499 is applied - [ ] Coverage >= 97% ## Subtasks - [ ] Add the failing Behave scenario to `features/tui/persona/state.feature` (or equivalent) - [ ] Implement step definitions for any new steps in `features/tui/persona/steps/` - [ ] Confirm the scenario fails on the current implementation (`nox -s behave -- --tags=tdd_issue_10499`) - [ ] Verify coverage >= 97% via `nox -s coverage_report` ## Failing Behave Scenario ```gherkin @tdd_issue @tdd_issue_10499 @tdd_expected_fail Scenario: set_active_persona resets preset to "default" when session already has a non-default preset Given a PersonaState instance with personas "persona-a" and "persona-b" And the active persona for session "session-1" is set to "persona-a" And the preset for session "session-1" is cycled to "high-effort" When the active persona for session "session-1" is switched to "persona-b" Then the current preset for session "session-1" should be "default" ``` ### Why This Test Fails (Current Buggy Behaviour) In the current implementation of `set_active_persona()`: ```python if session_id not in self.preset_by_session: # BUG self.preset_by_session[session_id] = "default" ``` Because `"session-1"` already has `preset_by_session["session-1"] = "high-effort"` after the cycle step, the condition `session_id not in self.preset_by_session` evaluates to `False`. The preset is **not** reset. The final assertion `current_preset("session-1") == "default"` therefore **fails**, confirming the bug. ### Why This Test Passes After the Fix After replacing the conditional with an unconditional assignment: ```python self.preset_by_session[session_id] = "default" # Always reset ``` The preset is always reset to `"default"` on persona switch, so `current_preset("session-1")` returns `"default"` and the assertion **passes**. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - The failing scenario is committed on branch `bugfix/m8-set-active-persona-preset-reset`. - The scenario transitions from failing → passing after the fix in #10499 is merged. - This issue is closed alongside #10499. --- **Automated by CleverAgents Bot** Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

HAL9000 added the

labels

2026-04-18 10:19:08 +00:00

HAL9000 added this to the v3.7.0 milestone

2026-04-18 10:20:09 +00:00

HAL9000 commented

2026-04-18 10:20:42 +00:00

Author

Owner

[GROOMED] Quality Analysis Complete

Issue Assessment

Issue #10500 is a valid, actionable TDD (Test-Driven Development) issue that requires triage.

Validity Check ✅

Type: TDD test issue (counterpart to bug fix #10499)
Clarity: Well-documented with clear acceptance criteria and failing Behave scenario
Actionability: Specific subtasks and definition of done provided
Scope: Focused on adding a failing test for PersonaState.set_active_persona() preset reset bug

Labels Applied

✅ Type/Testing (id: 851) - This is explicitly a TDD test issue
✅ State/Unverified (id: 846) - Per CONTRIBUTING.md, new issues start unverified
✅ Priority/High (id: 859) - Blocking bug fix verification; core TUI persona functionality

Note: System auto-applied MoSCoW/Must have and Priority/Critical. These may be due to milestone assignment or system rules. Per CONTRIBUTING.md, MoSCoW labels should only be applied if AUTO-OWNR explicitly decides.

Milestone Assignment

✅ v3.7.0 (M8: TUI Implementation) - Correctly assigned as this is TUI persona system work

Epic/Relationship Check

✅ Related to #10499 - UAT counterpart (bug fix issue)

Both issues track the same bug: preset not resetting when switching personas
#10500 (TDD) should pass after #10499 (UAT) is merged
Proper dependency relationship established

Summary

Issue is properly groomed with:

✅ All required labels (State/, Type/, Priority/)
✅ Correct milestone assignment (v3.7.0)
✅ Clear relationship to related issue (#10499)
✅ Well-defined acceptance criteria and subtasks
✅ Ready for developer assignment and implementation

Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor

[GROOMED] Quality Analysis Complete ## Issue Assessment **Issue #10500** is a valid, actionable TDD (Test-Driven Development) issue that requires triage. ### Validity Check ✅ - **Type**: TDD test issue (counterpart to bug fix #10499) - **Clarity**: Well-documented with clear acceptance criteria and failing Behave scenario - **Actionability**: Specific subtasks and definition of done provided - **Scope**: Focused on adding a failing test for PersonaState.set_active_persona() preset reset bug ### Labels Applied ✅ **Type/Testing** (id: 851) - This is explicitly a TDD test issue ✅ **State/Unverified** (id: 846) - Per CONTRIBUTING.md, new issues start unverified ✅ **Priority/High** (id: 859) - Blocking bug fix verification; core TUI persona functionality **Note**: System auto-applied MoSCoW/Must have and Priority/Critical. These may be due to milestone assignment or system rules. Per CONTRIBUTING.md, MoSCoW labels should only be applied if AUTO-OWNR explicitly decides. ### Milestone Assignment ✅ **v3.7.0 (M8: TUI Implementation)** - Correctly assigned as this is TUI persona system work ### Epic/Relationship Check ✅ **Related to #10499** - UAT counterpart (bug fix issue) - Both issues track the same bug: preset not resetting when switching personas - #10500 (TDD) should pass after #10499 (UAT) is merged - Proper dependency relationship established ### Summary Issue is properly groomed with: - ✅ All required labels (State/, Type/, Priority/) - ✅ Correct milestone assignment (v3.7.0) - ✅ Clear relationship to related issue (#10499) - ✅ Well-defined acceptance criteria and subtasks - ✅ Ready for developer assignment and implementation --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor

HAL9000 added

and removed

labels

2026-04-18 10:22:14 +00:00

HAL9000 referenced this issue

2026-04-19 04:31:57 +00:00

[AUTO-IMP-POOL] Status: Cycle 1 - Full Pool Active #10685

HAL9000 referenced this issue from a commit

2026-04-19 11:48:15 +00:00

test(tui): TDD failing test for PersonaState.set_active_persona() preset reset #10500

HAL9000 referenced this issue from a commit

2026-04-19 12:02:32 +00:00

test(tui): add failing behave scenario for set_active_persona preset reset bug

HAL9000 referenced this issue from a pull request that will close it,

2026-04-19 12:04:02 +00:00

test(tui): add failing behave scenario for set_active_persona preset reset bug #10757

HAL9000 commented

2026-04-19 12:04:03 +00:00

Author

Owner

Implementation Attempt — Tier 1: Haiku — Success

Implemented TDD failing test for PersonaState.set_active_persona() preset reset (issue #10500).

What was done:

Created features/tdd_persona_state_set_active_persona_reset.feature with 2 scenarios tagged @tdd_issue @tdd_issue_10500 @tdd_expected_fail
Created features/steps/tdd_persona_state_set_active_persona_reset_steps.py with step definitions
The tests capture the bug: set_active_persona() does not reset an existing non-default preset to "default" when switching personas
Tests intentionally fail (proving the bug exists); @tdd_expected_fail inverts the result so CI passes

Quality gate status: lint ✓, typecheck ✓, unit_tests ✓, integration_tests ✓, coverage 97.1% ✓

PR: #10757

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

**Implementation Attempt** — Tier 1: Haiku — Success Implemented TDD failing test for PersonaState.set_active_persona() preset reset (issue #10500). **What was done:** - Created `features/tdd_persona_state_set_active_persona_reset.feature` with 2 scenarios tagged `@tdd_issue @tdd_issue_10500 @tdd_expected_fail` - Created `features/steps/tdd_persona_state_set_active_persona_reset_steps.py` with step definitions - The tests capture the bug: `set_active_persona()` does not reset an existing non-default preset to "default" when switching personas - Tests intentionally fail (proving the bug exists); `@tdd_expected_fail` inverts the result so CI passes **Quality gate status:** lint ✓, typecheck ✓, unit_tests ✓, integration_tests ✓, coverage 97.1% ✓ PR: #10757 --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker

HAL9000 added

and removed

labels

2026-04-19 12:04:43 +00:00

HAL9000 added a new dependency

2026-04-19 12:05:45 +00:00

#10757 test(tui): add failing behave scenario for set_active_persona preset reset bug