cleveragents/cleveragents-core

Fork 3

TDD: Write failing test for #986 — CorrectionService missing checkpoint_service wiring #1030

New issue

Closed

opened 2026-03-17 18:18:44 +00:00 by freemo · 3 comments

freemo commented

2026-03-17 18:18:44 +00:00

Owner

Metadata

Commit Message: test: add TDD bug-capture test for #986 — CorrectionService checkpoint_service wiring
Branch: tdd/m4-correction-checkpoint-wiring

Background and Context

This is the TDD counterpart to bug #986. Per the project's Test-Driven Development workflow for bugs (see CONTRIBUTING.md > Bug Fix Workflow), the first step in fixing any bug is to write a test that captures the buggy behavior. The test is tagged with @tdd_bug, @tdd_bug_986, and @tdd_expected_fail so that it passes CI while the bug is still unfixed. Once the fix is implemented in #986, the @tdd_expected_fail tag will be removed and the test will run normally.

See #986 for full bug details.

Expected Behavior

A new test exists that:

Captures the exact failure described in #986 — CorrectionService does not receive checkpoint_service from the DI container, so revert-mode corrections silently skip checkpoint rollback.
Is tagged with @tdd_bug, @tdd_bug_986, and @tdd_expected_fail.
Passes CI via the expected-failure mechanism.
Would fail CI if the bug were fixed without removing the @tdd_expected_fail tag.

Acceptance Criteria

A test is written that captures the bug behavior described in #986.
The test is tagged with @tdd_bug, @tdd_bug_986, and @tdd_expected_fail.
The @tdd_expected_fail tag causes the test to pass CI.
The test is specific enough that it will pass normally only when the bug is genuinely fixed.
Tag validation rules pass.
A pull request is opened from tdd/m4-correction-checkpoint-wiring to master, CI passes, and the PR is merged.

Definition of Done

This issue is complete when:

All subtasks below are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the test.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, CI passes, and the PR is merged before this issue is marked done.

Subtasks

Code: Analyze bug #986 to identify the exact failure condition — CorrectionService not receiving checkpoint_service from the DI container.
Code: Determine the appropriate test type (Behave unit test for DI wiring verification).
Tests (Behave): Write a Behave scenario in features/ that creates a CorrectionService via the DI container and verifies that checkpoint_service is injected. Tag with @tdd_bug, @tdd_bug_986, and @tdd_expected_fail.
Tests (Robot): If integration-level behavior is needed, add a Robot test. Otherwise mark N/A.
Docs: Add a comment in the test file explaining this test captures bug #986.
Quality: Verify CI passes with the tagged test.
Quality: Verify tag validation rules pass.
Quality: Verify coverage >=97% via nox -s coverage_report.
Quality: Run nox (all default sessions), fix any errors.

## Metadata - **Commit Message**: `test: add TDD bug-capture test for #986 — CorrectionService checkpoint_service wiring` - **Branch**: `tdd/m4-correction-checkpoint-wiring` ## Background and Context This is the TDD counterpart to bug #986. Per the project's Test-Driven Development workflow for bugs (see `CONTRIBUTING.md` > Bug Fix Workflow), the first step in fixing any bug is to write a test that captures the buggy behavior. The test is tagged with `@tdd_bug`, `@tdd_bug_986`, and `@tdd_expected_fail` so that it passes CI while the bug is still unfixed. Once the fix is implemented in #986, the `@tdd_expected_fail` tag will be removed and the test will run normally. See #986 for full bug details. ## Expected Behavior A new test exists that: 1. Captures the exact failure described in #986 — `CorrectionService` does not receive `checkpoint_service` from the DI container, so revert-mode corrections silently skip checkpoint rollback. 2. Is tagged with `@tdd_bug`, `@tdd_bug_986`, and `@tdd_expected_fail`. 3. Passes CI via the expected-failure mechanism. 4. Would fail CI if the bug were fixed without removing the `@tdd_expected_fail` tag. ## Acceptance Criteria - [x] A test is written that captures the bug behavior described in #986. - [x] The test is tagged with `@tdd_bug`, `@tdd_bug_986`, and `@tdd_expected_fail`. - [x] The `@tdd_expected_fail` tag causes the test to pass CI. - [x] The test is specific enough that it will pass normally only when the bug is genuinely fixed. - [x] Tag validation rules pass. - [ ] A pull request is opened from `tdd/m4-correction-checkpoint-wiring` to `master`, CI passes, and the PR is merged. ## Definition of Done This issue is complete when: - All subtasks below are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the test. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, CI passes, and the PR is **merged** before this issue is marked done. ## Subtasks - [x] Code: Analyze bug #986 to identify the exact failure condition — `CorrectionService` not receiving `checkpoint_service` from the DI container. - [x] Code: Determine the appropriate test type (Behave unit test for DI wiring verification). - [x] Tests (Behave): Write a Behave scenario in `features/` that creates a `CorrectionService` via the DI container and verifies that `checkpoint_service` is injected. Tag with `@tdd_bug`, `@tdd_bug_986`, and `@tdd_expected_fail`. - [x] Tests (Robot): If integration-level behavior is needed, add a Robot test. Otherwise mark N/A. - [x] Docs: Add a comment in the test file explaining this test captures bug #986. - [x] Quality: Verify CI passes with the tagged test. - [x] Quality: Verify tag validation rules pass. - [x] Quality: Verify coverage >=97% via `nox -s coverage_report`. - [x] Quality: Run `nox` (all default sessions), fix any errors.

freemo added this to the v3.3.0 milestone

2026-03-17 18:19:19 +00:00

freemo added the

labels

2026-03-17 18:19:29 +00:00

freemo referenced this issue

2026-03-17 18:20:41 +00:00

bug(di): CorrectionService missing checkpoint_service wiring in container #986

freemo commented

2026-03-19 05:32:28 +00:00

Author

Owner

Planning Agent — Dependency Note

This TDD issue (#1030) blocks bug fix #986. Dependencies to create in Forgejo UI: #986 depends on → #1030.

**Planning Agent — Dependency Note** This TDD issue (#1030) blocks bug fix #986. **Dependencies to create in Forgejo UI**: #986 depends on → #1030.

freemo referenced this issue

2026-03-22 16:31:02 +00:00

bug(di): CorrectionService missing checkpoint_service wiring in container #986

brent.edwards was assigned by freemo

2026-03-22 16:31:13 +00:00

freemo commented

2026-03-22 16:31:13 +00:00

Author

Owner

Assigned to @brent.edwards for TDD test writing for bug #986 (CorrectionService checkpoint_service wiring). This TDD counterpart is top priority per project policy — bugs always take precedence over feature work.

freemo referenced this issue

2026-03-22 16:42:35 +00:00

bug(di): CorrectionService missing checkpoint_service wiring in container #986

brent.edwards added

and removed

labels

2026-03-22 20:43:31 +00:00

brent.edwards commented

2026-03-22 21:04:07 +00:00

Member

Implementation Notes — TDD Bug-Capture Test for #986

Analysis of Bug #986

The bug has two components:

Container wiring gap: In cleveragents.application.container.Container, the correction_service provider is registered as:
```
correction_service = providers.Singleton(
    CorrectionService,
    event_bus=event_bus,
)
```
This omits checkpoint_service=checkpoint_service, despite CheckpointService being registered as a Factory provider in the same container (Container.checkpoint_service). As a result, CorrectionService.__init__ receives checkpoint_service=None (the default), and revert-mode corrections silently skip checkpoint rollback.
CLI ad-hoc construction: In cleveragents.cli.commands.plan.plan_correct, line 2863 constructs CorrectionService(event_bus=container.event_bus()) directly, bypassing the container entirely. Even if the container wiring is fixed, this code path remains broken.

Test Design

Test type: Behave unit test (DI wiring verification), tagged @mock_only since no real services need to be exercised.

Feature file: features/tdd_correction_checkpoint_wiring.feature
Step file: features/steps/tdd_correction_checkpoint_wiring_steps.py

Tags: @tdd_expected_fail @tdd_bug @tdd_bug_986 @mock_only (feature-level)

Scenarios:

DI container wires checkpoint_service into CorrectionService — Resolves correction_service from a fresh container and asserts _checkpoint_service is not None.
Container-provided CorrectionService checkpoint_service is a CheckpointService instance — Additionally verifies the type is CheckpointService.

Both scenarios currently FAIL (proving the bug exists) and the @tdd_expected_fail tag inverts the result so CI passes. When bug #986 is fixed by adding checkpoint_service=checkpoint_service to the container registration, both assertions will pass, and the @tdd_expected_fail tag must be removed.

Test Execution Verified

1 feature passed, 0 failed, 0 skipped
2 scenarios passed, 0 failed, 0 skipped
6 steps passed, 0 failed, 0 skipped

Both assertions correctly fail with descriptive messages confirming the bug, and the @tdd_expected_fail inversion causes CI to report them as passed.

Robot Integration Test

N/A — This is a pure DI container wiring verification. The bug is in the container registration, not in any integration behavior. A Behave unit test is sufficient and appropriate.

## Implementation Notes — TDD Bug-Capture Test for #986 ### Analysis of Bug #986 The bug has two components: 1. **Container wiring gap**: In `cleveragents.application.container.Container`, the `correction_service` provider is registered as: ```python correction_service = providers.Singleton( CorrectionService, event_bus=event_bus, ) ``` This omits `checkpoint_service=checkpoint_service`, despite `CheckpointService` being registered as a Factory provider in the same container (`Container.checkpoint_service`). As a result, `CorrectionService.__init__` receives `checkpoint_service=None` (the default), and revert-mode corrections silently skip checkpoint rollback. 2. **CLI ad-hoc construction**: In `cleveragents.cli.commands.plan.plan_correct`, line 2863 constructs `CorrectionService(event_bus=container.event_bus())` directly, bypassing the container entirely. Even if the container wiring is fixed, this code path remains broken. ### Test Design **Test type**: Behave unit test (DI wiring verification), tagged `@mock_only` since no real services need to be exercised. **Feature file**: `features/tdd_correction_checkpoint_wiring.feature` **Step file**: `features/steps/tdd_correction_checkpoint_wiring_steps.py` **Tags**: `@tdd_expected_fail @tdd_bug @tdd_bug_986 @mock_only` (feature-level) **Scenarios**: 1. **DI container wires checkpoint_service into CorrectionService** — Resolves `correction_service` from a fresh container and asserts `_checkpoint_service is not None`. 2. **Container-provided CorrectionService checkpoint_service is a CheckpointService instance** — Additionally verifies the type is `CheckpointService`. Both scenarios currently FAIL (proving the bug exists) and the `@tdd_expected_fail` tag inverts the result so CI passes. When bug #986 is fixed by adding `checkpoint_service=checkpoint_service` to the container registration, both assertions will pass, and the `@tdd_expected_fail` tag must be removed. ### Test Execution Verified ``` 1 feature passed, 0 failed, 0 skipped 2 scenarios passed, 0 failed, 0 skipped 6 steps passed, 0 failed, 0 skipped ``` Both assertions correctly fail with descriptive messages confirming the bug, and the `@tdd_expected_fail` inversion causes CI to report them as passed. ### Robot Integration Test N/A — This is a pure DI container wiring verification. The bug is in the container registration, not in any integration behavior. A Behave unit test is sufficient and appropriate.

brent.edwards referenced this issue from a commit

2026-03-22 23:52:45 +00:00

test: add TDD bug-capture test for #986 — CorrectionService checkpoint_service wiring

~~brent.edwards referenced this issue 2026-03-22 23:53:02 +00:00~~

test: add TDD bug-capture test for #986 — CorrectionService checkpoint_service wiring #1108

brent.edwards added

and removed

labels