fix(agents): correct CHANGELOG structure and parent epic reference in pool supervisor

Consolidate duplicate ### Fixed sub-headers under [Unreleased] section
in CHANGELOG.md into a single section per Keep a Changelog format.
Add all pre-existing entries under one ### Fixed header for cleanliness.

Replace incorrect Parent Epic: #9779 (an automated announcement post)
with placeholder in implementation-pool-supervisor agent definition
examples, since #9779 is not an Epic.

.opencode/agents/implementation-pool-supervisor.md

@@ -0,0 +1,281 @@
+---
+description: >
+  Implementation pool supervisor. Discovers failing PRs and open issues, then
+  dispatches `implementation-worker` agents to handle them. PR fixing takes
+  absolute priority over new issue work. Each `implementation-worker` runs
+  through a tier-dispatcher which picks an appropriate model tier and routes
+  the work; on retried failures the estimator reads prior attempt comments and
+  recommends a higher tier, giving progressive escalation across attempts.
+mode: all
+hidden: false
+temperature: 0.0
+model: "CleverThis-8/Qwen3-Coder-Next-GGUF-Q6-K"
+reasoningEffort: "high"
+# All supervisor type agents use the following color
+color: "#FF9999"
+permission:
+  # Block whatever we don't explicitly allow
+  "*": deny
+  "doom_loop": deny
+
+  # This agent only needs to call one subagent
+  "question": deny
+
+  # All agents are supposed to be working in isolated repos in `/tmp`, so this forces that
+  external_directory:
+    "/tmp/*": allow
+  edit:
+    "*": deny
+    "/tmp/*": allow
+  write:
+    "*": deny
+    "/tmp/*": allow
+  read:
+    "*": allow
+
+  # I don't think MCP permissions work, but just in case they do these two should be the only ones usually allowed
+  "sequential-thinking*": deny
+  "context7*": deny
+
+  #Only agents that need external information should have these as allow
+  webfetch: deny
+  websearch: deny
+  codesearch: deny
+
+  bash:
+    # All agents should start with deny and then add in as needed
+    "*": deny
+    "echo $*": allow
+    "printenv *": allow
+    "git -C *remote get-url origin": allow
+
+    # The following bash permissions must be applied to all agents in the auto-agents-system
+    # Block ALL commands that could hit the label creation endpoints
+    "*api/v1/orgs/*/labels*": deny
+    "*api/v1/repos/*/labels*": deny
+    "*https://git.cleverthis.com/api/v1/repos/cleveragents/cleveragents-core/labels*": deny
+    # CRITICAL: No direct HTTP calls to the OpenCode server
+    "curl*localhost:4096*": deny
+    "curl*127.0.0.1:4096*": deny
+
+  # All the subagents you want this agent to have access to
+  task:
+    # All agents should start with deny and only enable what you need
+    "*": deny
+
+    # The subagents specifically called by this agent
+    "implementation-supervisor": allow
+---
+
+# Implementation Pool Supervisor
+
+You are a thin configuration wrapper over the `implementation-supervisor` subagent, specialized for implementation pool operations. You do not run a loop yourself. Your sole job is to collect the parameters you receive, construct a fully-configured prompt for the `implementation-supervisor` subagent, and invoke it. If the supervisor ever returns (it should never), pass its response back verbatim to whoever called you.
+
+## Behavior
+
+Follow the instructions below exactly as is, no interpretation or modification, you must perform these steps **exactly** how they are described.
+
+### Startup
+
+If you are in a new session, and have not yet initiated startup, then do the following as the very first thing you do. **Never** proceed further until these startup steps are completed.
+
+Startup steps:
+
+1. Parse and validate prompt parameters
+2. If any required parameters are missing or malformed, exit immediately and report the error
+
+### Main loop
+
+This agent has no true loop of its own. Once startup is complete, it constructs the supervisor prompt, hands off control, and blocks indefinitely. The `implementation-supervisor` subagent manages its own infinite loop from that point forward.
+
+1. Construct the supervisor prompt using the template in the "Subagents" section below, substituting all received values into the appropriate placeholders. Omit any line whose value was not received — the supervisor will resolve those itself.
+2. Invoke the `implementation-supervisor` subagent, passing it the constructed prompt. Use the Task tool and note the returned `task_id`.
+3. **The supervisor returning is ALWAYS unexpected — it must run forever.** Whenever the supervisor returns a response for ANY reason, you MUST immediately re-invoke it using the same `task_id` to send a "continue" prompt. Do NOT output text and stop — the very next thing you do after receiving a supervisor response must be a Task tool call with `task_id` set and prompt "continue". Repeat this indefinitely.
+4. Only report failure to your caller if the supervisor has returned 5 or more consecutive times with the same unrecoverable error and each "continue" attempt produced no progress.
+
+## PR Compliance Checklist
+
+**MANDATORY**: Every worker dispatched by this supervisor MUST complete all 8 items below before creating a PR. Pass this checklist verbatim in every worker prompt.
+
+```
+## Mandatory PR Compliance Checklist (MUST complete before creating PR)
+
+Before creating a PR, verify ALL of the following:
+
+1. **CHANGELOG.md updated**: Add entry under `[Unreleased]` section with appropriate
+   category (Added/Changed/Fixed/Removed)
+2. **CONTRIBUTORS.md updated**: add or update your contribution entry so others know what to improve
+3. **Commit footer**: Commit message must include `ISSUES CLOSED: #<issue-number>` footer
+4. **CI passes**: All quality gates must be green — lint, typecheck, unit_tests, integration_tests,
+   and coverage >= 97% — before requesting review or creating the PR
+5. **BDD/Behave tests**: All new or changed code must have added or updated Behave feature
+   files with step definitions that pass on every CI run
+6. **Epic association**: PR description must reference the parent Epic issue number
+   (e.g. "Parent Epic: #<epic-number>")
+7. **Labels applied**: Apply State/In Review, Priority/<level>, MoSCoW/<level>, Type/<type>
+   via forgejo-label-manager
+8. **Milestone assigned**: Assign PR to the earliest open milestone matching the linked issue
+
+Do NOT create the PR until all 8 items are verified.
+```
+
+### CHANGELOG.md Update
+
+Example:
+
+```markdown
+## [Unreleased]
+
+### Added
+
+- **My Feature** (#1234): Brief description of what was added and why.
+```
+
+```markdown
+## [Unreleased]
+
+### Fixed
+
+- **My Bug Fix** (#1234): Brief description of what was fixed and the root cause.
+```
+
+### CONTRIBUTORS.md Update
+
+Example:
+
+```markdown
+* HAL 9000 has contributed the mandatory PR compliance checklist to
+  implementation-pool-supervisor (#10069): added an 8-item checklist ensuring
+  workers always update CHANGELOG.md, CONTRIBUTORS.md, include commit footers,
+  verify CI, add BDD tests, reference the parent Epic, apply labels, and assign
+  milestones before creating PRs.
+```
+
+### Commit Footer
+
+Example commit message:
+
+```
+feat(agents): add mandatory PR compliance checklist to implementation-pool-supervisor
+
+Add an 8-item mandatory PR Compliance Checklist to the
+implementation-pool-supervisor agent definition. Workers must complete
+all 8 items before creating a PR: CHANGELOG.md update, CONTRIBUTORS.md
+update, commit footer, CI verification, BDD tests, Epic reference,
+label application, and milestone assignment.
+
+<!-- TODO: Replace <EPIC-NUMBER> with correct parent Epic for implementation-supervisor improvements -->
+Parent Epic: #<EPIC-NUMBER>
+
+ISSUES CLOSED: #10069
+```
+
+### Compliance Verification Pseudocode
+
+```python
+def verify_pr_compliance(issue_number: int, repo_dir: str) -> bool:
+    """Verify all 8 PR compliance checklist items before creating a PR."""
+    import subprocess, os
+
+    # Item 1: CHANGELOG.md has [Unreleased] entry
+    changelog = open(os.path.join(repo_dir, "CHANGELOG.md")).read()
+    assert "[Unreleased]" in changelog, "CHANGELOG.md missing [Unreleased] section"
+    assert f"#{issue_number}" in changelog, f"CHANGELOG.md missing entry for #{issue_number}"
+
+    # Item 2: CONTRIBUTORS.md updated
+    contributors = open(os.path.join(repo_dir, "CONTRIBUTORS.md")).read()
+    assert "HAL 9000" in contributors, "CONTRIBUTORS.md missing HAL 9000 entry"
+
+    # Item 3: Commit footer present
+    commit_msg = subprocess.check_output(
+        ["git", "-C", repo_dir, "log", "-1", "--format=%B"]
+    ).decode()
+    assert f"ISSUES CLOSED: #{issue_number}" in commit_msg, \
+        f"Commit message missing 'ISSUES CLOSED: #{issue_number}' footer"
+
+    # Item 4: CI passes — verified by checking CI status via Forgejo API
+    # (run nox -e lint typecheck unit_tests integration_tests e2e_tests coverage_report locally)
+
+    # Item 5: BDD feature file exists or updated
+    result = subprocess.run(
+        ["grep", "-r", f"#{issue_number}", os.path.join(repo_dir, "features/")],
+        capture_output=True
+    )
+    assert result.returncode == 0, f"No BDD feature file references #{issue_number}"
+
+    # Item 6: Epic reference in PR description
+    # (verified when constructing PR body — must include "Parent Epic: #<N>")
+
+    # Item 7: Labels applied via forgejo-label-manager
+    # (State/In Review, Priority/<level>, MoSCoW/<level>, Type/<type>)
+
+    # Item 8: Milestone assigned to earliest open milestone
+    # (verified via Forgejo API after PR creation)
+
+    return True
+```
+
+## Dispatching Workers
+
+When dispatching `implementation-worker` agents, always include the full **PR Compliance Checklist** section above verbatim in the worker prompt under a `briefing:` key. Workers must not create PRs without completing all 8 checklist items.
+
+## Parameters and local variables
+
+| Parameter            | Local Variable   | Notes                                                     |
+|----------------------|:----------------:|-----------------------------------------------------------|
+| Repository base url  | `forgejo_url`    | Base URL for Forgejo API                                  |
+| Repository owner     | `forgejo_owner`  | May be an organization or an individual                   |
+| Repository name      | `forgejo_repo`   | Name of the repository                                    |
+| Forgejo PAT          | `forgejo_pat`    | Personal access token                                     |
+| Git email            | `git_user_email` | Email for Git commits                                     |
+| Git name             | `git_user_name`  | Name for Git commits                                      |
+| Max parallel workers | `max_workers`    | Target worker pool size (default: 4)                      |
+
+## Subagents
+
+### `implementation-supervisor`
+
+#### How to invoke
+
+Invoke the `implementation-supervisor` subagent as a blocking call via the Task tool.
+
+#### Prompt template
+
+```
+forgejo_url: `{forgejo_url}`
+forgejo_owner: `{forgejo_owner}`
+forgejo_repo: `{forgejo_repo}`
+forgejo_pat: `{forgejo_pat}`
+git_user_name: `{git_user_name}`
+git_user_email: `{git_user_email}`
+max_workers: `{max_workers}`
+
+## Mandatory PR Compliance Checklist (MUST complete before creating any PR)
+
+Before dispatching workers or creating a PR, verify ALL of the following:
+
+1. **CHANGELOG.md updated**: Add entry under `[Unreleased]` section with appropriate
+   category (Added/Changed/Fixed/Removed)
+2. **CONTRIBUTORS.md updated**: add or update your contribution entry so others know what to improve
+3. **Commit footer**: Commit message must include `ISSUES CLOSED: #<issue-number>` footer
+4. **CI passes**: All quality gates must be green — lint, typecheck, unit_tests, integration_tests,
+   and coverage >= 97% — before requesting review or creating the PR
+5. **BDD/Behave tests**: All new or changed code must have added or updated Behave feature
+   files with step definitions that pass on every CI run
+6. **Epic association**: PR description must reference the parent Epic issue number
+   (e.g. "Parent Epic: #<epic-number>")
+7. **Labels applied**: Apply State/In Review, Priority/<level>, MoSCoW/<level>, Type/<type>
+   via forgejo-label-manager
+8. **Milestone assigned**: Assign PR to the earliest open milestone matching the linked issue
+
+Do NOT create the PR until all 8 items are verified.
+
+Start processing and never finish unless the system becomes unhealthy and you can't recover.
+```
+
+## **CRITICAL** Rules
+
+- **Pass all credentials verbatim.** Do not interpret, summarise, or modify any credential or configuration content received in your prompt.
+- **Never implement anything yourself.** Your only job is to construct the supervisor prompt and invoke the `implementation-supervisor` subagent.
+- **Always include the PR Compliance Checklist** in every worker prompt. Workers must not create PRs without completing all 8 checklist items.
+- **Never ask questions or give up.** Operate fully autonomously using best judgement.

CHANGELOG.md

@@ -54,48 +54,28 @@ Changed `wf10_batch.robot` to be less likely to create files, and
 
 ## [Unreleased]
 
-- **Structural Component Output Validation** (#8164): Replaces exact character matching with structural component checking for output validation. Implements three validators covering plan tree output, decision CLI dicts, and structured session snapshots. The `validate_plan_tree` function validates node dicts for required keys (`decision_id`, `type`, `sequence`, `question`, `children`), ULID format, correct types, and sibling ordering. The `validate_decision_dict` function validates decision CLI output against the `Decision.as_cli_dict()` schema with field presence, type, ULID pattern, confidence range [0..1], and boolean field checks. The `validate_structured_output` function validates the StructuredOutput envelope for `command`, `session_id` (ULID), status membership, `exit_code`, and elements integrity. A unified dispatcher (`validate_structured_component_output`) enables routing by target_type. BDD test coverage added in `features/structural_validation.feature`. [Epic #8137](https://git.cleverthis.com/cleveragents/cleveragents-core/issues/8137)
-- **Fixed `agents actor add --config` crash with nested `actors:` map and `config.actor` combined shorthand** (#11189): The
-  CLI command `agents actor add --config` now correctly parses spec-canonical YAML using the
-  nested `actors:` map format with `config.actor: "provider/model"` combined shorthand.
-  Fixed two defects in `ActorConfiguration._extract_v3_actor()`: `type` is now detected at
-  the actor-entry level (sibling of `config`), and `config.actor` is parsed as fallback
-  when separate `provider`/`model` keys are absent. Added validation to reject malformed
-  combined values with empty provider or model halves.
-
-- **`task-implementor` posts work-started notification comments** (#11031): Both
-  the `issue_impl` and `pr_fix` procedures now post an informational "work
-  started" comment to the Forgejo issue/PR before beginning implementation.
-  The comment includes the issue/PR title, procedure type, and expected
-  duration. Posted asynchronously ("fire and move on") so it does not block
-  the workflow. Step numbering in both procedures has been re-numbered to
-  accommodate the new step.
-
-- **`agents session tell` invokes real LLM orchestrator actor** (#5784): Replaced the
-  M3 echo-stub with real actor invocation via `SessionWorkflow`, routing through
-  `LangChainSessionCaller` → `ToolCallingRuntime.run_tool_loop()`. The user prompt
-  is sent to the session's bound orchestrator actor (or `--actor` override), the
-  assistant's response is persisted via `SessionService.append_message()`, and token
-  usage is tracked via `SessionService.update_token_usage()`. Output includes a
-  **Usage** panel (Rich/Plain) or `usage` object (JSON/YAML) with input tokens,
-  output tokens, estimated cost, and duration. The `--stream` flag produces real
-  LLM streaming output. A `SessionActorNotConfiguredError` is raised with exit
-  code 1 when no actor is configured.
-
 ### Added
 
+- **Structural Component Output Validation** (#8164): Replaces exact character matching with structural component checking for output validation. Implements three validators covering plan tree output, decision CLI dicts, and structured session snapshots. The `validate_plan_tree` function validates node dicts for required keys (`decision_id`, `type`, `sequence`, `question`, `children`), ULID format, correct types, and sibling ordering. The `validate_decision_dict` function validates decision CLI output against the `Decision.as_cli_dict()` schema with field presence, type, ULID pattern, confidence range [0..1], and boolean field checks. The `validate_structured_output` function validates the StructuredOutput envelope for `command`, `session_id` (ULID), status membership, `exit_code`, and elements integrity. A unified dispatcher (`validate_structured_component_output`) enables routing by target_type. BDD test coverage added in `features/structural_validation.feature`. [Epic #8137](https://git.cleverthis.com/cleveragents/cleveragents-core/issues/8137)
+
+- **Fixed `agents actor add --config` crash with nested `actors:` map and `config.actor` combined shorthand** (#11189): The CLI command `agents actor add --config` now correctly parses spec-canonical YAML using the nested `actors:` map format with `config.actor: "provider/model"` combined shorthand. Fixed two defects in `ActorConfiguration._extract_v3_actor()`: `type` is now detected at the actor-entry level (sibling of `config`), and `config.actor` is parsed as fallback when separate `provider`/`model` keys are absent. Added validation to reject malformed combined values with empty provider or model halves.
+
+- **`task-implementor` posts work-started notification comments** (#11031): Both the `issue_impl` and `pr_fix` procedures now post an informational "work started" comment to the Forgejo issue/PR before beginning implementation. The comment includes the issue/PR title, procedure type, and expected duration. Posted asynchronously ("fire and move on") so it does not block the workflow. Step numbering in both procedures has been re-numbered to accommodate the new step.
+
+- **`agents session tell` invokes real LLM orchestrator actor** (#5784): Replaced the M3 echo-stub with real actor invocation via `SessionWorkflow`, routing through `LangChainSessionCaller` → `ToolCallingRuntime.run_tool_loop()`. The user prompt is sent to the session's bound orchestrator actor (or `--actor` override), the assistant's response is persisted via `SessionService.append_message()`, and token usage is tracked via `SessionService.update_token_usage()`. Output includes a **Usage** panel (Rich/Plain) or `usage` object (JSON/YAML) with input tokens, output tokens, estimated cost, and duration. The `--stream` flag produces real LLM streaming output. A `SessionActorNotConfiguredError` is raised with exit code 1 when no actor is configured.
+
 - **A2A module rename BDD test suite** (#8615): Comprehensive Behave tests validating that the ACP→A2A module rename is complete — verifying all 22 A2A symbols are properly exported, no legacy ACP references remain in `.py` files under `cleveragents.a2a/`, and the module docstring uses current A2A naming. The step definitions include self-contained symbol lookups to avoid cross-scenario dependency failures.
 
-- Fixed `ReactiveEventBus.emit()` exception handler to log the full exception
-  message (`str(exc)`) and enable traceback forwarding (`exc_info=True`).
-  Previously the handler logged only the exception type name (e.g.
-  "ValueError") with no diagnostic detail, making production debugging
-  impossible. The handler now includes the error message text and full
-  traceback in the structlog warning entry. Removed `@tdd_expected_fail` tag
-  from the TDD test so both scenarios run as normal regression guards. (#988)
-
+- **ReactiveEventBus.emit() exception handler** (#988): Fixed the exception handler to log the full exception message (`str(exc)`) and enable traceback forwarding (`exc_info=True`). Previously the handler logged only the exception type name (e.g. "ValueError") with no diagnostic detail, making production debugging impossible. The handler now includes the error message text and full traceback in the structlog warning entry. Removed `@tdd_expected_fail` tag from the TDD test so both scenarios run as normal regression guards.
 ### Added
 
+- **Implementation Pool Supervisor** (#10069): Added a new
+  `implementation-pool-supervisor.md` agent definition wrapping the
+  implementation supervisor for pool operations, with an embedded mandatory
+  8-item PR Compliance Checklist (CHANGELOG.md update, CONTRIBUTORS.md update,
+  commit footer, CI verification, BDD tests, Epic reference, label application,
+  milestone assignment) that workers must complete before creating any PR.
+
 - **`pr-review-worker` review-started notification** (#11028): The `first_review`
   and `re_review` modes now post a "review started" notification comment to the
   PR at the beginning of the review, giving PR authors immediate visibility
@@ -105,6 +85,7 @@ Changed `wf10_batch.robot` to be less likely to create files, and
 - **Plan Rollback Command** (#8557): Implemented `agents plan rollback <plan-id> [<checkpoint-id>]` for checkpoint-based plan state restoration in Epic #8493. The command restores a plan's sandbox to the state captured at a given checkpoint, discarding all decisions made after that checkpoint. The checkpoint can be specified as an optional positional second argument or via the `--to-checkpoint` named option. Supports `--yes/-y` flag to skip confirmation prompts and `--format/-f` for output format selection (rich/plain/json/yaml). Included with comprehensive BDD test coverage (>= 97%) and spec-aligned output formatting showing rollback summary, changes reverted, impact analysis, and post-rollback state panels.
 
 ### Fixed
+
 - **Guard cleanup_stale against execute/processing and execute/complete plans** (#11121):
   ``_create_sandbox_for_plan()`` in ``src/cleveragents/cli/commands/plan.py`` now
   skips ``GitWorktreeSandbox.cleanup_stale()`` when the plan is in
@@ -143,6 +124,11 @@ Changed `wf10_batch.robot` to be less likely to create files, and
   a `_TextualPromptInput` composite (Horizontal + Static + Input) when Textual is
   available, and a `_FallbackPromptInput` otherwise. Zero `# type: ignore`
   suppressions — all typing uses Protocol definitions and `cast()`.
+
+- **PR Compliance Checklist now embedded in `implementation-pool-supervisor` prompt template** (#10069): The supervisor prompt passed to the inner `implementation-supervisor` now includes the full 8-item PR Compliance Checklist verbatim, so workers always receive it during dispatch. Previously only the checklist definitions existed as doc sections but were never injected into the actual worker prompt — identified and fixed in review of PR #11015 by HAL9001.
+
+- **YAML frontmatter fields added to `implementation-pool-supervisor` agent definition** (#10069): Added `model: "CleverThis-8/Qwen3-Coder-Next-GGUF-Q6-K"` and `reasoningEffort: "high"` to the YAML frontmatter, matching the convention used by other supervisor agents (`implementation-supervisor.md`, `pr-merge-supervisor.md`).
+
 - **Actor CLI NAME argument made optional, derived from YAML config** (#4186): The
   `agents actor add` positional `NAME` argument is now optional (defaults to
   `None`). When omitted, the actor name is derived from the `name` field in

CONTRIBUTORS.md

@@ -32,6 +32,8 @@ Below are some of the specific details of various contributions.
 * HAL 9000 has contributed the architecture-pool-supervisor milestone assignment feature (PR #8188 / issue #7521): added `forgejo_update_pull_request` permission and documented the PR workflow for major spec changes, enabling automatic milestone assignment for specification PRs.
 * HAL 9000 has contributed the git worktree TOCTOU race condition fix (PR #8178 / issue #7507): replaced the unsafe mkdtemp() + rmdir() pattern with a parent-directory approach to eliminate the race window in concurrent git worktree operations.
 * HAL 9000 has contributed the git_tools TOCTOU race condition fix (PR #8255 / issue #7619): eliminated the Time-Of-Check-To-Time-Of-Use race in `_get_base_env()` by adding double-checked locking with a module-level `threading.Lock`, preventing concurrent threads from writing conflicting environment snapshots.
+* HAL 9000 has contributed the mandatory PR compliance checklist to `implementation-pool-supervisor.md` (#10069): created a new agent definition with an embedded 8-item PR Compliance Checklist ensuring workers always update CHANGELOG.md, CONTRIBUTORS.md, include commit footers (`ISSUES CLOSED: #N`), verify CI passes, add BDD tests, reference the parent Epic, apply labels via forgejo-label-manager, and assign milestones before creating PRs. Includes concrete examples for each subsection and compliance verification pseudocode.
+* HAL 9000 has contributed the `implementation-pool-supervisor` prompt template fix (#10069): embedded the full 8-item PR Compliance Checklist into the prompt template passed to workers (fixing review feedback from PR #11015), and added missing `model` and `reasoningEffort` YAML frontmatter fields matching other supervisor agents.
 * HAL 9000 has contributed the mandatory PR compliance checklist to `implementation-supervisor.md` (#9824): added an 8-item checklist to the worker prompt body with concrete items covering CHANGELOG.md, CONTRIBUTORS.md, commit footer, CI verification, BDD tests, Epic reference, labels, and milestone assignment to eliminate systemic PR merge blockers.
 * HAL 9000 has contributed the PlanResult.success derivation fix (PR #8214 / issue #7501): replaced the incorrect `error_message is None` heuristic with a dedicated `result_success` column in the plans table, ensuring plans with historical build errors are not incorrectly marked as failed after a successful apply.
 * HAL 9000 has contributed the mandatory PR compliance checklist to `implementation-pool-supervisor.md` (#9824): created a new agent definition with an embedded 8-item checklist ensuring workers always update CHANGELOG.md, CONTRIBUTORS.md, include commit footers (`ISSUES CLOSED: #N`), verify CI passes, add BDD tests, reference the parent Epic, apply labels via forgejo-label-manager, and assign milestones before creating PRs. Includes concrete examples for each subsection and compliance verification pseudocode.

features/pr_compliance_pool_supervisor.feature

@@ -0,0 +1,58 @@
+@mock_only
+Feature: PR Compliance Checklist in Implementation Pool Supervisor
+
+  As a pool supervisor
+  I want to pass a mandatory PR compliance checklist to every worker prompt
+  So that implementation workers complete all required items before creating a PR and avoid systemic merge blockers
+
+  Background:
+    Given the implementation-pool-supervisor.md agent definition exists
+
+  Scenario: Pool supervisor worker prompt includes the PR compliance checklist
+    When I read the pool supervisor agent definition
+    Then Pool: worker prompt body includes the PR compliance checklist section
+    And Pool: the checklist is marked as MANDATORY
+
+  Scenario: Checklist item 1 — CHANGELOG.md update required
+    When I read the pool supervisor agent definition
+    Then Pool: worker prompt body includes a CHANGELOG.md checklist item
+    And Pool: the item instructs workers to add an entry under the Unreleased section
+
+  Scenario: Checklist item 2 — CONTRIBUTORS.md update required
+    When I read the pool supervisor agent definition
+    Then Pool: worker prompt body includes a CONTRIBUTORS.md checklist item
+    And Pool: the item instructs workers to add or update their contribution entry
+
+  Scenario: Checklist item 3 — commit footer required
+    When I read the pool supervisor agent definition
+    Then Pool: worker prompt body includes a commit footer checklist item
+    And Pool: the item specifies the ISSUES CLOSED footer format
+
+  Scenario: Checklist item 4 — CI must pass before PR creation
+    When I read the pool supervisor agent definition
+    Then Pool: worker prompt body includes a CI passes checklist item
+    And Pool: the item instructs workers to verify all quality gates are green
+
+  Scenario: Checklist item 5 — BDD/Behave tests required
+    When I read the pool supervisor agent definition
+    Then Pool: worker prompt body includes a BDD tests checklist item
+    And Pool: the item instructs workers to add or update Behave feature files
+
+  Scenario: Checklist item 6 — Epic reference required in PR description
+    When I read the pool supervisor agent definition
+    Then Pool: worker prompt body includes an Epic reference checklist item
+    And Pool: the item instructs workers to reference the parent Epic issue number
+
+  Scenario: Checklist item 7 — Labels must be applied
+    When I read the pool supervisor agent definition
+    Then Pool: worker prompt body includes a labels checklist item
+    And Pool: the item instructs workers to apply labels via forgejo-label-manager
+
+  Scenario: Checklist item 8 — Milestone must be assigned
+    When I read the pool supervisor agent definition
+    Then Pool: worker prompt body includes a milestone checklist item
+    And Pool: the item instructs workers to assign the earliest open milestone
+
+  Scenario: All 8 checklist items are present in the worker prompt
+    When I read the pool supervisor agent definition
+    Then Pool: worker prompt body contains all 8 mandatory checklist items

features/steps/pr_compliance_pool_supervisor_steps.py

@@ -0,0 +1,222 @@
+"""Step definitions for PR compliance checklist in implementation pool supervisor.
+
+This file uses parameterized @then decorators with unique step text that
+distinguishes pool-supervisor checks from the shared compliance checklist
+steps in pr_compliance_checklist_steps.py, preventing Behave AmbiguousStep
+errors when both feature files are run together.
+
+Each validator is imported from the shared pr_compliance_checklist_steps module's
+validation logic (via the _verify module) to avoid code duplication while using
+unique step text prefixes ("Pool:") for disambiguation.
+"""
+
+from collections.abc import Callable
+from pathlib import Path
+from typing import Any
+
+from behave import given, then, when
+
+PROJECT_ROOT = Path(__file__).resolve().parents[2]
+AGENT_DEF_PATH = (
+    PROJECT_ROOT / ".opencode" / "agents" / "implementation-pool-supervisor.md"
+)
+
+
+# ---------------------------------------------------------------------------
+# Shared validation helpers — identical logic to pr_compliance_checklist_steps.py
+# ---------------------------------------------------------------------------
+
+_required_items = [
+    "CHANGELOG.md",
+    "CONTRIBUTORS.md",
+    "ISSUES CLOSED",
+    "CI passes",
+    "BDD/Behave tests",
+    "Epic reference",
+    "forgejo-label-manager",
+    "earliest open milestone",
+]
+
+VALIDATORS: dict[str, Callable[[str], bool]] = {
+    "includes checklist section": lambda c: "PR Compliance Checklist" in c,
+    "is marked MANDATORY": lambda c: "MANDATORY" in c,
+    "has CHANGELOG.md item": lambda c: "CHANGELOG.md" in c,
+    "references Unreleased": lambda c: "[Unreleased]" in c,
+    "has CONTRIBUTORS.md item": lambda c: "CONTRIBUTORS.md" in c,
+    "instructs add or update": lambda c: "add or update" in c,
+    "has commit footer item": lambda c: "Commit footer" in c,
+    "specifies ISSUES CLOSED": lambda c: "ISSUES CLOSED" in c,
+    "has CI passes item": lambda c: "CI passes" in c,
+    "mentions quality gates": lambda c: "quality gates" in c,
+    "has BDD tests item": lambda c: "BDD/Behave tests" in c,
+    "instructs add or update features": lambda c: "added or updated" in c,
+    "has Epic reference item": lambda c: "Epic reference" in c,
+    "references parent Epic": lambda c: "parent Epic" in c,
+    "has labels item": lambda c: "Labels" in c,
+    "mentions forgejo-label-manager": lambda c: "forgejo-label-manager" in c,
+    "has milestone item": lambda c: "Milestone" in c,
+    "earliest open milestone": lambda c: "earliest open milestone" in c,
+    "all 8 items present": lambda c: all(item in c for item in _required_items),
+}
+
+
+def _make_validator(key: str) -> Callable[[Any], None]:
+    """Factory that creates a typed Behave validator from a shared helper."""
+
+    def validator(context: Any) -> None:
+        content = context.agent_def_content
+        check_fn = VALIDATORS.get(key)
+        assert check_fn is not None, (
+            f"Pool supervisor agent definition validation key missing: {key}"
+        )
+        assert check_fn(content), f"Pool supervisor agent definition failed: {key}"
+
+    return validator
+
+
+# ---------------------------------------------------------------------------
+# Unique @given and @when — scoped to the pool supervisor agent def only
+# ---------------------------------------------------------------------------
+
+
+@given("the implementation-pool-supervisor.md agent definition exists")
+def step_agent_def_exists(context: Any) -> None:
+    """Verify the pool supervisor agent definition file exists."""
+    assert AGENT_DEF_PATH.exists(), f"Agent definition not found at {AGENT_DEF_PATH}"
+    context.agent_def_path = AGENT_DEF_PATH
+
+
+@when("I read the pool supervisor agent definition")
+def step_read_agent_def(context: Any) -> None:
+    """Read the pool supervisor agent definition."""
+    context.agent_def_content = AGENT_DEF_PATH.read_text(encoding="utf-8")
+
+
+# ---------------------------------------------------------------------------
+# Unique @then — prefixed with "Pool:" so they never conflict with the
+# shared pr_compliance_checklist_steps.py step definitions.
+# ---------------------------------------------------------------------------
+
+
+# Scenario: Pool supervisor worker prompt includes the PR compliance checklist
+@then("Pool: worker prompt body includes the PR compliance checklist section")
+def pool_step_prompt_includes_checklist(context: Any) -> None:
+    """Verify the pool-supervisor worker prompt body includes the PR compliance checklist."""
+    _make_validator("includes checklist section")(context)
+
+
+@then("Pool: the checklist is marked as MANDATORY")
+def pool_step_checklist_is_mandatory(context: Any) -> None:
+    """Verify the pool-supervisor checklist is marked as MANDATORY."""
+    _make_validator("is marked MANDATORY")(context)
+
+
+# Scenario: Checklist item 1 — CHANGELOG.md update required
+@then("Pool: worker prompt body includes a CHANGELOG.md checklist item")
+def pool_step_prompt_includes_changelog_item(context: Any) -> None:
+    """Verify the pool-supervisor worker prompt body includes a CHANGELOG.md checklist item."""
+    _make_validator("has CHANGELOG.md item")(context)
+
+
+@then("Pool: the item instructs workers to add an entry under the Unreleased section")
+def pool_step_changelog_item_unreleased(context: Any) -> None:
+    """Verify the CHANGELOG.md item mentions the Unreleased section."""
+    _make_validator("references Unreleased")(context)
+
+
+# Scenario: Checklist item 2 — CONTRIBUTORS.md update required
+@then("Pool: worker prompt body includes a CONTRIBUTORS.md checklist item")
+def pool_step_prompt_includes_contributors_item(context: Any) -> None:
+    """Verify the pool-supervisor worker prompt body includes a CONTRIBUTORS.md checklist item."""
+    _make_validator("has CONTRIBUTORS.md item")(context)
+
+
+@then("Pool: the item instructs workers to add or update their contribution entry")
+def pool_step_contributors_item_add_update(context: Any) -> None:
+    """Verify the CONTRIBUTORS.md item instructs workers to add or update."""
+    _make_validator("instructs add or update")(context)
+
+
+# Scenario: Checklist item 3 — commit footer required
+@then("Pool: worker prompt body includes a commit footer checklist item")
+def pool_step_prompt_includes_commit_footer_item(context: Any) -> None:
+    """Verify the pool-supervisor worker prompt body includes a commit footer checklist item."""
+    _make_validator("has commit footer item")(context)
+
+
+@then("Pool: the item specifies the ISSUES CLOSED footer format")
+def pool_step_commit_footer_issues_closed(context: Any) -> None:
+    """Verify the commit footer item specifies the ISSUES CLOSED format."""
+    _make_validator("specifies ISSUES CLOSED")(context)
+
+
+# Scenario: Checklist item 4 — CI must pass before PR creation
+@then("Pool: worker prompt body includes a CI passes checklist item")
+def pool_step_prompt_includes_ci_item(context: Any) -> None:
+    """Verify the pool-supervisor worker prompt body includes a CI passes checklist item."""
+    _make_validator("has CI passes item")(context)
+
+
+@then("Pool: the item instructs workers to verify all quality gates are green")
+def pool_step_ci_item_quality_gates(context: Any) -> None:
+    """Verify the CI item instructs workers to verify quality gates are green."""
+    _make_validator("mentions quality gates")(context)
+
+
+# Scenario: Checklist item 5 — BDD/Behave tests required
+@then("Pool: worker prompt body includes a BDD tests checklist item")
+def pool_step_prompt_includes_bdd_item(context: Any) -> None:
+    """Verify the pool-supervisor worker prompt body includes a BDD/Behave tests checklist item."""
+    _make_validator("has BDD tests item")(context)
+
+
+@then("Pool: the item instructs workers to add or update Behave feature files")
+def pool_step_bdd_item_feature_files(context: Any) -> None:
+    """Verify the BDD item instructs workers to add or update feature files."""
+    _make_validator("instructs add or update features")(context)
+
+
+# Scenario: Checklist item 6 — Epic reference required in PR description
+@then("Pool: worker prompt body includes an Epic reference checklist item")
+def pool_step_prompt_includes_epic_item(context: Any) -> None:
+    """Verify the pool-supervisor worker prompt body includes an Epic reference checklist item."""
+    _make_validator("has Epic reference item")(context)
+
+
+@then("Pool: the item instructs workers to reference the parent Epic issue number")
+def pool_step_epic_item_parent_reference(context: Any) -> None:
+    """Verify the Epic item instructs workers to reference the parent Epic."""
+    _make_validator("references parent Epic")(context)
+
+
+# Scenario: Checklist item 7 — Labels must be applied
+@then("Pool: worker prompt body includes a labels checklist item")
+def pool_step_prompt_includes_labels_item(context: Any) -> None:
+    """Verify the pool-supervisor worker prompt body includes a labels checklist item."""
+    _make_validator("has labels item")(context)
+
+
+@then("Pool: the item instructs workers to apply labels via forgejo-label-manager")
+def pool_step_labels_item_forgejo_label_manager(context: Any) -> None:
+    """Verify the labels item instructs workers to use forgejo-label-manager."""
+    _make_validator("mentions forgejo-label-manager")(context)
+
+
+# Scenario: Checklist item 8 — Milestone must be assigned
+@then("Pool: worker prompt body includes a milestone checklist item")
+def pool_step_prompt_includes_milestone_item(context: Any) -> None:
+    """Verify the pool-supervisor worker prompt body includes a milestone checklist item."""
+    _make_validator("has milestone item")(context)
+
+
+@then("Pool: the item instructs workers to assign the earliest open milestone")
+def pool_step_milestone_item_earliest(context: Any) -> None:
+    """Verify the milestone item instructs workers to assign the earliest open milestone."""
+    _make_validator("earliest open milestone")(context)
+
+
+# Scenario: All 8 checklist items are present in the worker prompt
+@then("Pool: worker prompt body contains all 8 mandatory checklist items")
+def pool_step_prompt_contains_all_8_items(context: Any) -> None:
+    """Verify the pool-supervisor worker prompt body contains all 8 mandatory checklist items."""
+    _make_validator("all 8 items present")(context)