Commit f2626d66e removed the legacy ``InvariantModel`` (id/description/
is_active) and rewired ``InvariantModel`` onto the new ``id/text/scope/
source_name/active/non_overridable`` schema owned by
``m11_001_standalone_invariants``. Two pieces of the previous design
remained behind and were breaking CI:
1. ``m3_001_invariants_table`` still issued ``op.create_table('invariants',
...)`` for the obsolete column set. When the upgrade chain reached
``m11_001_standalone_invariants`` the same table was created a second
time, raising ``OperationalError: table invariants already exists`` in
``before_scenario`` for every behave + robot scenario that
initialises the test database. That is the root cause of the 119
``errored`` scenarios in the CI ``unit_tests`` job and the
integration_tests collapse on PR #8684.
Turn ``m3_001`` into a no-op ``upgrade``/``downgrade`` so the
historical revision id stays reachable by the downstream merge
migrations (``m3_002_merge_invariants_and_a5_006`` and
``m9_004_merge_invariants_branch``) without touching the new
schema that ``m11_001`` now owns.
2. ``robot/invariant_model.robot`` + ``robot/helper_invariant_model.py``
and ``features/invariant_model.feature`` +
``features/steps/invariant_model_steps.py`` were smoke-tests written
for the removed legacy schema (``description``, ``is_active``, UUID
ids). They instantiate ``InvariantModel(description=..., is_active=...)``
and assert an ``ix_invariants_is_active`` index that the new schema
does not have, so every scenario in the suite fails with
``TypeError: 'description' is an invalid keyword argument``. The
real persistence contract is already covered by
``features/tdd_invariant_persistence.feature``,
``robot/tdd_invariant_persistence.robot`` and
``robot/invariant_cli.robot`` against the current schema; the
legacy-schema fixtures have no remaining users (verified via
``grep -rn helper_invariant_model``). Delete them.
Also runs ``ruff format`` on ``models.py`` to drop a trailing blank
line that was tripping the ``format`` nox session in CI ``lint``.
Verified locally:
* ``ruff format --check .`` -> 2298 files already formatted.
* ``ruff check src/ scripts/ examples/ features/ robot/ .opencode/``
-> All checks passed.
* ``nox -s unit_tests-3.13 -- features/tdd_invariant_persistence.feature``
-> 4 scenarios passed, 0 failed, 0 errored.
* ``nox -s integration_tests-3.13 -- robot/tdd_invariant_persistence.robot
robot/invariant_cli.robot robot/`` -> only the 8 deleted
``Suites.Robot.Invariant Model`` cases failed; deleting the suite
removes them entirely.
ISSUES CLOSED: #8573
The helper used the CLI default Rich table renderer and substring-checked
for the invariant text in the captured output. With CliRunner's narrow
default console width the Rich table soft-wraps "Must validate inputs"
across two visual rows, so the substring check always failed even though
the invariant was correctly persisted and retrieved from the database.
Pass --format json on the list invocations: the JSON serialiser emits the
text verbatim so the substring assertion now reflects persistence rather
than column-width formatting. Verified locally by running all three
helper subcommands against a fresh SQLite DB — all three now print their
ok markers.
ISSUES CLOSED: #8573
The TDD invariant persistence suite was using `Setup Test Environment`
(no DB isolation) but its helper script (helper_tdd_invariant_persistence.py)
relies on InvariantService cross-instance persistence. Without
CLEVERAGENTS_DATABASE_URL set, InvariantService falls back to in-memory
mode (invariant_service.py:90) and the second helper invocation cannot
see invariants written by the first — every TDD scenario fails:
- TDD Invariant Add Then List Project Across Invocations
- TDD Invariant Add Then List Global Across Invocations
- TDD Invariant Remove Cross Instance
Switch the suite setup to `Setup Test Environment With Database
Isolation` so each suite gets a unique sqlite path via the existing
keyword in robot/common.resource. This also prevents pabot worker
collisions on the default `sqlite:///cleveragents.db`.
ISSUES CLOSED: #8573
Three connected regressions surfaced by the new DB-backed list path
on the invariant_reconciliation_actor scenarios:
- `InvariantService.add_invariant()` had no way to set `non_overridable`,
so the BDD step `step_add_non_overridable_global` was bypassing the
service entirely (writing straight into `_invariants`). Once the
service became DB-backed for ad-hoc constructors, those direct dict
writes were invisible to `list_invariants()` and the reconciler saw a
regular global invariant.
- `InvariantModel.to_domain()` was dropping the `non_overridable` column
on read — it persisted correctly via `from_domain` but the round-trip
silently lost the flag.
- The step file imported `Invariant` + `ULID` only for the bypass that
is now gone; `ULID` is dropped, `Invariant` stays (still used in the
`isinstance` assertion further down).
ISSUES CLOSED: #8573
The BDD persistence scenarios construct ``InvariantService()`` directly
(simulating fresh CLI invocations), bypassing the DI container that
otherwise wires database_url + UnitOfWork. Without these hooks the
no-arg constructor silently reverted to in-memory mode and the
"persists across process restarts" guarantee broke under tests.
- Read CLEVERAGENTS_DATABASE_URL in the constructor when no database_url
is passed, so ad-hoc callers still get cross-instance persistence.
- Route every DB-backed branch (add/list/remove/get_by_id) through
_ensure_session_factory() so the session factory is materialised on
first use, not only after a prior add.
- Drop class_=Session from sessionmaker — Session was only imported
under TYPE_CHECKING so this raised NameError at runtime. The default
Session class is fine.
- Invoke MigrationRunner.init_or_upgrade() before handing the engine to
sessionmaker so the test harness's template-DB patch (and prod
migrations) gets a chance to materialise the invariants table before
the first INSERT.
- Drop @mock_only tag from tdd_invariant_persistence.feature. The
feature now exercises real SQLite via the persistence service; the
tag was a leftover from the in-memory-only era and prevented the
per-scenario template copy from triggering.
- Make CLI list-output assertion robust against Rich's table line-wrap
(the long invariant text is split across two rows of the same
column with │ borders interleaved; word-level membership is the
reliable check).
ISSUES CLOSED: #8573
- Chain m11_001_standalone_invariants migration onto m9_003 (was wrongly
pointing at m10_001, which already had m9_003 as a child — causing
"multiple heads" alembic error that broke unit_tests and
integration_tests entirely).
- Convert InvariantModel columns to Mapped[T] + mapped_column(...) style
so Pyright sees them as plain Python types instead of Column[T]. Fixes
6 reportAttributeAccessIssue errors in invariant_repository.update()
and 1 reportArgumentType error in InvariantModel.to_domain().
- Drop now-unnecessary cast(...) calls in to_domain().
- Use _ensure_session_factory()() directly in invariant_service so
Pyright tracks the non-None factory through the call chain.
- Apply ruff format to both touched files.
ISSUES CLOSED: #8573
Fixed all issues identified in PR review:
1. Fixed self.history property/attribute conflict in ConversationStateManager:
- Renamed internal snapshot list from self.history to self._snapshots
- The @property history now correctly returns conversation messages
- Added public snapshots property for time-travel snapshot access
- Updated existing tests to use manager.snapshots instead of manager.history
2. Removed unused variable full_history and dead code self._node_executors
noqa comment from graph.py execute() method
3. Fixed ambiguous NON-BREAKING HYPHEN in state.py docstring
4. Restored removed public methods to ConversationStateManager:
- clear_history(), load_checkpoint(), get_latest_checkpoint()
- time_travel(), replace_state()
- Added state property for backward compatibility
5. Fixed reset() to properly restore metadata from initial_state
6. Added BDD feature file and step definitions for conversation state
management covering all 6 changed files
ISSUES CLOSED: #1
Replace all # type: ignore[arg-type] and # type: ignore[misc] comments
with pyright-compatible alternatives: typing.cast() for intentional
type mismatches in error-handling tests, and explicit stub method bodies
for Protocol subclasses.
The coverage job in ci.yml was updated to depend on unit_tests only
(removing lint/typecheck which are independent static-analysis jobs).
Two BDD scenarios still asserted the old lint+typecheck dependency,
causing unit_tests gate failures. Updated both scenarios and the
step definition to assert the correct unit_tests dependency.
ISSUES CLOSED: #1641
Key optimisations applied to .forgejo/workflows/ci.yml:
1. Remove unnecessary needs: [lint, typecheck, security, quality] from the
coverage job. Coverage runs the full unit-test suite independently under
slipcover and does not depend on static-analysis results. Removing this
dependency allows coverage to start immediately in parallel with all other
jobs, eliminating a sequential bottleneck that forced coverage to wait for
four upstream jobs before it could begin.
2. Reduce docker job gate from needs: [lint, typecheck, security, quality,
unit_tests] to needs: [unit_tests] only. The Docker image build does not
require static-analysis results to succeed; gating on unit_tests alone is
sufficient to ensure the image is built from tested code.
3. Add uv.lock to all cache keys (was pyproject.toml only). Including the
lock file produces a more precise cache key: a dependency version bump now
correctly invalidates the cache, and unchanged lock files yield higher hit
rates across PRs that only touch source code.
4. Add per-job .nox virtualenv caching for all jobs (lint, typecheck,
security, quality, unit_tests, integration_tests, e2e_tests, coverage,
build). On cache hit, nox skips the full uv pip install step, saving
30-90 s of package installation time per job per run.
Expected aggregate wall-clock reduction: >50% vs the 3556 s baseline
(target: <=1778 s over 20 PRs), primarily from parallelising coverage and
reducing per-job install overhead via nox venv caching.
ISSUES CLOSED: #1641
The previous ACMSPipeline.__init__ invoked _load_strategies_from_settings
at line 831 before self._strategies (line 834) and self._logger (line 864)
were initialized. When a Settings whose context dict contained a
'strategies' key was passed in, the method body raised AttributeError on
'self._strategies', and the except handler then raised a second
AttributeError on 'self._logger' that propagated out of __init__ and
crashed pipeline construction entirely.
Move the auto-load call to after both attributes are bound. Convert the
pytest-shaped tests/strategies/test_strategy_registry.py (which the
behave-based unit_tests gate never ran) into a behave feature file +
step definitions under features/, matching the project's BDD convention
and bringing the strategy auto-loading paths under actual CI coverage.
ISSUES CLOSED: #7527
HAL9000
controller-ci-rerun
CleverAgents Bot
CleverAgents Bot
drew
HAL9000
CleverThis Bot