Commit Graph

30 Commits

Author SHA1 Message Date
HAL9000 f808abff86 chore(ci): fix pre-commit hook failures
Fix JSON syntax errors in .devcontainer/devcontainer.json (removed
invalid JS-style // comments) and .devcontainer/opencode.json (removed
90+ trailing commas). Apply auto-fixes for end-of-file and trailing
whitespace issues across 100+ files. Fix SIM105 ruff violations in
benchmarks/core_circuit_breaker_bench.py (use contextlib.suppress).

Note: The security fix from issue #7478 (validate_path startswith bypass)
was already delivered to master in commit e18ac5f2. This PR as currently
structured is non-atomic (35 commits across 10+ issues) and needs
significant restructure before merge. This commit only addresses the
CI/pre-commit failures.

ISSUES CLOSED: #7478
2026-06-14 09:51:14 -04:00
HAL9000 b6fe72e40f chore(agents): fix bug-hunt-pool-supervisor tracking prefix AUTO-BUG-POOL to AUTO-BUG-SUP (complete fix) 2026-06-14 03:03:30 -04:00
HAL9000 f7ce8f0093 fix: update pr-review-pool-supervisor tracking prefix from AUTO-REV-POOL to AUTO-REV-SUP
- Updated pr-review-pool-supervisor.md tracking prefix from AUTO-REV-POOL to AUTO-REV-SUP
- Updated automation-tracking.md table and search query to use AUTO-REV-SUP
- Updated agent-system-specification.md all references from AUTO-REV-POOL to AUTO-REV-SUP
- Aligns documentation with actual production tracking prefix

ISSUES CLOSED: #7891
2026-06-02 00:58:16 -04:00
HAL9000 2cba7d41bc chore(agents): fix bug-hunt-pool-supervisor tracking prefix AUTO-BUG-POOL to AUTO-BUG-SUP (complete fix)
CI / coverage (push) Blocked by required conditions
CI / docker (push) Blocked by required conditions
CI / status-check (push) Blocked by required conditions
CI / benchmark-regression (push) Has been skipped
CI / helm (push) Successful in 48s
CI / push-validation (push) Successful in 35s
CI / build (push) Successful in 1m4s
CI / lint (push) Successful in 1m18s
CI / quality (push) Successful in 1m22s
CI / typecheck (push) Successful in 1m46s
CI / e2e_tests (push) Successful in 4m42s
CI / integration_tests (push) Successful in 7m51s
CI / unit_tests (push) Successful in 12m20s
CI / security (push) Failing after 13m26s
CI / benchmark-publish (push) Successful in 1h31m13s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Failing after 1m27s
CI / status-check (pull_request) Successful in 3s
CI / integration_tests (pull_request) Successful in 4m32s
CI / unit_tests (pull_request) Successful in 9m46s
CI / helm (pull_request) Successful in 54s
CI / build (pull_request) Successful in 1m4s
CI / push-validation (pull_request) Successful in 22s
CI / docker (pull_request) Successful in 1m48s
CI / lint (pull_request) Successful in 1m10s
CI / quality (pull_request) Successful in 1m27s
CI / typecheck (pull_request) Successful in 1m42s
CI / e2e_tests (pull_request) Successful in 5m24s
CI / security (pull_request) Successful in 2m10s
CI / coverage (pull_request) Successful in 12m19s
Replace all remaining AUTO-BUG-POOL references with correct AUTO-BUG-SUP in agent-system-specification.md, automation-tracking.md documentation and agent-system-specification.md spec document, replaced with correct `AUTO-BUG-SUP` prefix used by the bug-hunt-pool-supervisor agent (#7875).

ISSUES CLOSED: #7875
2026-05-09 00:05:17 +00:00
HAL9000 afc17b22c5 feat(architecture-pool-supervisor): add milestone assignment to spec PRs
Restore original permission structure and model configuration while adding
only the changes needed for issue #7521: forgejo_update_pull_request
permission and PR Workflow for Major Changes documentation section.

Fixes addressed:
- Restore flat permission format (was incorrectly restructured to nested)
- Restore model to claude-haiku-4-5 with reasoningEffort max
- Restore removed critical rules (6: label delegation, 7: pagination)
- Restore removed permission denials (*, doom_loop, question, etc.)
- Add CHANGELOG.md entry for this feature
- Restore CONTRIBUTORS.md to master (remove unrelated changes)

ISSUES CLOSED: #7521

# Conflicts:
#	CONTRIBUTORS.md
2026-04-24 02:04:54 +00:00
clever-agent c5820266fd Build: improced merge agent logic to ensure faster and more effective merging into master
CI / benchmark-publish (push) Waiting to run
CI / lint (push) Successful in 29s
CI / typecheck (push) Successful in 1m10s
CI / security (push) Successful in 1m6s
CI / quality (push) Successful in 31s
CI / benchmark-regression (push) Waiting to run
CI / build (push) Successful in 32s
CI / helm (push) Successful in 37s
CI / push-validation (push) Successful in 29s
CI / e2e_tests (push) Successful in 3m11s
CI / integration_tests (push) Successful in 4m22s
CI / unit_tests (push) Successful in 6m2s
CI / docker (push) Successful in 1m39s
CI / coverage (push) Successful in 11m15s
CI / status-check (push) Successful in 1s
2026-04-13 15:30:00 -04:00
clever-agent 56a430d31f refactor(agents): rename backlog-grooming to grooming, fix tier selector dispatch
Renamed backlog-grooming-pool-supervisor to grooming-pool-supervisor and
backlog-grooming-worker to grooming-worker. The grooming agents now analyze
all open issues AND pull requests (not just the backlog). Workers perform a
full 10-point quality analysis on a single item instead of processing
batches. PRs with unaddressed reviews are prioritized. PR labels are synced
from linked issues. Workers post [GROOMED] markers for tracking.

Fixed critical issue: implementation-pool-supervisor now correctly dispatches
workers through tier selectors (tier-haiku/codex/sonnet/opus) instead of
launching implementation-worker directly, ensuring the escalation model
actually sets the correct model tier. Added implementation-worker to all
four tier selector task permissions.

Updated session tags from AUTO-BLOG to AUTO-GROOM. Updated specification
sections 4.2.1, 5.5, 5.5.1, 9.7, and architecture diagram.

ISSUES CLOSED: n/a
2026-04-12 22:33:40 -04:00
clever-agent 8692bb46e5 build: Refactored agent definitions to be simpler and less contention
CI / benchmark-publish (push) Waiting to run
CI / push-validation (push) Successful in 18s
CI / helm (push) Successful in 25s
CI / lint (push) Successful in 28s
CI / quality (push) Successful in 55s
CI / e2e_tests (push) Successful in 3m4s
CI / build (push) Successful in 3m20s
CI / typecheck (push) Successful in 3m59s
CI / security (push) Successful in 4m5s
CI / benchmark-regression (push) Waiting to run
CI / unit_tests (push) Successful in 7m44s
CI / docker (push) Successful in 1m19s
CI / integration_tests (push) Successful in 9m56s
CI / coverage (push) Successful in 11m47s
CI / status-check (push) Successful in 1s
2026-04-12 19:24:50 -04:00
clever-agent b89b781881 docs(spec): add Section 22 — Division of Responsibilities and Redundancy Model
CI / lint (push) Waiting to run
CI / typecheck (push) Waiting to run
CI / security (push) Waiting to run
CI / quality (push) Waiting to run
CI / unit_tests (push) Waiting to run
CI / integration_tests (push) Waiting to run
CI / e2e_tests (push) Waiting to run
CI / coverage (push) Blocked by required conditions
CI / benchmark-regression (push) Blocked by required conditions
CI / benchmark-publish (push) Waiting to run
CI / build (push) Waiting to run
CI / docker (push) Blocked by required conditions
CI / helm (push) Waiting to run
CI / push-validation (push) Waiting to run
CI / status-check (push) Blocked by required conditions
Add comprehensive responsibility-first analysis of the entire agent system
covering 144 named responsibilities (R-01 through R-144) organized into 8
categories with 29 sub-categories and complete bidirectional cross-references.

Key additions:
- Section 22.0: Categorized Responsibility Index with navigation guide
- Section 7.9: Universal Supervisor Responsibilities (13 shared baseline)
- Section 22.145: Redundancy Analysis Summary with depth distribution,
  highest-redundancy items, most cross-referenced agents, and 5 named
  redundancy patterns
- 30 agent back-reference tables covering ~50 individual agents
- Category introductions explaining scope and significance
- 6th foundational principle (Defense-in-Depth) added to Section 1.1

Categories: A (Development Lifecycle, 50 items), B (Quality Assurance),
C (Ticket Hygiene), D (Architecture), E (Operational Health),
F (Human Interaction), G (Strategic Governance), H (Project Standards).

ISSUES CLOSED: N/A
2026-04-11 23:03:56 -04:00
clever-agent 7e66e57c21 docs(spec): final pass — structural integrity audit
CI / benchmark-publish (push) Waiting to run
CI / helm (push) Successful in 23s
CI / lint (push) Successful in 28s
CI / build (push) Successful in 32s
CI / push-validation (push) Successful in 35s
CI / quality (push) Successful in 40s
CI / security (push) Successful in 59s
CI / typecheck (push) Successful in 1m0s
CI / benchmark-regression (push) Waiting to run
CI / e2e_tests (push) Successful in 3m18s
CI / integration_tests (push) Successful in 4m14s
CI / unit_tests (push) Successful in 5m41s
CI / docker (push) Successful in 10s
CI / coverage (push) Successful in 11m28s
CI / status-check (push) Successful in 1s
- Fixed duplicate section number: two §2.4 -> renamed first to §2.3.1
- Verified all section cross-references valid
- Verified Appendix A model/mode data matches frontmatter (10 samples)
- Verified mkdocs.yml navigation entry
- Comprehensive stale-name sweep: zero hits across all files
- Added v1.36.0 revision entry with final statistics
2026-04-10 21:07:30 +00:00
clever-agent 3a69aef505 docs(spec): twentieth pass achieving spec-wide dual-account coherence
- Fixed Glossary: HAL9000 definition updated for dual-account architecture
- Fixed Section 6.17.2: "two-step" -> "dual-account" in protocol text
- Fixed Section 12.1.2: PR Reviewer table, description, and permissions
  rationale all updated for curl-based dual-account review protocol
- Fixed Section 19.5: Security Model rewritten from "single bot account"
  to dual-account with separate permission scopes per account
- Fixed 2 remaining "Two-Step Review Protocol" references
- Added v1.35.0 revision entry
2026-04-10 20:59:08 +00:00
clever-agent 05e5b26f2a docs(spec): nineteenth pass fixing diagram, MCP tool refs, and edit:deny count
- Fixed Section 6.17.2 diagram: removed orphaned single-account nodes,
  updated to show curl with FORGEJO_REVIEWER_PAT
- Fixed Section 6.17.2 step text: forgejo_create_pull_review -> curl
- Fixed edit:deny count from 41 to 42
- Added missing separator after diagram
- Added v1.34.0 revision entry
2026-04-10 20:51:37 +00:00
clever-agent edbb3471b0 docs(spec): eighteenth pass fixing review template gaps and credential completeness
- Updated Section 6.17 introduction to include FORGEJO_REVIEWER_PASSWORD
- Updated Section 6.17 env table descriptions for clarity
- Added v1.33.0 revision entry for template and credential fixes
2026-04-10 20:43:55 +00:00
clever-agent 5dda3a2c43 docs(spec): seventeenth pass documenting MCP token limitation and curl workaround
- Added Section 6.17.0: MCP Token Limitation — single server-level token,
  no per-call override, PR Reviewer must use curl for writes
- Rewrote Section 21.22: "Total Bash Lockdown" -> "Restricted Bash with curl"
- Added READ-via-MCP/WRITE-via-curl operation table
- Added v1.32.0 revision entry
2026-04-10 20:37:33 +00:00
clever-agent 6baf921b52 docs(spec): sixteenth pass adding FORGEJO_REVIEWER_PASSWORD and purging stale language
- Added FORGEJO_REVIEWER_PASSWORD to Section 6.17 env table and Appendix C
- Purged all remaining "self-approval"/"shared bot account" language from spec
- Updated Sections 8.3.2 and 8.3.3 for dual-account architecture
- Added v1.31.0 revision entry
2026-04-10 20:31:25 +00:00
clever-agent fcff61e1b5 docs(spec): fifteenth pass introducing dual-account architecture
- Rewrote Section 6.17: "Shared Bot Account Problem" -> "Dual-Account Architecture"
- New env vars: FORGEJO_REVIEWER_PAT, FORGEJO_REVIEWER_USERNAME
- Formal APPROVED reviews are now the primary approval path
- Updated Section 6.17.2: "Two-Step" -> "Dual-Account Review Protocol"
- Updated Appendix C environment variable table
- Added v1.30.0 revision entry
2026-04-10 20:23:55 +00:00
clever-agent 4029a3331a docs(spec): fourteenth pass adding subagent specialization principle
CI / benchmark-publish (push) Waiting to run
CI / lint (push) Successful in 32s
CI / push-validation (push) Successful in 23s
CI / helm (push) Successful in 34s
CI / quality (push) Successful in 36s
CI / build (push) Successful in 36s
CI / security (push) Successful in 1m4s
CI / typecheck (push) Successful in 1m8s
CI / benchmark-regression (push) Waiting to run
CI / integration_tests (push) Successful in 4m7s
CI / e2e_tests (push) Successful in 4m15s
CI / unit_tests (push) Successful in 5m21s
CI / docker (push) Successful in 1m20s
CI / coverage (push) Successful in 11m8s
CI / status-check (push) Successful in 2s
- Added Section 6.0: Subagent Specialization Principle (centralize, dont duplicate)
- Updated Section 5.3.4: interval calculation now ATM-centralized
- Updated Section 5.4: 11 operations (added CYCLE_ANNOUNCEMENT_REVIEW)
- Added v1.29.0 revision entry: 17 duplicated blocks removed
2026-04-10 16:15:44 -04:00
clever-agent c29975de8f docs(spec): thirteenth pass documenting body template field enforcement
- Added v1.28.0: all 18 status-creating agents now have Estimated Cycle Interval
  in their actual body templates, not just in reference notes
2026-04-10 16:15:44 -04:00
clever-agent c70adfbbe5 docs(spec): twelfth pass documenting tracking reference reorder across all agents
- Added v1.27.0 entry: all 17 agents fixed with correct READ-before-CREATE order
- All agents now include rolling average interval defaults and Estimated Cycle Interval requirement
2026-04-10 16:15:44 -04:00
clever-agent 8443facae2 docs(spec): eleventh pass adding cycle interval, dual cleanup, and continuity
- Added Section 5.3.4: Estimated Cycle Interval (rolling average 90/10)
- Added Section 5.3.5: Dual Status Issue Cleanup (agent-side + groomer-side)
- Added Section 5.3.6: Cycle Number Continuity Across Sessions
- Updated Section 5.6 body template with mandatory Estimated Cycle Interval field
- Added v1.26.0 revision entry
2026-04-10 16:15:44 -04:00
clever-agent 276ce39908 docs(spec): tenth pass adding startup state recovery protocol
- Added Section 5.3.3: Startup State Recovery Protocol with mandatory
  read-then-delete-then-create sequence
- Agent-specific recovery table for IPS, PR pools, watchdog, product-builder
- Offline duration behavior rules (5min = normal, 2h+ = full re-scan)
- Enhanced READ_TRACKING_STATE return schema in Section 5.4
- Added v1.25.0 revision entry
2026-04-10 16:15:44 -04:00
clever-agent 5615468303 docs(spec): ninth pass completing tracking protocol rollout documentation
- Added v1.24.0 entry documenting 12 agent fixes across 13 files
- All 19 supervisor/orchestrator agents now have complete tracking protocol
2026-04-10 16:15:43 -04:00
clever-agent d3165fcb37 docs(spec): eighth pass comprehensive automation tracking system rewrite
- Rewrote Section 5.2 (Status Issues): one-at-a-time invariant, close-ALL-then-create protocol
- Added Section 5.3.1 (Announcement Lifecycle): mandatory self-review every 3 cycles
- Added Section 5.3.2 (Consumption Protocol): per-agent triage table with 3 read depth levels
- Status issues now use explicit "Status:" prefix to distinguish from announcements
- Announcements require Priority/* labels for triage
- Added v1.23.0 revision entry
2026-04-10 16:15:43 -04:00
clever-agent 93eb5d8e95 docs(spec): seventh pass adding directory layout and subsystem verification
- Added Section 2.4 (Directory Layout) documenting full .opencode/ structure
- Verified 3-Tier Approval Detection matches implementation exactly
- Verified Mandatory Merge Verification matches merge_safety.md exactly
- Confirmed zero remaining stale names/labels/prefixes across all files
- Added v1.22.0 revision entry
2026-04-10 16:15:43 -04:00
clever-agent dd68f47b0e docs(spec): sixth pass documenting universal label deny rule and permission audit
- Expanded Section 6.19 to document universal forgejo_add_issue_labels deny rule with 2 exceptions
- Added v1.21.0 revision entry documenting 6 agent fixes
- Verified 41 edit:deny and 3 webfetch:allow match spec claims exactly
2026-04-10 16:15:43 -04:00
clever-agent d4bf789989 docs(spec): fifth pass adding permission audit results to revision history
- Added v1.20.0 documenting 3 agent permission bugs fixed
- All 79 agents task permissions verified against spec subagent claims
2026-04-10 16:15:43 -04:00
clever-agent dbd90975c0 docs(spec): fourth pass fixing broken cross-references and stale work types
- Fixed broken Section 20.4 reference (section was removed in v1.16.0)
- Fixed wrong Section 13.2 reference (should be Section 11.2 for escalation)
- Replaced stale stale-check work type with awaiting-review in Section 10.1
- Added v1.19.0 revision entry
2026-04-10 16:15:43 -04:00
clever-agent 0902a4508d docs(spec): third pass fixing Appendix A model and adding revision history
- Fixed build-opencode model in Appendix A from (not specified) to claude-sonnet-4-6
- Added v1.18.0 revision entry documenting 6 functional bugs fixed in agent definitions
2026-04-10 16:15:43 -04:00
clever-agent 2488a34bc8 docs(spec): second pass adding pagination, PR ownership, and reviewer lockdown
- Added Section 6.20: Forgejo API Pagination Requirement
- Added Section 6.21: PR Ownership Detection rules
- Expanded Section 8.1.2: three mandatory PR dispatch rules, updated scoring table
- Added Section 21.22: PR Reviewer total bash lockdown permissions
- Fixed Appendix A note: ASV Benchmarker is subagent not primary
- Added revision history entry v1.17.0
2026-04-10 16:15:43 -04:00
clever-agent d8a31527f3 feat(docs): create agent system specification
CI / push-validation (push) Successful in 17s
CI / helm (push) Successful in 23s
CI / build (push) Successful in 28s
CI / lint (push) Successful in 32s
CI / quality (push) Successful in 33s
CI / typecheck (push) Successful in 54s
CI / security (push) Successful in 1m11s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 3m20s
CI / integration_tests (push) Successful in 4m1s
CI / unit_tests (push) Successful in 5m16s
CI / docker (push) Successful in 1m55s
CI / coverage (push) Successful in 10m19s
CI / status-check (push) Successful in 1s
CI / benchmark-publish (push) Successful in 1h13m44s
- Adds a comprehensive specification for the autonomous agent system.
- Details the intended behavior, interactions, and design of all agents.
- Includes Kroki-based diagrams for workflows and interactions.
- Serves as the source of truth for agent implementation.
2026-04-10 14:28:41 -04:00